66332 2011-08-16 14:38:38 -0700 change references to leveldb.gyp to leveldatabase.gyp 2011-08-17 20:25:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan hans scottmg tonyg webkit.review.bot oldest_to_newest 451877 0 dgrogan 2011-08-16 14:38:38 -0700 change references to leveldb.gyp to leveldatabase.gyp 451888 1 104095 dgrogan 2011-08-16 14:53:08 -0700 Created attachment 104095 Patch 451889 2 dgrogan 2011-08-16 14:53:36 -0700 Hans, would you like to review? 452215 3 hans 2011-08-17 05:54:09 -0700 Looks good to me! It will be very nice to get this sorted out. 452284 4 dgrogan 2011-08-17 08:53:03 -0700 Tony, could you review this? This is stage 3 of the plan described here: http://code.google.com/p/chromium/issues/detail?id=89378 The summary is that we're splitting up the leveldb code so that chromium-specific bits will live in the chromium repository. This patch makes webcore use the new leveldb checkout. 452292 5 104095 webkit.review.bot 2011-08-17 09:38:31 -0700 Comment on attachment 104095 Patch Rejecting attachment 104095 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: romium/test_expectations.txt Auto-merging LayoutTests/platform/win/Skipped Failed to merge in the changes. Patch failed at 0001 Add Windows results for new test added in r91777 When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 146. Full output: http://queues.webkit.org/results/9405922 452366 6 104194 dgrogan 2011-08-17 11:03:03 -0700 Created attachment 104194 Patch 452379 7 104194 dgrogan 2011-08-17 11:09:45 -0700 Comment on attachment 104194 Patch This is just a rebase to try to fix the patch-command problem. But it looks like it had nothing to with the patch, just git acting out. Could you r+ and cq+ this to see if it will land this time? 452829 8 104194 webkit.review.bot 2011-08-17 20:25:11 -0700 Comment on attachment 104194 Patch Clearing flags on attachment: 104194 Committed r93278: <http://trac.webkit.org/changeset/93278> 452830 9 webkit.review.bot 2011-08-17 20:25:15 -0700 All reviewed patches have been landed. Closing bug. 104095 2011-08-16 14:53:08 -0700 2011-08-17 11:03:01 -0700 Patch bug-66332-20110816145307.patch text/plain 1651 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTMxNTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMTdkNGFhNmFiODA1NTg1 YmE1ZmM4YjMzZDViZGYwNDI0ZjEyZDllLi5kNWVlYWUwNzYyMzU1YzBjZGUyODQ4YWQ1MDQ1OTVi MzRhNWZlOTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSByZWZlcmVu Y2VzIHRvIGxldmVsZGIuZ3lwIHRvIGxldmVsZGF0YWJhc2UuZ3lwIGFzIHBhcnQgb2YgdGhlCisg ICAgICAgIGxldmVsZGIgcmVmYWN0b3JpbmcgZ29pbmcgb24gaW4gY2hyb21pdW06IGNyYnVnLmNv bS84OTM3OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjYzMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0czogbmV3LXJ1bi13ZWJraXQtdGVzdHMgLS1kZWJ1ZyAtLWNocm9taXVtIC0tbm8tcmV0cnkt ZmFpbHVyZXMgLS1idWlsZC1kaXJlY3Rvcnk9bGx2bSBzdG9yYWdlL2luZGV4ZWRkYgorCisgICAg ICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisKIDIwMTEtMDgtMTYgIE1paG5lYSBPdmlk ZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgVW5tYXRyaXggYWxnb3JpdGhtIGlt cGxlbWVudGF0aW9uIGlzIHdyb25nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lw CmluZGV4IDE0YzUxZTc0YTgwNGQ5OTBhNGUxMTkzYmEwOTFkMjU4NTdiZjlkYTkuLjAyYjFlNDY1 ZWY1YjJjZWNhNzg0ZTZjMWIzOTVhZmJlZDEyMmNjZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu Z3lwL1dlYkNvcmUuZ3lwCkBAIC0xMjY3LDEwICsxMjY3LDEwIEBACiAgICAgICAgIH1dLAogICAg ICAgICBbJyJFTkFCTEVfTEVWRUxEQj0xIiBpbiBmZWF0dXJlX2RlZmluZXMnLCB7CiAgICAgICAg ICAgJ2RlcGVuZGVuY2llcyc6IFsKLSAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Ro aXJkX3BhcnR5L2xldmVsZGIvbGV2ZWxkYi5neXA6bGV2ZWxkYicsCisgICAgICAgICAgICAnPChj aHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9sZXZlbGRhdGFiYXNlL2xldmVsZGF0YWJhc2Uu Z3lwOmxldmVsZGF0YWJhc2UnLAogICAgICAgICAgIF0sCiAgICAgICAgICAgJ2V4cG9ydF9kZXBl bmRlbnRfc2V0dGluZ3MnOiBbCi0gICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGly ZF9wYXJ0eS9sZXZlbGRiL2xldmVsZGIuZ3lwOmxldmVsZGInLAorICAgICAgICAgICAgJzwoY2hy b21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbGV2ZWxkYXRhYmFzZS9sZXZlbGRhdGFiYXNlLmd5 cDpsZXZlbGRhdGFiYXNlJywKICAgICAgICAgICBdLAogICAgICAgICB9XSwKICAgICAgIF0sCg== 104194 2011-08-17 11:03:03 -0700 2011-08-17 20:25:11 -0700 Patch bug-66332-20110817110303.patch text/plain 1670 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTMxNjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhODI4Y2VjMDAzMjMxNzQ3 MWE3YThiMTg3MWU1M2JlMWM1ZmIxNjNmLi45M2YwNjI0ZTdiNjUxOTVjNjllMDgyZWYyOWVkNDM1 N2EzMzc1YTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIENoYW5nZSByZWZlcmVu Y2VzIHRvIGxldmVsZGIuZ3lwIHRvIGxldmVsZGF0YWJhc2UuZ3lwIGFzIHBhcnQgb2YgdGhlCisg ICAgICAgIGxldmVsZGIgcmVmYWN0b3JpbmcgZ29pbmcgb24gaW4gY2hyb21pdW06IGNyYnVnLmNv bS84OTM3OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjYzMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0czogbmV3LXJ1bi13ZWJraXQtdGVzdHMgLS1kZWJ1ZyAtLWNocm9taXVtIC0tbm8tcmV0cnkt ZmFpbHVyZXMgLS1idWlsZC1kaXJlY3Rvcnk9bGx2bSBzdG9yYWdlL2luZGV4ZWRkYgorCisgICAg ICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisKIDIwMTEtMDgtMTYgIEpvc2VwaCBQZWNv cmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVt IFdpbmRvd3MgYnVpbGQgZml4IGFmdGVyIHI5MzE0MC4gVGFrZSA0LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCAxNGM1MWU3NGE4MDRkOTkwYTRlMTE5M2JhMDkxZDI1 ODU3YmY5ZGE5Li4wMmIxZTQ2NWVmNWIyY2VjYTc4NGU2YzFiMzk1YWZiZWQxMjJjY2ZkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMTI2NywxMCArMTI2NywxMCBA QAogICAgICAgICB9XSwKICAgICAgICAgWyciRU5BQkxFX0xFVkVMREI9MSIgaW4gZmVhdHVyZV9k ZWZpbmVzJywgewogICAgICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCi0gICAgICAgICAgICAnPChj aHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9sZXZlbGRiL2xldmVsZGIuZ3lwOmxldmVsZGIn LAorICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbGV2ZWxkYXRh YmFzZS9sZXZlbGRhdGFiYXNlLmd5cDpsZXZlbGRhdGFiYXNlJywKICAgICAgICAgICBdLAogICAg ICAgICAgICdleHBvcnRfZGVwZW5kZW50X3NldHRpbmdzJzogWwotICAgICAgICAgICAgJzwoY2hy b21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbGV2ZWxkYi9sZXZlbGRiLmd5cDpsZXZlbGRiJywK KyAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2xldmVsZGF0YWJh c2UvbGV2ZWxkYXRhYmFzZS5neXA6bGV2ZWxkYXRhYmFzZScsCiAgICAgICAgICAgXSwKICAgICAg ICAgfV0sCiAgICAgICBdLAo=