66328 2011-08-16 14:07:36 -0700 ASSERT in fast/css/custom-font-xheight.html 2011-08-17 10:48:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony joepeck joepeck mitz msaboff steveblock oldest_to_newest 451856 0 tony 2011-08-16 14:07:36 -0700 When running fast/css/custom-font-xheight.html on a debug build of chromium linux, we hit the following assert: ASSERTION FAILED: m_purgePreventCount WebKit/Source/WebCore/platform/graphics/FontCache.cpp(280) : WebCore::SimpleFontData* WebCore::FontCache::getCachedFontData(const WebCore::FontPlatformData*, WebCore::FontCache::ShouldRetain) 451857 1 tony 2011-08-16 14:09:14 -0700 I suspect this is due to http://trac.webkit.org/changeset/93140 451875 2 joepeck 2011-08-16 14:36:50 -0700 That is a good sign, this code was broken before so we need to add a another FontCachePurgePreventer somewhere now. I'm surprised I didn't encounter this assert when I ran tests. Do you have the backtrace? 451894 3 tony 2011-08-16 15:01:00 -0700 ASSERTION FAILED: m_purgePreventCount third_party/WebKit/Source/WebCore/platform/graphics/FontCache.cpp(280) : WebCore::SimpleFontData* WebCore::FontCache::getCachedFontData(const WebCore::FontPlatformData*, WebCore::FontCache::ShouldRetain) [12604:12604:7278047199282:ERROR:process_util_posix.cc(134)] Received signal 11 base::debug::StackTrace::StackTrace() [0x8b8df2] base::(anonymous namespace)::StackDumpSignalHandler() [0x8810a9] 0x7faae929bc20 WebCore::FontCache::getCachedFontData() [0xfe8f69] WebCore::FontCache::getLastResortFallbackFont() [0x1026f0c] WebCore::FontCache::getNonRetainedLastResortFallbackFont() [0xfe927c] WebCore::CSSFontFaceSource::getFontData() [0x168214b] WebCore::CSSFontFace::getFontData() [0x167e7f9] WebCore::CSSSegmentedFontFace::getFontData() [0x15d833b] WebCore::CSSFontSelector::getFontData() [0x15ba8ee] WebCore::FontCache::getFontData() [0xfe9a96] WebCore::FontFallbackList::fontDataAt() [0xff58e3] WebCore::FontFallbackList::primaryFontData() [0x4d97c2] WebCore::FontFallbackList::primarySimpleFontData() [0x4d976d] WebCore::Font::primaryFont() [0x4d988d] WebCore::Font::fontMetrics() [0x4d980e] WebCore::RenderStyle::fontMetrics() [0x11f18ea] WebCore::CSSPrimitiveValue::computeLengthDouble() [0x11ef440] WebCore::CSSPrimitiveValue::computeLength<>() [0x11ef1d7] WebCore::ApplyPropertyLength<>::applyValue() [0x15ef077] WebCore::CSSStyleApplyProperty::applyValue() [0x122ea59] WebCore::CSSStyleSelector::applyProperty() [0x1213f21] WebCore::CSSStyleSelector::applyDeclarations<>() [0x12344ab] WebCore::CSSStyleSelector::styleForElement() [0x120bd97] WebCore::Node::styleForRenderer() [0xe42925] WebCore::NodeRendererFactory::createRendererAndStyle() [0xe5b04b] WebCore::NodeRendererFactory::createRendererIfNeeded() [0xe5b250] WebCore::Node::createRendererIfNeeded() [0xe428a5] WebCore::Element::attach() [0xe1621d] WebCore::HTMLConstructionSite::attach<>() [0xf9f040] WebCore::HTMLConstructionSite::attachToCurrent() [0xf9d64c] WebCore::HTMLConstructionSite::insertHTMLElement() [0xf9daf4] WebCore::HTMLTreeBuilder::processStartTagForInBody() [0xf68c48] WebCore::HTMLTreeBuilder::processStartTag() [0xf6b2fe] WebCore::HTMLTreeBuilder::processToken() [0xf671e1] WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken() [0xf6708e] WebCore::HTMLTreeBuilder::constructTreeFromToken() [0xf66fe5] WebCore::HTMLDocumentParser::pumpTokenizer() [0xf4fc4a] WebCore::HTMLDocumentParser::pumpTokenizerIfPossible() [0xf4f668] WebCore::HTMLDocumentParser::append() [0xf501cc] WebCore::DecodedDataDocumentParser::appendBytes() [0x2177c48] WebCore::DocumentWriter::addData() [0x138b518] WebCore::DocumentLoader::commitData() [0x137c93d] WebKit::WebFrameImpl::commitDocumentData() [0x484d3a] WebKit::FrameLoaderClientImpl::committedLoad() [0x4dd06b] WebCore::DocumentLoader::commitLoad() [0x137c804] WebCore::DocumentLoader::receivedData() [0x137c9f8] WebCore::MainResourceLoader::addData() [0x13af777] WebCore::ResourceLoader::didReceiveData() [0x13c3011] WebCore::MainResourceLoader::didReceiveData() [0x13b0bc0] WebCore::ResourceLoader::didReceiveData() [0x13c3928] WebCore::ResourceHandleInternal::didReceiveData() [0x4f0d6e] webkit_glue::WebURLLoaderImpl::Context::OnReceivedData() [0x19b18b0] (anonymous namespace)::RequestProxy::NotifyReceivedData() [0x1a7255b] DispatchToMethod<>() [0x1a77f6b] RunnableMethod<>::Run() [0x1a77444] base::subtle::TaskClosureAdapter::Run() [0x89a39b] base::internal::Invoker1<>::DoInvoke() [0x86401c] base::Callback<>::Run() [0x862ded] MessageLoop::RunTask() [0x8609b5] MessageLoop::DeferOrRunPendingTask() [0x860abd] MessageLoop::DoWork() [0x8612b5] 451895 4 tony 2011-08-16 15:01:34 -0700 Looks like chromium mac debug hit this as well. It's probably all chromium dbg builds that hit this assert. 451910 5 joepeck 2011-08-16 15:25:35 -0700 Yah, this was clearly my fault. I ran the test and saw the crash and ignored it because it was failing for me before I made my change. I'm compiling a fix now. Sorry about that! 451926 6 104104 joepeck 2011-08-16 15:40:40 -0700 Created attachment 104104 [PATCH] Add a FontCachePurgePreventer and a Comment 451931 7 104104 joepeck 2011-08-16 15:47:10 -0700 Comment on attachment 104104 [PATCH] Add a FontCachePurgePreventer and a Comment I'll land manually since it looks like chromium test expectations were updated before I could get the fix out. 451941 8 joepeck 2011-08-16 15:59:04 -0700 Unskipped the test and landed the fix in: r93171 <http://trac.webkit.org/changeset/93171> 452355 9 steveblock 2011-08-17 10:48:38 -0700 *** Bug 66375 has been marked as a duplicate of this bug. *** 104104 2011-08-16 15:40:40 -0700 2011-08-16 15:47:10 -0700 [PATCH] Add a FontCachePurgePreventer and a Comment assert-fix.patch text/plain 1913 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhODI4Y2VjLi5lODVmOTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDgtMTYgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAor ICAgICAgICBBU1NFUlQgaW4gZmFzdC9jc3MvY3VzdG9tLWZvbnQteGhlaWdodC5odG1sCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjMyOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHI5MzE0MCB0aGUg dGVtcG9yYXJ5IGZvbnQgY3JlYXRlZCBmb3IgYSByZW1vdGUgQ1NTIGZvbnQgZmFjZQorICAgICAg ICB3YXMgY3JlYXRlZCB3aXRob3V0IGJlaW5nIHJldGFpbmVkLiBXZSBuZWVkIHRvIHByb3RlY3Qg dGhlCisgICAgICAgIGZvbnQgZnJvbSBiZWluZyBwdXJnZWQgd2hpbGUgd2UgaG9sZCBvbnRvIGl0 LCBzbyBhZGQgYSBmb250IGNhY2hlCisgICAgICAgIHB1cmdlIHByZXZlbnRlci4KKworICAgICAg ICAqIGNzcy9DU1NGb250RmFjZVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NGb250 RmFjZVNvdXJjZTo6Z2V0Rm9udERhdGEpOgorCisyMDExLTA4LTE2ICBKb3NlcGggUGVjb3Jhcm8g IDxqb2VwZWNrQHdlYmtpdC5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBXaW5k b3dzIGJ1aWxkIGZpeCBhZnRlciByOTMxNDAuIFRha2UgNC4KICAgICAgICAgTmFtZXNwYWNlIHRo ZSBub3cgcHVibGljIGVudW0gYXMgRm9udENhY2hlOjpTaG91bGRSZXRhaW4uCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTRm9udEZhY2VTb3VyY2UuY3BwCmluZGV4IDJjNzJjNzUuLjFhOThkZGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVNvdXJjZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlU291cmNlLmNwcApAQCAtMTg1LDggKzE4NSwx MCBAQCBTaW1wbGVGb250RGF0YSogQ1NTRm9udEZhY2VTb3VyY2U6OmdldEZvbnREYXRhKGNvbnN0 IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaQogICAgICAgICBpZiAoIW1fbG9hZFN0YXJ0VGlt ZXIuaXNBY3RpdmUoKSkKICAgICAgICAgICAgIG1fbG9hZFN0YXJ0VGltZXIuc3RhcnRPbmVTaG90 KDApOwogCi0gICAgICAgIFNpbXBsZUZvbnREYXRhKiB0ZW1wRGF0YSA9IGZvbnRDYWNoZSgpLT5n ZXROb25SZXRhaW5lZExhc3RSZXNvcnRGYWxsYmFja0ZvbnQoZm9udERlc2NyaXB0aW9uKTsKLSAg ICAgICAgZm9udERhdGEgPSBhZG9wdFB0cihuZXcgU2ltcGxlRm9udERhdGEodGVtcERhdGEtPnBs YXRmb3JtRGF0YSgpLCB0cnVlLCB0cnVlKSk7CisgICAgICAgIC8vIFRoaXMgdGVtcG9yYXJ5IGZv bnQgaXMgbm90IHJldGFpbmVkIGFuZCBzaG91bGQgbm90IGJlIHJldHVybmVkLgorICAgICAgICBG b250Q2FjaGVQdXJnZVByZXZlbnRlciBmb250Q2FjaGVQdXJnZVByZXZlbnRlcjsKKyAgICAgICAg U2ltcGxlRm9udERhdGEqIHRlbXBvcmFyeUZvbnQgPSBmb250Q2FjaGUoKS0+Z2V0Tm9uUmV0YWlu ZWRMYXN0UmVzb3J0RmFsbGJhY2tGb250KGZvbnREZXNjcmlwdGlvbik7CisgICAgICAgIGZvbnRE YXRhID0gYWRvcHRQdHIobmV3IFNpbXBsZUZvbnREYXRhKHRlbXBvcmFyeUZvbnQtPnBsYXRmb3Jt RGF0YSgpLCB0cnVlLCB0cnVlKSk7CiAgICAgfQogCiAgICAgU2ltcGxlRm9udERhdGEqIGZvbnRE YXRhUmF3UHRyID0gZm9udERhdGEubGVha1B0cigpOwo=