66318 2011-08-16 10:59:41 -0700 Summary view should not add multiple entries for the same test failure. 2011-08-16 14:55:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66144 1 dglazkov dglazkov abarth oldest_to_newest 451743 0 dglazkov 2011-08-16 10:59:41 -0700 Summary view should not add multiple entries for the same test failure. 451744 1 104068 dglazkov 2011-08-16 11:01:37 -0700 Created attachment 104068 Patch 451843 2 104068 abarth 2011-08-16 13:47:52 -0700 Comment on attachment 104068 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104068&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:132 > + return !!Array.prototype.filter.call(this._tests.children, function(child) { > + return child.equals(failureAnalysis); > + }).length; This feels like something to abstract into base, like the any/all functions in Python. 451890 3 dglazkov 2011-08-16 14:55:52 -0700 Committed r93161: <http://trac.webkit.org/changeset/93161> 104068 2011-08-16 11:01:37 -0700 2011-08-16 13:47:52 -0700 Patch bug-66318-20110816110136.patch text/plain 6705 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwNjMKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL3N1bW1hcnkuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9zdW1tYXJ5LmpzCmlu ZGV4IDI3ZjlkYTIyOWU5MGNjYWRiNWViYzdkMjdiOTFhYTBiMWU2OTliZDIuLjkyNGVkNjQ4OWZh M2JkMjM5MTU4OWFiZjUyM2JiYjM2NWIyZWY5NTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9zY3JpcHRzL3N1bW1hcnkuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvc3VtbWFy eS5qcwpAQCAtNjMsNiArNjMsMTIgQEAgJChkb2N1bWVudCkucmVhZHkoZnVuY3Rpb24oKSB7CiAg ICAgZ191cGRhdGVUaW1lcklkID0gd2luZG93LnNldEludGVydmFsKHVwZGF0ZSwgY29uZmlnLmtV cGRhdGVGcmVxdWVuY3kpOwogICAgIGRvY3VtZW50LmJvZHkuaW5zZXJ0QmVmb3JlKGdfYWN0aW9u cywgZG9jdW1lbnQuYm9keS5maXJzdENoaWxkKTsKICAgICBkb2N1bWVudC5ib2R5Lmluc2VydEJl Zm9yZShnX2luZm8sIGRvY3VtZW50LmJvZHkuZmlyc3RDaGlsZCk7CisgICAgdmFyIGJ1dHRvbiA9 IGRvY3VtZW50LmJvZHkuaW5zZXJ0QmVmb3JlKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImJ1dHRv biIpLCBkb2N1bWVudC5ib2R5LmZpcnN0Q2hpbGQpOworICAgIGJ1dHRvbi5hZGRFdmVudExpc3Rl bmVyKCJjbGljayIsIGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHVwZGF0ZSgpOworICAgIH0s IGZhbHNlKTsKKyAgICBidXR0b24udGV4dENvbnRlbnQgPSAndXBkYXRlJzsKICAgICB1cGRhdGUo KTsKIH0pOwogCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmlj YXRpb25zLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9ucy5qcwpp bmRleCBiOTkzNzRmYTdmNGY1OTVjNzJjOTk4MjFhOWU4MTY1ZWY3ZjhmZDEwLi4zMWU3ZGNiOGY0 OGMzZGU3MzBiZWIyNzcwN2YxMmNkMzA1MDZhMDhhIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVy ZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3Jp cHRzL3VpL25vdGlmaWNhdGlvbnMuanMKQEAgLTgyLDYgKzgyLDEwIEBAIHVpLm5vdGlmaWNhdGlv bnMuRmFpbGluZ1Rlc3QgPSBiYXNlLmV4dGVuZHMoJ2xpJywgewogICAgIHsKICAgICAgICAgLy8g RklYTUU6IFNob3cgdHlwZSBvZiBmYWlsdXJlIGFuZCB3aGVyZSBpdCdzIGZhaWxpbmcuCiAgICAg ICAgIHRoaXMudGV4dENvbnRlbnQgPSBmYWlsdXJlQW5hbHlzaXMudGVzdE5hbWU7CisgICAgfSwK KyAgICBlcXVhbHM6IGZ1bmN0aW9uKGZhaWx1cmVBbmFseXNpcykKKyAgICB7CisgICAgICAgIHJl dHVybiB0aGlzLnRleHRDb250ZW50ID09IGZhaWx1cmVBbmFseXNpcy50ZXN0TmFtZTsKICAgICB9 CiB9KQogCkBAIC0xMjEsMTEgKzEyNSwxOCBAQCB1aS5ub3RpZmljYXRpb25zLlRlc3RGYWlsdXJl cyA9IGJhc2UuZXh0ZW5kcyhOb3RpZmljYXRpb24sIHsKICAgICAgICAgdGhpcy5fY2F1c2VzID0g cHJvYmxlbS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCd1bCcpKTsKICAgICAg ICAgdGhpcy5fY2F1c2VzLmNsYXNzTmFtZSA9ICdjYXVzZXMnOwogICAgIH0sCisgICAgY29udGFp bnNGYWlsdXJlQW5hbHlzaXM6IGZ1bmN0aW9uKGZhaWx1cmVBbmFseXNpcykKKyAgICB7CisgICAg ICAgIHJldHVybiAhIUFycmF5LnByb3RvdHlwZS5maWx0ZXIuY2FsbCh0aGlzLl90ZXN0cy5jaGls ZHJlbiwgZnVuY3Rpb24oY2hpbGQpIHsKKyAgICAgICAgICAgIHJldHVybiBjaGlsZC5lcXVhbHMo ZmFpbHVyZUFuYWx5c2lzKTsKKyAgICAgICAgfSkubGVuZ3RoOworICAgIH0sCiAgICAgYWRkRmFp bHVyZUFuYWx5c2lzOiBmdW5jdGlvbihmYWlsdXJlQW5hbHlzaXMpCiAgICAgewotICAgICAgICAv LyBGSVhNRTogQWRkIGluIG9yZGVyLgotICAgICAgICAvLyBGSVhNRTogRG9uJ3QgYWRkIG1vcmUg dGhhbiBvbmNlLgorICAgICAgICBpZiAodGhpcy5jb250YWluc0ZhaWx1cmVBbmFseXNpcyhmYWls dXJlQW5hbHlzaXMpKQorICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAvLyBGSVhNRTogUmV0 cmlldmUgZGF0ZSBmcm9tIGZhaWx1cmVBbmFseXNpcyBhbmQgc2V0IHRoaXMuX3RpbWUuCisgICAg ICAgIC8vIEZJWE1FOiBBZGQgaW4gb3JkZXIgYnkgdGltZS4KICAgICAgICAgcmV0dXJuIHRoaXMu X3Rlc3RzLmFwcGVuZENoaWxkKG5ldyB1aS5ub3RpZmljYXRpb25zLkZhaWxpbmdUZXN0KGZhaWx1 cmVBbmFseXNpcykpOwogICAgIH0sCiAgICAgYWRkQ29tbWl0RGF0YTogZnVuY3Rpb24oY29tbWl0 RGF0YSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlv bnNfdW5pdHRlc3RzLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9u c191bml0dGVzdHMuanMKaW5kZXggZGI2NDY2YTBhNzkwNTZkNmYyNWFjYjFlZDE5NjU4OWQ5YjVl MGFlMC4uZGQ3NDhkMGM3MzdiZWRiNjBiZjk4YmJlNTgwMTIzNTVhZTA1YTZhZiAxMDA2NDQKLS0t IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9uc191bml0dGVzdHMuanMK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9uc191bml0dGVzdHMu anMKQEAgLTQ2LDEwICs0NiwxMiBAQCB0ZXN0KCd1aS5ub3RpZmljYXRpb25zLkluZm8nLCAzLCBm dW5jdGlvbigpIHsKICAgICBvayhpbmZvLmRpc21pc3MpOwogfSk7CiAKLXRlc3QoJ3VpLm5vdGlm aWNhdGlvbnMuRmFpbGluZ1Rlc3QnLCAyLCBmdW5jdGlvbigpIHsKK3Rlc3QoJ3VpLm5vdGlmaWNh dGlvbnMuRmFpbGluZ1Rlc3QnLCA0LCBmdW5jdGlvbigpIHsKICAgICB2YXIgZmFpbGluZ1Rlc3Qg PSBuZXcgdWkubm90aWZpY2F0aW9ucy5GYWlsaW5nVGVzdCh7dGVzdE5hbWU6ICd0ZXN0J30pOwog ICAgIGVxdWFsKGZhaWxpbmdUZXN0LnRhZ05hbWUsICdMSScpOwogICAgIGVxdWFsKGZhaWxpbmdU ZXN0LmlubmVySFRNTCwgJ3Rlc3QnKTsKKyAgICBvayhmYWlsaW5nVGVzdC5lcXVhbHMoe3Rlc3RO YW1lOiAndGVzdCd9KSk7CisgICAgb2soIWZhaWxpbmdUZXN0LmVxdWFscyh7dGVzdE5hbWU6ICdm b28nfSkpOwogfSk7CiAKIHRlc3QoJ3VpLm5vdGlmaWNhdGlvbnMuU3VzcGljaW91c0NvbW1pdCcs IDIsIGZ1bmN0aW9uKCkgewpAQCAtNTgsMTIgKzYwLDE2IEBAIHRlc3QoJ3VpLm5vdGlmaWNhdGlv bnMuU3VzcGljaW91c0NvbW1pdCcsIDIsIGZ1bmN0aW9uKCkgewogICAgIGVxdWFsKHN1c3BpY2lv dXNDb21taXQuaW5uZXJIVE1MLCAnPGRpdiBjbGFzcz0iZGVzY3JpcHRpb24iPjxhIGhyZWY9IiI+ MTwvYT50aXRsZSBhdXRob3IgKHJldmlld2VyKTwvZGl2Pjx1bCBjbGFzcz0iYWN0aW9ucyI+PGxp PjxidXR0b24+Um9sbCBvdXQ8L2J1dHRvbj48L2xpPjwvdWw+Jyk7CiB9KTsKIAotdGVzdCgndWku bm90aWZpY2F0aW9ucy5UZXN0RmFpbHVyZXMnLCA0LCBmdW5jdGlvbigpIHsKK3Rlc3QoJ3VpLm5v dGlmaWNhdGlvbnMuVGVzdEZhaWx1cmVzJywgNywgZnVuY3Rpb24oKSB7CiAgICAgdmFyIHRlc3RG YWlsdXJlcyA9IG5ldyB1aS5ub3RpZmljYXRpb25zLlRlc3RGYWlsdXJlcygpOwogICAgIGVxdWFs KHRlc3RGYWlsdXJlcy50YWdOYW1lLCAnTEknKTsKICAgICBlcXVhbCh0ZXN0RmFpbHVyZXMuaW5u ZXJIVE1MLCAnPHRpbWU+SnVzdCBOb3c8L3RpbWU+PGRpdiBjbGFzcz0id2hhdCI+PGRpdiBjbGFz cz0icHJvYmxlbSI+PHVsIGNsYXNzPSJlZmZlY3RzIj48L3VsPjx1bCBjbGFzcz0iY2F1c2VzIj48 L3VsPjwvZGl2PjwvZGl2PicpOwogICAgIHRlc3RGYWlsdXJlcy5hZGRGYWlsdXJlQW5hbHlzaXMo e3Rlc3ROYW1lOiAndGVzdCd9KTsKICAgICBlcXVhbCh0ZXN0RmFpbHVyZXMuaW5uZXJIVE1MLCAn PHRpbWU+SnVzdCBOb3c8L3RpbWU+PGRpdiBjbGFzcz0id2hhdCI+PGRpdiBjbGFzcz0icHJvYmxl bSI+PHVsIGNsYXNzPSJlZmZlY3RzIj48bGk+dGVzdDwvbGk+PC91bD48dWwgY2xhc3M9ImNhdXNl cyI+PC91bD48L2Rpdj48L2Rpdj4nKTsKKyAgICBvayh0ZXN0RmFpbHVyZXMuY29udGFpbnNGYWls dXJlQW5hbHlzaXMoe3Rlc3ROYW1lOiAndGVzdCd9KSk7CisgICAgb2soIXRlc3RGYWlsdXJlcy5j b250YWluc0ZhaWx1cmVBbmFseXNpcyh7dGVzdE5hbWU6ICdmb28nfSkpOworICAgIHRlc3RGYWls dXJlcy5hZGRGYWlsdXJlQW5hbHlzaXMoe3Rlc3ROYW1lOiAndGVzdCd9KTsKKyAgICBlcXVhbCh0 ZXN0RmFpbHVyZXMuaW5uZXJIVE1MLCAnPHRpbWU+SnVzdCBOb3c8L3RpbWU+PGRpdiBjbGFzcz0i d2hhdCI+PGRpdiBjbGFzcz0icHJvYmxlbSI+PHVsIGNsYXNzPSJlZmZlY3RzIj48bGk+dGVzdDwv bGk+PC91bD48dWwgY2xhc3M9ImNhdXNlcyI+PC91bD48L2Rpdj48L2Rpdj4nKTsKICAgICB0ZXN0 RmFpbHVyZXMuYWRkQ29tbWl0RGF0YSh7cmV2aXNpb246IDEsIHRpdGxlOiAidGl0bGUiLCBhdXRo b3I6ICJhdXRob3IiLCByZXZpZXdlcjogInJldmlld2VyIn0pOwogICAgIGVxdWFsKHRlc3RGYWls dXJlcy5pbm5lckhUTUwsICc8dGltZT5KdXN0IE5vdzwvdGltZT48ZGl2IGNsYXNzPSJ3aGF0Ij48 ZGl2IGNsYXNzPSJwcm9ibGVtIj48dWwgY2xhc3M9ImVmZmVjdHMiPjxsaT50ZXN0PC9saT48L3Vs Pjx1bCBjbGFzcz0iY2F1c2VzIj48bGk+PGRpdiBjbGFzcz0iZGVzY3JpcHRpb24iPjxhIGhyZWY9 IiI+MTwvYT50aXRsZSBhdXRob3IgKHJldmlld2VyKTwvZGl2Pjx1bCBjbGFzcz0iYWN0aW9ucyI+ PGxpPjxidXR0b24+Um9sbCBvdXQ8L2J1dHRvbj48L2xpPjwvdWw+PC9saT48L3VsPjwvZGl2Pjwv ZGl2PicpOwogfSk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggY2U5YzEyZmRiY2NmN2M2ZjBhZmVhMTEwZGExNjljOTk2ODkwOGQ0NS4uMGYwNTA1 YWYyZWI1ZDkzMjlmNDdmMzBiNzcwZTYwMThkZWM1ZjkwZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDExLTA4LTE2 ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgU3Vt bWFyeSB2aWV3IHNob3VsZCBub3QgYWRkIG11bHRpcGxlIGVudHJpZXMgZm9yIHRoZSBzYW1lIHRl c3QgZmFpbHVyZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY2MzE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRt bC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9zdW1tYXJ5LmpzOiBBZGRlZCBhIHNpbXBsaXN0aWMgdXBk YXRpbmcgYnV0dG9uLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlv bnMuanM6IEFkZGVkIHdheXMgdG8gY2hlY2sgZm9yCisgICAgICAgICAgICBlcXVhbGl0eSBvZiB1 aS5ub3RpZmljYXRpb25zLkZhaWxpbmdUZXN0LCBhbmQgd2hldGhlciB1aS5ub3RpZmljYXRpb25z LlRlc3RGYWlsdXJlcyBhbHJlYWR5IGNvbnRhaW5zIGEgZ2l2ZW4gZmFpbHVyZSBhbmFseXNpcy4K KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zX3VuaXR0ZXN0cy5q czogQWRkZWQgdGVzdHMuCisKKzIwMTEtMDgtMTYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292 QGNocm9taXVtLm9yZz4KKwogICAgICAgICBnYXJkZW4tby1tYXRpYyBuZWVkcyBhIHN1bW1hcnkg dmlldyB3aXRoIGFjdGlvbnMgZm9yIGVhY2ggcHJvYmxlbS4KICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2MTQ0CiAK