66315 2011-08-16 10:18:26 -0700 [chromium] SVG pan updates have wrong vertical sense 2011-08-16 11:28:16 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified All RESOLVED DUPLICATE 65800 P2 Normal --- 1 wjmaclean webkit-unassigned thorton zimmermann oldest_to_newest 451711 0 wjmaclean 2011-08-16 10:18:26 -0700 When a .svg file is is panned in chromium (using shift+right-click+drag), the vertical motion is reversed from the mouse motion. This operation works as expected on Safari, so a mechanism is needed to specify which sense to use for the different ports. 451713 1 104063 wjmaclean 2011-08-16 10:19:16 -0700 Created attachment 104063 Proposed fix + test 451716 2 thorton 2011-08-16 10:23:15 -0700 My understanding is that we already have a mechanism for converting between the coordinate spaces (windowToContents). Check out the patch in https://bugs.webkit.org/show_bug.cgi?id=65800 which makes use of this, and if you have a chance, build it with Chromium and see why it doesn't pass the test there. I'd prefer that patch to this one because it seems unfortunate to keep track of this information in different places, especially because it's different between different platforms *and* frontends. 451717 3 thorton 2011-08-16 10:23:48 -0700 (In reply to comment #0) > When a .svg file is is panned in chromium (using shift+right-click+drag), the vertical motion is reversed from the mouse motion. This operation works as expected on Safari, so a mechanism is needed to specify which sense to use for the different ports. I will note that it no longer works correctly in the latest shipping version of Safari on OS X. 451762 4 wjmaclean 2011-08-16 11:25:52 -0700 (In reply to comment #2) > My understanding is that we already have a mechanism for converting between the coordinate spaces (windowToContents). Check out the patch in https://bugs.webkit.org/show_bug.cgi?id=65800 which makes use of this, and if you have a chance, build it with Chromium and see why it doesn't pass the test there. > > I'd prefer that patch to this one because it seems unfortunate to keep track of this information in different places, especially because it's different between different platforms *and* frontends. I was unaware of windowToContents, but the patch you mention does resolve the issue. Presumably we should mark this bug as a duplicate, and proceed with https://bugs.webkit.org/show_bug.cgi?id=65800. 451763 5 wjmaclean 2011-08-16 11:26:27 -0700 *** This bug has been marked as a duplicate of bug 65800 *** 451766 6 thorton 2011-08-16 11:28:16 -0700 (In reply to comment #4) > I was unaware of windowToContents, but the patch you mention does resolve the issue. Presumably we should mark this bug as a duplicate, and proceed with https://bugs.webkit.org/show_bug.cgi?id=65800. Seems like the right thing to do, to me! If you could run the test with pixel results on and send me the chromium result, I'd love to see why it differs, but haven't had the time to set up a Chromium build. 104063 2011-08-16 10:19:16 -0700 2011-08-16 10:19:16 -0700 Proposed fix + test svg-pan.patch text/plain 6717 wjmaclean ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3N2Zy12ZXJ0aWNhbC1wYW4tZXhw ZWN0ZWQucG5nIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3ZnLXZlcnRpY2FsLXBhbi1leHBl Y3RlZC5wbmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uN2YxYzQ5MjNjZmUwMGVkMjMzYTYzNTAzYjUzYWIwOTY1YmVk NWM5NQpHSVQgYmluYXJ5IHBhdGNoCmxpdGVyYWwgMjg1OQp6Y21lQVNATj8ob2xIeWB1VkJxIWlh MHl+eVV7K3ZZVjJhPmkwKlopPWheaGxBJUBXcyRsSGBvazxtfT9vVG4wMDkKekwqcW8jUjNwPjBM Xz4+MjE5TDttdkB8b0lwcVooZVd1bDNOUUVyOHgwUnNjcVVRWlh0a2N2NVA/LSs3NUlQZnF5Cnpv YDNmNWY2VkcxNEF6a1hEYS1obSF+fl9CSjtUVzBAY2Q1fEJTWFZ9ITNZS2ghJHd2SDBiJCZYPTw0 Jk9kdTZfewp6JFQyKVAkOyE+M3B0Z2E1QSZGX0E3fjlnR3lfUktRczU/NkZQOHJ5TTdgMSglbEho Ml9rQjBtSm1WbCRsWiM0T2gKaUNjbntLRiNLe3M4TUMkfnw1QWZUe35yVGV6WUx6UGVsRntyNX1F K0hsLTFxPAoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvc3ZnLXZlcnRpY2FsLXBhbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9zdmctdmVydGljYWwtcGFuLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi4yNGU5MDg2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvc3ZnLXZlcnRpY2FsLXBhbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1 IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBz aXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJTVkdSb290 IHtzdmd9IGF0ICgwLDEwKSBzaXplIDIweDMwCisgICAgUmVuZGVyU1ZHUGF0aCB7cmVjdH0gYXQg KDAsMTApIHNpemUgMjB4MzAgW2ZpbGw9e1t0eXBlPVNPTElEXSBbY29sb3I9IzAwMDBGRl19XSBb eD0wLjAwXSBbeT0wLjAwXSBbd2lkdGg9MjAuMDBdIFtoZWlnaHQ9MzAuMDBdCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zdmctdmVydGljYWwtcGFuLnN2ZyBiL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL3N2Zy12ZXJ0aWNhbC1wYW4uc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjdjZjdjZTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9zdmctdmVydGljYWwtcGFuLnN2ZwpAQCAtMCwwICsxLDI5IEBACis8P3htbCB2 ZXJzaW9uPSIxLjAiPz4KKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIgor ICAgICB4bWxuczp4aHRtbD0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCIKKyAgICAgd2lk dGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgdmlld2JveD0iMCAwIDIwIDMwIgorICAgICBvbmxvYWQ9 InBhblRlc3QoKTsiPgorICA8cmVjdCB4PSIwIiB5PSIwIiB3aWR0aD0iMjBweCIgaGVpZ2h0PSIz MHB4IiBmaWxsPSJibHVlIiAvPgorICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+Cisg ICAgZnVuY3Rpb24gcGFuVGVzdCgpIHsKKyAgICAgIGlmICghd2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyIHx8ICF3aW5kb3cuZXZlbnRTZW5kZXIpCisgICAgICAgICAgcmV0dXJuOworCisgICAg ICAvLyBTeW50aGVzaXplIG1vdXNlIHBhbiB2ZXJ0aWNhbCBldmVudC4KKyAgICAgIGV2ZW50U2Vu ZGVyLm1vdXNlTW92ZVRvKDEwLDEwKTsKKyAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigwLCBb J3NoaWZ0S2V5J10pOworICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAsMjApOworICAg ICAgZXZlbnRTZW5kZXIubW91c2VVcCgwLCBbJ3NoaWZ0a2V5J10pOworCisgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorCisgICAgLy8gVXNlIG5lc3RlZC1p ZnMgdG8gYXZvaWQgInhtbFBhcnNlRW50aXR5UmVmOiBubyBuYW1lIiBlcnJvciB3aGVuIHZpZXdp bmcgaW4gYnJvd3Nlci4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7Cisg ICAgICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgfQorICAgIH0KKyAgPC9zY3JpcHQ+ Cis8L3N2Zz4KKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDYwMWVjYzcu Ljc0OTgwNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTE1NzMsNyAr MTU3Myw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZU1vdmVFdmVudChjb25zdCBQ bGF0Zm9ybU1vdXNlRXZlbnQmIG1vdXNlRXZlbnQsIEhpCiAKICNpZiBFTkFCTEUoU1ZHKQogICAg IGlmIChtX3N2Z1BhbikgewotICAgICAgICBzdGF0aWNfY2FzdDxTVkdEb2N1bWVudCo+KG1fZnJh bWUtPmRvY3VtZW50KCkpLT51cGRhdGVQYW4obV9jdXJyZW50TW91c2VQb3NpdGlvbik7CisgICAg ICAgIHN0YXRpY19jYXN0PFNWR0RvY3VtZW50Kj4obV9mcmFtZS0+ZG9jdW1lbnQoKSktPnVwZGF0 ZVBhbihtX2N1cnJlbnRNb3VzZVBvc2l0aW9uLCBtb3VzZUV2ZW50LnN2Z1JldmVyc2VZKCkpOwog ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAjZW5kaWYKQEAgLTE2OTQsNyArMTY5NCw3IEBA IGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVJlbGVhc2VFdmVudChjb25zdCBQbGF0Zm9y bU1vdXNlRXZlbnQmIG1vdXNlRXZlbnQpCiAjaWYgRU5BQkxFKFNWRykKICAgICBpZiAobV9zdmdQ YW4pIHsKICAgICAgICAgbV9zdmdQYW4gPSBmYWxzZTsKLSAgICAgICAgc3RhdGljX2Nhc3Q8U1ZH RG9jdW1lbnQqPihtX2ZyYW1lLT5kb2N1bWVudCgpKS0+dXBkYXRlUGFuKG1fY3VycmVudE1vdXNl UG9zaXRpb24pOworICAgICAgICBzdGF0aWNfY2FzdDxTVkdEb2N1bWVudCo+KG1fZnJhbWUtPmRv Y3VtZW50KCkpLT51cGRhdGVQYW4obV9jdXJyZW50TW91c2VQb3NpdGlvbiwgbW91c2VFdmVudC5z dmdSZXZlcnNlWSgpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogI2VuZGlmCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybU1vdXNlRXZlbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oCmluZGV4IDczYzFiYjUu LjA4MjBiYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91 c2VFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVu dC5oCkBAIC04Myw2ICs4Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICwg bV9jdHJsS2V5KGZhbHNlKQogICAgICAgICAgICAgLCBtX2FsdEtleShmYWxzZSkKICAgICAgICAg ICAgICwgbV9tZXRhS2V5KGZhbHNlKQorICAgICAgICAgICAgLCBtX3N2Z1JldmVyc2VZKGZhbHNl KQogICAgICAgICAgICAgLCBtX3RpbWVzdGFtcCgwKQogICAgICAgICAgICAgLCBtX21vZGlmaWVy RmxhZ3MoMCkKICNpZiBQTEFURk9STShNQUMpCkBAIC0xMDQsNiArMTA1LDcgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgICAgICAgICAgLCBtX2N0cmxLZXkoY3RybCkKICAgICAgICAgICAgICwg bV9hbHRLZXkoYWx0KQogICAgICAgICAgICAgLCBtX21ldGFLZXkobWV0YSkKKyAgICAgICAgICAg ICwgbV9zdmdSZXZlcnNlWShmYWxzZSkKICAgICAgICAgICAgICwgbV90aW1lc3RhbXAodGltZXN0 YW1wKQogICAgICAgICAgICAgLCBtX21vZGlmaWVyRmxhZ3MoMCkKICNpZiBQTEFURk9STShNQUMp CkBAIC0xMjYsNiArMTI4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIGN0 cmxLZXkoKSBjb25zdCB7IHJldHVybiBtX2N0cmxLZXk7IH0KICAgICAgICAgYm9vbCBhbHRLZXko KSBjb25zdCB7IHJldHVybiBtX2FsdEtleTsgfQogICAgICAgICBib29sIG1ldGFLZXkoKSBjb25z dCB7IHJldHVybiBtX21ldGFLZXk7IH0KKyAgICAgICAgYm9vbCBzdmdSZXZlcnNlWSgpIGNvbnN0 IHsgcmV0dXJuIG1fc3ZnUmV2ZXJzZVk7IH0KICAgICAgICAgdW5zaWduZWQgbW9kaWZpZXJGbGFn cygpIGNvbnN0IHsgcmV0dXJuIG1fbW9kaWZpZXJGbGFnczsgfQogICAgICAgICAKICAgICAgICAg Ly8gVGltZSBpbiBzZWNvbmRzLgpAQCAtMTg3LDYgKzE5MCw3IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgYm9vbCBtX2N0cmxLZXk7CiAgICAgICAgIGJvb2wgbV9hbHRLZXk7CiAgICAg ICAgIGJvb2wgbV9tZXRhS2V5OworICAgICAgICBib29sIG1fc3ZnUmV2ZXJzZVk7CiAgICAgICAg IGRvdWJsZSBtX3RpbWVzdGFtcDsgLy8gdW5pdDogc2Vjb25kcwogICAgICAgICB1bnNpZ25lZCBt X21vZGlmaWVyRmxhZ3M7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1 bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnQuY3BwCmluZGV4IDliMjAw YjcuLmI5NTliZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1bWVudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50LmNwcApAQCAtODYsMTAgKzg2 LDExIEBAIHZvaWQgU1ZHRG9jdW1lbnQ6OnN0YXJ0UGFuKGNvbnN0IEZsb2F0UG9pbnQmIHN0YXJ0 KQogICAgICAgICBtX3RyYW5zbGF0ZSA9IEZsb2F0UG9pbnQoc3RhcnQueCgpIC0gcm9vdEVsZW1l bnQoKS0+Y3VycmVudFRyYW5zbGF0ZSgpLngoKSwgcm9vdEVsZW1lbnQoKS0+Y3VycmVudFRyYW5z bGF0ZSgpLnkoKSArIHN0YXJ0LnkoKSk7CiB9CiAKLXZvaWQgU1ZHRG9jdW1lbnQ6OnVwZGF0ZVBh bihjb25zdCBGbG9hdFBvaW50JiBwb3MpIGNvbnN0Cit2b2lkIFNWR0RvY3VtZW50Ojp1cGRhdGVQ YW4oY29uc3QgRmxvYXRQb2ludCYgcG9zLCBjb25zdCBib29sIHJldmVyc2VZKSBjb25zdAogewog ICAgIGlmIChyb290RWxlbWVudCgpKSB7Ci0gICAgICAgIHJvb3RFbGVtZW50KCktPnNldEN1cnJl bnRUcmFuc2xhdGUoRmxvYXRQb2ludChwb3MueCgpIC0gbV90cmFuc2xhdGUueCgpLCBtX3RyYW5z bGF0ZS55KCkgLSBwb3MueSgpKSk7CisgICAgICAgIGZsb2F0IHlTZW5zZSA9IHJldmVyc2VZID8g MS4wZiA6IC0xLjBmOworICAgICAgICByb290RWxlbWVudCgpLT5zZXRDdXJyZW50VHJhbnNsYXRl KEZsb2F0UG9pbnQocG9zLngoKSAtIG1fdHJhbnNsYXRlLngoKSwgeVNlbnNlICogKHBvcy55KCkg LSBtX3RyYW5zbGF0ZS55KCkpKSk7CiAgICAgICAgIGlmIChyZW5kZXJlcigpKQogICAgICAgICAg ICAgcmVuZGVyZXIoKS0+cmVwYWludCgpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3N2Zy9TVkdEb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50LmgK aW5kZXggYjkzNDE0NS4uYTY3OTRiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NW R0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50LmgKQEAgLTQ2 LDcgKzQ2LDcgQEAgcHVibGljOgogICAgIGJvb2wgem9vbUFuZFBhbkVuYWJsZWQoKSBjb25zdDsK IAogICAgIHZvaWQgc3RhcnRQYW4oY29uc3QgRmxvYXRQb2ludCYgc3RhcnQpOwotICAgIHZvaWQg dXBkYXRlUGFuKGNvbnN0IEZsb2F0UG9pbnQmIHBvcykgY29uc3Q7CisgICAgdm9pZCB1cGRhdGVQ YW4oY29uc3QgRmxvYXRQb2ludCYgcG9zLCBjb25zdCBib29sIHJldmVyc2VZKSBjb25zdDsKIAog cHJpdmF0ZToKICAgICBTVkdEb2N1bWVudChGcmFtZSosIGNvbnN0IEtVUkwmKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNw cAppbmRleCAwZGRlYTAyLi4wYTllZGIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3BwCkBAIC02MCw2ICs2MCw3IEBA IFBsYXRmb3JtTW91c2VFdmVudEJ1aWxkZXI6OlBsYXRmb3JtTW91c2VFdmVudEJ1aWxkZXIoV2lk Z2V0KiB3aWRnZXQsIGNvbnN0IFdlYk1vCiAgICAgbV9jdHJsS2V5ID0gKGUubW9kaWZpZXJzICYg V2ViSW5wdXRFdmVudDo6Q29udHJvbEtleSk7CiAgICAgbV9hbHRLZXkgPSAoZS5tb2RpZmllcnMg JiBXZWJJbnB1dEV2ZW50OjpBbHRLZXkpOwogICAgIG1fbWV0YUtleSA9IChlLm1vZGlmaWVycyAm IFdlYklucHV0RXZlbnQ6Ok1ldGFLZXkpOworICAgIG1fc3ZnUmV2ZXJzZVkgPSB0cnVlOwogICAg IG1fbW9kaWZpZXJGbGFncyA9IGUubW9kaWZpZXJzOwogICAgIG1fdGltZXN0YW1wID0gZS50aW1l U3RhbXBTZWNvbmRzOwogICAgIG1fY2xpY2tDb3VudCA9IGUuY2xpY2tDb3VudDsK