66311 2011-08-16 09:56:46 -0700 Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface 2011-08-17 04:46:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED P2 Normal --- 1 sail sail jamesr thakis webkit.review.bot oldest_to_newest 451689 0 sail 2011-08-16 09:56:46 -0700 This bug is to track the work need to update wkScrollbarMinimumTotalLengthNeededForThumb() to match the implementation in WebKitSystemInterface. 452072 1 104139 sail 2011-08-16 19:08:00 -0700 Created attachment 104139 Patch 452073 2 104139 thakis 2011-08-16 19:12:25 -0700 Comment on attachment 104139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104139&action=review > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:213 > + [painter knobOverlapEndInset] + why are trackOverlapEndInset and knobOverlapEndInset not *2? 452082 3 104139 sail 2011-08-16 20:02:24 -0700 Comment on attachment 104139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104139&action=review >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:213 >> + [painter knobOverlapEndInset] + > > why are trackOverlapEndInset and knobOverlapEndInset not *2? I spent some time running this on Lion to see if I could figure out why the various values meant but I still don't understand it. When I run this for opaque scrollbars I get the following values: - knobMinLenth: 20 - knobEndInset: 2 - everything else: 0 For overlay scrollbars I get: - knowMinLength: 26 - trackOverlapEndInset: 3 - trackEndInset: 1 At this point I just gave up and copied the code from the disassembly. 452083 4 sail 2011-08-16 20:03:12 -0700 For reference, here's the disassembly: http://code.google.com/p/chromium/issues/detail?id=74057#c35 and here's what I understood from it: 0xf0(%rbp) <- knobMinLength + trackOverlapEndInset + knobOverlapEndInset 0xe8(%rbp) <- trackEndInset movq 0x0010629d(%rip),%rsi trackEndInset movq %rbx,%rdi callq 0x00112d3e -[%rdi trackEndInset] movsd %xmm0,0xe8(%rbp) %xmm0 <- knobEndInset movq 0x00106281(%rip),%rsi knobEndInset movq %rbx,%rdi callq 0x00112d3e -[%rdi knobEndInset] %xmm0 <- knobEndInset + trackEndInset addsd 0xe8(%rbp),%xmm0 %xmm0 <- (knobEndInset + trackEndInset) * 2 addsd %xmm0,%xmm0 %xmm0 <- knobMinLength + trackOverlapEndInset + knobOverlapEndInset + (knobEndInset + trackEndInset) * 2 addsd 0xf0(%rbp),%xmm0 452103 5 104139 thakis 2011-08-16 21:12:15 -0700 Comment on attachment 104139 Patch LGTM 452106 6 104139 dglazkov 2011-08-16 21:15:15 -0700 Comment on attachment 104139 Patch my rubberstamp is quick like a monkey. 452130 7 104139 webkit.review.bot 2011-08-16 22:33:06 -0700 Comment on attachment 104139 Patch Rejecting attachment 104139 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: it-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource From git://git.webkit.org/WebKit + 0651a90...54d0520 master -> origin/master (forced update) Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9403679 452134 8 thakis 2011-08-16 22:38:57 -0700 Huh! If you reupload with `land-safely`, the script will hopefully fill in the "reviewed by" line; if not you'll have to do that manually. Weird the commit-queue didn't do that. 452136 9 104152 sail 2011-08-16 22:43:14 -0700 Created attachment 104152 Patch for landing 452137 10 104152 webkit.review.bot 2011-08-16 22:43:39 -0700 Comment on attachment 104152 Patch for landing Rejecting attachment 104152 from commit-queue. sail@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 452205 11 104152 webkit.review.bot 2011-08-17 04:45:55 -0700 Comment on attachment 104152 Patch for landing Clearing flags on attachment: 104152 Committed r93202: <http://trac.webkit.org/changeset/93202> 452206 12 webkit.review.bot 2011-08-17 04:46:00 -0700 All reviewed patches have been landed. Closing bug. 104139 2011-08-16 19:08:00 -0700 2011-08-16 22:43:11 -0700 Patch bug-66311-20110816190759.patch text/plain 2212 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MGU4ZmM1MzEzOThiMmNk YjZjMDk4YmY5NjBhYTczNzlhODhiYmVhLi5lMTc5YjA2ZTdhMTBhM2U0MTc3NjJmNjk2YjM4NDRj ODk4YTc4ZjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog Rml4IGltcGxlbWVudGF0aW9uIG9mIHdrU2Nyb2xsYmFyTWluaW11bVRvdGFsTGVuZ3RoTmVlZGVk Rm9yVGh1bWIgdG8gbWF0Y2ggV2ViS2l0U3lzdGVtSW50ZXJmYWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjMxMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgd2tTY3JvbGxiYXJNaW5pbXVt VG90YWxMZW5ndGhOZWVkZWRGb3JUaHVtYigpIGJhc2VkIG9uIHRoZSBsYXRlc3QgZGlzYXNzZW1i bHkgb2YgbGliV2ViS2l0U3lzdGVtSW50ZXJmYWNlTGlvbi5hLgorCisgICAgICAgICogcGxhdGZv cm0vY2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFjLm1tOgorICAg ICAgICAod2tTY3JvbGxiYXJNaW5pbXVtVG90YWxMZW5ndGhOZWVkZWRGb3JUaHVtYik6CisKIDIw MTEtMDgtMTUgIEplZmZyZXkgUGZhdSAgPGpwZmF1QGFwcGxlLmNvbT4KIAogICAgICAgICBOZXcg WE1MIHBhcnNlcjogYWRkIHhtbCBuYW1lc3BhY2UgdG8gdGhlIGRlZmF1bHQgbWFwIG9mIG5hbWVz cGFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9s bGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5tbQppbmRl eCA2NDAzZjA3NzI4MWJjYzE4MzkzZWMxZmYxYWRjNjhhMzkxMGVkYjA3Li41YmQ0NTgxMjg5YWMy YzFmNmExNDRiODI5OThhYjFkODhkODAzOTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0K KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0 aWxpdGllc0Nocm9taXVtTWFjLm1tCkBAIC02Nyw2ICs2NywxMCBAQAogQHByb3BlcnR5KGFzc2ln bikgaWQgZGVsZWdhdGU7CiAKIC0gKENHRmxvYXQpa25vYk1pbkxlbmd0aDsKKy0gKENHRmxvYXQp dHJhY2tPdmVybGFwRW5kSW5zZXQ7CistIChDR0Zsb2F0KWtub2JPdmVybGFwRW5kSW5zZXQ7Cist IChDR0Zsb2F0KXRyYWNrRW5kSW5zZXQ7CistIChDR0Zsb2F0KWtub2JFbmRJbnNldDsKIC0gKENH RmxvYXQpdHJhY2tCb3hXaWR0aDsKIC0gKENHRmxvYXQpdHJhY2tXaWR0aDsKIC0gKHZvaWQpc2V0 Qm91bmRzU2l6ZTooTlNTaXplKXNpemU7CkBAIC0yMDQsOCArMjA4LDEwIEBAIGludCB3a1Njcm9s bGJhclRoaWNrbmVzcyhpbnQgY29udHJvbFNpemUpCiAKIGludCB3a1Njcm9sbGJhck1pbmltdW1U b3RhbExlbmd0aE5lZWRlZEZvclRodW1iKFdLU2Nyb2xsYmFyUGFpbnRlclJlZiBwYWludGVyKQog ewotICAgIC8vIFRPRE8oc2FpbCk6IFRoaXMgZG9lc24ndCBtYXRjaCB0aGUgaW1wbGVtZW50YXRp b24gaW4gV2ViS2l0U3lzdGVtSW50ZXJmYWNlLgotICAgIHJldHVybiB3a1Njcm9sbGJhck1pbmlt dW1UaHVtYkxlbmd0aChwYWludGVyKTsKKyAgICByZXR1cm4gW3BhaW50ZXIga25vYk1pbkxlbmd0 aF0gKworICAgICAgICAgICBbcGFpbnRlciB0cmFja092ZXJsYXBFbmRJbnNldF0gKworICAgICAg ICAgICBbcGFpbnRlciBrbm9iT3ZlcmxhcEVuZEluc2V0XSArCisgICAgICAgICAgIChbcGFpbnRl ciB0cmFja0VuZEluc2V0XSArIFtwYWludGVyIGtub2JFbmRJbnNldF0pICogMjsKIH0KIAogV0tT Y3JvbGxiYXJQYWludGVyUmVmIHdrVmVydGljYWxTY3JvbGxiYXJQYWludGVyRm9yQ29udHJvbGxl cihXS1Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyUmVmIGNvbnRyb2xsZXIpCg== 104152 2011-08-16 22:43:14 -0700 2011-08-17 04:45:55 -0700 Patch for landing bug-66311-20110816224313.patch text/plain 2213 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MGU4ZmM1MzEzOThiMmNk YjZjMDk4YmY5NjBhYTczNzlhODhiYmVhLi5lZTQzZGI4N2IxM2EwNGM3Y2JiOGNhYzNjODBkZjU2 YWYwN2RiMTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog Rml4IGltcGxlbWVudGF0aW9uIG9mIHdrU2Nyb2xsYmFyTWluaW11bVRvdGFsTGVuZ3RoTmVlZGVk Rm9yVGh1bWIgdG8gbWF0Y2ggV2ViS2l0U3lzdGVtSW50ZXJmYWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjMxMQorCisgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KKworICAgICAgICBVcGRhdGVkIHdrU2Nyb2xsYmFyTWluaW11 bVRvdGFsTGVuZ3RoTmVlZGVkRm9yVGh1bWIoKSBiYXNlZCBvbiB0aGUgbGF0ZXN0IGRpc2Fzc2Vt Ymx5IG9mIGxpYldlYktpdFN5c3RlbUludGVyZmFjZUxpb24uYS4KKworICAgICAgICAqIHBsYXRm b3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5tbToKKyAg ICAgICAgKHdrU2Nyb2xsYmFyTWluaW11bVRvdGFsTGVuZ3RoTmVlZGVkRm9yVGh1bWIpOgorCiAy MDExLTA4LTE1ICBKZWZmcmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5jb20+CiAKICAgICAgICAgTmV3 IFhNTCBwYXJzZXI6IGFkZCB4bWwgbmFtZXNwYWNlIHRvIHRoZSBkZWZhdWx0IG1hcCBvZiBuYW1l c3BhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3Jv bGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0KaW5k ZXggNjQwM2YwNzcyODFiY2MxODM5M2VjMWZmMWFkYzY4YTM5MTBlZGIwNy4uNWJkNDU4MTI4OWFj MmMxZjZhMTQ0YjgyOTk4YWIxZDg4ZDgwMzkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFjLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlV dGlsaXRpZXNDaHJvbWl1bU1hYy5tbQpAQCAtNjcsNiArNjcsMTAgQEAKIEBwcm9wZXJ0eShhc3Np Z24pIGlkIGRlbGVnYXRlOwogCiAtIChDR0Zsb2F0KWtub2JNaW5MZW5ndGg7CistIChDR0Zsb2F0 KXRyYWNrT3ZlcmxhcEVuZEluc2V0OworLSAoQ0dGbG9hdClrbm9iT3ZlcmxhcEVuZEluc2V0Owor LSAoQ0dGbG9hdCl0cmFja0VuZEluc2V0OworLSAoQ0dGbG9hdClrbm9iRW5kSW5zZXQ7CiAtIChD R0Zsb2F0KXRyYWNrQm94V2lkdGg7CiAtIChDR0Zsb2F0KXRyYWNrV2lkdGg7CiAtICh2b2lkKXNl dEJvdW5kc1NpemU6KE5TU2l6ZSlzaXplOwpAQCAtMjA0LDggKzIwOCwxMCBAQCBpbnQgd2tTY3Jv bGxiYXJUaGlja25lc3MoaW50IGNvbnRyb2xTaXplKQogCiBpbnQgd2tTY3JvbGxiYXJNaW5pbXVt VG90YWxMZW5ndGhOZWVkZWRGb3JUaHVtYihXS1Njcm9sbGJhclBhaW50ZXJSZWYgcGFpbnRlcikK IHsKLSAgICAvLyBUT0RPKHNhaWwpOiBUaGlzIGRvZXNuJ3QgbWF0Y2ggdGhlIGltcGxlbWVudGF0 aW9uIGluIFdlYktpdFN5c3RlbUludGVyZmFjZS4KLSAgICByZXR1cm4gd2tTY3JvbGxiYXJNaW5p bXVtVGh1bWJMZW5ndGgocGFpbnRlcik7CisgICAgcmV0dXJuIFtwYWludGVyIGtub2JNaW5MZW5n dGhdICsKKyAgICAgICAgICAgW3BhaW50ZXIgdHJhY2tPdmVybGFwRW5kSW5zZXRdICsKKyAgICAg ICAgICAgW3BhaW50ZXIga25vYk92ZXJsYXBFbmRJbnNldF0gKworICAgICAgICAgICAoW3BhaW50 ZXIgdHJhY2tFbmRJbnNldF0gKyBbcGFpbnRlciBrbm9iRW5kSW5zZXRdKSAqIDI7CiB9CiAKIFdL U2Nyb2xsYmFyUGFpbnRlclJlZiB3a1ZlcnRpY2FsU2Nyb2xsYmFyUGFpbnRlckZvckNvbnRyb2xs ZXIoV0tTY3JvbGxiYXJQYWludGVyQ29udHJvbGxlclJlZiBjb250cm9sbGVyKQo=