66282 2011-08-15 23:13:31 -0700 When changing the size of a menulist from x (x>1) to 1, the first item should be selected. 2011-08-18 04:06:11 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jingzhao webkit-unassigned jnd kling satish tkent wangxianzhu webkit.review.bot zhenghao oldest_to_newest 451510 0 jingzhao 2011-08-15 23:13:31 -0700 Should set default selection for single selects 451511 1 104010 jingzhao 2011-08-15 23:25:38 -0700 Created attachment 104010 Patch 451513 2 jingzhao 2011-08-15 23:32:41 -0700 Now we only set default selection for a single select when its size is 1. We should change that condition to if it's presented as a menulist, because in Android we present a single select as a menulist no matter what its size is. 451583 3 104034 jingzhao 2011-08-16 06:42:17 -0700 Created attachment 104034 Patch 451585 4 jingzhao 2011-08-16 06:47:01 -0700 Xianzhu suggested not to select the first item when size > 1, because that's inconsistent with other platforms. If a developer assumes a select should be unselected because its size > 1, his/her page may have different behavior in Android browser. I changed this bug to fix another problem: when changing the size of a menulist from x (x>1) to 1, the first item should be selected. The current logic assumes a menulist must have its size <= 1, which is true in most WebKit platforms, but in Android browser, a select is always presented as a menulist no matter what size it is. 451598 5 104034 jnd 2011-08-16 07:17:19 -0700 Comment on attachment 104034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104034&action=review > Source/WebCore/html/HTMLSelectElement.cpp:266 > + if ((oldUsesMenuList != m_data.usesMenuList() || (!oldUsesMenuList && m_data.size() != oldSize)) && attached()) Current WebKit code assumes that menuList is always only used for select(size<=1 && !m_multiple), but looks like Android browser breaks this rule. So in the second condition, even the oldUsesMenuList is true (which means m_data.usesMenuList() is also true, but does not mean the size of select is 1), the Select's size still can be changed to value other than 1 and the change still requires to re-generate the renderer object (call method reattach) What do you think? 451600 6 104039 jingzhao 2011-08-16 07:25:11 -0700 Created attachment 104039 Patch 451603 7 104034 jingzhao 2011-08-16 07:28:02 -0700 Comment on attachment 104034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104034&action=review >> Source/WebCore/html/HTMLSelectElement.cpp:266 >> + if ((oldUsesMenuList != m_data.usesMenuList() || (!oldUsesMenuList && m_data.size() != oldSize)) && attached()) > > Current WebKit code assumes that menuList is always only used for select(size<=1 && !m_multiple), but looks like Android browser breaks this rule. So in the second condition, even the oldUsesMenuList is true (which means m_data.usesMenuList() is also true, but does not mean the size of select is 1), the Select's size still can be changed to value other than 1 and the change still requires to re-generate the renderer object (call method reattach) > > What do you think? Totally agreed. Just updated a new patch. Thanks! 452188 8 104164 jingzhao 2011-08-17 03:15:15 -0700 Created attachment 104164 Patch 452189 9 104164 webkit-ews 2011-08-17 03:22:22 -0700 Comment on attachment 104164 Patch Attachment 104164 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9402827 452190 10 104165 jingzhao 2011-08-17 03:26:35 -0700 Created attachment 104165 Patch 452191 11 jingzhao 2011-08-17 03:28:23 -0700 There are 3 different cases when (m_data.size() != oldSize): 1. (oldUsesMenuList != m_data.usesMenuList()): menu list changes to list box or list box changes to menu list 2. (!oldUsesMenuList && m_data.size() != oldSize): list box changes size 3. (oldUsesMenuList && m_data.size() != oldSize): menu list changes size The original condition excludes the third case because it doesn't exist in platforms other than Android browser. My change is to add back the third case. 452848 12 104165 tkent 2011-08-17 21:42:48 -0700 Comment on attachment 104165 Patch The code change looks ok. I'm afraid the test coverage. Do you have a plan to create LayoutTests/platforms/android/ directory? If so, you should add a test for this change into LayouTests/platforms/android/fast/forms/. 452927 13 jingzhao 2011-08-18 03:17:12 -0700 I already have a test for this, and will commit it later when Android DumpRenderTree is ready. Thanks! 452928 14 tkent 2011-08-18 03:18:48 -0700 (In reply to comment #13) > I already have a test for this, and will commit it later when Android DumpRenderTree is ready. Ok, it's reasonable. 452945 15 104165 webkit.review.bot 2011-08-18 04:06:06 -0700 Comment on attachment 104165 Patch Clearing flags on attachment: 104165 Committed r93295: <http://trac.webkit.org/changeset/93295> 452946 16 webkit.review.bot 2011-08-18 04:06:11 -0700 All reviewed patches have been landed. Closing bug. 104010 2011-08-15 23:25:38 -0700 2011-08-16 06:42:07 -0700 Patch bug-66282-20110816142536.patch text/plain 1825 jingzhao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMDg2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTUgIEppbmcgWmhh byAgPGppbmd6aGFvQGNocm9taXVtLm9yZz4KKworICAgICAgICBTZXQgZGVmYXVsdCBzZWxlY3Rp b24gZm9yIGEgc2luZ2xlIHNlbGVjdCB3aGVuIGl0J3MgcHJlc2VudGVkIGFzIGEgbWVudWxpc3Qu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI4Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL1Nl bGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0RWxlbWVudDo6cmVjYWxj TGlzdEl0ZW1zKToKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdEVsZW1lbnQ6OnJlc2V0KToKKwog MjAxMS0wOC0xNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtDTUFLRV0gV3JhcCBmaWxlcyBvZiB3ZWJzb2NrZXQgYW5kIHdvcmtlciBpbiBlYWNo IG1hY3JvLgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAkocmV2aXNpb24g OTI4MzMpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMxMyw3ICszMTMsNyBAQCB2b2lkIFNlbGVjdEVsZW1lbnQ6OnJlY2FsY0xpc3RJ dGVtcyhTZWxlCiAgICAgICAgICAgICBsaXN0SXRlbXMuYXBwZW5kKGN1cnJlbnQpOwogCiAgICAg ICAgICAgICBpZiAodXBkYXRlU2VsZWN0ZWRTdGF0ZXMgJiYgIWRhdGEubXVsdGlwbGUoKSkgewot ICAgICAgICAgICAgICAgIGlmICghZm91bmRTZWxlY3RlZCAmJiAoZGF0YS5zaXplKCkgPD0gMSB8 fCBvcHRpb25FbGVtZW50LT5zZWxlY3RlZCgpKSkgeworICAgICAgICAgICAgICAgIGlmICghZm91 bmRTZWxlY3RlZCAmJiAoZGF0YS51c2VzTWVudUxpc3QoKSB8fCBvcHRpb25FbGVtZW50LT5zZWxl Y3RlZCgpKSkgewogICAgICAgICAgICAgICAgICAgICBmb3VuZFNlbGVjdGVkID0gb3B0aW9uRWxl bWVudDsKICAgICAgICAgICAgICAgICAgICAgZm91bmRTZWxlY3RlZC0+c2V0U2VsZWN0ZWRTdGF0 ZSh0cnVlKTsKICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGZvdW5kU2VsZWN0ZWQgJiYgb3B0 aW9uRWxlbWVudC0+c2VsZWN0ZWQoKSkgewpAQCAtNTUxLDcgKzU1MSw3IEBAIHZvaWQgU2VsZWN0 RWxlbWVudDo6cmVzZXQoU2VsZWN0RWxlbWVudEQKICAgICAgICAgICAgIGZpcnN0T3B0aW9uID0g b3B0aW9uRWxlbWVudDsKICAgICB9CiAKLSAgICBpZiAoIXNlbGVjdGVkT3B0aW9uICYmIGZpcnN0 T3B0aW9uICYmICFkYXRhLm11bHRpcGxlKCkgJiYgZGF0YS5zaXplKCkgPD0gMSkKKyAgICBpZiAo IXNlbGVjdGVkT3B0aW9uICYmIGZpcnN0T3B0aW9uICYmICFkYXRhLm11bHRpcGxlKCkgJiYgZGF0 YS51c2VzTWVudUxpc3QoKSkKICAgICAgICAgZmlyc3RPcHRpb24tPnNldFNlbGVjdGVkU3RhdGUo dHJ1ZSk7CiAKICAgICBzZXRPcHRpb25zQ2hhbmdlZE9uUmVuZGVyZXIoZGF0YSwgZWxlbWVudCk7 Cg== 104034 2011-08-16 06:42:17 -0700 2011-08-16 07:28:02 -0700 Patch bug-66282-20110816214215.patch text/plain 1691 jingzhao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMDkyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIEppbmcgWmhh byAgPGppbmd6aGFvQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2luZyB0aGUgc2l6ZSBv ZiBhIG1lbnVsaXN0IGZyb20geCAoeD4xKSB0byAxIHNob3VsZCBhY3F1aXJlIHNlbGVjdGlvbiBv ZiB0aGUgZmlyc3QgaXRlbS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY2MjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGl0IG9ubHkgY2hhbmdlcyB0aGUgYmVoYXZpb3Ig aW4gQW5kcm9pZCBCcm93c2VyLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRy aWJ1dGUpOgorCiAyMDExLTA4LTE1ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29t PgogCiAgICAgICAgIFJFR1JFU1NJT04ocjcwNTk4KTogW0Nocm9taXVtXSBTdHlsZSBjaGFuZ2Vz IGluIHRleHRJbnB1dCBldmVudCBjYW4gcHJldmVudCBmcm9tIHVwZGF0aW5nIDx0ZXh0YXJlYT4g dmFsdWUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAko cmV2aXNpb24gOTMwOTIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYzLDEwICsyNjMsMTAgQEAgdm9pZCBIVE1MU2VsZWN0 RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaQogCiAgICAgICAgIG1fZGF0YS5zZXRTaXplKHNpemUp OwogICAgICAgICBzZXROZWVkc1ZhbGlkaXR5Q2hlY2soKTsKLSAgICAgICAgaWYgKChvbGRVc2Vz TWVudUxpc3QgIT0gbV9kYXRhLnVzZXNNZW51TGlzdCgpIHx8ICghb2xkVXNlc01lbnVMaXN0ICYm IG1fZGF0YS5zaXplKCkgIT0gb2xkU2l6ZSkpICYmIGF0dGFjaGVkKCkpIHsKKyAgICAgICAgaWYg KChvbGRVc2VzTWVudUxpc3QgIT0gbV9kYXRhLnVzZXNNZW51TGlzdCgpIHx8ICghb2xkVXNlc01l bnVMaXN0ICYmIG1fZGF0YS5zaXplKCkgIT0gb2xkU2l6ZSkpICYmIGF0dGFjaGVkKCkpCiAgICAg ICAgICAgICByZWF0dGFjaCgpOworICAgICAgICBpZiAobV9kYXRhLnNpemUoKSAhPSBvbGRTaXpl KQogICAgICAgICAgICAgc2V0UmVjYWxjTGlzdEl0ZW1zKCk7Ci0gICAgICAgIH0KICAgICB9IGVs c2UgaWYgKGF0dHItPm5hbWUoKSA9PSBtdWx0aXBsZUF0dHIpCiAgICAgICAgIFNlbGVjdEVsZW1l bnQ6OnBhcnNlTXVsdGlwbGVBdHRyaWJ1dGUobV9kYXRhLCB0aGlzLCBhdHRyKTsKICAgICBlbHNl IGlmIChhdHRyLT5uYW1lKCkgPT0gYWNjZXNza2V5QXR0cikgewo= 104039 2011-08-16 07:25:11 -0700 2011-08-17 03:14:59 -0700 Patch bug-66282-20110816222503.patch text/plain 1466 jingzhao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMDkyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIEppbmcgWmhh byAgPGppbmd6aGFvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXaGVuIGNoYW5naW5nIHRoZSBz aXplIG9mIGEgbWVudWxpc3QgZnJvbSB4ICh4PjEpIHRvIDEsIHRoZSBmaXJzdCBpdGVtIHNob3Vs ZCBiZSBzZWxlY3RlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY2MjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGl0IG9ubHkgY2hhbmdlcyB0aGUgYmVoYXZpb3IgaW4g QW5kcm9pZCBCcm93c2VyLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1 dGUpOgorCiAyMDExLTA4LTE1ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgog CiAgICAgICAgIFJFR1JFU1NJT04ocjcwNTk4KTogW0Nocm9taXVtXSBTdHlsZSBjaGFuZ2VzIGlu IHRleHRJbnB1dCBldmVudCBjYW4gcHJldmVudCBmcm9tIHVwZGF0aW5nIDx0ZXh0YXJlYT4gdmFs dWUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAkocmV2 aXNpb24gOTMwOTIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjYzLDcgKzI2Myw3IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1l bnQ6OnBhcnNlTWFwcGVkQXR0cmkKIAogICAgICAgICBtX2RhdGEuc2V0U2l6ZShzaXplKTsKICAg ICAgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7Ci0gICAgICAgIGlmICgob2xkVXNlc01lbnVM aXN0ICE9IG1fZGF0YS51c2VzTWVudUxpc3QoKSB8fCAoIW9sZFVzZXNNZW51TGlzdCAmJiBtX2Rh dGEuc2l6ZSgpICE9IG9sZFNpemUpKSAmJiBhdHRhY2hlZCgpKSB7CisgICAgICAgIGlmICgob2xk VXNlc01lbnVMaXN0ICE9IG1fZGF0YS51c2VzTWVudUxpc3QoKSB8fCBtX2RhdGEuc2l6ZSgpICE9 IG9sZFNpemUpICYmIGF0dGFjaGVkKCkpIHsKICAgICAgICAgICAgIHJlYXR0YWNoKCk7CiAgICAg ICAgICAgICBzZXRSZWNhbGNMaXN0SXRlbXMoKTsKICAgICAgICAgfQo= 104164 2011-08-17 03:15:15 -0700 2011-08-17 03:26:20 -0700 Patch bug-66282-20110817181514.patch text/plain 1398 jingzhao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMTk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIEppbmcgWmhh byAgPGppbmd6aGFvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXaGVuIGNoYW5naW5nIHRoZSBz aXplIG9mIGEgbWVudWxpc3QgZnJvbSB4ICh4PjEpIHRvIDEsIHRoZSBmaXJzdCBpdGVtIHNob3Vs ZCBiZSBzZWxlY3RlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY2MjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGl0IG9ubHkgY2hhbmdlcyB0aGUgYmVoYXZpb3IgaW4g QW5kcm9pZCBCcm93c2VyLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1 dGUpOgorCiAyMDExLTA4LTE2ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmVwcmVzZW50IFJlbmRlclN0eWxlOjp0ZXh0T3ZlcmZsb3cgcHJv cGVydHkgdXNpbmcgYW4gZW51bSBpbnN0ZWFkIG9mIGEgYm9vbC4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiA5MzE5NSkKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NjMsNyArMjYzLDcgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaQog CiAgICAgICAgIG1fZGF0YS5zZXRTaXplKHNpemUpOwogICAgICAgICBzZXROZWVkc1ZhbGlkaXR5 Q2hlY2soKTsKLSAgICAgICAgaWYgKChvbGRVc2VzTWVudUxpc3QgIT0gbV9kYXRhLnVzZXNNZW51 TGlzdCgpIHx8ICghb2xkVXNlc01lbnVMaXN0ICYmIG1fZGF0YS5zaXplKCkgIT0gb2xkU2l6ZSkp ICYmIGF0dGFjaGVkKCkpIHsKKyAgICAgICAgaWYgKG1fZGF0YS5zaXplKCkgIT0gb2xkU2l6ZSAm JiBhdHRhY2hlZCgpKSB7CiAgICAgICAgICAgICByZWF0dGFjaCgpOwogICAgICAgICAgICAgc2V0 UmVjYWxjTGlzdEl0ZW1zKCk7CiAgICAgICAgIH0K 104165 2011-08-17 03:26:35 -0700 2011-08-18 04:06:06 -0700 Patch bug-66282-20110817182633.patch text/plain 1799 jingzhao SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMTk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTYgIEppbmcgWmhh byAgPGppbmd6aGFvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXaGVuIGNoYW5naW5nIHRoZSBz aXplIG9mIGEgbWVudWxpc3QgZnJvbSB4ICh4PjEpIHRvIDEsIHRoZSBmaXJzdCBpdGVtIHNob3Vs ZCBiZSBzZWxlY3RlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY2MjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGl0IG9ubHkgY2hhbmdlcyB0aGUgYmVoYXZpb3IgaW4g QW5kcm9pZCBCcm93c2VyLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1 dGUpOgorCiAyMDExLTA4LTE2ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmVwcmVzZW50IFJlbmRlclN0eWxlOjp0ZXh0T3ZlcmZsb3cgcHJv cGVydHkgdXNpbmcgYW4gZW51bSBpbnN0ZWFkIG9mIGEgYm9vbC4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiA5MzE5NSkKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NDQsOSArMjQ0LDggQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6cmVzdG9yZUZvcm1Db250cgog ICAgIHNldE5lZWRzVmFsaWRpdHlDaGVjaygpOwogfQogCi12b2lkIEhUTUxTZWxlY3RFbGVtZW50 OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZShBdHRyaWJ1dGUqIGF0dHIpIAordm9pZCBIVE1MU2VsZWN0 RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUoQXR0cmlidXRlKiBhdHRyKQogewotICAgIGJv b2wgb2xkVXNlc01lbnVMaXN0ID0gbV9kYXRhLnVzZXNNZW51TGlzdCgpOwogICAgIGlmIChhdHRy LT5uYW1lKCkgPT0gc2l6ZUF0dHIpIHsKICAgICAgICAgaW50IG9sZFNpemUgPSBtX2RhdGEuc2l6 ZSgpOwogICAgICAgICAvLyBTZXQgdGhlIGF0dHJpYnV0ZSB2YWx1ZSB0byBhIG51bWJlci4KQEAg LTI2Myw3ICsyNjIsNyBAQCB2b2lkIEhUTUxTZWxlY3RFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJp CiAKICAgICAgICAgbV9kYXRhLnNldFNpemUoc2l6ZSk7CiAgICAgICAgIHNldE5lZWRzVmFsaWRp dHlDaGVjaygpOwotICAgICAgICBpZiAoKG9sZFVzZXNNZW51TGlzdCAhPSBtX2RhdGEudXNlc01l bnVMaXN0KCkgfHwgKCFvbGRVc2VzTWVudUxpc3QgJiYgbV9kYXRhLnNpemUoKSAhPSBvbGRTaXpl KSkgJiYgYXR0YWNoZWQoKSkgeworICAgICAgICBpZiAobV9kYXRhLnNpemUoKSAhPSBvbGRTaXpl ICYmIGF0dGFjaGVkKCkpIHsKICAgICAgICAgICAgIHJlYXR0YWNoKCk7CiAgICAgICAgICAgICBz ZXRSZWNhbGNMaXN0SXRlbXMoKTsKICAgICAgICAgfQo=