66281 2011-08-15 22:44:24 -0700 Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty 2011-08-17 17:07:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric macpherson mitz simon.fraser tony webkit.review.bot oldest_to_newest 451505 0 macpherson 2011-08-15 22:44:24 -0700 Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty 451506 1 104008 macpherson 2011-08-15 22:49:09 -0700 Created attachment 104008 Patch 452402 2 104008 eric 2011-08-17 11:26:35 -0700 Comment on attachment 104008 Patch Seems previously it would ignore bad values, and now this will ASSERT on bad values, is that a correct reading? Could you end up getting the grammar to hand the style-selector a non-number here? 452704 3 macpherson 2011-08-17 16:26:32 -0700 That is correct, and it should be an assert because anything other than a number would indicate a bug in CSSParser.cpp:1524 - 1528 case CSSPropertyWebkitBoxFlex: validPrimitive = validUnit(value, FNumber, m_strict); break; case CSSPropertyWebkitBoxFlexGroup: case CSSPropertyWebkitBoxOrdinalGroup: validPrimitive = validUnit(value, FInteger | FNonNeg, true); As you can see only the appropriate types are considered valid. 452744 4 104008 webkit.review.bot 2011-08-17 17:07:12 -0700 Comment on attachment 104008 Patch Clearing flags on attachment: 104008 Committed r93263: <http://trac.webkit.org/changeset/93263> 452745 5 webkit.review.bot 2011-08-17 17:07:16 -0700 All reviewed patches have been landed. Closing bug. 104008 2011-08-15 22:49:09 -0700 2011-08-17 17:07:12 -0700 Patch bug-66281-20110816154907.patch text/plain 3790 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMDg2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDgtMTUgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBTdXBwb3J0IGNh c3QgZnJvbSBDU1NQcmltaXRpdmVWYWx1ZSB0byB1bnNpZ25lZCwgYW5kIHVzZSBpbiBhcHByb3By aWF0ZSBwbGFjZXMgaW4gQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYyODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgLSByZWZh Y3RvcmluZyBvbmx5LgorCisgICAgICAgIFRoZSByZXR1cm4gaWYgdHlwZSE9Q1NTX05VTUJFUiBj YXNlIGJlY29tZXMgYW4gQVNTRVJUIGJlY2F1c2UgaXQgaXMgdW5yZWFjaGFibGUgdW5sZXNzIHRo ZXJlIGlzIGFuIGVycm9yIGluIHRoZSBwYXJzZXIuCisKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0 aXZlVmFsdWVNYXBwaW5ncy5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6 OkNTU1ByaW1pdGl2ZVZhbHVlKToKKyAgICAgICAgU3VwcG9ydCBjYXN0IGZyb20gdW5zaWduZWQg dG8gQ1NTUHJpbWl0aXZlVmFsdWUKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1pdGl2ZVZhbHVl OjpvcGVyYXRvciB1bnNpZ25lZCk6CisgICAgICAgIFN1cHBvcnQgY2FzdCBmcm9tIENTU1ByaW1p dGl2ZVZhbHVlIHRvIHVuc2lnbmVkCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6Cisg ICAgICAgIFVzZSBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFIG1hY3Jv IGZvciBDU1NQcm9wZXJ0eVdlYmtpdEJveEZsZXgsCisgICAgICAgIENTU1Byb3BlcnR5V2Via2l0 Qm94RmxleEdyb3VwIGFuZCBDU1NQcm9wZXJ0eVdlYmtpdEJveE9yZGluYWxHcm91cCBwcm9wZXJ0 aWVzLgorCiAyMDExLTA4LTE1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5j b20+CiAKICAgICAgICAgW0NNQUtFXSBXcmFwIGZpbGVzIG9mIHdlYnNvY2tldCBhbmQgd29ya2Vy IGluIGVhY2ggbWFjcm8uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFs dWVNYXBwaW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRp dmVWYWx1ZU1hcHBpbmdzLmgJKHJldmlzaW9uIDkzMDg2KQorKysgU291cmNlL1dlYkNvcmUvY3Nz L0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtMTAxLDYgKzEw MSwyMyBAQCB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6b3BlCiB9CiAjZW5k aWYKIAordGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZh bHVlKHVuc2lnbmVkIGkpCisgICAgOiBtX3R5cGUoQ1NTX05VTUJFUikKKyAgICAsIG1faGFzQ2Fj aGVkQ1NTVGV4dChmYWxzZSkKK3sKKyAgICBtX3ZhbHVlLm51bSA9IHN0YXRpY19jYXN0PGRvdWJs ZT4oaSk7Cit9CisKK3RlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRv ciB1bnNpZ25lZCgpIGNvbnN0Cit7CisgICAgaWYgKG1fdHlwZSA9PSBDU1NfTlVNQkVSKQorICAg ICAgICByZXR1cm4gY2xhbXBUbzx1bnNpZ25lZD4obV92YWx1ZS5udW0pOworCisgICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIDA7Cit9CisKKwogdGVtcGxhdGU8PiBpbmxpbmUg Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKGZsb2F0IGkpCiAgICAgOiBtX3R5 cGUoQ1NTX05VTUJFUikKICAgICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDkzMDg2KQorKysg U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00NTI5LDIyICs0NTI5LDEzIEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0 eShpbnQKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0 Qm94RmxleDoKLSAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUwoYm94RmxleCwgQm94 RmxleCkKLSAgICAgICAgaWYgKCFwcmltaXRpdmVWYWx1ZSB8fCBwcmltaXRpdmVWYWx1ZS0+cHJp bWl0aXZlVHlwZSgpICE9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSKQotICAgICAgICAg ICAgcmV0dXJuOyAvLyBFcnJvciBjYXNlLgotICAgICAgICBtX3N0eWxlLT5zZXRCb3hGbGV4KHBy aW1pdGl2ZVZhbHVlLT5nZXRGbG9hdFZhbHVlKCkpOworICAgICAgICBIQU5ETEVfSU5IRVJJVF9B TkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFKGJveEZsZXgsIEJveEZsZXgpCiAgICAgICAgIHJldHVy bjsKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Qm94RmxleEdyb3VwOgotICAgICAgICBIQU5E TEVfSU5IRVJJVF9BTkRfSU5JVElBTChib3hGbGV4R3JvdXAsIEJveEZsZXhHcm91cCkKLSAgICAg ICAgaWYgKCFwcmltaXRpdmVWYWx1ZSB8fCBwcmltaXRpdmVWYWx1ZS0+cHJpbWl0aXZlVHlwZSgp ICE9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSKQotICAgICAgICAgICAgcmV0dXJuOyAv LyBFcnJvciBjYXNlLgotICAgICAgICBtX3N0eWxlLT5zZXRCb3hGbGV4R3JvdXAocHJpbWl0aXZl VmFsdWUtPmdldFZhbHVlPHVuc2lnbmVkPigpKTsKKyAgICAgICAgSEFORExFX0lOSEVSSVRfQU5E X0lOSVRJQUxfQU5EX1BSSU1JVElWRShib3hGbGV4R3JvdXAsIEJveEZsZXhHcm91cCkKICAgICAg ICAgcmV0dXJuOwogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3hPcmRpbmFsR3JvdXA6Ci0g ICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMKGJveE9yZGluYWxHcm91cCwgQm94T3Jk aW5hbEdyb3VwKQotICAgICAgICBpZiAoIXByaW1pdGl2ZVZhbHVlIHx8IHByaW1pdGl2ZVZhbHVl LT5wcmltaXRpdmVUeXBlKCkgIT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpCi0gICAg ICAgICAgICByZXR1cm47IC8vIEVycm9yIGNhc2UuCi0gICAgICAgIG1fc3R5bGUtPnNldEJveE9y ZGluYWxHcm91cChwcmltaXRpdmVWYWx1ZS0+Z2V0VmFsdWU8dW5zaWduZWQ+KCkpOworICAgICAg ICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFKGJveE9yZGluYWxHcm91 cCwgQm94T3JkaW5hbEdyb3VwKQogICAgICAgICByZXR1cm47CiAgICAgY2FzZSBDU1NQcm9wZXJ0 eUJveFNpemluZzoKICAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUxfQU5EX1BSSU1J VElWRShib3hTaXppbmcsIEJveFNpemluZyk7Cg==