66253 2011-08-15 14:09:32 -0700 Defer creating AVPlayer and AVPlayerItem in MediaPlayerPrivateAVFoundation::setPreload() 2011-09-01 10:14:42 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 67316 1 jeffm jeffm dglazkov eric.carlson webkit-bug-importer webkit.review.bot oldest_to_newest 451270 0 jeffm 2011-08-15 14:09:32 -0700 Currently, MediaPlayerPrivateAVFoundation::setPreload() defers creating the AVPlayerItem on the Mac, but not the AVPlayer, until we know that the asset is playable. We can't do this on Windows, since creating the AVPlayer requires and AVPlayerItem. In reality, we don't need either of these before the asset is playable, so on both platforms we should defer creating the AVPlayer and AVPlayerItem. 451272 1 webkit-bug-importer 2011-08-15 14:09:51 -0700 <rdar://problem/9956744> 459284 2 105712 jeffm 2011-08-30 15:51:09 -0700 Created attachment 105712 Patch 459915 3 jeffm 2011-08-31 14:12:43 -0700 It turns out that this patch doesn't work on the Mac, which I didn't realize because AVFoundation was disabled by bug 67316. I will submit a new patch after I fix 67316. 460099 4 105866 jeffm 2011-08-31 17:11:55 -0700 Created attachment 105866 Patch 460146 5 105866 webkit.review.bot 2011-08-31 18:38:51 -0700 Comment on attachment 105866 Patch Attachment 105866 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9566961 New failing tests: http/tests/loading/empty-urls.html 460536 6 jeffm 2011-09-01 09:56:15 -0700 (In reply to comment #5) > (From update of attachment 105866 [details]) > Attachment 105866 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9566961 > > New failing tests: > http/tests/loading/empty-urls.html I don't think the test failure is caused by this patch, since the patch only modifies code used in Apple builds. 460557 7 jeffm 2011-09-01 10:14:42 -0700 Committed r94302: <http://trac.webkit.org/changeset/94302> 105712 2011-08-30 15:51:09 -0700 2011-08-31 17:11:52 -0700 Patch bug-66253-20110830155107.patch text/plain 2571 jeffm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MTE5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMzAgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIERlZmVyIGNyZWF0aW5nIEFWUGxheWVy IGFuZCBBVlBsYXllckl0ZW0gaW4gTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpzZXRQ cmVsb2FkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY2MjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBzaG91bGQgYmUgY292ZXJlZCBieSBleGlzdGluZyBtZWRpYSB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uOjpzZXRQcmVsb2FkKTogVXNlIHRoZSBzYW1lIGNvZGUgb24gTWFjIGFu ZCBXaW5kb3dzIHRvIG9ubHkgY3JlYXRlIHRoZSBBVlBsYXllciBhbmQgQVZQbGF5ZXJJdGVtIHdo ZW4gbmVlZGVkLgorCiAyMDExLTA4LTMwICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmVmYWN0b3IgSlMgZGljdGlvbmFyeSBjb2RlIGludG8gaGVscGVyIGNsYXNzIGFu ZCBjb3ZlcnQgZ2VvbG9jYXRpb24gY29kZSB0byB1c2UgaXQKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCShyZXZpc2lv biA5NDA3NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02 MTcsMjMgKzYxNywxNSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6c2V0 CiAKICAgICBpZiAobV9wcmVsb2FkID49IE1lZGlhUGxheWVyOjpNZXRhRGF0YSAmJiBhc3NldFN0 YXR1cygpID09IE1lZGlhUGxheWVyQVZBc3NldFN0YXR1c0RvZXNOb3RFeGlzdCkgewogICAgICAg ICBjcmVhdGVBVkFzc2V0Rm9yVVJMKG1fYXNzZXRVUkwpOwotICAgICAgICAvLyBGSVhNRTogUmVt b3ZlIHRoaXMgV2luZG93cy1zcGVjaWZpYyBjb2RlIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzk4Nzc3 MzA+IGlzIGZpeGVkLCB1bnRpbCB0aGVuCi0gICAgICAgIC8vIHdlIGNhbid0IGNyZWF0ZSBhbiBB VlBsYXllciB3aXRob3V0IGFuIEFWUGxheWVySXRlbSBvbiBXaW5kb3dzLCBzbyB3ZSBhbHdheXMg aGF2ZSB0byBjcmVhdGUKLSAgICAgICAgLy8gdGhlIGl0ZW0gZmlyc3QuCi0jaWYgUExBVEZPUk0o V0lOKQotICAgICAgICBjcmVhdGVBVlBsYXllckl0ZW0oKTsKLSNlbmRpZgotICAgICAgICBjcmVh dGVBVlBsYXllcigpOwogICAgICAgICBjaGVja1BsYXlhYmlsaXR5KCk7CiAgICAgfQogCi0gICAg Ly8gRklYTUU6IEVuYWJsZSB0aGlzIGNvZGUgb24gV2luZG93cyB3aGVuIDxyZGFyOi8vcHJvYmxl bS85ODc3NzMwPiBpcyBmaXhlZC4KLSNpZiBQTEFURk9STShNQUMpCi0gICAgLy8gRG9uJ3QgZm9y Y2UgY3JlYXRpb24gb2YgdGhlIHBsYXllciBpdGVtIHVubGVzcyB3ZSBhbHJlYWR5IGtub3cgdGhh dCB0aGUgYXNzZXQgaXMgcGxheWFibGUuIElmIHdlIGFyZW4ndAotICAgIC8vIHRoZXJlIHlldCwg b3IgaWYgd2UgYWxyZWFkeSBrbm93IGl0IGlzIG5vdCBwbGF5YWJsZSwgY3JlYXRpbmcgaXQgbm93 IHdvbid0IGhlbHAuCi0gICAgaWYgKG1fcHJlbG9hZCA9PSBNZWRpYVBsYXllcjo6QXV0byAmJiBt X2Fzc2V0SXNQbGF5YWJsZSkKKyAgICAvLyBEb24ndCBmb3JjZSBjcmVhdGlvbiBvZiB0aGUgcGxh eWVyIGFuZCBwbGF5ZXIgaXRlbSB1bmxlc3Mgd2UgYWxyZWFkeSBrbm93IHRoYXQgdGhlIGFzc2V0 IGlzIHBsYXlhYmxlLiBJZiB3ZSBhcmVuJ3QKKyAgICAvLyB0aGVyZSB5ZXQsIG9yIGlmIHdlIGFs cmVhZHkga25vdyBpdCBpcyBub3QgcGxheWFibGUsIGNyZWF0aW5nIHRoZW0gbm93IHdvbid0IGhl bHAuCisgICAgaWYgKG1fcHJlbG9hZCA9PSBNZWRpYVBsYXllcjo6QXV0byAmJiBtX2Fzc2V0SXNQ bGF5YWJsZSkgewogICAgICAgICBjcmVhdGVBVlBsYXllckl0ZW0oKTsKLSNlbmRpZgorICAgICAg ICBjcmVhdGVBVlBsYXllcigpOworICAgIH0KIAogICAgIHNldERlbGF5Q2FsbGJhY2tzKGZhbHNl KTsKIH0K 105866 2011-08-31 17:11:55 -0700 2011-08-31 18:38:51 -0700 Patch bug-66253-20110831171154.patch text/plain 4512 jeffm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MjUyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMzEgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIERlZmVyIGNyZWF0aW5nIEFWUGxheWVy IGFuZCBBVlBsYXllckl0ZW0gaW4gTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpzZXRQ cmVsb2FkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY2MjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBzaG91bGQgYmUgY292ZXJlZCBieSBleGlzdGluZyBtZWRpYSB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uOjpzZXRQcmVsb2FkKTogVXNlIHRoZSBzYW1lIGNvZGUgb24gTWFjIGFu ZCBXaW5kb3dzIHRvIG9ubHkgY3JlYXRlIHRoZSBBVlBsYXllciBhbmQgQVZQbGF5ZXJJdGVtIHdo ZW4gbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OmNyZWF0ZUFWUGxheWVyKTog QXNzaWduIGFueSBleGlzdGluZyBBVlBsYXllckl0ZW0gdG8gdGhlIG5ldyBBVlBsYXllci4KKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OmNyZWF0 ZUFWUGxheWVySXRlbSk6IEFsbG93IGNyZWF0aW9uIG9mIHRoZSBBVlBsYXllckl0ZW0gYmVmb3Jl IHRoZSBBVlBsYXllci4KKwogMjAxMS0wOC0zMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBNb3ZlIHRleHQoKSBhbmQgdGV4dFdpdGhIYXJkTGluZUJyZWFrcygp IGZyb20gUmVuZGVyVGV4dENvbnRyb2wgdG8gSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb24uY3BwCShyZXZpc2lvbiA5NDI1MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02MTcsMjMgKzYxNywxNSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbjo6c2V0CiAKICAgICBpZiAobV9wcmVsb2FkID49IE1lZGlhUGxheWVyOjpN ZXRhRGF0YSAmJiBhc3NldFN0YXR1cygpID09IE1lZGlhUGxheWVyQVZBc3NldFN0YXR1c0RvZXNO b3RFeGlzdCkgewogICAgICAgICBjcmVhdGVBVkFzc2V0Rm9yVVJMKG1fYXNzZXRVUkwpOwotICAg ICAgICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgV2luZG93cy1zcGVjaWZpYyBjb2RlIHdoZW4gPHJk YXI6Ly9wcm9ibGVtLzk4Nzc3MzA+IGlzIGZpeGVkLCB1bnRpbCB0aGVuCi0gICAgICAgIC8vIHdl IGNhbid0IGNyZWF0ZSBhbiBBVlBsYXllciB3aXRob3V0IGFuIEFWUGxheWVySXRlbSBvbiBXaW5k b3dzLCBzbyB3ZSBhbHdheXMgaGF2ZSB0byBjcmVhdGUKLSAgICAgICAgLy8gdGhlIGl0ZW0gZmly c3QuCi0jaWYgUExBVEZPUk0oV0lOKQotICAgICAgICBjcmVhdGVBVlBsYXllckl0ZW0oKTsKLSNl bmRpZgotICAgICAgICBjcmVhdGVBVlBsYXllcigpOwogICAgICAgICBjaGVja1BsYXlhYmlsaXR5 KCk7CiAgICAgfQogCi0gICAgLy8gRklYTUU6IEVuYWJsZSB0aGlzIGNvZGUgb24gV2luZG93cyB3 aGVuIDxyZGFyOi8vcHJvYmxlbS85ODc3NzMwPiBpcyBmaXhlZC4KLSNpZiBQTEFURk9STShNQUMp Ci0gICAgLy8gRG9uJ3QgZm9yY2UgY3JlYXRpb24gb2YgdGhlIHBsYXllciBpdGVtIHVubGVzcyB3 ZSBhbHJlYWR5IGtub3cgdGhhdCB0aGUgYXNzZXQgaXMgcGxheWFibGUuIElmIHdlIGFyZW4ndAot ICAgIC8vIHRoZXJlIHlldCwgb3IgaWYgd2UgYWxyZWFkeSBrbm93IGl0IGlzIG5vdCBwbGF5YWJs ZSwgY3JlYXRpbmcgaXQgbm93IHdvbid0IGhlbHAuCi0gICAgaWYgKG1fcHJlbG9hZCA9PSBNZWRp YVBsYXllcjo6QXV0byAmJiBtX2Fzc2V0SXNQbGF5YWJsZSkKKyAgICAvLyBEb24ndCBmb3JjZSBj cmVhdGlvbiBvZiB0aGUgcGxheWVyIGFuZCBwbGF5ZXIgaXRlbSB1bmxlc3Mgd2UgYWxyZWFkeSBr bm93IHRoYXQgdGhlIGFzc2V0IGlzIHBsYXlhYmxlLiBJZiB3ZSBhcmVuJ3QKKyAgICAvLyB0aGVy ZSB5ZXQsIG9yIGlmIHdlIGFscmVhZHkga25vdyBpdCBpcyBub3QgcGxheWFibGUsIGNyZWF0aW5n IHRoZW0gbm93IHdvbid0IGhlbHAuCisgICAgaWYgKG1fcHJlbG9hZCA9PSBNZWRpYVBsYXllcjo6 QXV0byAmJiBtX2Fzc2V0SXNQbGF5YWJsZSkgewogICAgICAgICBjcmVhdGVBVlBsYXllckl0ZW0o KTsKLSNlbmRpZgorICAgICAgICBjcmVhdGVBVlBsYXllcigpOworICAgIH0KIAogICAgIHNldERl bGF5Q2FsbGJhY2tzKGZhbHNlKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQkocmV2 aXNpb24gOTQyNTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0yODcsNiArMjg3LDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb25PYmpDOgogICAgIG1fdGltZU9ic2VydmVyID0gW21fYXZQbGF5ZXIuZ2V0KCkgYWRkUGVy aW9kaWNUaW1lT2JzZXJ2ZXJGb3JJbnRlcnZhbDpDTVRpbWVNYWtlV2l0aFNlY29uZHModmVyeUxv bmdJbnRlcnZhbCwgMTApIHF1ZXVlOm5pbCB1c2luZ0Jsb2NrOl4oQ01UaW1lIHRpbWUpewogICAg ICAgICBbb2JzZXJ2ZXIgdGltZUNoYW5nZWQ6Q01UaW1lR2V0U2Vjb25kcyh0aW1lKV07CiAgICAg fV07CisgICAgCisgICAgaWYgKG1fYXZQbGF5ZXJJdGVtKQorICAgICAgICBbbV9hdlBsYXllci5n ZXQoKSByZXBsYWNlQ3VycmVudEl0ZW1XaXRoUGxheWVySXRlbTptX2F2UGxheWVySXRlbS5nZXQo KV07CiAKICAgICBzZXREZWxheUNhbGxiYWNrcyhmYWxzZSk7CiB9CkBAIC0yOTgsOCArMzAxLDYg QEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOgogCiAgICAgTE9HKE1l ZGlhLCAiTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6Y3JlYXRlQVZQbGF5ZXJJ dGVtKCVwKSIsIHRoaXMpOwogCi0gICAgQVNTRVJUKG1fYXZQbGF5ZXIpOwotCiAgICAgc2V0RGVs YXlDYWxsYmFja3ModHJ1ZSk7CiAKICAgICAvLyBDcmVhdGUgdGhlIHBsYXllciBpdGVtIHNvIHdl IGNhbiBsb2FkIG1lZGlhIGRhdGEuIApAQCAtMzEwLDcgKzMxMSw4IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzoKICAgICBmb3IgKE5TU3RyaW5nICprZXlOYW1lIGlu IGl0ZW1LVk9Qcm9wZXJ0aWVzKCkpCiAgICAgICAgIFttX2F2UGxheWVySXRlbS5nZXQoKSBhZGRP YnNlcnZlcjptX29iamNPYnNlcnZlci5nZXQoKSBmb3JLZXlQYXRoOmtleU5hbWUgb3B0aW9uczpu aWwgY29udGV4dDoodm9pZCAqKU1lZGlhUGxheWVyQVZGb3VuZGF0aW9uT2JzZXJ2YXRpb25Db250 ZXh0UGxheWVySXRlbV07CiAKLSAgICBbbV9hdlBsYXllci5nZXQoKSByZXBsYWNlQ3VycmVudEl0 ZW1XaXRoUGxheWVySXRlbTptX2F2UGxheWVySXRlbS5nZXQoKV07CisgICAgaWYgKG1fYXZQbGF5 ZXIpCisgICAgICAgIFttX2F2UGxheWVyLmdldCgpIHJlcGxhY2VDdXJyZW50SXRlbVdpdGhQbGF5 ZXJJdGVtOm1fYXZQbGF5ZXJJdGVtLmdldCgpXTsKIAogICAgIHNldERlbGF5Q2FsbGJhY2tzKGZh bHNlKTsKIH0K