66252 2011-08-15 14:03:49 -0700 garden-o-matic frontend needs model.commitDataForRevisionRange function. 2011-08-15 15:14:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66144 1 dglazkov dglazkov abarth oldest_to_newest 451263 0 dglazkov 2011-08-15 14:03:49 -0700 garden-o-matic frontend needs model.getCommitDataList function. 451265 1 103949 dglazkov 2011-08-15 14:05:22 -0700 Created attachment 103949 Patch 451278 2 103949 abarth 2011-08-15 14:15:50 -0700 Comment on attachment 103949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103949&action=review I think the main question in this patch is what behavior we want when oldestRevision or newestRevision isn't in model.state.recentCommits. This patch returns [], but another reasonable behavior is to return whatever commitData we have that falls inside that range. For example, when you compute an implied impliedFirstFailingRevision by adding one to newestPassingRevision, you're computing a revision number that might not exist in model.state.recentCommits (e.g, because it was a revision that went into a branch other than trunk). I'd imagine you'd want this function to return whatever commitData objects we have for the regression range rather than returning the empty list. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:118 > +model.getCommitDataList = function(oldestRevision, newestRevision) I would have called this commitDataListForRevisionRange to be explicit about the types, but this is fine too. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:121 > + var commitData = g_commitIndex[oldestRevision]; What if commitData is undefined? This will return [] rather than whatever commitDatas we have in the range. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:122 > + var index = model.state.recentCommits.indexOf(commitData); Is there a reason to use g_commitIndex? indexOf requires a linear scan over recentCommits anyway. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:126 > + while(commitData.revision != newestRevision) { commitData.revision <= newestRevision The caller might supply a newestRevision that doesn't happen to be in our dataset (e.g., because they added 1 to a rev that was, and the computed rev actually went into a branch). With the test written this way, we'll walk off the beginning of model.state.recentCommits and return []. 451300 3 103949 dglazkov 2011-08-15 14:36:51 -0700 Comment on attachment 103949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103949&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:118 >> +model.getCommitDataList = function(oldestRevision, newestRevision) > > I would have called this commitDataListForRevisionRange to be explicit about the types, but this is fine too. I'll rename. >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:122 >> + var index = model.state.recentCommits.indexOf(commitData); > > Is there a reason to use g_commitIndex? indexOf requires a linear scan over recentCommits anyway. You're right -- I'll rework the algorithm. 451314 4 103961 dglazkov 2011-08-15 15:08:23 -0700 Created attachment 103961 Patch 451317 5 103961 abarth 2011-08-15 15:13:19 -0700 Comment on attachment 103961 Patch Looks great. Thanks. 451318 6 dglazkov 2011-08-15 15:14:15 -0700 Committed r93063: <http://trac.webkit.org/changeset/93063> 103949 2011-08-15 14:05:22 -0700 2011-08-15 15:08:20 -0700 Patch bug-66252-20110815140521.patch text/plain 4198 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwNTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9t b2RlbC5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbC5qcwppbmRleCBiNzcyMjM2YzJlMzJkZjNj NDY2ZDAwZmZlZWJjODljN2ZkOGY2OTQyLi5iMDhmNWNiNWI5OGIzNThiNTQxZTZhYTQ1NzNmYjUy OGEyY2EwNTkwIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWwuanMKKysrIGIvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL21vZGVsLmpzCkBAIC05NywxNSArOTcsNDIgQEAgbW9kZWwudGFrZUV4cGVj dGF0aW9uVXBkYXRlUXVldWUgPSBmdW5jdGlvbigpCiAgICAgcmV0dXJuIHF1ZXVlOwogfTsKIAor dmFyIGdfY29tbWl0SW5kZXggPSB7fTsKKwogbW9kZWwudXBkYXRlUmVjZW50Q29tbWl0cyA9IGZ1 bmN0aW9uKGNhbGxiYWNrKQogewogICAgIHRyYWMucmVjZW50Q29tbWl0RGF0YSgndHJ1bmsnLCBr Q29tbWl0TG9nTGVuZ3RoLCBmdW5jdGlvbihjb21taXREYXRhTGlzdCkgewogICAgICAgICBtb2Rl bC5zdGF0ZS5yZWNlbnRDb21taXRzID0gY29tbWl0RGF0YUxpc3Q7CisgICAgICAgIHVwZGF0ZUNv bW1pdEluZGV4KCk7CiAgICAgICAgIGZpbmRBbmRNYXJrUmV2ZXJ0ZWRSZXZpc2lvbnMobW9kZWwu c3RhdGUucmVjZW50Q29tbWl0cyk7CiAgICAgICAgIGNhbGxiYWNrKCk7CiAgICAgfSk7CiB9Owog CitmdW5jdGlvbiB1cGRhdGVDb21taXRJbmRleCgpIHsKKyAgICBtb2RlbC5zdGF0ZS5yZWNlbnRD b21taXRzLmZvckVhY2goZnVuY3Rpb24oY29tbWl0RGF0YSkgeworICAgICAgICBnX2NvbW1pdElu ZGV4W2NvbW1pdERhdGEucmV2aXNpb25dID0gY29tbWl0RGF0YTsKKyAgICB9KTsKK30KKworbW9k ZWwuZ2V0Q29tbWl0RGF0YUxpc3QgPSBmdW5jdGlvbihvbGRlc3RSZXZpc2lvbiwgbmV3ZXN0UmV2 aXNpb24pCit7CisgICAgdmFyIHJlc3VsdCA9IFtdOworICAgIHZhciBjb21taXREYXRhID0gZ19j b21taXRJbmRleFtvbGRlc3RSZXZpc2lvbl07CisgICAgdmFyIGluZGV4ID0gbW9kZWwuc3RhdGUu cmVjZW50Q29tbWl0cy5pbmRleE9mKGNvbW1pdERhdGEpOworICAgIGlmIChpbmRleCA9PSAtMSkK KyAgICAgICAgcmV0dXJuIHJlc3VsdDsKKworICAgIHdoaWxlKGNvbW1pdERhdGEucmV2aXNpb24g IT0gbmV3ZXN0UmV2aXNpb24pIHsKKyAgICAgICAgaWYgKCFpbmRleCkKKyAgICAgICAgICAgIHJl dHVybiBbXTsKKyAgICAgICAgcmVzdWx0LnB1c2goY29tbWl0RGF0YSk7CisgICAgICAgIGNvbW1p dERhdGEgPSBtb2RlbC5zdGF0ZS5yZWNlbnRDb21taXRzWy0taW5kZXhdOworICAgIH0KKyAgICBy ZXN1bHQucHVzaChjb21taXREYXRhKTsKKyAgICByZXR1cm4gcmVzdWx0OworfTsKKwogbW9kZWwu dXBkYXRlUmVzdWx0c0J5QnVpbGRlciA9IGZ1bmN0aW9uKGNhbGxiYWNrKQogewogICAgIHJlc3Vs dHMuZmV0Y2hSZXN1bHRzQnlCdWlsZGVyKGNvbmZpZy5rQnVpbGRlcnMsIGZ1bmN0aW9uKHJlc3Vs dHNCeUJ1aWxkZXIpIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbF91bml0dGVz dHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWxfdW5pdHRlc3RzLmpzCmluZGV4IDg4MWI5YmE3 MGI3ZWJiOGJkODE1MTJlYTI2YjlhZGQ4M2UzMWMxZmMuLmVjOWI0OGIzM2NkYmJlYTNkNDA1OTg0 YWYxODAwMTI4M2ZiNzY3OTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbF91bml0 dGVzdHMuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsX3VuaXR0ZXN0cy5qcwpAQCAtMTc3 LDQgKzE3NywzMyBAQCB0ZXN0KCJ1cGRhdGVSZWNlbnRDb21taXRzIiwgMiwgZnVuY3Rpb24oKSB7 CiAgICAgfSk7CiB9KTsKIAordGVzdCgiZ2V0Q29tbWl0RGF0YUxpc3QiLCA2LCBmdW5jdGlvbigp IHsKKyAgICB2YXIgc2ltdWxhdG9yID0gbmV3IE5ldHdvcmtTaW11bGF0b3IoKTsKKworICAgIHNp bXVsYXRvci5nZXQgPSBmdW5jdGlvbih1cmwsIGNhbGxiYWNrKQorICAgIHsKKyAgICAgICAgc2lt dWxhdG9yLnNjaGVkdWxlQ2FsbGJhY2soZnVuY3Rpb24oKSB7CisgICAgICAgICAgICB2YXIgcGFy c2VyID0gbmV3IERPTVBhcnNlcigpOworICAgICAgICAgICAgdmFyIHJlc3BvbnNlRE9NID0gcGFy c2VyLnBhcnNlRnJvbVN0cmluZyhrRXhhbXBsZUNvbW1pdERhdGFYTUwsICJhcHBsaWNhdGlvbi94 bWwiKTsKKyAgICAgICAgICAgIGNhbGxiYWNrKHJlc3BvbnNlRE9NKTsKKyAgICAgICAgfSk7Cisg ICAgfTsKKworICAgIHNpbXVsYXRvci5ydW5UZXN0KGZ1bmN0aW9uKCkgeworICAgICAgICBtb2Rl bC51cGRhdGVSZWNlbnRDb21taXRzKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgZnVuY3Rpb24g ZXh0cmFjdEJ1Z0lEcyhjb21taXREYXRhKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg IHJldHVybiBjb21taXREYXRhLmJ1Z0lEOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBk ZWVwRXF1YWwobW9kZWwuZ2V0Q29tbWl0RGF0YUxpc3QoOTIyNTksIDkyMjU5KS5tYXAoZXh0cmFj dEJ1Z0lEcyksIFs2NTU5M10pOworICAgICAgICAgICAgZGVlcEVxdWFsKG1vZGVsLmdldENvbW1p dERhdGFMaXN0KDkyMjU2LCA5MjI1OSkubWFwKGV4dHJhY3RCdWdJRHMpLCBbNjU2NTcsIDY1NTkz XSk7CisgICAgICAgICAgICBkZWVwRXF1YWwobW9kZWwuZ2V0Q29tbWl0RGF0YUxpc3QoOTIyNTks IDkyMjU2KS5tYXAoZXh0cmFjdEJ1Z0lEcyksIFtdKTsKKyAgICAgICAgICAgIGRlZXBFcXVhbCht b2RlbC5nZXRDb21taXREYXRhTGlzdCgwLCA5MjI1NikubWFwKGV4dHJhY3RCdWdJRHMpLCBbXSk7 CisgICAgICAgICAgICBkZWVwRXF1YWwobW9kZWwuZ2V0Q29tbWl0RGF0YUxpc3QoOTIyNTYsIDAp Lm1hcChleHRyYWN0QnVnSURzKSwgW10pOworICAgICAgICAgICAgZGVsZXRlIG1vZGVsLnN0YXRl LnJlY2VudENvbW1pdHM7CisgICAgICAgIH0pOworICAgIH0pOworfSk7CisKIH0pKCk7CmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWVlZjg1YmYy N2Y4ZGMzNGY3YjU1Njc5YzEzNWZiZTc5Y2NjNmI4Mi4uZjQzNWQ0MmYwNjg3ZjRjZWQyZjc5NDBi MTk4NWY1ZjgyZTFmYWFiZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA4LTE1ICBEaW1pdHJpIEdsYXprb3Yg IDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZ2FyZGVuLW8tbWF0aWMgZnJvbnRl bmQgbmVlZHMgbW9kZWwuZ2V0Q29tbWl0RGF0YUxpc3QgZnVuY3Rpb24uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI1MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsLmpzOiBB ZGRlZCBnZXRDb21taXREYXRhTGlzdCBtZXRob2QuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVs X3VuaXR0ZXN0cy5qczogQWRkZWQgdGVzdHMuCisKIDIwMTEtMDgtMTUgIEFkYW0gUm9iZW4gIDxh cm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFRlYWNoIFRlc3RXZWJLaXRBUEkvZ3Rlc3QgaG93 IHRvIHByaW50IEphdmFTY3JpcHQgZmFpbHVyZXMgbmljZWx5Cg== 103961 2011-08-15 15:08:23 -0700 2011-08-15 15:13:19 -0700 Patch bug-66252-20110815150822.patch text/plain 4237 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwNjEKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9t b2RlbC5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbC5qcwppbmRleCBiNzcyMjM2YzJlMzJkZjNj NDY2ZDAwZmZlZWJjODljN2ZkOGY2OTQyLi5iY2UwZDRhMTM4YmNlZjVhOWY4MjIxYjJmNjJmYTQw Y2Q3Mzc4YzcwIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWwuanMKKysrIGIvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL21vZGVsLmpzCkBAIC05NywxNSArOTcsMzggQEAgbW9kZWwudGFrZUV4cGVj dGF0aW9uVXBkYXRlUXVldWUgPSBmdW5jdGlvbigpCiAgICAgcmV0dXJuIHF1ZXVlOwogfTsKIAor dmFyIGdfY29tbWl0SW5kZXggPSB7fTsKKwogbW9kZWwudXBkYXRlUmVjZW50Q29tbWl0cyA9IGZ1 bmN0aW9uKGNhbGxiYWNrKQogewogICAgIHRyYWMucmVjZW50Q29tbWl0RGF0YSgndHJ1bmsnLCBr Q29tbWl0TG9nTGVuZ3RoLCBmdW5jdGlvbihjb21taXREYXRhTGlzdCkgewogICAgICAgICBtb2Rl bC5zdGF0ZS5yZWNlbnRDb21taXRzID0gY29tbWl0RGF0YUxpc3Q7CisgICAgICAgIHVwZGF0ZUNv bW1pdEluZGV4KCk7CiAgICAgICAgIGZpbmRBbmRNYXJrUmV2ZXJ0ZWRSZXZpc2lvbnMobW9kZWwu c3RhdGUucmVjZW50Q29tbWl0cyk7CiAgICAgICAgIGNhbGxiYWNrKCk7CiAgICAgfSk7CiB9Owog CitmdW5jdGlvbiB1cGRhdGVDb21taXRJbmRleCgpIHsKKyAgICBtb2RlbC5zdGF0ZS5yZWNlbnRD b21taXRzLmZvckVhY2goZnVuY3Rpb24oY29tbWl0RGF0YSkgeworICAgICAgICBnX2NvbW1pdElu ZGV4W2NvbW1pdERhdGEucmV2aXNpb25dID0gY29tbWl0RGF0YTsKKyAgICB9KTsKK30KKworLyoK KyAgICBBc3N1bWVzIFNWTi1zdHlsZSwgY29uc2VjdXRpdmUgcmV2aXNpb24gc2NoZW1lLgorKi8K K21vZGVsLmNvbW1pdERhdGFMaXN0Rm9yUmV2aXNpb25SYW5nZSA9IGZ1bmN0aW9uKGZyb21SZXZp c2lvbiwgdG9SZXZpc2lvbikKK3sKKyAgICB2YXIgcmVzdWx0ID0gW107CisgICAgZm9yICh2YXIg cmV2aXNpb24gPSBmcm9tUmV2aXNpb247IHJldmlzaW9uIDw9IHRvUmV2aXNpb247ICsrcmV2aXNp b24pIHsKKyAgICAgICAgdmFyIGNvbW1pdERhdGEgPSBnX2NvbW1pdEluZGV4W3JldmlzaW9uXTsK KyAgICAgICAgaWYgKGNvbW1pdERhdGEpCisgICAgICAgICAgICByZXN1bHQucHVzaChjb21taXRE YXRhKTsKKyAgICB9CisgICAgcmV0dXJuIHJlc3VsdDsKK307CisKIG1vZGVsLnVwZGF0ZVJlc3Vs dHNCeUJ1aWxkZXIgPSBmdW5jdGlvbihjYWxsYmFjaykKIHsKICAgICByZXN1bHRzLmZldGNoUmVz dWx0c0J5QnVpbGRlcihjb25maWcua0J1aWxkZXJzLCBmdW5jdGlvbihyZXN1bHRzQnlCdWlsZGVy KSB7CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWxfdW5pdHRlc3RzLmpzIGIvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL21vZGVsX3VuaXR0ZXN0cy5qcwppbmRleCA4ODFiOWJhNzBiN2ViYjhiZDgx NTEyZWEyNmI5YWRkODNlMzFjMWZjLi4zMjgyM2U4ZGNhNmFlZDM5OGEwNmUyYTRiZGM4OWJiZjFh ZDg4ZDE0IDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWxfdW5pdHRlc3RzLmpzCisr KyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbF91bml0dGVzdHMuanMKQEAgLTE3Nyw0ICsxNzcsMzMg QEAgdGVzdCgidXBkYXRlUmVjZW50Q29tbWl0cyIsIDIsIGZ1bmN0aW9uKCkgewogICAgIH0pOwog fSk7CiAKK3Rlc3QoImNvbW1pdERhdGFMaXN0Rm9yUmV2aXNpb25SYW5nZSIsIDYsIGZ1bmN0aW9u KCkgeworICAgIHZhciBzaW11bGF0b3IgPSBuZXcgTmV0d29ya1NpbXVsYXRvcigpOworCisgICAg c2ltdWxhdG9yLmdldCA9IGZ1bmN0aW9uKHVybCwgY2FsbGJhY2spCisgICAgeworICAgICAgICBz aW11bGF0b3Iuc2NoZWR1bGVDYWxsYmFjayhmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHZhciBw YXJzZXIgPSBuZXcgRE9NUGFyc2VyKCk7CisgICAgICAgICAgICB2YXIgcmVzcG9uc2VET00gPSBw YXJzZXIucGFyc2VGcm9tU3RyaW5nKGtFeGFtcGxlQ29tbWl0RGF0YVhNTCwgImFwcGxpY2F0aW9u L3htbCIpOworICAgICAgICAgICAgY2FsbGJhY2socmVzcG9uc2VET00pOworICAgICAgICB9KTsK KyAgICB9OworCisgICAgc2ltdWxhdG9yLnJ1blRlc3QoZnVuY3Rpb24oKSB7CisgICAgICAgIG1v ZGVsLnVwZGF0ZVJlY2VudENvbW1pdHMoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBmdW5jdGlv biBleHRyYWN0QnVnSURzKGNvbW1pdERhdGEpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAg ICAgcmV0dXJuIGNvbW1pdERhdGEuYnVnSUQ7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAg IGRlZXBFcXVhbChtb2RlbC5jb21taXREYXRhTGlzdEZvclJldmlzaW9uUmFuZ2UoOTIyNTksIDky MjU5KS5tYXAoZXh0cmFjdEJ1Z0lEcyksIFs2NTU5M10pOworICAgICAgICAgICAgZGVlcEVxdWFs KG1vZGVsLmNvbW1pdERhdGFMaXN0Rm9yUmV2aXNpb25SYW5nZSg5MjI1NiwgOTIyNTkpLm1hcChl eHRyYWN0QnVnSURzKSwgWzY1NjU3LCA2NTU5M10pOworICAgICAgICAgICAgZGVlcEVxdWFsKG1v ZGVsLmNvbW1pdERhdGFMaXN0Rm9yUmV2aXNpb25SYW5nZSg5MjI1OSwgOTIyNTYpLm1hcChleHRy YWN0QnVnSURzKSwgW10pOworICAgICAgICAgICAgZGVlcEVxdWFsKG1vZGVsLmNvbW1pdERhdGFM aXN0Rm9yUmV2aXNpb25SYW5nZSgwLCA5MjI1NikubWFwKGV4dHJhY3RCdWdJRHMpLCBbNjU2NTdd KTsKKyAgICAgICAgICAgIGRlZXBFcXVhbChtb2RlbC5jb21taXREYXRhTGlzdEZvclJldmlzaW9u UmFuZ2UoOTIyNTYsIDApLm1hcChleHRyYWN0QnVnSURzKSwgW10pOworICAgICAgICAgICAgZGVs ZXRlIG1vZGVsLnN0YXRlLnJlY2VudENvbW1pdHM7CisgICAgICAgIH0pOworICAgIH0pOworfSk7 CisKIH0pKCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggZTc3NWI4ZjY3MWQ3N2IzYzQ5NWQyNDAxNjczNWM0YmExZDY2OGRmNy4uOTUxMWFhZjYz MmMzNjZiMzQ4NjgxNGM2YmZiMGMxOTc4NWI5YzJiZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTA4LTE1ICBE aW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgZ2FyZGVu LW8tbWF0aWMgZnJvbnRlbmQgbmVlZHMgbW9kZWwuY29tbWl0RGF0YUZvclJldmlzaW9uUmFuZ2Ug ZnVuY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NjI1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL21vZGVsLmpzOiBBZGRlZCBjb21taXREYXRhRm9yUmV2aXNpb25SYW5nZSBt ZXRob2QuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsX3VuaXR0ZXN0cy5qczogQWRkZWQgdGVz dHMuCisKKzIwMTEtMDgtMTUgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9y Zz4KKwogICAgICAgICBnYXJkZW4tby1tYXRpYyBmcm9udGVuZCBuZWVkcyBhIGdlbmVyaWMgd2F5 IHRvIHRyYWNrIHVwZGF0ZXMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NjI0NQogCg==