66244 2011-08-15 11:58:53 -0700 Cached pages don't fully update when going back after changing the display scale factor 2011-08-24 07:46:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 66229 1 aroben bdakin bdakin hyatt simon.fraser sullivan webkit-bug-importer oldest_to_newest 451188 0 aroben 2011-08-15 11:58:53 -0700 To reproduce: 1. Go to data:text/html,This%20is%20some%20text 2. Go to about:blank 3. Change your display's scale factor 4. Click Back The text is blurry because it hasn't been redrawn at the new scale factor. Ew! 451189 1 webkit-bug-importer 2011-08-15 11:59:20 -0700 <rdar://problem/9955656> 455750 2 bdakin 2011-08-23 15:36:36 -0700 Adam's original steps actually don't reproduce a bug any more, but there is still a bug here. Re-titling to reflect the remaining issues. Here are steps to reproduce the remaining issue: 1. Go to data:text/html,%3C!DOCTYPEhtml%3E%3Cstyle%3E@media(-webkit-min-device-pixel-ratio:2)%7Bspan::after%7Bcontent:'2'!important;%7D%7Dspan::after%7Bcontent:'1';%7D%3C/style%3EDevice%20pixel%20ratio:%20%3Cspan%3E%3C/span%3E 2. Go to about:blank 3. Change your display's scale factor 4. Click Back The displayed scale factor is not appropriately updated to reflect the new scale factor. 455771 3 104923 bdakin 2011-08-23 16:01:19 -0700 Created attachment 104923 Patch Here's a patch! 455785 4 104923 darin 2011-08-23 16:10:59 -0700 Comment on attachment 104923 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104923&action=review Patch seems OK. Could be improved a bit. > Source/WebCore/page/Frame.cpp:1068 > + pageCache()->markPagesForFullStyleRecalc(); This will run a bit too often. It runs for the top level frame and then runs again for each subframe. That means we’ll run through the page cache over and over again. No need to do that. Also, this does more work than needed as I mention below. > Source/WebCore/page/Page.cpp:601 > + pageCache()->markPagesForFullStyleRecalc(); This does more work than it has to. Items in the page cache might be for the back/forward in other windows that have a different scale factor. It’s overkill to do it on all the pages in the page cache. Instead we could iterate the back/forward list and do it only for the history items found there. 455872 5 bdakin 2011-08-23 17:30:20 -0700 I revised the patch to address Darin's comments and got an in-person review. Committed with revision 93669. 456096 6 aroben 2011-08-24 07:46:56 -0700 Nice! It would be great to write a regression test for this. You could probably base it on this one: <http://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm?rev=93451>. I'd be happy to help with writing such a test. 104923 2011-08-23 16:01:19 -0700 2011-08-23 16:10:59 -0700 Patch for-review.txt text/plain 6162 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNjQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNDQgQEAKKzIwMTEtMDgtMjMgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NjI0NAorICAgICAgICBDYWNoZWQgcGFnZXMgZG9uJ3QgZnVsbHkg dXBkYXRlIHdoZW4gZ29pbmcgYmFjayBhZnRlciBjaGFuZ2luZyB0aGUgZGlzcGxheSBzY2FsZSAK KyAgICAgICAgZmFjdG9yCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzk5NTU2NTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgZ2VuZXJhbGl6ZWQgY29uY2VwdCBvZiBu ZWVkaW5nIGEgZnVsbCBzdHlsZSByZWNhbGMgdG8gdGhlIAorICAgICAgICBQYWdlQ2FjaGUuIFNv IHdoZW4gdGhlIGRpc3BsYXkgc2NhbGUgZmFjdG9yIGlzIGNoYW5nZWQsIHRoZSBQYWdlQ2FjaGUg Y2FuIGJlIAorICAgICAgICBpbmZvcm1lZCB0aGF0IGFsbCBwYWdlcyB3aWxsIG5lZWQgYSBmdWxs IHN0eWxlIHJlY2FsYyB3aGVuIHRoZXkgY29tZSBvdXQgb2YgdGhlIAorICAgICAgICBjYWNoZS4g VGhpcyBzYW1lIG1lY2hhbmlzbSBpcyBhbHNvIHVzZWQgdG8gZml4IGEgbG9uZy1zdGFuZGluZyBi dWcgd2l0aCBmdWxsLXBhZ2UvCisgICAgICAgIHRleHQgem9vbS4KKworICAgICAgICBDaGFjaGVk UGFnZSBoYXMgYSBuZXcgYm9vbCAtLSBtX25lZWRzRnVsbFN0eWxlUmVjYWxjIC0tIHRvIHRyYWNr IHdoZXRoZXIgYSBmdWxsIAorICAgICAgICBzdHlsZSByZWNhbGMgaXMgbmVlZGVkIHdoZW4gdGhl IENhY2hlZFBhZ2UgaXMgcmVzdG9yZWQuCisgICAgICAgICogaGlzdG9yeS9DYWNoZWRQYWdlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFBhZ2U6OkNhY2hlZFBhZ2UpOgorICAgICAgICAo V2ViQ29yZTo6Q2FjaGVkUGFnZTo6cmVzdG9yZSk6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRQ YWdlOjpjbGVhcik6CisgICAgICAgICogaGlzdG9yeS9DYWNoZWRQYWdlLmg6CisgICAgICAgIChX ZWJDb3JlOjpDYWNoZWRQYWdlOjptYXJrRm9yRnVsbFN0eWxlUmVjYWxjKToKKworICAgICAgICBJ dGVyYXRlIHRocm91Z2ggdGhlIEhpc3RvcnlJdGVtcyBhbmQgbWFyayBhbGwgQ2FjaGVkUGFnZXMg YXMgbmVlZGluZyBhIGZ1bGwgc3R5bGUgCisgICAgICAgIHJlY2FsYy4KKyAgICAgICAgKiBoaXN0 b3J5L1BhZ2VDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlQ2FjaGU6Om1hcmtQYWdl c0ZvckZ1bGxTdHlsZVJlY2FsYyk6CisgICAgICAgICogaGlzdG9yeS9QYWdlQ2FjaGUuaDoKKwor ICAgICAgICBGaXggc3R5bGUgcmVjYWxjIGlzc3VlcyBmb3IgZnVsbC1wYWdlL3RleHQgem9vbSBi eSBjYWxsaW5nIG91ciBuZXcgZnVuY3Rpb24gb24gCisgICAgICAgIFBhZ2VDYWNoZS4KKyAgICAg ICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpzZXRQYWdlQW5k VGV4dFpvb21GYWN0b3JzKToKKworICAgICAgICBGaXggc3R5bGUgcmVjYWxjIGlzc3VlcyBmb3Ig ZGlzcGxheSBzY2FsZSBmYWN0b3IgY2hhbmdlcyBieSBjYWxsaW5nIG91ciBuZXcgCisgICAgICAg IGZ1bmN0aW9uIG9uIFBhZ2VDYWNoZS4KKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGFnZTo6c2V0RGV2aWNlU2NhbGVGYWN0b3IpOgorCiAyMDExLTA4LTIzICBB ZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBG aXggcG90ZW50aWFsIG51bGxwdHIgZGVyZWYgaW4gVGlsZWRMYXllckNocm9taXVtOjpwdXNoUHJv cGVydGllc1RvCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZFBhZ2UuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQ2FjaGVkUGFnZS5jcHAJKHJldmlz aW9uIDkzNTIxKQorKysgU291cmNlL1dlYkNvcmUvaGlzdG9yeS9DYWNoZWRQYWdlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTQsNiArNTQsNyBAQCBDYWNoZWRQYWdlOjpDYWNoZWRQYWdlKFBhZ2Uq IHBhZ2UpCiAgICAgOiBtX3RpbWVTdGFtcChjdXJyZW50VGltZSgpKQogICAgICwgbV9jYWNoZWRN YWluRnJhbWUoQ2FjaGVkRnJhbWU6OmNyZWF0ZShwYWdlLT5tYWluRnJhbWUoKSkpCiAgICAgLCBt X25lZWRTdHlsZVJlY2FsY0ZvclZpc2l0ZWRMaW5rcyhmYWxzZSkKKyAgICAsIG1fbmVlZHNGdWxs U3R5bGVSZWNhbGMoZmFsc2UpCiB7CiAjaWZuZGVmIE5ERUJVRwogICAgIGNhY2hlZFBhZ2VDb3Vu dGVyLmluY3JlbWVudCgpOwpAQCAtOTMsNiArOTQsOSBAQCB2b2lkIENhY2hlZFBhZ2U6OnJlc3Rv cmUoUGFnZSogcGFnZSkKICAgICAgICAgfQogICAgIH0KIAorICAgIGlmIChtX25lZWRzRnVsbFN0 eWxlUmVjYWxjKQorICAgICAgICBwYWdlLT5zZXROZWVkc1JlY2FsY1N0eWxlSW5BbGxGcmFtZXMo KTsKKwogICAgIGNsZWFyKCk7CiB9CiAKQEAgLTEwMiw2ICsxMDYsNyBAQCB2b2lkIENhY2hlZFBh Z2U6OmNsZWFyKCkKICAgICBtX2NhY2hlZE1haW5GcmFtZS0+Y2xlYXIoKTsKICAgICBtX2NhY2hl ZE1haW5GcmFtZSA9IDA7CiAgICAgbV9uZWVkU3R5bGVSZWNhbGNGb3JWaXNpdGVkTGlua3MgPSBm YWxzZTsKKyAgICBtX25lZWRzRnVsbFN0eWxlUmVjYWxjID0gZmFsc2U7CiB9CiAKIHZvaWQgQ2Fj aGVkUGFnZTo6ZGVzdHJveSgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZFBh Z2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZFBhZ2UuaAko cmV2aXNpb24gOTM1MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZFBhZ2UuaAko d29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsNyBAQCBwdWJsaWM6CiAgICAgQ2FjaGVkRnJhbWUq IGNhY2hlZE1haW5GcmFtZSgpIHsgcmV0dXJuIG1fY2FjaGVkTWFpbkZyYW1lLmdldCgpOyB9CiAK ICAgICB2b2lkIG1hcmtGb3JWaXN0ZWRMaW5rU3R5bGVSZWNhbGMoKSB7IG1fbmVlZFN0eWxlUmVj YWxjRm9yVmlzaXRlZExpbmtzID0gdHJ1ZTsgfQorICAgIHZvaWQgbWFya0ZvckZ1bGxTdHlsZVJl Y2FsYygpIHsgbV9uZWVkc0Z1bGxTdHlsZVJlY2FsYyA9IHRydWU7IH0KIAogcHJpdmF0ZToKICAg ICBDYWNoZWRQYWdlKFBhZ2UqKTsKQEAgLTU4LDYgKzU5LDcgQEAgcHJpdmF0ZToKICAgICBkb3Vi bGUgbV90aW1lU3RhbXA7CiAgICAgUmVmUHRyPENhY2hlZEZyYW1lPiBtX2NhY2hlZE1haW5GcmFt ZTsKICAgICBib29sIG1fbmVlZFN0eWxlUmVjYWxjRm9yVmlzaXRlZExpbmtzOworICAgIGJvb2wg bV9uZWVkc0Z1bGxTdHlsZVJlY2FsYzsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAJKHJldmlzaW9uIDkzNTIxKQorKysg U291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MzgsNiArMzM4LDEyIEBAIGludCBQYWdlQ2FjaGU6OmF1dG9yZWxlYXNlZFBhZ2VDb3VudCgpIGMK ICAgICByZXR1cm4gbV9hdXRvcmVsZWFzZVNldC5zaXplKCk7CiB9CiAKK3ZvaWQgUGFnZUNhY2hl OjptYXJrUGFnZXNGb3JGdWxsU3R5bGVSZWNhbGMoKQoreworICAgIGZvciAoSGlzdG9yeUl0ZW0q IGN1cnJlbnQgPSBtX2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5tX25leHQpCisg ICAgICAgIGN1cnJlbnQtPm1fY2FjaGVkUGFnZS0+bWFya0ZvckZ1bGxTdHlsZVJlY2FsYygpOwor fQorCiB2b2lkIFBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yVmlzdGVkTGlua1N0eWxlUmVjYWxjKCkK IHsKICAgICBmb3IgKEhpc3RvcnlJdGVtKiBjdXJyZW50ID0gbV9oZWFkOyBjdXJyZW50OyBjdXJy ZW50ID0gY3VycmVudC0+bV9uZXh0KQpJbmRleDogU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdl Q2FjaGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5o CShyZXZpc2lvbiA5MzUyMSkKKysrIFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmgJ KHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICBpbnQgZnJhbWVDb3VudCgpIGNvbnN0OwogICAgICAgICBpbnQgYXV0b3JlbGVhc2VkUGFn ZUNvdW50KCkgY29uc3Q7CiAKKyAgICAgICAgdm9pZCBtYXJrUGFnZXNGb3JGdWxsU3R5bGVSZWNh bGMoKTsKICAgICAgICAgdm9pZCBtYXJrUGFnZXNGb3JWaXN0ZWRMaW5rU3R5bGVSZWNhbGMoKTsK IAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUu Y3BwCShyZXZpc2lvbiA5MzUyMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02NCw2ICs2NCw3IEBACiAjaW5jbHVkZSAiTmF2aWdhdG9yLmgiCiAj aW5jbHVkZSAiTm9kZUxpc3QuaCIKICNpbmNsdWRlICJQYWdlLmgiCisjaW5jbHVkZSAiUGFnZUNh Y2hlLmgiCiAjaW5jbHVkZSAiUGFnZUdyb3VwLmgiCiAjaW5jbHVkZSAiUmVndWxhckV4cHJlc3Np b24uaCIKICNpbmNsdWRlICJSZW5kZXJMYXllci5oIgpAQCAtMTA2Myw2ICsxMDY0LDggQEAgdm9p ZCBGcmFtZTo6c2V0UGFnZUFuZFRleHRab29tRmFjdG9ycyhmbAogICAgICAgICBpZiAoZG9jdW1l bnQtPnJlbmRlcmVyKCkgJiYgZG9jdW1lbnQtPnJlbmRlcmVyKCktPm5lZWRzTGF5b3V0KCkgJiYg dmlldy0+ZGlkRmlyc3RMYXlvdXQoKSkKICAgICAgICAgICAgIHZpZXctPmxheW91dCgpOwogICAg IH0KKworICAgIHBhZ2VDYWNoZSgpLT5tYXJrUGFnZXNGb3JGdWxsU3R5bGVSZWNhbGMoKTsKIH0K IAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BhZ2UvUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNw cAkocmV2aXNpb24gOTM1MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01NSw2ICs1NSw3IEBACiAjaW5jbHVkZSAiTWVkaWFTdHJlYW1Db250cm9s bGVyLmgiCiAjaW5jbHVkZSAiTmF2aWdhdG9yLmgiCiAjaW5jbHVkZSAiTmV0d29ya1N0YXRlTm90 aWZpZXIuaCIKKyNpbmNsdWRlICJQYWdlQ2FjaGUuaCIKICNpbmNsdWRlICJQYWdlR3JvdXAuaCIK ICNpbmNsdWRlICJQbHVnaW5EYXRhLmgiCiAjaW5jbHVkZSAiUGx1Z2luVmlldy5oIgpAQCAtNTk2 LDYgKzU5Nyw4IEBAIHZvaWQgUGFnZTo6c2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQgc2MKICNp ZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgbV9tYWluRnJhbWUtPmRldmljZU9y UGFnZVNjYWxlRmFjdG9yQ2hhbmdlZCgpOwogI2VuZGlmCisKKyAgICBwYWdlQ2FjaGUoKS0+bWFy a1BhZ2VzRm9yRnVsbFN0eWxlUmVjYWxjKCk7CiB9CiAKIHZvaWQgUGFnZTo6ZGlkTW92ZU9uc2Ny ZWVuKCkK