66243 2011-08-15 11:37:59 -0700 [GTK] Change webview API tests to use "load-status" signal instead of "load-progress" 2011-08-18 08:52:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 28851 1 cmarcelo cmarcelo mrobinson xan.lopez oldest_to_newest 451179 0 cmarcelo 2011-08-15 11:37:59 -0700 [GTK] Change webview API tests to use "load-status" signal instead of "load-progress" 451180 1 103935 cmarcelo 2011-08-15 11:43:31 -0700 Created attachment 103935 Patch 452629 2 103935 mrobinson 2011-08-17 15:11:32 -0700 Comment on attachment 103935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103935&action=review > Source/WebKit/gtk/ChangeLog:10 > + The idle_quit_loop_cb() already checks the "load-status" flag, so it should be > + enough to call it when the "load-status" change. > + I'm not sure I understand why this patch is an improvement. Perhaps you could expand a bit here. It doesn't seem to remove any code. Does it make things more efficient or more correct somehow? > Source/WebKit/gtk/tests/testwebview.c:170 > + g_signal_connect(view, "notify::load-status", G_CALLBACK (idle_quit_loop_cb), NULL); Do you mind also fixing the style issue here? G_CALLBACK (idle_quit_loop_cb) G_CALLBACK(idle_quit_loop_cb) 453026 3 104338 cmarcelo 2011-08-18 07:24:36 -0700 Created attachment 104338 Patch 453030 4 cmarcelo 2011-08-18 07:31:30 -0700 Thanks for the review Martin. (In reply to comment #2) > I'm not sure I understand why this patch is an improvement. Perhaps you could expand a bit here. It doesn't seem to remove any code. Does it make things more efficient or more correct somehow? Improved with an explanation. It is related to bug 28851. Since it is using progress to check whether its load-status changed, I think it is also a good change to do even if bug 28851 doesn't land. > Do you mind also fixing the style issue here? G_CALLBACK (idle_quit_loop_cb) G_CALLBACK(idle_quit_loop_cb) Done. 453038 5 104338 mrobinson 2011-08-18 07:51:01 -0700 Comment on attachment 104338 Patch Thank you! 453073 6 cmarcelo 2011-08-18 08:52:01 -0700 Committed r93311: <http://trac.webkit.org/changeset/93311> 103935 2011-08-15 11:43:31 -0700 2011-08-18 07:24:30 -0700 Patch bug-66243-20110815154328.patch text/plain 1896 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwNDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCAzZTMzNjAyOGQ4 OGQyZGNlN2NiMTEyY2VmNzMwMGUzNDhmNjAyNjg2Li4zY2FjMmVjODlmMDg5MDMxZWUxY2U5Njcx YzU5Y2YxNDU1NjI1OTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDgtMTUgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3Bl bmJvc3NhLm9yZz4KKworICAgICAgICBbR1RLXSBDaGFuZ2Ugd2VidmlldyBBUEkgdGVzdHMgdG8g dXNlICJsb2FkLXN0YXR1cyIgc2lnbmFsIGluc3RlYWQgb2YgImxvYWQtcHJvZ3Jlc3MiCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpZGxlX3F1aXRf bG9vcF9jYigpIGFscmVhZHkgY2hlY2tzIHRoZSAibG9hZC1zdGF0dXMiIGZsYWcsIHNvIGl0IHNo b3VsZCBiZQorICAgICAgICBlbm91Z2ggdG8gY2FsbCBpdCB3aGVuIHRoZSAibG9hZC1zdGF0dXMi IGNoYW5nZS4KKworICAgICAgICAqIHRlc3RzL3Rlc3R3ZWJ2aWV3LmM6CisgICAgICAgICh0ZXN0 X3dlYmtpdF93ZWJfdmlld19ncmFiX2ZvY3VzKToKKwogMjAxMS0wOC0xMCAgQWRhbSBSb2JlbiAg PGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYXIgdXAgc2NhbGUgZmFjdG9yIHRlcm1p bm9sb2d5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5j IGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYwppbmRleCA4ZWJkZDkyYTIw NDRkYWU4Y2U5N2UxNDdmZjVkY2NkYjc1MzRiNThhLi41ZDJhYzEwODUzYzM3ZGI3NDJhNjBjNmEw YzQ0YWYwZGM2NzNhMzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0 d2Vidmlldy5jCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMKQEAg LTE2Nyw3ICsxNjcsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF93ZWJfdmlld19ncmFiX2Zv Y3VzKCkKIAogICAgIGxvb3AgPSBnX21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CiAKLSAgICBn X3NpZ25hbF9jb25uZWN0KHZpZXcsICJub3RpZnk6OnByb2dyZXNzIiwgR19DQUxMQkFDSyAoaWRs ZV9xdWl0X2xvb3BfY2IpLCBOVUxMKTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KHZpZXcsICJub3Rp Znk6OmxvYWQtc3RhdHVzIiwgR19DQUxMQkFDSyAoaWRsZV9xdWl0X2xvb3BfY2IpLCBOVUxMKTsK IAogICAgIC8qIFdhaXQgZm9yIHdpbmRvdyB0byBzaG93IHVwICovCiAgICAgZ3RrX3dpZGdldF9z aG93X2FsbCh3aW5kb3cpOwpAQCAtMjM1LDcgKzIzNSw3IEBAIHN0YXRpYyB2b2lkIGRvX3Rlc3Rf d2Via2l0X3dlYl92aWV3X2FkanVzdG1lbnRzKGdib29sZWFuIHdpdGhfcGFnZV9jYWNoZSkKICAg ICBsb29wID0gZ19tYWluX2xvb3BfbmV3KE5VTEwsIFRSVUUpOwogCiAgICAgZ19vYmplY3RfY29u bmVjdChHX09CSkVDVCh2aWV3KSwKLSAgICAgICAgICAgICAgICAgICAgICJzaWduYWw6Om5vdGlm eTo6cHJvZ3Jlc3MiLCBpZGxlX3F1aXRfbG9vcF9jYiwgTlVMTCwKKyAgICAgICAgICAgICAgICAg ICAgICJzaWduYWw6Om5vdGlmeTo6bG9hZC1zdGF0dXMiLCBpZGxlX3F1aXRfbG9vcF9jYiwgTlVM TCwKICAgICAgICAgICAgICAgICAgICAgIE5VTEwpOwogCiAgICAgLyogV2FpdCBmb3Igd2luZG93 IHRvIHNob3cgdXAgKi8K 104338 2011-08-18 07:24:36 -0700 2011-08-18 07:51:01 -0700 Patch bug-66243-20110818112434.patch text/plain 2209 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogOTMyMTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA2NmI5ODhjZDhh NTg3YThhOGZjYjMyNTRmNzk3MjFiNzMxZGQyNjJjLi41YjhmNjI2ZWZjYWY0NDkwNzJmMjFjZmU0 NjdlZDg1MGVjNzQ2ZWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDgtMTggIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3Bl bmJvc3NhLm9yZz4KKworICAgICAgICBbR1RLXSBDaGFuZ2Ugd2VidmlldyBBUEkgdGVzdHMgdG8g dXNlICJsb2FkLXN0YXR1cyIgc2lnbmFsIGluc3RlYWQgb2YgImxvYWQtcHJvZ3Jlc3MiCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjI0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpZGxlX3F1aXRf bG9vcF9jYigpIGFscmVhZHkgY2hlY2tzIHRoZSAibG9hZC1zdGF0dXMiIGZsYWcsIHNvIGl0IGlz IGVub3VnaCB0bworICAgICAgICBjYWxsIGl0IG9ubHkgd2hlbiB0aGUgImxvYWQtc3RhdHVzIiBj aGFuZ2UuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgaXMgaW1wb3J0YW50IGluIHRoZSBjb250ZXh0 IG9mIGJ1ZyAyODg1MSwgd2hpY2ggYWltcyB0byBjaGFuZ2UgdGhlCisgICAgICAgIG9yZGVyIGlu IHdoaWNoICJwcm9ncmVzcyBmaW5pc2hlZCIgYW5kICJsb2FkIGZpbmlzaGVkIiBjYWxsYmFja3Mg YXJlIGNhbGxlZC4gSW4KKyAgICAgICAgdGhpcyBuZXcgc2NlbmFyaW8sIGF0IHRoZSBwcm9ncmVz cyBjYWxsYmFjayB0aGUgbG9hZCB3aWxsIG5ldmVyIGJlIGZpbmlzaGVkLgorCisgICAgICAgICog dGVzdHMvdGVzdHdlYnZpZXcuYzoKKyAgICAgICAgKHRlc3Rfd2Via2l0X3dlYl92aWV3X2dyYWJf Zm9jdXMpOgorCiAyMDExLTA4LTE2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5v cm9uaGFAY29sbGFib3JhLmNvbT4KIAogICAgICAgICBBZGQgamF2YXNjcmlwdGNvcmVndGsgdG8g dGhlIGludHJvc3BlY3Rpb24gYnVpbGQsIHRvIGZpeCBpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90 ZXN0d2Vidmlldy5jCmluZGV4IDhlYmRkOTJhMjA0NGRhZThjZTk3ZTE0N2ZmNWRjY2RiNzUzNGI1 OGEuLjE1NmRmNjFmZTVmY2E2Y2QyYzU5ZTA1NjRhZGFhNGZmOGRlYjljY2IgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMKKysrIGIvU291cmNlL1dlYktp dC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYwpAQCAtMTY3LDcgKzE2Nyw3IEBAIHN0YXRpYyB2b2lk IHRlc3Rfd2Via2l0X3dlYl92aWV3X2dyYWJfZm9jdXMoKQogCiAgICAgbG9vcCA9IGdfbWFpbl9s b29wX25ldyhOVUxMLCBUUlVFKTsKIAotICAgIGdfc2lnbmFsX2Nvbm5lY3QodmlldywgIm5vdGlm eTo6cHJvZ3Jlc3MiLCBHX0NBTExCQUNLIChpZGxlX3F1aXRfbG9vcF9jYiksIE5VTEwpOworICAg IGdfc2lnbmFsX2Nvbm5lY3QodmlldywgIm5vdGlmeTo6bG9hZC1zdGF0dXMiLCBHX0NBTExCQUNL KGlkbGVfcXVpdF9sb29wX2NiKSwgTlVMTCk7CiAKICAgICAvKiBXYWl0IGZvciB3aW5kb3cgdG8g c2hvdyB1cCAqLwogICAgIGd0a193aWRnZXRfc2hvd19hbGwod2luZG93KTsKQEAgLTIzNSw3ICsy MzUsNyBAQCBzdGF0aWMgdm9pZCBkb190ZXN0X3dlYmtpdF93ZWJfdmlld19hZGp1c3RtZW50cyhn Ym9vbGVhbiB3aXRoX3BhZ2VfY2FjaGUpCiAgICAgbG9vcCA9IGdfbWFpbl9sb29wX25ldyhOVUxM LCBUUlVFKTsKIAogICAgIGdfb2JqZWN0X2Nvbm5lY3QoR19PQkpFQ1QodmlldyksCi0gICAgICAg ICAgICAgICAgICAgICAic2lnbmFsOjpub3RpZnk6OnByb2dyZXNzIiwgaWRsZV9xdWl0X2xvb3Bf Y2IsIE5VTEwsCisgICAgICAgICAgICAgICAgICAgICAic2lnbmFsOjpub3RpZnk6OmxvYWQtc3Rh dHVzIiwgaWRsZV9xdWl0X2xvb3BfY2IsIE5VTEwsCiAgICAgICAgICAgICAgICAgICAgICBOVUxM KTsKIAogICAgIC8qIFdhaXQgZm9yIHdpbmRvdyB0byBzaG93IHVwICovCg==