66222 2011-08-15 06:12:14 -0700 [Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate() 2011-08-15 12:07:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 benjamin benjamin kenneth webkit.review.bot oldest_to_newest 451049 0 benjamin 2011-08-15 06:12:14 -0700 As Kenneth pointed out, this method is evil because it breaks encapsulation and we have no control over who can access the private object. 451050 1 103910 benjamin 2011-08-15 06:19:50 -0700 Created attachment 103910 Patch 451194 2 103910 webkit.review.bot 2011-08-15 12:07:14 -0700 Comment on attachment 103910 Patch Clearing flags on attachment: 103910 Committed r93049: <http://trac.webkit.org/changeset/93049> 451195 3 webkit.review.bot 2011-08-15 12:07:18 -0700 All reviewed patches have been landed. Closing bug. 103910 2011-08-15 06:19:50 -0700 2011-08-15 12:07:14 -0700 Patch bug-66222-20110815152622.patch text/plain 3520 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwMzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyYmI3NWM5NTBlNGYwMjZk YTBmM2I4ZmM0YjgxY2MxMGQyNTkwYjI1Li42MzljY2EyMjY0M2YwYjIzMTdkZDRiMjM1NmMwYzE1 ZTVhZmNiYTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMTUgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF1bV0syXSBH ZXQgcmlkIG9mIFFUb3VjaFdlYlBhZ2VQcml2YXRlOjpnZXRQYWdlVmlld1ByaXZhdGUoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYyMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZnVuY3Rpb24g UVRvdWNoV2ViUGFnZVByaXZhdGU6OmdldFBhZ2VWaWV3UHJpdmF0ZSgpIGV4cG9zZWQKKyAgICAg ICAgdGhlIHByaXZhdGUgUVRvdWNoV2ViUGFnZSB0byBhbnkgb2JqZWN0IGluIFdlYktpdC4KKwor ICAgICAgICBJbnN0ZWFkLCB1c2UgdGhlIGZyaWVuZCBrZXl3b3JkIHRvIGxpc3Qgd2hpY2ggb2Jq ZWN0cyBjYW4gYWNjZXNzCisgICAgICAgIHRoZSBpbnRlcm5hbCBvZiBRVG91Y2hXZWJQYWdlLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmg6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlX3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3F0b3VjaHdlYnZpZXcuY3BwOgorICAgICAgICAoUVRvdWNoV2ViVmlld1ByaXZhdGU6 OlFUb3VjaFdlYlZpZXdQcml2YXRlKToKKyAgICAgICAgKFFUb3VjaFdlYlZpZXdQcml2YXRlOjp2 aWV3cG9ydFJlY3RVcGRhdGVkKToKKwogMjAxMS0wOC0xMyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgdmFyaWFibGVzIGZyb20gV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlci5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXRvdWNod2VicGFnZS5oCmluZGV4IDFjNDJhMzYzN2Q4OTg0M2QzMjZlYTRhMGZjNzVkZGQ2 Nzk4OTg1ZWEuLjYwOGM3NTMyMTNmNGE4NTAwMGQ5M2I1YjVlNTY0NjYxODI0YTViNWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZS5oCkBAIC03 OSw5ICs3OSw4IEBAIHByb3RlY3RlZDoKIAogcHJpdmF0ZToKICAgICBRVG91Y2hXZWJQYWdlUHJp dmF0ZSogZDsKLSAgICBmcmllbmQgY2xhc3MgUVRvdWNoV2ViUGFnZVByaXZhdGU7CisgICAgZnJp ZW5kIGNsYXNzIFFUb3VjaFdlYlZpZXdQcml2YXRlOwogICAgIGZyaWVuZCBjbGFzcyBXZWJLaXQ6 OlRvdWNoVmlld0ludGVyZmFjZTsKLSAgICBmcmllbmQgY2xhc3MgVGlsZWREcmF3aW5nQXJlYVBy b3h5OwogfTsKIAogI2VuZGlmIC8qIHF0b3VjaHdlYnBhZ2VfaCAqLwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlX3AuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZV9wLmgKaW5kZXggNTQ2YTIwZGI0 ZDRkYjc4MDMxYjQ3YjEzNGEyMmRmZWRkZjI1MThmYy4uNjRkZGQ2Yjg3ZjRlMzNmMWRkYjhlODU4 NWMxYjFkZGMyYTQwYjVmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xdG91Y2h3ZWJwYWdlX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3F0b3VjaHdlYnBhZ2VfcC5oCkBAIC0zNiw4ICszNiw2IEBAIGNsYXNzIFFUb3VjaFdlYlBh Z2VQcml2YXRlIHsKIHB1YmxpYzoKICAgICBRVG91Y2hXZWJQYWdlUHJpdmF0ZShRVG91Y2hXZWJQ YWdlKiB2aWV3KTsKIAotICAgIHN0YXRpYyBRVG91Y2hXZWJQYWdlUHJpdmF0ZSogZ2V0UGFnZVZp ZXdQcml2YXRlKFFUb3VjaFdlYlBhZ2UqIHZpZXcpIHsgcmV0dXJuIHZpZXctPmQ7IH0KLQogICAg IHZvaWQgc2V0UGFnZShRVG91Y2hXZWJQYWdlUHJveHkqKTsKIAogICAgIHZvaWQgc2V0Vmlld3Bv cnRSZWN0KGNvbnN0IFFSZWN0RiYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXRvdWNod2Vidmlldy5jcHAKaW5kZXggMjQ1YWFiZmY0MmMxYWUwMGEyNGNkYTU1OWZl MTIwZTFhMjE4OTQyMi4uOGNmZjdjZmY5ZTcxMzNiYjU4OWQxNjRmMmUwMzdiYTFkYWNiNDllMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnZpZXcu Y3BwCkBAIC0zNSw3ICszNSw3IEBAIFFUb3VjaFdlYlZpZXdQcml2YXRlOjpRVG91Y2hXZWJWaWV3 UHJpdmF0ZShRVG91Y2hXZWJWaWV3KiBxKQogICAgICwgdmlld0ludGVyZmFjZShxLCBwYWdlVmll dy5kYXRhKCkpCiAgICAgLCBwYWdlKCZ2aWV3SW50ZXJmYWNlLCBkZWZhdWx0V0tDb250ZXh0KCkp CiB7Ci0gICAgUVRvdWNoV2ViUGFnZVByaXZhdGUqIGNvbnN0IHBhZ2VWaWV3UHJpdmF0ZSA9IFFU b3VjaFdlYlBhZ2VQcml2YXRlOjpnZXRQYWdlVmlld1ByaXZhdGUocGFnZVZpZXcuZGF0YSgpKTsK KyAgICBRVG91Y2hXZWJQYWdlUHJpdmF0ZSogY29uc3QgcGFnZVZpZXdQcml2YXRlID0gcGFnZVZp ZXcuZGF0YSgpLT5kOwogICAgIHBhZ2VWaWV3UHJpdmF0ZS0+c2V0UGFnZSgmcGFnZSk7CiB9CiAK QEAgLTQ4LDcgKzQ4LDcgQEAgdm9pZCBRVG91Y2hXZWJWaWV3UHJpdmF0ZTo6c2Nyb2xsKHFyZWFs IGRlbHRhWCwgcXJlYWwgZGVsdGFZKQogCiB2b2lkIFFUb3VjaFdlYlZpZXdQcml2YXRlOjp2aWV3 cG9ydFJlY3RVcGRhdGVkKCkKIHsKLSAgICBRVG91Y2hXZWJQYWdlUHJpdmF0ZSogY29uc3QgcGFn ZVZpZXdQcml2YXRlID0gUVRvdWNoV2ViUGFnZVByaXZhdGU6OmdldFBhZ2VWaWV3UHJpdmF0ZShw YWdlVmlldy5kYXRhKCkpOworICAgIFFUb3VjaFdlYlBhZ2VQcml2YXRlKiBjb25zdCBwYWdlVmll d1ByaXZhdGUgPSBwYWdlVmlldy5kYXRhKCktPmQ7CiAgICAgY29uc3QgUVJlY3RGIHZpZXdwb3J0 UmVjdEluUGFnZVZpZXdDb29yZGluYXRlID0gcS0+bWFwUmVjdFRvSXRlbShwYWdlVmlldy5kYXRh KCksIHEtPmJvdW5kaW5nUmVjdCgpKTsKICAgICBwYWdlVmlld1ByaXZhdGUtPnNldFZpZXdwb3J0 UmVjdCh2aWV3cG9ydFJlY3RJblBhZ2VWaWV3Q29vcmRpbmF0ZSk7CiB9Cg==