66191 2011-08-13 11:34:41 -0700 Fix incorrect objective-c initialize in WebCore 2011-08-13 11:51:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam cfleizach ddkilzer oldest_to_newest 450870 0 sam 2011-08-13 11:34:41 -0700 Fix incorrect objective-c initialize in WebCore 450871 1 103863 sam 2011-08-13 11:35:40 -0700 Created attachment 103863 Patch 450872 2 103863 mitz 2011-08-13 11:39:09 -0700 Comment on attachment 103863 Patch ! 450873 3 sam 2011-08-13 11:40:53 -0700 Eek! I am so ashamed :( 450874 4 103864 sam 2011-08-13 11:42:44 -0700 Created attachment 103864 Patch 450875 5 103864 ddkilzer 2011-08-13 11:45:56 -0700 Comment on attachment 103864 Patch r=me It's more straightforward if you do this anyway: self = [super init]; if (!self) return nil; 450876 6 sam 2011-08-13 11:51:10 -0700 Committed r93021: <http://trac.webkit.org/changeset/93021> 103863 2011-08-13 11:35:40 -0700 2011-08-13 11:42:41 -0700 Patch bug-66191-20110813113539.patch text/plain 1871 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMDIwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTMgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggaW5jb3JyZWN0IG9iamVjdGl2ZS1j IGluaXRpYWxpemUgaW4gV2ViQ29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjYxOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyLm1tOgorICAgICAgICAoLVtBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBpbml0V2l0aEFj Y2Vzc2liaWxpdHlPYmplY3Q6XSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tOgorICAgICAgICAoLVtXZWJDb3JlUmVuZGVyVGhlbWVOb3RpZmljYXRpb25PYnNlcnZlciBp bml0V2l0aFRoZW1lOldlYkNvcmU6Ol0pOgorICAgICAgICBDb3JyZWN0bHkgaW5pdGlhbGl6ZSBi eSBhc3NpZ25pbmcgdG8gc2VsZiBhbmQgbmlsIGNoZWNraW5nIHRoZSByZXN1bHQuCisKIDIwMTEt MDgtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggY2xh bmcgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5tbQkocmV2aXNpb24gOTMw MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMzM4LDcgKzMzOCw4IEBAIC0gKE5TQXJy YXkgKilhY2Nlc3NpYmlsaXR5QXJyYXlBdHRyaWJ1dGUKIAogLSAoaWQpaW5pdFdpdGhBY2Nlc3Np YmlsaXR5T2JqZWN0OihBY2Nlc3NpYmlsaXR5T2JqZWN0KilheE9iamVjdAogewotICAgIFtzdXBl ciBpbml0XTsKKyAgICBpZiAoKHNlbGYgPSBbc3VwZXIgaW5pdF0pKQorICAgICAgICByZXR1cm4g bmlsOwogCiAgICAgbV9vYmplY3QgPSBheE9iamVjdDsKICAgICByZXR1cm4gc2VsZjsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0JKHJldmlzaW9uIDkz MDE2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC04OCw5ICs4OCwxMCBAQCAtICh2b2lkKXN5c3RlbUNvbG9yc0RpZENoYW5n ZTooTlNOb3RpZmljCiAKIC0gKGlkKWluaXRXaXRoVGhlbWU6KFdlYkNvcmU6OlJlbmRlclRoZW1l ICopdGhlbWUKIHsKLSAgICBbc3VwZXIgaW5pdF07Ci0gICAgX3RoZW1lID0gdGhlbWU7Ci0gICAg CisgICAgaWYgKChzZWxmID0gW3N1cGVyIGluaXRdKSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKwor ICAgIF90aGVtZSA9IHRoZW1lOyAgICAKICAgICByZXR1cm4gc2VsZjsKIH0KIAo= 103864 2011-08-13 11:42:44 -0700 2011-08-13 11:45:56 -0700 Patch bug-66191-20110813114243.patch text/plain 1873 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMDIwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTMgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggaW5jb3JyZWN0IG9iamVjdGl2ZS1j IGluaXRpYWxpemUgaW4gV2ViQ29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjYxOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyLm1tOgorICAgICAgICAoLVtBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBpbml0V2l0aEFj Y2Vzc2liaWxpdHlPYmplY3Q6XSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tOgorICAgICAgICAoLVtXZWJDb3JlUmVuZGVyVGhlbWVOb3RpZmljYXRpb25PYnNlcnZlciBp bml0V2l0aFRoZW1lOldlYkNvcmU6Ol0pOgorICAgICAgICBDb3JyZWN0bHkgaW5pdGlhbGl6ZSBi eSBhc3NpZ25pbmcgdG8gc2VsZiBhbmQgbmlsIGNoZWNraW5nIHRoZSByZXN1bHQuCisKIDIwMTEt MDgtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggY2xh bmcgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5tbQkocmV2aXNpb24gOTMw MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMzM4LDcgKzMzOCw4IEBAIC0gKE5TQXJy YXkgKilhY2Nlc3NpYmlsaXR5QXJyYXlBdHRyaWJ1dGUKIAogLSAoaWQpaW5pdFdpdGhBY2Nlc3Np YmlsaXR5T2JqZWN0OihBY2Nlc3NpYmlsaXR5T2JqZWN0KilheE9iamVjdAogewotICAgIFtzdXBl ciBpbml0XTsKKyAgICBpZiAoIShzZWxmID0gW3N1cGVyIGluaXRdKSkKKyAgICAgICAgcmV0dXJu IG5pbDsKIAogICAgIG1fb2JqZWN0ID0gYXhPYmplY3Q7CiAgICAgcmV0dXJuIHNlbGY7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCShyZXZpc2lvbiA5 MzAxNikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtODgsOSArODgsMTAgQEAgLSAodm9pZClzeXN0ZW1Db2xvcnNEaWRDaGFu Z2U6KE5TTm90aWZpYwogCiAtIChpZClpbml0V2l0aFRoZW1lOihXZWJDb3JlOjpSZW5kZXJUaGVt ZSAqKXRoZW1lCiB7Ci0gICAgW3N1cGVyIGluaXRdOwotICAgIF90aGVtZSA9IHRoZW1lOwotICAg IAorICAgIGlmICghKHNlbGYgPSBbc3VwZXIgaW5pdF0pKQorICAgICAgICByZXR1cm4gbmlsOwor CisgICAgX3RoZW1lID0gdGhlbWU7ICAgIAogICAgIHJldHVybiBzZWxmOwogfQogCg==