66182 2011-08-12 21:04:15 -0700 Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore 2011-08-13 10:48:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 450802 0 sam 2011-08-12 21:04:15 -0700 Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore 450804 1 103854 sam 2011-08-12 21:12:24 -0700 Created attachment 103854 Patch 450854 2 sam 2011-08-13 10:48:58 -0700 Committed r93017: <http://trac.webkit.org/changeset/93017> 103854 2011-08-12 21:12:24 -0700 2011-08-12 21:14:04 -0700 Patch bug-66182-20110812211223.patch text/plain 3759 sam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTMwMTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAK KzIwMTEtMDgtMTIgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXgg YSBidW5jaCBvZiBtaW5vciBidWdzIGNhdWdodCBieSB0aGUgY2xhbmcgc3RhdGljIGFuYWx5emVy IGluIEphdmFTY3JpcHRDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NjE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeGVzIDEwIHdhcm5pbmdzIGluIEphdmFTY3JpcHRDb3JlIGFuZCAyIGluIHRl c3RhcGkuCisKKyAgICAgICAgKiBBUEkvdGVzdHMvdGVzdGFwaS5jOgorICAgICAgICAobWFpbik6 CisgICAgICAgIFJlbW92ZSBkZWFkIHZhcmlhYmxlcy4KKworICAgICAgICAqIGRmZy9ERkdHcmFw aC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6R3JhcGg6OmR1bXApOgorICAgICAgICBJbml0aWFs aXplIGhhc1ByaW50ZWQgYW5kIHNpbGVuY2UgYW4gdW51c2VkIHdhcm5pbmcgYnkgY2FzdGluZyB0 byB2b2lkIChPayBoZXJlCisgICAgICAgIHNpbmNlIGl0IGlzIGRlYnVnIGNvZGUgYW5kIEkgd2Fu dCB0byBrZWVwIGl0IGNsZWFyIHRoYXQgaWYgb3RoZXIgY2FzZXMgYXJlIGFkZGVkLAorICAgICAg ICB0aGUgaGFzUHJpbnRlZCBmbGFnIHdvdWxkIGJlIG5lZWRlZCkuCisKKyAgICAgICAgKiB3dGYv ZHRvYS5jcHA6CisgICAgICAgIChXVEY6OmQyYik6CisgICAgICAgIFRoZSB2YXJpYWJsZSAiZGUi IGluIHRoZSBlbHNlIGJsb2NrIGlzIGFsd2F5cyB6ZXJvLCBzbyB0aGVyZSBpcyBubyByZWFzb24g dG8KKyAgICAgICAgdXNlIGl0LgorCiAyMDExLTA4LTEyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVXNlIF9fYnVpbHRpbl90cmFwKCkgZm9yIENSQVNIIHdoZW4gYnVp bGRpbmcgd2l0aCBjbGFuZwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90 ZXN0YXBpLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90 ZXN0YXBpLmMJKHJldmlzaW9uIDkzMDExKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90 ZXN0cy90ZXN0YXBpLmMJKHdvcmtpbmcgY29weSkKQEAgLTEzNjYsNyArMTM2Niw3IEBAIGludCBt YWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgZnVuY3Rpb24gPSBKU09iamVjdE1ha2VG dW5jdGlvbihjb250ZXh0LCBmb28sIDEsIGFyZ3VtZW50TmFtZXMsIGZ1bmN0aW9uQm9keSwgTlVM TCwgMSwgJmV4Y2VwdGlvbik7CiAgICAgQVNTRVJUKGZ1bmN0aW9uICYmICFleGNlcHRpb24pOwog ICAgIEpTVmFsdWVSZWYgYXJndW1lbnRzW10gPSB7IEpTVmFsdWVNYWtlTnVtYmVyKGNvbnRleHQs IDIpIH07Ci0gICAgdiA9IEpTT2JqZWN0Q2FsbEFzRnVuY3Rpb24oY29udGV4dCwgZnVuY3Rpb24s IE5VTEwsIDEsIGFyZ3VtZW50cywgJmV4Y2VwdGlvbik7CisgICAgSlNPYmplY3RDYWxsQXNGdW5j dGlvbihjb250ZXh0LCBmdW5jdGlvbiwgTlVMTCwgMSwgYXJndW1lbnRzLCAmZXhjZXB0aW9uKTsK ICAgICBKU1N0cmluZ1JlbGVhc2UoZm9vKTsKICAgICBKU1N0cmluZ1JlbGVhc2UoZnVuY3Rpb25C b2R5KTsKICAgICAKQEAgLTE0OTMsNyArMTQ5Myw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFy KiBhcmd2W10pCiAgICAgLy8gYW4gYXNzZXJ0IGluc2lkZSBwdXREaXJlY3Qgb3IgbGVhZCB0byBh IGNyYXNoIGR1cmluZyBHQy4gPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNTc4NT4KICAgICBudWxsRGVmaW5pdGlvbiA9IGtKU0NsYXNzRGVmaW5pdGlvbkVtcHR5Owog ICAgIG51bGxDbGFzcyA9IEpTQ2xhc3NDcmVhdGUoJm51bGxEZWZpbml0aW9uKTsKLSAgICBteUNv bnN0cnVjdG9yID0gSlNPYmplY3RNYWtlQ29uc3RydWN0b3IoY29udGV4dCwgbnVsbENsYXNzLCAw KTsKKyAgICBKU09iamVjdE1ha2VDb25zdHJ1Y3Rvcihjb250ZXh0LCBudWxsQ2xhc3MsIDApOwog ICAgIEpTQ2xhc3NSZWxlYXNlKG51bGxDbGFzcyk7CiAKICAgICBjaGFyKiBzY3JpcHRVVEY4ID0g Y3JlYXRlU3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKHNjcmlwdFBhdGgpOwpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlzaW9uIDkzMDExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxLDcg KzgxLDcgQEAgdm9pZCBHcmFwaDo6ZHVtcChOb2RlSW5kZXggbm9kZUluZGV4LCBDbwogICAgIGVs c2UKICAgICAgICAgcHJpbnRmKCItIik7CiAgICAgcHJpbnRmKCI+XHQlcygiLCBvcE5hbWUob3Ap KTsKLSAgICBib29sIGhhc1ByaW50ZWQ7CisgICAgYm9vbCBoYXNQcmludGVkID0gZmFsc2U7CiAg ICAgaWYgKG9wICYgTm9kZUhhc1ZhckFyZ3MpIHsKICAgICAgICAgZm9yICh1bnNpZ25lZCBjaGls ZElkeCA9IG5vZGUuZmlyc3RDaGlsZCgpOyBjaGlsZElkeCA8IG5vZGUuZmlyc3RDaGlsZCgpICsg bm9kZS5udW1DaGlsZHJlbigpOyBjaGlsZElkeCsrKSB7CiAgICAgICAgICAgICBpZiAoaGFzUHJp bnRlZCkKQEAgLTEzMSw3ICsxMzEsOCBAQCB2b2lkIEdyYXBoOjpkdW1wKE5vZGVJbmRleCBub2Rl SW5kZXgsIENvCiAgICAgICAgIHByaW50ZigiJXNGOiMldSIsIGhhc1ByaW50ZWQgPyAiLCAiIDog IiIsIGJsb2NrSW5kZXhGb3JCeXRlY29kZU9mZnNldChub2RlLm5vdFRha2VuQnl0ZWNvZGVPZmZz ZXQoKSkpOwogICAgICAgICBoYXNQcmludGVkID0gdHJ1ZTsKICAgICB9Ci0KKyAgICAodm9pZClo YXNQcmludGVkOworICAgIAogICAgIHByaW50ZigiKSIpOwogICAgIAogICAgIGlmIChub2RlLmhh c0xvY2FsKCkpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL2R0b2EuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvZHRvYS5jcHAJKHJldmlzaW9uIDkz MDExKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9kdG9hLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzA0LDcgKzcwNCw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQgZDJiKEJpZ0lu dCYgYiwKICAgICAgICAgKmUgPSBkZSAtIEJpYXMgLSAoUCAtIDEpICsgazsKICAgICAgICAgKmJp dHMgPSBQIC0gazsKICAgICB9IGVsc2UgewotICAgICAgICAqZSA9IGRlIC0gQmlhcyAtIChQIC0g MSkgKyAxICsgazsKKyAgICAgICAgKmUgPSAwIC0gQmlhcyAtIChQIC0gMSkgKyAxICsgazsKICAg ICAgICAgKmJpdHMgPSAoMzIgKiBpKSAtIGhpMGJpdHMoeFtpIC0gMV0pOwogICAgIH0KIH0K