66166 2011-08-12 14:17:48 -0700 garden-o-matic's analyzeUnexpectedFailures needs a completion callback. 2011-08-13 08:39:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64188 1 dglazkov dglazkov abarth oldest_to_newest 450662 0 dglazkov 2011-08-12 14:17:48 -0700 garden-o-matic's analyzeUnexpectedFailures needs a completion callback. 450663 1 103814 dglazkov 2011-08-12 14:18:33 -0700 Created attachment 103814 Patch 450671 2 103814 abarth 2011-08-12 14:31:55 -0700 Comment on attachment 103814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103814&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:292 > + model.analyzeUnexpectedFailures(showUnexpectedFailure, function() { > + dismissButterbar(); > + }); You can just pass dismissButterbar as the completion callback. You don't need the thunk. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:126 > + var queriesInFlight = Object.keys(unexpectedFailures).length; please use base.RequestTracker. 450722 3 103833 dglazkov 2011-08-12 15:49:01 -0700 Created attachment 103833 Patch 450727 4 103833 abarth 2011-08-12 15:53:11 -0700 Comment on attachment 103833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103833&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:114 > + this._tryCallback(); Did you check the other call sites to see what they thought of this new behavior? I seem to remember a bunch of them doing this manually. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:117 > +base.RequestTracker.prototype = { I prefer the other style of modifying the prototype, but whatever. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:126 > + var tracker = new base.RequestTracker(Object.keys(unexpectedFailures).length, completionCallback); Why Object.keys and not base.keys ? Should base.keys == Object.keys when Object.keys is available? 450733 5 103833 dglazkov 2011-08-12 15:59:02 -0700 Comment on attachment 103833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103833&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:114 >> + this._tryCallback(); > > Did you check the other call sites to see what they thought of this new behavior? I seem to remember a bunch of them doing this manually. Yep. I did. There were only two other callsites. >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:117 >> +base.RequestTracker.prototype = { > > I prefer the other style of modifying the prototype, but whatever. :) 450841 6 103833 dglazkov 2011-08-13 08:39:17 -0700 Comment on attachment 103833 Patch Clearing flags on attachment: 103833 Committed r93016: <http://trac.webkit.org/changeset/93016> 450842 7 dglazkov 2011-08-13 08:39:22 -0700 All reviewed patches have been landed. Closing bug. 103814 2011-08-12 14:18:33 -0700 2011-08-12 15:48:57 -0700 Patch bug-66166-20110812141831.patch text/plain 3268 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTI5OTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9t YWluLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21haW4uanMKaW5kZXggZjU5NzQzNzM4NDM4NmE5YWE3 YWM0ZTcwNTllODc2YWRmODE1NmJjNi4uOTY3MDJlZTFiYWNlNDAxYzc2MTY4OTJlZTUyY2E3ZWUy ODI3ODMxMyAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21haW4uanMKKysrIGIvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL21haW4uanMKQEAgLTI4Nyw4ICsyODcsOSBAQCBmdW5jdGlvbiB1cGRhdGUoKQog ICAgIGJhc2UuY2FsbEluUGFyYWxsZWwoW21vZGVsLnVwZGF0ZVJlY2VudENvbW1pdHMsIG1vZGVs LnVwZGF0ZVJlc3VsdHNCeUJ1aWxkZXJdLCBmdW5jdGlvbigpIHsKICAgICAgICAgc2hvd1JlY2Vu dENvbW1pdHMoKTsKICAgICAgICAgc2hvd0J1aWxkZXJQcm9ncmVzcygpOwotICAgICAgICBtb2Rl bC5hbmFseXplVW5leHBlY3RlZEZhaWx1cmVzKHNob3dVbmV4cGVjdGVkRmFpbHVyZSk7Ci0gICAg ICAgIGRpc21pc3NCdXR0ZXJiYXIoKTsKKyAgICAgICAgbW9kZWwuYW5hbHl6ZVVuZXhwZWN0ZWRG YWlsdXJlcyhzaG93VW5leHBlY3RlZEZhaWx1cmUsIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAg ZGlzbWlzc0J1dHRlcmJhcigpOworICAgICAgICB9KTsKICAgICAgICAgY2hlY2tGb3JMb2NhbFNl cnZlcigpOwogICAgIH0pOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsLmpz IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsLmpzCmluZGV4IDA4ZTFkMGQ0ZjViZGZlZDhiZTcxM2M2 Y2NiMzEyM2Y2YzljMWUwODEuLjczNGU4MjczNzg3MzJlNTQ1N2U1YzAzM2UyYmUyNDY5YmE4ZDZi MTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbC5qcworKysgYi9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFp bHVyZXMvbW9kZWwuanMKQEAgLTExNCw3ICsxMTQsNyBAQCBtb2RlbC51cGRhdGVSZXN1bHRzQnlC dWlsZGVyID0gZnVuY3Rpb24oY2FsbGJhY2spCiAgICAgfSk7CiB9OwogCi1tb2RlbC5hbmFseXpl VW5leHBlY3RlZEZhaWx1cmVzID0gZnVuY3Rpb24oY2FsbGJhY2spCittb2RlbC5hbmFseXplVW5l eHBlY3RlZEZhaWx1cmVzID0gZnVuY3Rpb24oY2FsbGJhY2ssIGNvbXBsZXRpb25DYWxsYmFjaykK IHsKICAgICB2YXIgdW5leHBlY3RlZEZhaWx1cmVzID0gcmVzdWx0cy51bmV4cGVjdGVkRmFpbHVy ZXNCeVRlc3QobW9kZWwuc3RhdGUucmVzdWx0c0J5QnVpbGRlcik7CiAKQEAgLTEyMyw2ICsxMjMs NyBAQCBtb2RlbC5hbmFseXplVW5leHBlY3RlZEZhaWx1cmVzID0gZnVuY3Rpb24oY2FsbGJhY2sp CiAgICAgICAgICAgICBkZWxldGUgbW9kZWwuc3RhdGUuZmFpbHVyZUFuYWx5c2lzQnlUZXN0W3Rl c3ROYW1lXTsKICAgICB9KTsKIAorICAgIHZhciBxdWVyaWVzSW5GbGlnaHQgPSBPYmplY3Qua2V5 cyh1bmV4cGVjdGVkRmFpbHVyZXMpLmxlbmd0aDsKICAgICAkLmVhY2godW5leHBlY3RlZEZhaWx1 cmVzLCBmdW5jdGlvbih0ZXN0TmFtZSwgcmVzdWx0Tm9kZXNCeUJ1aWxkZXIpIHsKICAgICAgICAg dmFyIGJ1aWxkZXJOYW1lTGlzdCA9IGJhc2Uua2V5cyhyZXN1bHROb2Rlc0J5QnVpbGRlcik7CiAg ICAgICAgIHJlc3VsdHMudW5pZnlSZWdyZXNzaW9uUmFuZ2VzKGJ1aWxkZXJOYW1lTGlzdCwgdGVz dE5hbWUsIGZ1bmN0aW9uKG9sZGVzdEZhaWxpbmdSZXZpc2lvbiwgbmV3ZXN0UGFzc2luZ1Jldmlz aW9uKSB7CkBAIC0xNDUsNiArMTQ2LDcgQEAgbW9kZWwuYW5hbHl6ZVVuZXhwZWN0ZWRGYWlsdXJl cyA9IGZ1bmN0aW9uKGNhbGxiYWNrKQogCiAgICAgICAgICAgICBtb2RlbC5zdGF0ZS5mYWlsdXJl QW5hbHlzaXNCeVRlc3RbdGVzdE5hbWVdID0gZmFpbHVyZUFuYWx5c2lzOwogICAgICAgICAgICAg Y2FsbGJhY2soZmFpbHVyZUFuYWx5c2lzKTsKKyAgICAgICAgICAgIC0tcXVlcmllc0luRmxpZ2h0 IHx8IGNvbXBsZXRpb25DYWxsYmFjayAmJiBjb21wbGV0aW9uQ2FsbGJhY2soKTsKICAgICAgICAg fSk7CiAgICAgfSk7CiB9OwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IGY0ZDc3MDFhODVkZDcyODFlZjBmNzg3MjY0YThmYWY3NzE5ZTc2NjYuLjU0 MzU0YWM0NmQ0NmI3MjM4YWNjNmU1MTRkNDA0ZWVkNDA2OWQ1NmMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0w OC0xMiAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAg IGdhcmRlbi1vLW1hdGljJ3MgYW5hbHl6ZVVuZXhwZWN0ZWRGYWlsdXJlcyBuZWVkcyBhIGNvbXBs ZXRpb24gY2FsbGJhY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NjE2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvVGVzdEZhaWx1cmVzL21haW4uanM6IFN0YXJ0ZWQgdXNpbmcgY29tcGxldGlvbiBjYWxs YmFjay4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWwuanM6IEFkZGVkIGNvbXBsZXRpb24gY2Fs bGJhY2suCisKIDIwMTEtMDgtMTIgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAg ICAgICAgIGFsbG93Um91bmRpbmdIYWNrc0NhbGxiYWNrIHVzZXMgdGhlIHdyb25nIGFyZ3VtZW50 IGZvciAndGhpc09iamVjdCcuCg== 103833 2011-08-12 15:49:01 -0700 2011-08-13 08:39:17 -0700 Patch bug-66166-20110812154900.patch text/plain 5947 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwMDMKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9i YXNlLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL2Jhc2UuanMKaW5kZXggNzliMmQyOTI4MGJlYmFmODY4 MTFlODNjMmUwYjFjNjcwNzYwYjI4Yi4uMzdkNTJmZGNjMzFlODVhMzQ0YmVkNTJkYTZhNjRjYWFk ZDMwNmZkOSAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL2Jhc2UuanMKKysrIGIvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL2Jhc2UuanMKQEAgLTExMSwxNCArMTExLDIxIEBAIGJhc2UuUmVxdWVzdFRyYWNr ZXIgPSBmdW5jdGlvbihyZXF1ZXN0c0luRmxpZ2h0LCBjYWxsYmFjaywgYXJncykKICAgICB0aGlz Ll9yZXF1ZXN0c0luRmxpZ2h0ID0gcmVxdWVzdHNJbkZsaWdodDsKICAgICB0aGlzLl9jYWxsYmFj ayA9IGNhbGxiYWNrOwogICAgIHRoaXMuX2FyZ3MgPSBhcmdzIHx8IFtdOworICAgIHRoaXMuX3Ry eUNhbGxiYWNrKCk7CiB9OwogCi1iYXNlLlJlcXVlc3RUcmFja2VyLnByb3RvdHlwZS5yZXF1ZXN0 Q29tcGxldGUgPSBmdW5jdGlvbigpCi17Ci0gICAgLS10aGlzLl9yZXF1ZXN0c0luRmxpZ2h0Owot ICAgIGlmICghdGhpcy5fcmVxdWVzdHNJbkZsaWdodCkKLSAgICAgICAgdGhpcy5fY2FsbGJhY2su YXBwbHkobnVsbCwgdGhpcy5fYXJncyk7Ci19OworYmFzZS5SZXF1ZXN0VHJhY2tlci5wcm90b3R5 cGUgPSB7CisgICAgX3RyeUNhbGxiYWNrOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAo IXRoaXMuX3JlcXVlc3RzSW5GbGlnaHQgJiYgdGhpcy5fY2FsbGJhY2spCisgICAgICAgICAgICB0 aGlzLl9jYWxsYmFjay5hcHBseShudWxsLCB0aGlzLl9hcmdzKTsKKyAgICB9LAorICAgIHJlcXVl c3RDb21wbGV0ZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgLS10aGlzLl9yZXF1ZXN0c0lu RmxpZ2h0OworICAgICAgICB0aGlzLl90cnlDYWxsYmFjaygpOworICAgIH0KK30KIAogYmFzZS5j YWxsSW5QYXJhbGxlbCA9IGZ1bmN0aW9uKGZ1bmN0aW9uTGlzdCwgY2FsbGJhY2spCiB7CmRpZmYg LS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvYmFzZV91bml0dGVzdHMuanMgYi9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVy ZXMvYmFzZV91bml0dGVzdHMuanMKaW5kZXggYWU2YTNmNDIwZDgyZmY4YmM4MGNjZWZmNDQzOWY1 MTgyNjRjNTQ0NS4uNmI4Y2I3MmI3ZTJmZDg3MTVkYzJjOTc3ZWNhMjUwNTA2N2JjYTM4ZCAxMDA2 NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL2Jhc2VfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RG YWlsdXJlcy9iYXNlX3VuaXR0ZXN0cy5qcwpAQCAtMTEzLDcgKzExMyw3IEBAIHRlc3QoImNhbGxJ blNlcXVlbmNlIiwgNywgZnVuY3Rpb24oKSB7CiAgICAgfSkKIH0pOwogCi10ZXN0KCJSZXF1ZXN0 VHJhY2tlciIsIDMsIGZ1bmN0aW9uKCkgewordGVzdCgiUmVxdWVzdFRyYWNrZXIiLCA1LCBmdW5j dGlvbigpIHsKICAgICB2YXIgcmVhZHkgPSBmYWxzZTsKICAgICB2YXIgdHJhY2tlciA9IG5ldyBi YXNlLlJlcXVlc3RUcmFja2VyKDEsIGZ1bmN0aW9uKCkgewogICAgICAgICBvayhyZWFkeSk7CkBA IC0xMzIsOSArMTMyLDE0IEBAIHRlc3QoIlJlcXVlc3RUcmFja2VyIiwgMywgZnVuY3Rpb24oKSB7 CiAgICAgcmVhZHkgPSBmYWxzZTsKIAogICAgIHRyYWNrZXIgPSBuZXcgYmFzZS5SZXF1ZXN0VHJh Y2tlcigwLCBmdW5jdGlvbigpIHsKLSAgICAgICAgb2soZmFsc2UpOworICAgICAgICBvayh0cnVl KTsKICAgICB9KTsKICAgICB0cmFja2VyLnJlcXVlc3RDb21wbGV0ZSgpOworCisgICAgdHJhY2tl ciA9IG5ldyBiYXNlLlJlcXVlc3RUcmFja2VyKDApOworICAgIHRyYWNrZXIucmVxdWVzdENvbXBs ZXRlKCk7CisgICAgLy8gU2hvdWxkIG5vdCBiYXJmLgorICAgIG9rKHRydWUpOwogfSk7CiAKIHRl c3QoIkNhbGxiYWNrSXRlcmF0b3IiLCAyMiwgZnVuY3Rpb24oKSB7CmRpZmYgLS1naXQgYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvbWFpbi5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tYWluLmpzCmluZGV4IGY1OTc0 MzczODQzODZhOWFhN2FjNGU3MDU5ZTg3NmFkZjgxNTZiYzYuLjBiN2QzODU0MzE0NGY3NDIyYWQy MjQwY2NlYjlmNmYxYzU5YmQ5OWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tYWluLmpz CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tYWluLmpzCkBAIC0yODcsOCArMjg3LDcgQEAgZnVuY3Rp b24gdXBkYXRlKCkKICAgICBiYXNlLmNhbGxJblBhcmFsbGVsKFttb2RlbC51cGRhdGVSZWNlbnRD b21taXRzLCBtb2RlbC51cGRhdGVSZXN1bHRzQnlCdWlsZGVyXSwgZnVuY3Rpb24oKSB7CiAgICAg ICAgIHNob3dSZWNlbnRDb21taXRzKCk7CiAgICAgICAgIHNob3dCdWlsZGVyUHJvZ3Jlc3MoKTsK LSAgICAgICAgbW9kZWwuYW5hbHl6ZVVuZXhwZWN0ZWRGYWlsdXJlcyhzaG93VW5leHBlY3RlZEZh aWx1cmUpOwotICAgICAgICBkaXNtaXNzQnV0dGVyYmFyKCk7CisgICAgICAgIG1vZGVsLmFuYWx5 emVVbmV4cGVjdGVkRmFpbHVyZXMoc2hvd1VuZXhwZWN0ZWRGYWlsdXJlLCBkaXNtaXNzQnV0dGVy YmFyKTsKICAgICAgICAgY2hlY2tGb3JMb2NhbFNlcnZlcigpOwogICAgIH0pOwogfQpkaWZmIC0t Z2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL21vZGVsLmpz CmluZGV4IDA4ZTFkMGQ0ZjViZGZlZDhiZTcxM2M2Y2NiMzEyM2Y2YzljMWUwODEuLmI3NzIyMzZj MmUzMmRmM2M0NjZkMDBmZmVlYmM4OWM3ZmQ4ZjY5NDIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWls dXJlcy9tb2RlbC5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbW9kZWwuanMKQEAgLTExNCw3ICsx MTQsNyBAQCBtb2RlbC51cGRhdGVSZXN1bHRzQnlCdWlsZGVyID0gZnVuY3Rpb24oY2FsbGJhY2sp CiAgICAgfSk7CiB9OwogCi1tb2RlbC5hbmFseXplVW5leHBlY3RlZEZhaWx1cmVzID0gZnVuY3Rp b24oY2FsbGJhY2spCittb2RlbC5hbmFseXplVW5leHBlY3RlZEZhaWx1cmVzID0gZnVuY3Rpb24o Y2FsbGJhY2ssIGNvbXBsZXRpb25DYWxsYmFjaykKIHsKICAgICB2YXIgdW5leHBlY3RlZEZhaWx1 cmVzID0gcmVzdWx0cy51bmV4cGVjdGVkRmFpbHVyZXNCeVRlc3QobW9kZWwuc3RhdGUucmVzdWx0 c0J5QnVpbGRlcik7CiAKQEAgLTEyMyw2ICsxMjMsNyBAQCBtb2RlbC5hbmFseXplVW5leHBlY3Rl ZEZhaWx1cmVzID0gZnVuY3Rpb24oY2FsbGJhY2spCiAgICAgICAgICAgICBkZWxldGUgbW9kZWwu c3RhdGUuZmFpbHVyZUFuYWx5c2lzQnlUZXN0W3Rlc3ROYW1lXTsKICAgICB9KTsKIAorICAgIHZh ciB0cmFja2VyID0gbmV3IGJhc2UuUmVxdWVzdFRyYWNrZXIoT2JqZWN0LmtleXModW5leHBlY3Rl ZEZhaWx1cmVzKS5sZW5ndGgsIGNvbXBsZXRpb25DYWxsYmFjayk7CiAgICAgJC5lYWNoKHVuZXhw ZWN0ZWRGYWlsdXJlcywgZnVuY3Rpb24odGVzdE5hbWUsIHJlc3VsdE5vZGVzQnlCdWlsZGVyKSB7 CiAgICAgICAgIHZhciBidWlsZGVyTmFtZUxpc3QgPSBiYXNlLmtleXMocmVzdWx0Tm9kZXNCeUJ1 aWxkZXIpOwogICAgICAgICByZXN1bHRzLnVuaWZ5UmVncmVzc2lvblJhbmdlcyhidWlsZGVyTmFt ZUxpc3QsIHRlc3ROYW1lLCBmdW5jdGlvbihvbGRlc3RGYWlsaW5nUmV2aXNpb24sIG5ld2VzdFBh c3NpbmdSZXZpc2lvbikgewpAQCAtMTQ1LDYgKzE0Niw3IEBAIG1vZGVsLmFuYWx5emVVbmV4cGVj dGVkRmFpbHVyZXMgPSBmdW5jdGlvbihjYWxsYmFjaykKIAogICAgICAgICAgICAgbW9kZWwuc3Rh dGUuZmFpbHVyZUFuYWx5c2lzQnlUZXN0W3Rlc3ROYW1lXSA9IGZhaWx1cmVBbmFseXNpczsKICAg ICAgICAgICAgIGNhbGxiYWNrKGZhaWx1cmVBbmFseXNpcyk7CisgICAgICAgICAgICB0cmFja2Vy LnJlcXVlc3RDb21wbGV0ZSgpOwogICAgICAgICB9KTsKICAgICB9KTsKIH07CmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGE2MzY0YjA2YjYyNmVm ZTlhZjE4OGU5Y2M2OGNiZjA4ZjA3YjIzOS4uNWE0YzY3MTk0Y2VlMzFlMzEwYWRlOGY3OTg0MTMw OWI4ODE3ODhlYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTA4LTEyICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xh emtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZ2FyZGVuLW8tbWF0aWMncyBhbmFseXplVW5l eHBlY3RlZEZhaWx1cmVzIG5lZWRzIGEgY29tcGxldGlvbiBjYWxsYmFjay4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2MTY2CisKKyAgICAgICAgQWxz byBjaGFuZ2VkIGJhc2UuUmVxdWVzdFRyYWNrZXIgdG86CisgICAgICAgIGEpIGZpcmUgY2FsbGJh Y2sgaW1tZWRpYXRlbHkgaWYgcmVxdWVzdHNJbkZsaWdodCBpcyAwOworICAgICAgICBiKSBub3Qg YmFyZiBpZiBjYWxsYmFjayBpcyBub3Qgc3VwcGxpZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvbWFpbi5qczogU3RhcnRlZCB1 c2luZyBjb21wbGV0aW9uIGNhbGxiYWNrLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9tb2RlbC5qczog QWRkZWQgY29tcGxldGlvbiBjYWxsYmFjay4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvYmFzZS5qczog Q2hhbmdlZCBSZXF1ZXN0VHJhY2tlci4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvYmFzZV91bml0dGVz dC5qczogQWRkZWQgdW5pdCB0ZXN0cy4KKwogMjAxMS0wOC0xMiAgU2FkcnVsIEhhYmliIENob3dk aHVyeSAgPHNhZHJ1bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRFJUOiBBZGQgc3VwcG9ydCBm b3IgZ2VzdHVyZSBldmVudHMuCg==