66155 2011-08-12 12:33:30 -0700 REGRESSION(r92978): This patch does not compile (Requested by abarth|gardener on #webkit). 2011-08-12 12:38:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66089 1 webkit.review.bot webkit.review.bot abarth fishd fsamuel oldest_to_newest 450568 0 webkit.review.bot 2011-08-12 12:33:30 -0700 http://trac.webkit.org/changeset/92978 broke the build: This patch does not compile (Requested by abarth|gardener on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 450569 1 103794 webkit.review.bot 2011-08-12 12:33:54 -0700 Created attachment 103794 ROLLOUT of r92978 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 450572 2 103794 abarth 2011-08-12 12:38:48 -0700 Comment on attachment 103794 ROLLOUT of r92978 Clearing flags on attachment: 103794 Committed r92980: <http://trac.webkit.org/changeset/92980> 450573 3 abarth 2011-08-12 12:38:51 -0700 All reviewed patches have been landed. Closing bug. 103794 2011-08-12 12:33:54 -0700 2011-08-12 12:38:48 -0700 ROLLOUT of r92978 bug-66155-20110812193315.patch text/plain 7434 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogOTI5NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZTkxMGM2ZWM4ZDVmMGZlNjJlYzA3OTI1ZDAxNmMyZTFkNmNjYTkzOC4uMTc1ODdiNWY5MWFiYjcx ZDRhY2IxZjVhNGJkZDdlOGU4ODM4ZTdiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMiBAQAorMjAxMS0wOC0xMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkyOTc4Lgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC85Mjk3OAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYxNTUKKworICAgICAgICBU aGlzIHBhdGNoIGRvZXMgbm90IGNvbXBpbGUgKFJlcXVlc3RlZCBieSBhYmFydGh8Z2FyZGVuZXIg b24KKyAgICAgICAgI3dlYmtpdCkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs Ojp6b29tTGV2ZWwpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0Wm9vbUxldmVs KToKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6Onpvb21MaW1pdHNDaGFuZ2VkKToKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmZ1bGxGcmFtZVBsdWdpblpvb21MZXZlbENoYW5n ZWQpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojp6b29tTGV2ZWxUb1pvb21GYWN0b3IpOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojp6b29tRmFjdG9yVG9ab29tTGV2ZWwpOgorICAgICAg ICAqIHNyYy9XZWJWaWV3SW1wbC5oOgorCiAyMDExLTA4LTEyICBGYWR5IFNhbXVlbCAgPGZzYW11 ZWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENocm9taXVtJ3MgV2ViS2l0IEFQSSBzaG91bGQg dXNlIGZsb2F0cyBpbnN0ZWFkIG9mIGRvdWJsZXMgZm9yIHpvb20gdG8gbWF0Y2ggV2ViQ29yZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCmluZGV4IDQ3ZmI4Yzk4MTFkNTE0 ZTI5MmFmMTFjZTdjMzcxZmQ3ZWQ1YTE5MGMuLjI2NTk5YWMzMDE5OWY4ZTQ1ZWFmNmI0YjNjYTVl OTdjZDZjMDcwYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKQEAg LTE4Miw3ICsxODIsNyBAQCBwdWJsaWM6CiAgICAgLy8gb2YgMzAwJSBhbmQgNTAlIG9mIG9yaWdp bmFsIHNpemUsIHJlc3BlY3RpdmVseS4gIE9ubHkgcGx1Z2lucyB1c2UKICAgICAvLyBub24gd2hv bGUtbnVtYmVycywgc2luY2UgdGhleSBtaWdodCBjaG9vc2UgdG8gaGF2ZSBzcGVjaWZpYyB6b29t IGxldmVsIHNvCiAgICAgLy8gdGhhdCBmaXhlZC13aWR0aCBjb250ZW50IGlzIGZpdC10by1wYWdl LXdpZHRoLCBmb3IgZXhhbXBsZS4KLSAgICB2aXJ0dWFsIGZsb2F0IHpvb21MZXZlbCgpIGNvbnN0 ID0gMDsKKyAgICB2aXJ0dWFsIGRvdWJsZSB6b29tTGV2ZWwoKSA9IDA7CiAKICAgICAvLyBDaGFu Z2VzIHRoZSB6b29tIGxldmVsIHRvIHRoZSBzcGVjaWZpZWQgbGV2ZWwsIGNsYW1waW5nIGF0IHRo ZSBsaW1pdHMKICAgICAvLyBub3RlZCBhYm92ZSwgYW5kIHJldHVybnMgdGhlIGN1cnJlbnQgem9v bSBsZXZlbCBhZnRlciBhcHBseWluZyB0aGUKQEAgLTE5MiwxNiArMTkyLDE2IEBAIHB1YmxpYzoK ICAgICAvLyBwYWdlIHdpbGwgYmUgem9vbWVkLiBZb3UgY2FuIG9ubHkgaGF2ZSBlaXRoZXIgdGV4 dCB6b29tIG9yIGZ1bGwgcGFnZSB6b29tCiAgICAgLy8gYXQgb25lIHRpbWUuICBDaGFuZ2luZyB0 aGUgbW9kZSB3aGlsZSB0aGUgcGFnZSBpcyB6b29tZWQgd2lsbCBoYXZlIG9kZAogICAgIC8vIGVm ZmVjdHMuCi0gICAgdmlydHVhbCBmbG9hdCBzZXRab29tTGV2ZWwoYm9vbCB0ZXh0T25seSwgZmxv YXQgem9vbUxldmVsKSA9IDA7CisgICAgdmlydHVhbCBkb3VibGUgc2V0Wm9vbUxldmVsKGJvb2wg dGV4dE9ubHksIGRvdWJsZSB6b29tTGV2ZWwpID0gMDsKIAogICAgIC8vIFVwZGF0ZXMgdGhlIHpv b20gbGltaXRzIGZvciB0aGlzIHZpZXcuCi0gICAgdmlydHVhbCB2b2lkIHpvb21MaW1pdHNDaGFu Z2VkKGZsb2F0IG1pbmltdW1ab29tTGV2ZWwsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGZsb2F0IG1heGltdW1ab29tTGV2ZWwpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgem9v bUxpbWl0c0NoYW5nZWQoZG91YmxlIG1pbmltdW1ab29tTGV2ZWwsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGRvdWJsZSBtYXhpbXVtWm9vbUxldmVsKSA9IDA7CiAKICAgICAv LyBIZWxwZXIgZnVuY3Rpb25zIHRvIGNvbnZlcnQgYmV0d2VlbiB6b29tIGxldmVsIGFuZCB6b29t IGZhY3Rvci4gIHpvb20KICAgICAvLyBmYWN0b3IgaXMgem9vbSBwZXJjZW50IC8gMTAwLCBzbyAz MDAlID0gMy4wLgotICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIGZsb2F0IHpvb21MZXZlbFRvWm9v bUZhY3RvcihmbG9hdCB6b29tTGV2ZWwpOwotICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIGZsb2F0 IHpvb21GYWN0b3JUb1pvb21MZXZlbChmbG9hdCBmYWN0b3IpOworICAgIFdFQktJVF9FWFBPUlQg c3RhdGljIGRvdWJsZSB6b29tTGV2ZWxUb1pvb21GYWN0b3IoZG91YmxlIHpvb21MZXZlbCk7Cisg ICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgZG91YmxlIHpvb21GYWN0b3JUb1pvb21MZXZlbChkb3Vi bGUgZmFjdG9yKTsKIAogICAgIC8vIFNjYWxlcyBhIHBhZ2UgYnkgYSBmYWN0b3Igb2Ygc2NhbGVG YWN0b3IgYW5kIHRoZW4gc2V0cyBhIHNjcm9sbCBwb3NpdGlvbiB0byAoeCwgeSkuCiAgICAgLy8g c2NhbGVQYWdlKCkgbWFnbmlmaWVzIGFuZCBzaHJpbmtzIGEgcGFnZSB3aXRob3V0IGFmZmVjdGlu ZyBsYXlvdXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5k ZXggNDNkYjMzMTY4ZGQ4MDYyNmFkMDVkNzYwMWNkNjkwODNmMWY3MGYwNC4uYTIxZjM0ZDNjZTY2 ZmFkZDI3OGQyZmEwNWNlODAwNDE3NzI4YzkxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtMTc4MSwxMiArMTc4MSwxMiBAQCB2b2lkIFdlYlZpZXdJ bXBsOjpzY3JvbGxGb2N1c2VkTm9kZUludG9WaWV3KCkKICAgICB9CiB9CiAKLWZsb2F0IFdlYlZp ZXdJbXBsOjp6b29tTGV2ZWwoKSBjb25zdAorZG91YmxlIFdlYlZpZXdJbXBsOjp6b29tTGV2ZWwo KQogewogICAgIHJldHVybiBtX3pvb21MZXZlbDsKIH0KIAotZmxvYXQgV2ViVmlld0ltcGw6OnNl dFpvb21MZXZlbChib29sIHRleHRPbmx5LCBmbG9hdCB6b29tTGV2ZWwpCitkb3VibGUgV2ViVmll d0ltcGw6OnNldFpvb21MZXZlbChib29sIHRleHRPbmx5LCBkb3VibGUgem9vbUxldmVsKQogewog ICAgIGlmICh6b29tTGV2ZWwgPCBtX21pbmltdW1ab29tTGV2ZWwpCiAgICAgICAgIG1fem9vbUxl dmVsID0gbV9taW5pbXVtWm9vbUxldmVsOwpAQCAtMTgwMCw3ICsxODAwLDcgQEAgZmxvYXQgV2Vi Vmlld0ltcGw6OnNldFpvb21MZXZlbChib29sIHRleHRPbmx5LCBmbG9hdCB6b29tTGV2ZWwpCiAg ICAgaWYgKHBsdWdpbkNvbnRhaW5lcikKICAgICAgICAgcGx1Z2luQ29udGFpbmVyLT5wbHVnaW4o KS0+c2V0Wm9vbUxldmVsKG1fem9vbUxldmVsLCB0ZXh0T25seSk7CiAgICAgZWxzZSB7Ci0gICAg ICAgIGZsb2F0IHpvb21GYWN0b3IgPSB6b29tTGV2ZWxUb1pvb21GYWN0b3IobV96b29tTGV2ZWwp OworICAgICAgICBmbG9hdCB6b29tRmFjdG9yID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHpvb21MZXZl bFRvWm9vbUZhY3RvcihtX3pvb21MZXZlbCkpOwogICAgICAgICBpZiAodGV4dE9ubHkpCiAgICAg ICAgICAgICBmcmFtZS0+c2V0UGFnZUFuZFRleHRab29tRmFjdG9ycygxLCB6b29tRmFjdG9yKTsK ICAgICAgICAgZWxzZQpAQCAtMTgwOSwxNSArMTgwOSwxNSBAQCBmbG9hdCBXZWJWaWV3SW1wbDo6 c2V0Wm9vbUxldmVsKGJvb2wgdGV4dE9ubHksIGZsb2F0IHpvb21MZXZlbCkKICAgICByZXR1cm4g bV96b29tTGV2ZWw7CiB9CiAKLXZvaWQgV2ViVmlld0ltcGw6Onpvb21MaW1pdHNDaGFuZ2VkKGZs b2F0IG1pbmltdW1ab29tTGV2ZWwsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmbG9hdCBtYXhpbXVtWm9vbUxldmVsKQordm9pZCBXZWJWaWV3SW1wbDo6em9vbUxpbWl0c0No YW5nZWQoZG91YmxlIG1pbmltdW1ab29tTGV2ZWwsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBkb3VibGUgbWF4aW11bVpvb21MZXZlbCkKIHsKICAgICBtX21pbmltdW1ab29t TGV2ZWwgPSBtaW5pbXVtWm9vbUxldmVsOwogICAgIG1fbWF4aW11bVpvb21MZXZlbCA9IG1heGlt dW1ab29tTGV2ZWw7CiAgICAgbV9jbGllbnQtPnpvb21MaW1pdHNDaGFuZ2VkKG1fbWluaW11bVpv b21MZXZlbCwgbV9tYXhpbXVtWm9vbUxldmVsKTsKIH0KIAotdm9pZCBXZWJWaWV3SW1wbDo6ZnVs bEZyYW1lUGx1Z2luWm9vbUxldmVsQ2hhbmdlZChmbG9hdCB6b29tTGV2ZWwpCit2b2lkIFdlYlZp ZXdJbXBsOjpmdWxsRnJhbWVQbHVnaW5ab29tTGV2ZWxDaGFuZ2VkKGRvdWJsZSB6b29tTGV2ZWwp CiB7CiAgICAgaWYgKHpvb21MZXZlbCA9PSBtX3pvb21MZXZlbCkKICAgICAgICAgcmV0dXJuOwpA QCAtMTgyNiwxMiArMTgyNiwxMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpmdWxsRnJhbWVQbHVnaW5a b29tTGV2ZWxDaGFuZ2VkKGZsb2F0IHpvb21MZXZlbCkKICAgICBtX2NsaWVudC0+em9vbUxldmVs Q2hhbmdlZCgpOwogfQogCi1mbG9hdCBXZWJWaWV3Ojp6b29tTGV2ZWxUb1pvb21GYWN0b3IoZmxv YXQgem9vbUxldmVsKQorZG91YmxlIFdlYlZpZXc6Onpvb21MZXZlbFRvWm9vbUZhY3Rvcihkb3Vi bGUgem9vbUxldmVsKQogewogICAgIHJldHVybiBwb3codGV4dFNpemVNdWx0aXBsaWVyUmF0aW8s IHpvb21MZXZlbCk7CiB9CiAKLWZsb2F0IFdlYlZpZXc6Onpvb21GYWN0b3JUb1pvb21MZXZlbChm bG9hdCBmYWN0b3IpCitkb3VibGUgV2ViVmlldzo6em9vbUZhY3RvclRvWm9vbUxldmVsKGRvdWJs ZSBmYWN0b3IpCiB7CiAgICAgLy8gU2luY2UgZmFjdG9yID0gMS4yXmxldmVsLCBsZXZlbCA9IGxv ZyhmYWN0b3IpIC8gbG9nKDEuMikKICAgICByZXR1cm4gbG9nKGZhY3RvcikgLyBsb2codGV4dFNp emVNdWx0aXBsaWVyUmF0aW8pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmgKaW5kZXggOGY5ZDUzYmEwOGFiMGMwNWU0NTlmOTdmNTI1NTU5MmIzMTk3YzIxYy4uNGEyYTI5 ZWNiOTgyZjdiNjYxN2Q2NDU5NGVjODU3MjVjM2I1MDJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC0xNTEsMTAgKzE1MSwxMCBAQCBwdWJsaWM6CiAgICAg dmlydHVhbCB2b2lkIHNldEluaXRpYWxGb2N1cyhib29sIHJldmVyc2UpOwogICAgIHZpcnR1YWwg dm9pZCBjbGVhckZvY3VzZWROb2RlKCk7CiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbEZvY3VzZWRO b2RlSW50b1ZpZXcoKTsKLSAgICB2aXJ0dWFsIGZsb2F0IHpvb21MZXZlbCgpIGNvbnN0OwotICAg IHZpcnR1YWwgZmxvYXQgc2V0Wm9vbUxldmVsKGJvb2wgdGV4dE9ubHksIGZsb2F0IHpvb21MZXZl bCk7Ci0gICAgdmlydHVhbCB2b2lkIHpvb21MaW1pdHNDaGFuZ2VkKGZsb2F0IG1pbmltdW1ab29t TGV2ZWwsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsb2F0IG1heGltdW1a b29tTGV2ZWwpOworICAgIHZpcnR1YWwgZG91YmxlIHpvb21MZXZlbCgpOworICAgIHZpcnR1YWwg ZG91YmxlIHNldFpvb21MZXZlbChib29sIHRleHRPbmx5LCBkb3VibGUgem9vbUxldmVsKTsKKyAg ICB2aXJ0dWFsIHZvaWQgem9vbUxpbWl0c0NoYW5nZWQoZG91YmxlIG1pbmltdW1ab29tTGV2ZWws CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvdWJsZSBtYXhpbXVtWm9vbUxl dmVsKTsKICAgICB2aXJ0dWFsIHZvaWQgc2NhbGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9yLCBXZWJQ b2ludCBvcmlnaW4pOwogICAgIHZpcnR1YWwgdm9pZCBwZXJmb3JtTWVkaWFQbGF5ZXJBY3Rpb24o CiAgICAgICAgIGNvbnN0IFdlYk1lZGlhUGxheWVyQWN0aW9uJiBhY3Rpb24sCkBAIC0zOTQsNyAr Mzk0LDcgQEAgcHVibGljOgogICAgIC8vIHpvb20gbGV2ZWwgaGFzIGJlZW4gdXBkYXRlZC4gIFRo ZSBwbHVnaW4gc2hvdWxkIG9ubHkgY2FsbCB0aGlzIGZ1bmN0aW9uCiAgICAgLy8gaWYgdGhlIHpv b20gY2hhbmdlIHdhcyB0cmlnZ2VyZWQgYnkgdGhlIGJyb3dzZXIsIGl0J3Mgb25seSBuZWVkZWQg aW4gY2FzZQogICAgIC8vIGEgcGx1Z2luIGNhbiB1cGRhdGUgaXRzIG93biB6b29tLCBzYXkgYmVj YXVzZSBvZiBpdHMgb3duIFVJLgotICAgIHZvaWQgZnVsbEZyYW1lUGx1Z2luWm9vbUxldmVsQ2hh bmdlZChmbG9hdCB6b29tTGV2ZWwpOworICAgIHZvaWQgZnVsbEZyYW1lUGx1Z2luWm9vbUxldmVs Q2hhbmdlZChkb3VibGUgem9vbUxldmVsKTsKIAogI2lmIEVOQUJMRShHRVNUVVJFX1JFQ09HTkla RVIpCiAgICAgdm9pZCByZXNldEdlc3R1cmVSZWNvZ25pemVyKCk7CkBAIC00OTMsMTEgKzQ5Mywx MSBAQCBwcml2YXRlOgogCiAgICAgLy8gS2VlcHMgdHJhY2sgb2YgdGhlIGN1cnJlbnQgem9vbSBs ZXZlbC4gMCBtZWFucyBubyB6b29tLCBwb3NpdGl2ZSBudW1iZXJzCiAgICAgLy8gbWVhbiB6b29t IGluLCBuZWdhdGl2ZSBudW1iZXJzIG1lYW4gem9vbSBvdXQuCi0gICAgZmxvYXQgbV96b29tTGV2 ZWw7CisgICAgZG91YmxlIG1fem9vbUxldmVsOwogCi0gICAgZmxvYXQgbV9taW5pbXVtWm9vbUxl dmVsOworICAgIGRvdWJsZSBtX21pbmltdW1ab29tTGV2ZWw7CiAKLSAgICBmbG9hdCBtX21heGlt dW1ab29tTGV2ZWw7CisgICAgZG91YmxlIG1fbWF4aW11bVpvb21MZXZlbDsKIAogICAgIGJvb2wg bV9jb250ZXh0TWVudUFsbG93ZWQ7CiAK