66140 2011-08-12 09:20:34 -0700 Patch to fix GTK Windows build after r92308 2011-08-14 05:22:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned aroben jeffm webkit.review.bot oldest_to_newest 450457 0 kalevlember 2011-08-12 09:20:34 -0700 r92308 added #include <WebCore/WebCoreHeaderDetection.h> to config.h, but the file is not generated with the autotools build. To fix build breakage, disable the inclusion for GTK, similar to what's done for Qt and Chromium builds. 450459 1 103778 kalevlember 2011-08-12 09:23:31 -0700 Created attachment 103778 Fix GTK Windows build after r92308. 450504 2 103778 jeffm 2011-08-12 10:50:06 -0700 Comment on attachment 103778 Fix GTK Windows build after r92308. Thanks for fixing this. Looks fine to me, but I can't officially r+ the patch since I'm not a reviewer. 450824 3 kalevlember 2011-08-13 01:53:29 -0700 Adam, this is a follow-up to the patch in bug #65634 you reviewed. Jeff said the patch is fine, but he is not a reviewer; could you please review this? Thanks! 450931 4 103778 xan.lopez 2011-08-14 03:22:14 -0700 Comment on attachment 103778 Fix GTK Windows build after r92308. r=me 450937 5 103778 webkit.review.bot 2011-08-14 05:22:11 -0700 Comment on attachment 103778 Fix GTK Windows build after r92308. Clearing flags on attachment: 103778 Committed r93030: <http://trac.webkit.org/changeset/93030> 450938 6 webkit.review.bot 2011-08-14 05:22:15 -0700 All reviewed patches have been landed. Closing bug. 103778 2011-08-12 09:23:31 -0700 2011-08-14 05:22:11 -0700 Fix GTK Windows build after r92308. webkitgtk-1.5.2-WebCoreHeaderDetection.patch text/plain 1020 kalevlember ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwM2FkNDU4Li40NWE2ZTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDgtMTIgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXggR1RLIFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjkyMzA4LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYxNDAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvbmZpZy5oOiBEb24ndCB0cnkg dG8gaW5jbHVkZSBXZWJDb3JlSGVhZGVyRGV0ZWN0aW9uLmggZm9yIEdUSy4KKwogMjAxMS0wOC0x MSAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBwcm9wZXJseSB1cGRhdGUgY29uc29sZSBtZXNzYWdlIGNvdW50IGluIHNv dXJjZSBmcmFtZXMgYW5kIHJlc291cmNlcyBwYW5lbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2NvbmZpZy5oIGIvU291cmNlL1dlYkNvcmUvY29uZmlnLmgKaW5kZXggNjNlM2Q2YS4uOWJi ZmU3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY29uZmlnLmgKKysrIGIvU291cmNlL1dl YkNvcmUvY29uZmlnLmgKQEAgLTI5LDcgKzI5LDcgQEAKIAogI2luY2x1ZGUgPHd0Zi9QbGF0Zm9y bS5oPgogCi0jaWYgT1MoV0lORE9XUykgJiYgIU9TKFdJTkNFKSAmJiAhUExBVEZPUk0oUVQpICYm ICFQTEFURk9STShDSFJPTUlVTSkKKyNpZiBPUyhXSU5ET1dTKSAmJiAhT1MoV0lOQ0UpICYmICFQ TEFURk9STShRVCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKSAmJiAhUExBVEZPUk0oR1RLKQogI2lu Y2x1ZGUgPFdlYkNvcmUvV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oPgogI2VuZGlmCiAK