66121 2011-08-11 18:26:27 -0700 Rename GraphicsContextGL::paintToCanvas() to a more generic name 2024-09-04 09:45:03 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified REOPENED DoNotImportToRadar P2 Normal --- 1 jbauman webkit-unassigned annevk bfulgham cmarrin guanqun.lu jamesr kbr mdelaney7 sabouhallawa oldest_to_newest 450207 0 jbauman 2011-08-11 18:26:27 -0700 This is referenced in GraphicsContext3D::paintRenderingResultsToCanvas, which is a layering violation. It would be pretty easy to replace this with the canvas's ImageBuffer in these circumstances. 2057338 1 annevk 2024-09-03 11:49:44 -0700 I can no longer find that method. 2057612 2 sabouhallawa 2024-09-04 09:45:03 -0700 GraphicsContext3D was renamed to GraphicsContextGL in 218939@main. But GraphicsContextGL still has a static method called GraphicsContextGL::paintToCanvas(). This method does not do anything specific to the canvas or to the GraphicsContextGL itself. It just draws a NativeImage to a GraphicsContext. I think function should be removed from this class and should be renamed to a more generic name. Also this function has this code which I think is valid only for Cocoa platforms: GraphicsContextStateSaver stateSaver(context); context.scale(FloatSize(1, -1)); context.translate(0, -imageSize.height());