66107 2011-08-11 15:38:14 -0700 JSC verbose debugging output sometimes doesn't work as expected. 2014-04-24 16:45:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 450096 0 fpizlo 2011-08-11 15:38:14 -0700 There are a few holes in our verbose debugging output: CodeBlock::dump(): - Will crash when printing JSCell constants, if converting them to string requires calling into JS code. - Will crash on op_new_regexp because of an out-of-bounds. DFG verbose mode: - Reports only the bottom address of generated code, and not the top, making it somewhat harder to mentally map executing code to the debug dumps. 450098 1 103688 fpizlo 2011-08-11 15:40:12 -0700 Created attachment 103688 the patch 450115 2 103688 fpizlo 2011-08-11 15:58:49 -0700 Comment on attachment 103688 the patch tests pass. 452480 3 103688 barraclough 2011-08-17 12:56:22 -0700 Comment on attachment 103688 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=103688&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:549 > + printf("bad_regexp(%d)\n", re0); There is something a little odd about making our dumping robust against bad regexp numbers here, since I don't think we're robust against other forms of bad bytecode in dumping. Still, this is debug code, if this is helpful, sure! why not! 452537 4 103688 webkit.review.bot 2011-08-17 13:54:46 -0700 Comment on attachment 103688 the patch Clearing flags on attachment: 103688 Committed r93238: <http://trac.webkit.org/changeset/93238> 452538 5 webkit.review.bot 2011-08-17 13:54:50 -0700 All reviewed patches have been landed. Closing bug. 1003858 6 darin 2014-04-24 16:45:23 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 103688 2011-08-11 15:40:12 -0700 2011-08-17 13:54:46 -0700 the patch fixverbose_patch_1.diff text/plain 4122 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTI4ODQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTEtMDgtMTEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK U0MgdmVyYm9zZSBkZWJ1Z2dpbmcgb3V0cHV0IHNvbWV0aW1lcyBkb2Vzbid0IHdvcmsgYXMgZXhw ZWN0ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NjEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgSGFyZGVuZWQgdGhlIENvZGVCbG9jazo6ZHVtcCgpIGNvZGUgc28gdGhhdCBpdCBubyBs b25nZXIgY3Jhc2hlcy4gIEltcHJvdmVkCisgICAgICAgIHRoZSBERkcgdmVyYm9zZSBjb2RlIHNv IHRoYXQgaXQgcHJpbnRzIHNsaWdodGx5IG1vcmUgdXNlZnVsIGluZm9ybWF0aW9uLgorCisgICAg ICAgICogYXNzZW1ibGVyL0xpbmtCdWZmZXIuaDoKKyAgICAgICAgKEpTQzo6TGlua0J1ZmZlcjo6 ZGVidWdTaXplKToKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAo SlNDOjp2YWx1ZVRvU291cmNlU3RyaW5nKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpkdW1w KToKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suaDoKKyAgICAgICAgKEpTQzo6Q29kZUJs b2NrOjpudW1iZXJPZlJlZ0V4cHMpOgorICAgICAgICAqIGRmZy9ERkdKSVRDb21waWxlci5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6SklUQ29tcGlsZXI6OmxpbmspOgorCiAyMDExLTA4LTExICBK YW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgbnVsbHB0ciBj YW4ndCBiZSB1c2VkIGZvciBQYXNzUmVmUHRyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0xpbmtCdWZmZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL0xpbmtCdWZmZXIuaAkocmV2aXNpb24gOTI4ODMpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL0xpbmtCdWZmZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjA1 LDYgKzIwNSwxMSBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICByZXR1cm4gbV9jb2RlOwogICAg IH0KKyAgICAKKyAgICBzaXplX3QgZGVidWdTaXplKCkKKyAgICB7CisgICAgICAgIHJldHVybiBt X3NpemU7CisgICAgfQogI2VuZGlmCiAKIHByaXZhdGU6CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkocmV2aXNpb24gOTI4ODMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzYsNyArNzYsNyBAQCBzdGF0aWMgVVN0cmluZyB2YWx1ZVRvU291cmNlU3RyaW5nKEV4ZWNT CiAgICAgaWYgKHZhbC5pc1N0cmluZygpKQogICAgICAgICByZXR1cm4gbWFrZVVTdHJpbmcoIlwi IiwgZXNjYXBlUXVvdGVzKHZhbC50b1N0cmluZyhleGVjKSksICJcIiIpOwogCi0gICAgcmV0dXJu IHZhbC50b1N0cmluZyhleGVjKTsKKyAgICByZXR1cm4gdmFsLmRlc2NyaXB0aW9uKCk7CiB9CiAK IHN0YXRpYyBDU3RyaW5nIGNvbnN0YW50TmFtZShFeGVjU3RhdGUqIGV4ZWMsIGludCBrLCBKU1Zh bHVlIHZhbHVlKQpAQCAtNTQyLDcgKzU0MiwxMSBAQCB2b2lkIENvZGVCbG9jazo6ZHVtcChFeGVj U3RhdGUqIGV4ZWMsIGNvCiAgICAgICAgIGNhc2Ugb3BfbmV3X3JlZ2V4cDogewogICAgICAgICAg ICAgaW50IHIwID0gKCsraXQpLT51Lm9wZXJhbmQ7CiAgICAgICAgICAgICBpbnQgcmUwID0gKCsr aXQpLT51Lm9wZXJhbmQ7Ci0gICAgICAgICAgICBwcmludGYoIlslNGRdIG5ld19yZWdleHBcdCAl cywgJXNcbiIsIGxvY2F0aW9uLCByZWdpc3Rlck5hbWUoZXhlYywgcjApLmRhdGEoKSwgcmVnZXhw TmFtZShyZTAsIHJlZ2V4cChyZTApKS5kYXRhKCkpOworICAgICAgICAgICAgcHJpbnRmKCJbJTRk XSBuZXdfcmVnZXhwXHQgJXMsICIsIGxvY2F0aW9uLCByZWdpc3Rlck5hbWUoZXhlYywgcjApLmRh dGEoKSk7CisgICAgICAgICAgICBpZiAocjAgPj0wICYmIHIwIDwgKGludCludW1iZXJPZlJlZ0V4 cHMoKSkKKyAgICAgICAgICAgICAgICBwcmludGYoIiVzXG4iLCByZWdleHBOYW1lKHJlMCwgcmVn ZXhwKHJlMCkpLmRhdGEoKSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgcHJp bnRmKCJiYWRfcmVnZXhwKCVkKVxuIiwgcmUwKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICB9CiAgICAgICAgIGNhc2Ugb3BfbW92OiB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvQ29kZUJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lvbiA5Mjg4MykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtNDcxLDYgKzQ3 MSwxMiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIG1fcmFyZURhdGEtPm1fcmVnZXhw cy5hcHBlbmQoV3JpdGVCYXJyaWVyPFJlZ0V4cD4oKm1fZ2xvYmFsRGF0YSwgb3duZXJFeGVjdXRh YmxlKCksIHIpKTsKICAgICAgICAgICAgIHJldHVybiBzaXplOwogICAgICAgICB9CisgICAgICAg IHVuc2lnbmVkIG51bWJlck9mUmVnRXhwcygpIGNvbnN0CisgICAgICAgIHsKKyAgICAgICAgICAg IGlmICghbV9yYXJlRGF0YSkKKyAgICAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgICAg IHJldHVybiBtX3JhcmVEYXRhLT5tX3JlZ2V4cHMuc2l6ZSgpOworICAgICAgICB9CiAgICAgICAg IFJlZ0V4cCogcmVnZXhwKGludCBpbmRleCkgY29uc3QgeyBBU1NFUlQobV9yYXJlRGF0YSk7IHJl dHVybiBtX3JhcmVEYXRhLT5tX3JlZ2V4cHNbaW5kZXhdLmdldCgpOyB9CiAKICAgICAgICAgdW5z aWduZWQgYWRkQ29uc3RhbnRCdWZmZXIodW5zaWduZWQgbGVuZ3RoKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAJKHJldmlzaW9uIDkyODgzKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTg0Myw3ICs4NDMsNyBAQCB2b2lkIEpJVENvbXBpbGVyOjpsaW5rKExpbmtCdWZm ZXImIGxpbmtCCiB7CiAgICAgLy8gTGluayB0aGUgY29kZSwgcG9wdWxhdGUgZGF0YSBpbiBDb2Rl QmxvY2sgZGF0YSBzdHJ1Y3R1cmVzLgogI2lmIERGR19ERUJVR19WRVJCT1NFCi0gICAgZnByaW50 ZihzdGRlcnIsICJKSVQgY29kZSBzdGFydCBhdCAlcFxuIiwgbGlua0J1ZmZlci5kZWJ1Z0FkZHJl c3MoKSk7CisgICAgZnByaW50ZihzdGRlcnIsICJKSVQgY29kZSBzdGFydCBhdCBbJXAsICVwKVxu IiwgbGlua0J1ZmZlci5kZWJ1Z0FkZHJlc3MoKSwgc3RhdGljX2Nhc3Q8Y2hhcio+KGxpbmtCdWZm ZXIuZGVidWdBZGRyZXNzKCkpICsgbGlua0J1ZmZlci5kZWJ1Z1NpemUoKSk7CiAjZW5kaWYKIAog ICAgIC8vIExpbmsgYWxsIGNhbGxzIG91dCBmcm9tIHRoZSBKSVQgY29kZSB0byB0aGVpciByZXNw ZWN0aXZlIGZ1bmN0aW9ucy4K