6610 2006-01-17 03:15:50 -0800 change RefPtr so that it works when deref ends up deleting the RefPtr 2006-01-17 09:26:35 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 darin darin mjs oldest_to_newest 28679 0 darin 2006-01-17 03:15:50 -0800 Maciej ran into this with what he's working on. 28680 1 5735 darin 2006-01-17 03:16:22 -0800 Created attachment 5735 patch to always set the pointer before doing a deref() on the old value 28693 2 5735 andersca 2006-01-17 08:55:36 -0800 Comment on attachment 5735 patch to always set the pointer before doing a deref() on the old value r=me 5735 2006-01-17 03:16:22 -0800 2006-01-17 08:55:36 -0800 patch to always set the pointer before doing a deref() on the old value RefPtrPatch.txt text/plain 3197 darin SW5kZXg6IGt4bWxjb3JlL1Bhc3NSZWZQdHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBreG1sY29yZS9QYXNz UmVmUHRyLmgJKHJldmlzaW9uIDEyMTQ4KQorKysga3htbGNvcmUvUGFzc1JlZlB0ci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC03NCwxMiArNzQsMTMgQEAKICAgICAKICAgICB0ZW1wbGF0ZSA8dHlwZW5h bWUgVD4gdGVtcGxhdGUgPHR5cGVuYW1lIFU+IGlubGluZSBQYXNzUmVmUHRyPFQ+JiBQYXNzUmVm UHRyPFQ+OjpvcGVyYXRvcj0oY29uc3QgUmVmUHRyPFU+JiBvKSAKICAgICB7Ci0gICAgICAgIFQg Km9wdHIgPSBvLm1fcHRyOworICAgICAgICBUKiBvcHRyID0gby5tX3B0cjsKICAgICAgICAgaWYg KG9wdHIpCiAgICAgICAgICAgICBvcHRyLT5yZWYoKTsKLSAgICAgICAgaWYgKFQgKnB0ciA9IG1f cHRyKQorICAgICAgICBUKiBwdHIgPSBtX3B0cjsKKyAgICAgICAgbV9wdHIgPSBvcHRyOworICAg ICAgICBpZiAocHRyKQogICAgICAgICAgICAgcHRyLT5kZXJlZigpOwotICAgICAgICBtX3B0ciA9 IG9wdHI7CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAgICAgCkBAIC04NywyNyArODgs MjggQEAKICAgICB7CiAgICAgICAgIGlmIChvcHRyKQogICAgICAgICAgICAgb3B0ci0+cmVmKCk7 Ci0gICAgICAgIGlmIChUICpwdHIgPSBtX3B0cikKKyAgICAgICAgVCogcHRyID0gbV9wdHI7Cisg ICAgICAgIG1fcHRyID0gb3B0cjsKKyAgICAgICAgaWYgKHB0cikKICAgICAgICAgICAgIHB0ci0+ ZGVyZWYoKTsKLSAgICAgICAgbV9wdHIgPSBvcHRyOwogICAgICAgICByZXR1cm4gKnRoaXM7CiAg ICAgfQogCiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IGlubGluZSBQYXNzUmVmUHRyPFQ+JiBQ YXNzUmVmUHRyPFQ+OjpvcGVyYXRvcj0oY29uc3QgUGFzc1JlZlB0cjxUPiYgcmVmKQogICAgIHsK LSAgICAgICAgVCAqb3B0ciA9IHJlZi5yZWxlYXNlKCk7Ci0gICAgICAgIGlmIChUICpwdHIgPSBt X3B0cikKKyAgICAgICAgVCogcHRyID0gbV9wdHI7CisgICAgICAgIG1fcHRyID0gcmVmLnJlbGVh c2UoKTsKKyAgICAgICAgaWYgKHB0cikKICAgICAgICAgICAgIHB0ci0+ZGVyZWYoKTsKLSAgICAg ICAgbV9wdHIgPSBvcHRyOwogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogICAgIAogICAg IHRlbXBsYXRlIDx0eXBlbmFtZSBUPiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVT4gaW5saW5lIFBhc3NS ZWZQdHI8VD4mIFBhc3NSZWZQdHI8VD46Om9wZXJhdG9yPShjb25zdCBQYXNzUmVmUHRyPFU+JiBy ZWYpCiAgICAgewotICAgICAgICBUICpvcHRyID0gcmVmLnJlbGVhc2UoKTsKLSAgICAgICAgaWYg KFQgKnB0ciA9IG1fcHRyKQorICAgICAgICBUKiBwdHIgPSBtX3B0cjsKKyAgICAgICAgbV9wdHIg PSByZWYucmVsZWFzZSgpOworICAgICAgICBpZiAocHRyKQogICAgICAgICAgICAgcHRyLT5kZXJl ZigpOwotICAgICAgICBtX3B0ciA9IG9wdHI7CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9 CiAgICAgCkluZGV4OiBreG1sY29yZS9SZWZQdHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBreG1sY29yZS9S ZWZQdHIuaAkocmV2aXNpb24gMTIxNDgpCisrKyBreG1sY29yZS9SZWZQdHIuaAkod29ya2luZyBj b3B5KQpAQCAtNzQsMTIgKzc0LDEzIEBACiAKICAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gUmVm UHRyPFQ+JiBSZWZQdHI8VD46Om9wZXJhdG9yPShjb25zdCBSZWZQdHI8VD4mIG8pCiAgICAgewot ICAgICAgICBUICpvcHRyID0gby5tX3B0cjsKKyAgICAgICAgVCogb3B0ciA9IG8ubV9wdHI7CiAg ICAgICAgIGlmIChvcHRyKQogICAgICAgICAgICAgb3B0ci0+cmVmKCk7Ci0gICAgICAgIGlmICht X3B0cikKLSAgICAgICAgICAgIG1fcHRyLT5kZXJlZigpOworICAgICAgICBUKiBwdHIgPSBtX3B0 cjsKICAgICAgICAgbV9wdHIgPSBvcHRyOworICAgICAgICBpZiAocHRyKQorICAgICAgICAgICAg cHRyLT5kZXJlZigpOwogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogICAgIApAQCAtODgs OSArODksMTAgQEAKICAgICAgICAgVCAqb3B0ciA9IG8ubV9wdHI7CiAgICAgICAgIGlmIChvcHRy KQogICAgICAgICAgICAgb3B0ci0+cmVmKCk7Ci0gICAgICAgIGlmIChtX3B0cikKLSAgICAgICAg ICAgIG1fcHRyLT5kZXJlZigpOworICAgICAgICBUKiBwdHIgPSBtX3B0cjsKICAgICAgICAgbV9w dHIgPSBvcHRyOworICAgICAgICBpZiAocHRyKQorICAgICAgICAgICAgcHRyLT5kZXJlZigpOwog ICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogICAgIApAQCAtOTgsMjUgKzEwMCwyOCBAQAog ICAgIHsKICAgICAgICAgaWYgKG9wdHIpCiAgICAgICAgICAgICBvcHRyLT5yZWYoKTsKLSAgICAg ICAgaWYgKG1fcHRyKQotICAgICAgICAgICAgbV9wdHItPmRlcmVmKCk7CisgICAgICAgIFQqIHB0 ciA9IG1fcHRyOwogICAgICAgICBtX3B0ciA9IG9wdHI7CisgICAgICAgIGlmIChwdHIpCisgICAg ICAgICAgICBwdHItPmRlcmVmKCk7CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKICAg ICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gaW5saW5lIFJlZlB0cjxUPiYgUmVmUHRyPFQ+OjpvcGVy YXRvcj0oY29uc3QgUGFzc1JlZlB0cjxUPiYgbykKICAgICB7Ci0gICAgICAgIGlmIChtX3B0cikK LSAgICAgICAgICAgIG1fcHRyLT5kZXJlZigpOworICAgICAgICBUKiBwdHIgPSBtX3B0cjsKICAg ICAgICAgbV9wdHIgPSBvLnJlbGVhc2UoKTsKKyAgICAgICAgaWYgKHB0cikKKyAgICAgICAgICAg IHB0ci0+ZGVyZWYoKTsKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIAogICAgIHRlbXBs YXRlIDx0eXBlbmFtZSBUPiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVT4gaW5saW5lIFJlZlB0cjxUPiYg UmVmUHRyPFQ+OjpvcGVyYXRvcj0oY29uc3QgUGFzc1JlZlB0cjxVPiYgbykKICAgICB7Ci0gICAg ICAgIGlmIChtX3B0cikKLSAgICAgICAgICAgIG1fcHRyLT5kZXJlZigpOworICAgICAgICBUKiBw dHIgPSBtX3B0cjsKICAgICAgICAgbV9wdHIgPSBvLnJlbGVhc2UoKTsKKyAgICAgICAgaWYgKHB0 cikKKyAgICAgICAgICAgIHB0ci0+ZGVyZWYoKTsKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAg IH0KIAo=