66097 2011-08-11 14:16:39 -0700 REGRESSION: Qt JavaScript bridge signal connection fails 2011-08-12 08:53:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rectalogic webkit-unassigned erights jwalden+bwo webkit.review.bot oldest_to_newest 450031 0 rectalogic 2011-08-11 14:16:39 -0700 Connecting to a Qt signal from JavaScript now fails. This can be reproduced with an existing testcase: $ WebKitBuild/Debug/WebKit/qt/tests/qwebframe/tst_qwebframe connectAndDisconnect ********* Start testing of tst_QWebFrame ********* Config: Using QTest library 4.7.3, Qt 4.7.3 PASS : tst_QWebFrame::initTestCase() ASSERTION FAILED: isValidThisObject(thisValue, exec) ../../../Source/JavaScriptCore/runtime/CallData.cpp(38) : JSC::JSValue JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, const JSC::CallData&, JSC::JSValue, const JSC::ArgList&) QFATAL : tst_QWebFrame::connectAndDisconnect() Received signal 11 FAIL! : tst_QWebFrame::connectAndDisconnect() Received a fatal error. Loc: [Unknown file(0)] Totals: 1 passed, 1 failed, 0 skipped ********* Finished testing of tst_QWebFrame ********* Aborted 450145 1 rectalogic 2011-08-11 16:35:27 -0700 Looks like the problem was introduced with r91095 from bug 64250 450187 2 rectalogic 2011-08-11 17:32:30 -0700 A workaround is to pass an anonymous object as the first arg to connect, e.g.: context.someSignal.connect({}, function() { }); Because otherwise JSC::Bindings::QtRuntimeConnectionMethod::call() uses the window object (exec->lexicalGlobalObject()) and that seems to trigger the assert. See http://trac.webkit.org/browser/trunk/Source/WebCore/bridge/qt/qt_runtime.cpp#L1587 450216 3 103719 rectalogic 2011-08-11 18:36:36 -0700 Created attachment 103719 pass toThisObject() to JS signal handler This also re-enables tst_QWebFrame::connectAndDisconnect() tests that were disabled with bug 65170 450239 4 103719 barraclough 2011-08-11 19:29:33 -0700 Comment on attachment 103719 pass toThisObject() to JS signal handler Ooops, apologies for the breakage! - thanks for the fix. 450251 5 103719 webkit.review.bot 2011-08-11 20:14:45 -0700 Comment on attachment 103719 pass toThisObject() to JS signal handler Clearing flags on attachment: 103719 Committed r92907: <http://trac.webkit.org/changeset/92907> 450252 6 webkit.review.bot 2011-08-11 20:14:49 -0700 All reviewed patches have been landed. Closing bug. 103719 2011-08-11 18:36:36 -0700 2011-08-11 20:14:45 -0700 pass toThisObject() to JS signal handler jsbridge.diff text/plain 5133 rectalogic ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZTdjNGI0Li45NjI3MzUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMTEgIEFuZHJldyBXYXNvbiAgPHJlY3RhbG9naWNAcmVjdGFsb2dpYy5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTjogUXQgSmF2YVNjcmlwdCBicmlkZ2Ugc2lnbmFsIGNvbm5l Y3Rpb24gZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY2MDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdHMgaW4gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZQorCisgICAgICAgIENhbGwgdG9U aGlzT2JqZWN0KCkgb24gZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpIHNvIHRoZSBjb3JyZWN0 CisgICAgICAgIG9iamVjdCBpcyBwYXNzZWQgdG8gdGhlIEpTIHNpZ25hbCBoYW5kbGVyLgorCisg ICAgICAgICogYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5n czo6UXRSdW50aW1lQ29ubmVjdGlvbk1ldGhvZDo6Y2FsbCk6CisKIDIwMTEtMDgtMDEgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KIAogICAgICAgICBFbmFibGUgZmFzdCBwYXRo IHNjcm9sbGluZyBmb3IgY29tcG9zaXRlZCBpZnJhbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQv cXRfcnVudGltZS5jcHAKaW5kZXggNDFiM2U4Zi4uMzMwZjRjYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jy aWRnZS9xdC9xdF9ydW50aW1lLmNwcApAQCAtMTU4NCw3ICsxNTg0LDcgQEAgRW5jb2RlZEpTVmFs dWUgUXRSdW50aW1lQ29ubmVjdGlvbk1ldGhvZDo6Y2FsbChFeGVjU3RhdGUqIGV4ZWMpCiAKICAg ICBpZiAoc2VuZGVyKSB7CiAKLSAgICAgICAgSlNPYmplY3QqIHRoaXNPYmplY3QgPSBleGVjLT5s ZXhpY2FsR2xvYmFsT2JqZWN0KCk7CisgICAgICAgIEpTT2JqZWN0KiB0aGlzT2JqZWN0ID0gZXhl Yy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT50b1RoaXNPYmplY3QoZXhlYyk7CiAgICAgICAgIEpT T2JqZWN0KiBmdW5jT2JqZWN0ID0gMDsKIAogICAgICAgICAvLyBRdFNjcmlwdCBjaGVja3Mgc2ln bmFsbmVzcyBmaXJzdCwgYXJndW1lbnRzIHNlY29uZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9xdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAxMzhlM2Y4 Li44ZjAxZmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA4LTExICBB bmRyZXcgV2Fzb24gIDxyZWN0YWxvZ2ljQHJlY3RhbG9naWMuY29tPgorCisgICAgICAgIFJFR1JF U1NJT046IFF0IEphdmFTY3JpcHQgYnJpZGdlIHNpZ25hbCBjb25uZWN0aW9uIGZhaWxzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA5NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVubWFyayB0ZXN0cyBh cyBleHBlY3RlZCBmYWlsdXJlcywgdGhleSBwYXNzIG5vdy4KKworICAgICAgICAqIHRlc3RzL3F3 ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKHRzdF9RV2ViRnJhbWU6OmNvbm5l Y3RBbmREaXNjb25uZWN0KToKKwogMjAxMS0wOC0wOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjky NjgzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3 ZWJmcmFtZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZy YW1lLmNwcAppbmRleCBjZGFmYzNjLi5iNDIzMzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcApAQCAtMTQ1NCw3ICsxNDU0LDYg QEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpjb25uZWN0QW5kRGlzY29ubmVjdCgpCiAgICAgUUNPTVBB UkUoZXZhbEpTKCJnb3RTaWduYWwiKSwgc1RydWUpOwogICAgIFFDT01QQVJFKGV2YWxKUygic2ln bmFsQXJncy5sZW5ndGggPT0gMCIpLCBzVHJ1ZSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJzaWdu YWxTZW5kZXIiKSxldmFsSlMoIm15T2JqZWN0IikpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTE3MCIsIENvbnRpbnVlKTsK ICAgICBRQ09NUEFSRShldmFsSlMoInNsb3RUaGlzT2JqZWN0ID09IHdpbmRvdyIpLCBzVHJ1ZSk7 CiAKICAgICBldmFsSlMoImdvdFNpZ25hbCA9IGZhbHNlIik7CkBAIC0xNTYwLDcgKzE1NTksNiBA QCB2b2lkIHRzdF9RV2ViRnJhbWU6OmNvbm5lY3RBbmREaXNjb25uZWN0KCkKICAgICAvLyBvbmUg YXJndW1lbnQKICAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0Lm15U2lnbmFsV2l0aEludEFy Zy5jb25uZWN0KG15T2JqZWN0Lm15U2xvdFdpdGhJbnRBcmcpIiksIHNVbmRlZmluZWQpOwogICAg IG1fbXlPYmplY3QtPnJlc2V0UXRGdW5jdGlvbkludm9rZWQoKTsKLSAgICBRRVhQRUNUX0ZBSUwo IiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNzAiLCBDb250 aW51ZSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVjdC5teVNpZ25hbFdpdGhJbnRBcmco MTIzKSIpLCBzVW5kZWZpbmVkKTsKICAgICBRQ09NUEFSRShtX215T2JqZWN0LT5xdEZ1bmN0aW9u SW52b2tlZCgpLCAyMSk7CiAgICAgUUNPTVBBUkUobV9teU9iamVjdC0+cXRGdW5jdGlvbkFjdHVh bHMoKS5zaXplKCksIDEpOwpAQCAtMTU2OSw3ICsxNTY3LDYgQEAgdm9pZCB0c3RfUVdlYkZyYW1l Ojpjb25uZWN0QW5kRGlzY29ubmVjdCgpCiAKICAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0 Lm15U2lnbmFsV2l0aEludEFyZy5jb25uZWN0KG15T2JqZWN0Lm15U2xvdFdpdGhEb3VibGVBcmcp IiksIHNVbmRlZmluZWQpOwogICAgIG1fbXlPYmplY3QtPnJlc2V0UXRGdW5jdGlvbkludm9rZWQo KTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjUxNzAiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVj dC5teVNpZ25hbFdpdGhJbnRBcmcoMTIzKSIpLCBzVW5kZWZpbmVkKTsKICAgICBRQ09NUEFSRSht X215T2JqZWN0LT5xdEZ1bmN0aW9uSW52b2tlZCgpLCAyMik7CiAgICAgUUNPTVBBUkUobV9teU9i amVjdC0+cXRGdW5jdGlvbkFjdHVhbHMoKS5zaXplKCksIDEpOwpAQCAtMTU3OCw3ICsxNTc1LDYg QEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpjb25uZWN0QW5kRGlzY29ubmVjdCgpCiAKICAgICBRQ09N UEFSRShldmFsSlMoIm15T2JqZWN0Lm15U2lnbmFsV2l0aEludEFyZy5jb25uZWN0KG15T2JqZWN0 Lm15U2xvdFdpdGhTdHJpbmdBcmcpIiksIHNVbmRlZmluZWQpOwogICAgIG1fbXlPYmplY3QtPnJl c2V0UXRGdW5jdGlvbkludm9rZWQoKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNzAiLCBDb250aW51ZSk7CiAgICAgUUNP TVBBUkUoZXZhbEpTKCJteU9iamVjdC5teVNpZ25hbFdpdGhJbnRBcmcoMTIzKSIpLCBzVW5kZWZp bmVkKTsKICAgICBRQ09NUEFSRShtX215T2JqZWN0LT5xdEZ1bmN0aW9uSW52b2tlZCgpLCAyMyk7 CiAgICAgUUNPTVBBUkUobV9teU9iamVjdC0+cXRGdW5jdGlvbkFjdHVhbHMoKS5zaXplKCksIDEp OwpAQCAtMTU4OCw3ICsxNTg0LDYgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpjb25uZWN0QW5kRGlz Y29ubmVjdCgpCiAgICAgLy8gY29ubmVjdGluZyB0byBvdmVybG9hZGVkIHNsb3QKICAgICBRQ09N UEFSRShldmFsSlMoIm15T2JqZWN0Lm15U2lnbmFsV2l0aEludEFyZy5jb25uZWN0KG15T2JqZWN0 Lm15T3ZlcmxvYWRlZFNsb3QpIiksIHNVbmRlZmluZWQpOwogICAgIG1fbXlPYmplY3QtPnJlc2V0 UXRGdW5jdGlvbkludm9rZWQoKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNzAiLCBDb250aW51ZSk7CiAgICAgUUNPTVBB UkUoZXZhbEpTKCJteU9iamVjdC5teVNpZ25hbFdpdGhJbnRBcmcoMTIzKSIpLCBzVW5kZWZpbmVk KTsKICAgICBRQ09NUEFSRShtX215T2JqZWN0LT5xdEZ1bmN0aW9uSW52b2tlZCgpLCAyNik7IC8v IGRvdWJsZSBvdmVybG9hZAogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPnF0RnVuY3Rpb25BY3R1 YWxzKCkuc2l6ZSgpLCAxKTsKQEAgLTE1OTcsNyArMTU5Miw2IEBAIHZvaWQgdHN0X1FXZWJGcmFt ZTo6Y29ubmVjdEFuZERpc2Nvbm5lY3QoKQogCiAgICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVj dC5teVNpZ25hbFdpdGhJbnRBcmcuY29ubmVjdChteU9iamVjdFsnbXlPdmVybG9hZGVkU2xvdChp bnQpJ10pIiksIHNVbmRlZmluZWQpOwogICAgIG1fbXlPYmplY3QtPnJlc2V0UXRGdW5jdGlvbklu dm9rZWQoKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjUxNzAiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJt eU9iamVjdC5teVNpZ25hbFdpdGhJbnRBcmcoNDU2KSIpLCBzVW5kZWZpbmVkKTsKICAgICBRQ09N UEFSRShtX215T2JqZWN0LT5xdEZ1bmN0aW9uSW52b2tlZCgpLCAyOCk7IC8vIGludCBvdmVybG9h ZAogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPnF0RnVuY3Rpb25BY3R1YWxzKCkuc2l6ZSgpLCAx KTsK