<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66080</bug_id>
          
          <creation_ts>2011-08-11 11:20:45 -0700</creation_ts>
          <short_desc>Unmatrix algorithm implementation is wrong</short_desc>
          <delta_ts>2011-08-16 13:45:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Mihnea Ovidenie">mihnea</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cmarrin</cc>
    
    <cc>dino</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>449894</commentid>
    <comment_count>0</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-08-11 11:20:45 -0700</bug_when>
    <thetext>The implementation of unmatrix algorithm in TransformationMatrix.cpp, function decompose is wrong. The spec contains the corrected version of the algorithm:
http://dev.w3.org/csswg/css3-2d-transforms/Overview.html#unmatrix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449899</commentid>
    <comment_count>1</comment_count>
      <attachid>103649</attachid>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-08-11 11:28:18 -0700</bug_when>
    <thetext>Created attachment 103649
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449904</commentid>
    <comment_count>2</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-08-11 11:40:19 -0700</bug_when>
    <thetext>The implementation is wrong at the step where the matrix and the scale factors must be negated. The current implementation only negates scaleX while leaving scaleY and scaleZ untouched.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449920</commentid>
    <comment_count>3</comment_count>
      <attachid>103649</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-08-11 12:17:12 -0700</bug_when>
    <thetext>Comment on attachment 103649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103649&amp;action=review

&gt; LayoutTests/animations/animation-matrix-negative-scale.html:74
&gt; +                setTimeout(&quot;snapshot(0)&quot;, 500);
&gt; +                setTimeout(&quot;snapshot(1)&quot;, 1000);
&gt; +                setTimeout(&quot;snapshot(2)&quot;, 1500);
&gt; +                setTimeout(&quot;snapshot(3)&quot;, 1900);

A test that takes almost 2 seconds is not acceptable. Can&apos;t you test this change with WebKitCSSMatix somehow?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449934</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-11 12:31:31 -0700</bug_when>
    <thetext>Attachment 103649 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;LayoutTests/ChangeLog&apos;, u&apos;LayoutTests/anim...&quot; exit_code: 1

Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>450819</commentid>
    <comment_count>5</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-08-12 23:26:54 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 103649 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=103649&amp;action=review
&gt; 
&gt; &gt; LayoutTests/animations/animation-matrix-negative-scale.html:74
&gt; &gt; +                setTimeout(&quot;snapshot(0)&quot;, 500);
&gt; &gt; +                setTimeout(&quot;snapshot(1)&quot;, 1000);
&gt; &gt; +                setTimeout(&quot;snapshot(2)&quot;, 1500);
&gt; &gt; +                setTimeout(&quot;snapshot(3)&quot;, 1900);
&gt; 
&gt; A test that takes almost 2 seconds is not acceptable. Can&apos;t you test this change with WebKitCSSMatix somehow?

I will change the test, thx. for the review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>450924</commentid>
    <comment_count>6</comment_count>
      <attachid>103875</attachid>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-08-14 00:13:36 -0700</bug_when>
    <thetext>Created attachment 103875
Patch 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>450936</commentid>
    <comment_count>7</comment_count>
      <attachid>103875</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-08-14 05:16:06 -0700</bug_when>
    <thetext>Comment on attachment 103875
Patch 2

I like the new test. My only comment would be that the test file name could related to the fix - something like animation-matrix-unmatrix-scale</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451211</commentid>
    <comment_count>8</comment_count>
      <attachid>103875</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2011-08-15 12:25:02 -0700</bug_when>
    <thetext>Comment on attachment 103875
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=103875&amp;action=review

&gt; LayoutTests/animations/animation-matrix-negative-scale.html:54
&gt; +            function stopAnimation()
&gt; +            {
&gt; +                document.getElementById(&quot;box&quot;).style.webkitAnimationName = &quot;&quot;;
&gt; +            }

Why is this necessary? snapshot() does notifyDone().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451229</commentid>
    <comment_count>9</comment_count>
      <attachid>103945</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-08-15 12:41:36 -0700</bug_when>
    <thetext>Created attachment 103945
Updated test case

There are a couple of issues with the test case. I&apos;ve uploaded a new test.

- no need for quotes around the keyframe
- I needed to add a to rule for the animation to fail on TOT as it stands
- no need for stopAnimation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451525</commentid>
    <comment_count>10</comment_count>
      <attachid>104015</attachid>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-08-16 01:26:54 -0700</bug_when>
    <thetext>Created attachment 104015
Patch 3

Reworked patch, sorry for the delay, i was in vacation. I also renamed the test to animation-matrix-negative-scale-unmatrix.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451545</commentid>
    <comment_count>11</comment_count>
      <attachid>104015</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-16 04:17:58 -0700</bug_when>
    <thetext>Comment on attachment 104015
Patch 3

Rejecting attachment 104015 from review queue.

dino@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451552</commentid>
    <comment_count>12</comment_count>
      <attachid>104015</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2011-08-16 04:36:47 -0700</bug_when>
    <thetext>Comment on attachment 104015
Patch 3

I wasn&apos;t listed in the reviewers section. I&apos;ve updated that but the queue might not pick it up for a while. I&apos;ll check again tomorrow if this doesn&apos;t stick.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451553</commentid>
    <comment_count>13</comment_count>
      <attachid>104015</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-16 04:37:00 -0700</bug_when>
    <thetext>Comment on attachment 104015
Patch 3

Rejecting attachment 104015 from review queue.

dino@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451837</commentid>
    <comment_count>14</comment_count>
      <attachid>104015</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-16 13:45:05 -0700</bug_when>
    <thetext>Comment on attachment 104015
Patch 3

Clearing flags on attachment: 104015

Committed r93150: &lt;http://trac.webkit.org/changeset/93150&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>451838</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-16 13:45:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103649</attachid>
            <date>2011-08-11 11:28:18 -0700</date>
            <delta_ts>2011-08-14 00:13:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>66080.patch</filename>
            <type>text/plain</type>
            <size>5968</size>
            <attacher name="Mihnea Ovidenie">mihnea</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA2ZGEwNWI2Li4wZWE4YzQ0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgt
MTEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgVW5tYXRy
aXggYWxnb3JpdGhtIGltcGxlbWVudGF0aW9uIGlzIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA4MAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4
LW5lZ2F0aXZlLXNjYWxlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYW5pbWF0aW9u
cy9hbmltYXRpb24tbWF0cml4LW5lZ2F0aXZlLXNjYWxlLmh0bWw6IEFkZGVkLgorCiAyMDExLTA4
LTExICBRaSBaaGFuZyAgPHFpLjIuemhhbmdAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gZmFz
dC9kb20vSFRNTERvY3VtZW50L2hhc0ZvY3VzLmh0bWwgZmFpbGVkCmRpZmYgLS1naXQgYS9MYXlv
dXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1tYXRyaXgtbmVnYXRpdmUtc2NhbGUtZXhwZWN0
ZWQudHh0IGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4LW5lZ2F0aXZl
LXNjYWxlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43
ZWYyMmU5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRp
b24tbWF0cml4LW5lZ2F0aXZlLXNjYWxlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNT
CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1tYXRyaXgtbmVn
YXRpdmUtc2NhbGUuaHRtbCBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLW1hdHJp
eC1uZWdhdGl2ZS1zY2FsZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu
LjEyY2E4YTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1h
dGlvbi1tYXRyaXgtbmVnYXRpdmUtc2NhbGUuaHRtbApAQCAtMCwwICsxLDg0IEBACis8IWRvY3R5
cGUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8IS0tCisgICAgICAgIFRoaXMg
dGVzdCBwZXJmb3JtcyBhbiBhbmltYXRpb24gb2YgdGhlIG1hdHJpeCBvcGVyYXRvci4gVGhlIG1h
dHJpeCBpcyBkZWZpbmVkIHNvIHRoYXQgdGhlCisgICAgICAgIGRlY29tcG9zaXRpb24gKHVubWF0
cml4KSBhbGdvcml0aG0gaXMgdGVzdGVkIG9uIHRoZSBwYXRoIHdoZXJlIHRoZSBtYXRyaXggaXMg
bmVnYXRlZCBhbmQgdGhlCisgICAgICAgIHRoZSBzY2FsaW5nIGZhY3RvcnMgYXJlIGFsc28gbmVn
YXRlZC4KKyAgICAgICAgVGhlIGFuaW1hdGlvbiB0YWtlcyBwbGFjZSBmb3IgMiBzZWNvbmRzLiBB
dCBzcGVjaWZpYyBpbnRlcnZhbHMsIGEgc25hcHNob3QgaXMgdGFrZW4gYW5kIHRoZSB2YWx1ZXMK
KyAgICAgICAgZm9yIHNjYWxlWCBhbmQgc2NhbGVZIHNob3VsZCBiZSBpbiB0aGUgZXhwZWN0ZWQg
cmFuZ2UuCisgICAgICAgIC0tPgorICAgICAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlh
PSJzY3JlZW4iPgorICAgICAgICAgICAgI2JveCB7CisgICAgICAgICAgICAgICAgd2lkdGg6IDEw
MHB4OworICAgICAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICAgICAgYmFj
a2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAgICAgICAgICAgICAgICAtd2Via2l0LWFuaW1hdGlvbi1k
dXJhdGlvbjogMnM7CisgICAgICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb24tdGltaW5nLWZ1
bmN0aW9uOiBsaW5lYXI7CisgICAgICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb24tbmFtZTog
ImFuaW0iOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBALXdlYmtpdC1rZXlmcmFtZXMg
ImFuaW0iIHsKKyAgICAgICAgICAgICAgICBmcm9tIHsgLXdlYmtpdC10cmFuc2Zvcm06IG1hdHJp
eCgxLCAwLCAwLCAtMSwgMCwgMCk7IH0KKyAgICAgICAgICAgICAgICB0byAgIHsgLXdlYmtpdC10
cmFuc2Zvcm06IG1hdHJpeCgyLCAwLCAwLCAtMiwgMCwgMCk7IH0KKyAgICAgICAgICAgIH0KKyAg
ICAgICAgPC9zdHlsZT4KKyAgICAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNo
YXJzZXQ9InV0Zi04Ij4KKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs
ZXIpIHsKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7
CisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwor
ICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBpc0VxdWFsKGFjdHVhbCwgZGVz
aXJlZCwgdG9sZXJhbmNlKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHZhciBkaWZm
ID0gTWF0aC5hYnMoYWN0dWFsIC0gZGVzaXJlZCk7CisgICAgICAgICAgICAgICAgcmV0dXJuIGRp
ZmYgPD0gdG9sZXJhbmNlOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICByZXN1bHQgPSAi
IjsKKworICAgICAgICAgICAgY29uc3QgZXhwZWN0ZWQgPSAgWyBbIDEuMjUsIC0xLjI1IF0sCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsgMS41LCAgLTEuNSAgXSwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgWyAxLjc1LCAtMS43NSBdLAorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBbIDEuOTUsIC0xLjk1IF0KKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIF07CisKKyAgICAgICAgICAgIGNvbnN0IHRvbGVyYW5jZSA9IFsgMC4xLCAwLjEgXTsK
KworICAgICAgICAgICAgY29uc3QgcHJvcCA9IFsgImEiLCAiZCJdOworCisgICAgICAgICAgICB2
YXIgbnVtU25hcHNob3RzID0gMDsKKworICAgICAgICAgICAgZnVuY3Rpb24gc25hcHNob3Qod2hp
Y2gpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgdmFyIGJveENvbXB1dGVkU3R5bGUg
PSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94Jykp
OworICAgICAgICAgICAgICAgIHZhciBtYXRyaXggPSBuZXcgV2ViS2l0Q1NTTWF0cml4KGJveENv
bXB1dGVkU3R5bGUud2Via2l0VHJhbnNmb3JtKTsKKyAgICAgICAgICAgICAgICBmb3IgKGkgPSAw
OyBpIDwgcHJvcC5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgICAgICAgICBpZiAoIWlzRXF1
YWwobWF0cml4W3Byb3BbaV1dLCBleHBlY3RlZFt3aGljaF1baV0sIHRvbGVyYW5jZVtpXSkpCisg
ICAgICAgICAgICAgICAgICAgICAgICByZXN1bHQgKz0gIkZBSUwoJyIgKyBwcm9wW2ldICsgIicg
d2FzOiIgKyBtYXRyaXhbcHJvcFtpXV0rICIsIGV4cGVjdGVkOiIgKyBleHBlY3RlZFt3aGljaF1b
aV0rIikiOworICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgIG51bVNuYXBzaG90
cysrOworICAgICAgICAgICAgICAgIGlmIChudW1TbmFwc2hvdHMgPT0gNCkgeworICAgICAgICAg
ICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0g
cmVzdWx0IHx8ICJQQVNTIjsKKyAgICAgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRU
ZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9s
bGVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisKKyAg
ICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAg
ICBzZXRUaW1lb3V0KCJzbmFwc2hvdCgwKSIsIDUwMCk7CisgICAgICAgICAgICAgICAgc2V0VGlt
ZW91dCgic25hcHNob3QoMSkiLCAxMDAwKTsKKyAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KCJz
bmFwc2hvdCgyKSIsIDE1MDApOworICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoInNuYXBzaG90
KDMpIiwgMTkwMCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGRvY3VtZW50LmFkZEV2
ZW50TGlzdGVuZXIoJ3dlYmtpdEFuaW1hdGlvblN0YXJ0Jywgc3RhcnQsIGZhbHNlKTsKKyAgICAg
ICAgPC9zY3JpcHQ+CisgICAgPC9oZWFkPgorICAgIDxib2R5PgorICAgICAgICA8ZGl2IGlkPSJi
b3giPjwvZGl2PgorICAgICAgICA8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorICAgIDwvYm9keT4K
KzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X
ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZTRmMWE4Li5jY2JlOGJmIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTggQEAKKzIwMTEtMDgtMTEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5j
b20+CisKKyAgICAgICAgVW5tYXRyaXggYWxnb3JpdGhtIGltcGxlbWVudGF0aW9uIGlzIHdyb25n
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA4MAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnQg
dmVyc2lvbiBvZiB0aGUgYWxnb3JpdGhtIG5lZ2F0ZXMgb25seSB0aGUgc2NhbGVYIHdoaWxlCisJ
aXQgc2hvdWxkIG5lZ2F0ZSBhbHNvIHNjYWxlWSBhbmQgc2NhbGVaIHdoZW4gYXBwcm9wcmlhdGUu
CisKKyAgICAgICAgVGVzdDogYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4LW5lZ2F0aXZlLXNj
YWxlLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNm
b3JtYXRpb25NYXRyaXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZGVjb21wb3NlKToKKwogMjAx
MS0wOC0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAg
ICAgW1F0XSBQYWdlU2VyaWFsaXplciBpcyBzcGVjaWZpYyB0byBNSFRNTCwgd2Ugc2hvdWxkIG5v
dCBjb21waWxlIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguY3BwCmluZGV4
IDJlYjY4NzAuLjYzNjYzNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXgu
Y3BwCkBAIC0zOTUsOCArMzk1LDEyIEBAIHN0YXRpYyBib29sIGRlY29tcG9zZShjb25zdCBUcmFu
c2Zvcm1hdGlvbk1hdHJpeDo6TWF0cml4NCYgbWF0LCBUcmFuc2Zvcm1hdGlvbk1hCiAgICAgLy8g
aXMgLTEsIHRoZW4gbmVnYXRlIHRoZSBtYXRyaXggYW5kIHRoZSBzY2FsaW5nIGZhY3RvcnMuCiAg
ICAgdjNDcm9zcyhyb3dbMV0sIHJvd1syXSwgcGR1bTMpOwogICAgIGlmICh2M0RvdChyb3dbMF0s
IHBkdW0zKSA8IDApIHsKKworICAgICAgICByZXN1bHQuc2NhbGVYICo9IC0xOworICAgICAgICBy
ZXN1bHQuc2NhbGVZICo9IC0xOworICAgICAgICByZXN1bHQuc2NhbGVaICo9IC0xOworCiAgICAg
ICAgIGZvciAoaSA9IDA7IGkgPCAzOyBpKyspIHsKLSAgICAgICAgICAgIHJlc3VsdC5zY2FsZVgg
Kj0gLTE7CiAgICAgICAgICAgICByb3dbaV1bMF0gKj0gLTE7CiAgICAgICAgICAgICByb3dbaV1b
MV0gKj0gLTE7CiAgICAgICAgICAgICByb3dbaV1bMl0gKj0gLTE7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103875</attachid>
            <date>2011-08-14 00:13:36 -0700</date>
            <delta_ts>2011-08-16 01:26:54 -0700</delta_ts>
            <desc>Patch 2</desc>
            <filename>66080-2.patch</filename>
            <type>text/plain</type>
            <size>5337</size>
            <attacher name="Mihnea Ovidenie">mihnea</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBiNjQ1ZDY5Li5iNjk1NWVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgt
MTQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgVW5tYXRy
aXggYWxnb3JpdGhtIGltcGxlbWVudGF0aW9uIGlzIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA4MAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4
LW5lZ2F0aXZlLXNjYWxlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYW5pbWF0aW9u
cy9hbmltYXRpb24tbWF0cml4LW5lZ2F0aXZlLXNjYWxlLmh0bWw6IEFkZGVkLgorCiAyMDExLTA4
LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFNraXAgdGhl
IHRlc3QgYWRkZWQgYnkgcjkyOTk3IG9uIFF0IHBvcnQgYmVjYXVzZSBpdCB1c2VzIGEgbWV0aG9k
IG9uIEV2ZW50U2VuZGVyIHRoYXQgaGFzbid0IGJlZW4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz
L2FuaW1hdGlvbnMvYW5pbWF0aW9uLW1hdHJpeC1uZWdhdGl2ZS1zY2FsZS1leHBlY3RlZC50eHQg
Yi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1tYXRyaXgtbmVnYXRpdmUtc2NhbGUt
ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjdlZjIyZTkK
LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1tYXRy
aXgtbmVnYXRpdmUtc2NhbGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1MKZGlmZiAt
LWdpdCBhL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLW1hdHJpeC1uZWdhdGl2ZS1z
Y2FsZS5odG1sIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4LW5lZ2F0
aXZlLXNjYWxlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTZhMWQz
NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLW1h
dHJpeC1uZWdhdGl2ZS1zY2FsZS5odG1sCkBAIC0wLDAgKzEsNzIgQEAKKzwhZG9jdHlwZSBodG1s
PgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDwhLS0KKyAgICAgICAgVGhpcyB0ZXN0IHBl
cmZvcm1zIGFuIGFuaW1hdGlvbiBvZiB0aGUgbWF0cml4IG9wZXJhdG9yLiBUaGUgbWF0cml4IGlz
IGRlZmluZWQgc28gdGhhdCB0aGUKKyAgICAgICAgZGVjb21wb3NpdGlvbiAodW5tYXRyaXgpIGFs
Z29yaXRobSBpcyB0ZXN0ZWQgb24gdGhlIHBhdGggd2hlcmUgdGhlIG1hdHJpeCBpcyBuZWdhdGVk
IGFuZCB0aGUKKyAgICAgICAgdGhlIHNjYWxpbmcgZmFjdG9ycyBhcmUgYWxzbyBuZWdhdGVkLgor
ICAgICAgICBUaGUgYW5pbWF0aW9uIGlzIHN0YXJ0ZWQgYW5kIGEgc25hcHNob3QgaXMgdGFrZW4g
YWZ0ZXIgc3RhcnQuIFRoZSAiZCIgY29tcG9uZW50IG9mIG1hdHJpeAorICAgICAgICBzaG91bGQg
YmUgbmVnYXRpdmUuCisgICAgICAgIC0tPgorICAgICAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3Mi
IG1lZGlhPSJzY3JlZW4iPgorICAgICAgICAgICAgI2JveCB7CisgICAgICAgICAgICAgICAgd2lk
dGg6IDEwMHB4OworICAgICAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICAg
ICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAgICAgICAgICAgICAgICAtd2Via2l0LWFuaW1h
dGlvbi1kdXJhdGlvbjogMXM7CisgICAgICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb24tdGlt
aW5nLWZ1bmN0aW9uOiBsaW5lYXI7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIEAtd2Vi
a2l0LWtleWZyYW1lcyAiYW5pbSIgeworICAgICAgICAgICAgICAgIGZyb20geyAtd2Via2l0LXRy
YW5zZm9ybTogbWF0cml4KDEsIDAsIDAsIC0xLCAwLCAwKTsgfQorICAgICAgICAgICAgfQorICAg
ICAgICA8L3N0eWxlPgorICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hh
cnNldD0idXRmLTgiPgorICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl
cikgeworICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK
KyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cisg
ICAgICAgICAgICB9CisKKyAgICAgICAgICAgIHJlc3VsdCA9ICJQQVNTIjsKKworICAgICAgICAg
ICAgZnVuY3Rpb24gc25hcHNob3QoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHZh
ciBib3hDb21wdXRlZFN0eWxlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0
RWxlbWVudEJ5SWQoJ2JveCcpKTsKKyAgICAgICAgICAgICAgICB2YXIgbWF0cml4ID0gbmV3IFdl
YktpdENTU01hdHJpeChib3hDb21wdXRlZFN0eWxlLndlYmtpdFRyYW5zZm9ybSk7CisKKyAgICAg
ICAgICAgICAgICAvLyAiZCIgY29tcG9uZW50IChzY2FsZVkpIHNob3VsZCBiZSBuZWdhdGl2ZS4K
KyAgICAgICAgICAgICAgICBpZiAobWF0cml4WyJkIl0gPiAwKQorICAgICAgICAgICAgICAgICAg
ICByZXN1bHQgPSAiRkFJTChzY2FsZVkgd2FzIHBvc2l0aXZlLCBleHBlY3RlZCB0byBiZSBuZWdh
dGl2ZSkiOworCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3Vs
dCcpLmlubmVySFRNTCA9IHJlc3VsdDsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91
dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl
ci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHN0
YXJ0QW5pbWF0aW9uKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5n
ZXRFbGVtZW50QnlJZCgiYm94Iikuc3R5bGUud2Via2l0QW5pbWF0aW9uTmFtZSA9ICJhbmltIjsK
KyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gc3RvcEFuaW1hdGlvbigpCisg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJv
eCIpLnN0eWxlLndlYmtpdEFuaW1hdGlvbk5hbWUgPSAiIjsKKyAgICAgICAgICAgIH0KKworICAg
ICAgICAgICAgZnVuY3Rpb24gc3RhcnQoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg
IHNuYXBzaG90KCk7CisgICAgICAgICAgICAgICAgc3RvcEFuaW1hdGlvbigpOworICAgICAgICAg
ICAgfQorCisgICAgICAgICAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCd3ZWJraXRBbmlt
YXRpb25TdGFydCcsIHN0YXJ0LCBmYWxzZSk7CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVh
ZD4KKyAgICA8Ym9keT4KKyAgICAgICAgPGRpdiBpZD0iYm94Ij48L2Rpdj4KKyAgICAgICAgPGRp
diBpZD0icmVzdWx0Ij48L2Rpdj4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIHN0YXJ0
QW5pbWF0aW9uKCk7CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRtbD4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwppbmRleCA3YWZkYmEyLi42ZTEzMmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK
KzIwMTEtMDgtMTQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAg
ICAgVW5tYXRyaXggYWxnb3JpdGhtIGltcGxlbWVudGF0aW9uIGlzIHdyb25nCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA4MAorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnQgdmVyc2lvbiBvZiB0
aGUgYWxnb3JpdGhtIG5lZ2F0ZXMgb25seSB0aGUgc2NhbGVYIHdoaWxlCisgICAgICAgIGl0IHNo
b3VsZCBuZWdhdGUgYWxzbyBzY2FsZVkgYW5kIHNjYWxlWiB3aGVuIGFwcHJvcHJpYXRlLgorCisg
ICAgICAgIFRlc3Q6IGFuaW1hdGlvbnMvYW5pbWF0aW9uLW1hdHJpeC1uZWdhdGl2ZS1zY2FsZS5o
dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0
aW9uTWF0cml4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRlY29tcG9zZSk6CisKIDIwMTEtMDgt
MTMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgZm9yd2Fy
ZCBkZWNsYXJhdGlvbiBvZiAtW1dlYlVuZGVmaW5lZCBkZWFsbG9jXSB0byBhcHBlYXNlIHRoZSBi
b3QgZ29kcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Ry
YW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAKaW5kZXggMmVi
Njg3MC4uNjM2NjM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp
Y3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAK
QEAgLTM5NSw4ICszOTUsMTIgQEAgc3RhdGljIGJvb2wgZGVjb21wb3NlKGNvbnN0IFRyYW5zZm9y
bWF0aW9uTWF0cml4OjpNYXRyaXg0JiBtYXQsIFRyYW5zZm9ybWF0aW9uTWEKICAgICAvLyBpcyAt
MSwgdGhlbiBuZWdhdGUgdGhlIG1hdHJpeCBhbmQgdGhlIHNjYWxpbmcgZmFjdG9ycy4KICAgICB2
M0Nyb3NzKHJvd1sxXSwgcm93WzJdLCBwZHVtMyk7CiAgICAgaWYgKHYzRG90KHJvd1swXSwgcGR1
bTMpIDwgMCkgeworCisgICAgICAgIHJlc3VsdC5zY2FsZVggKj0gLTE7CisgICAgICAgIHJlc3Vs
dC5zY2FsZVkgKj0gLTE7CisgICAgICAgIHJlc3VsdC5zY2FsZVogKj0gLTE7CisKICAgICAgICAg
Zm9yIChpID0gMDsgaSA8IDM7IGkrKykgewotICAgICAgICAgICAgcmVzdWx0LnNjYWxlWCAqPSAt
MTsKICAgICAgICAgICAgIHJvd1tpXVswXSAqPSAtMTsKICAgICAgICAgICAgIHJvd1tpXVsxXSAq
PSAtMTsKICAgICAgICAgICAgIHJvd1tpXVsyXSAqPSAtMTsK
</data>
<flag name="review"
          id="99589"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
    <flag name="commit-queue"
          id="99590"
          type_id="3"
          status="-"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>103945</attachid>
            <date>2011-08-15 12:41:36 -0700</date>
            <delta_ts>2011-08-15 12:41:36 -0700</delta_ts>
            <desc>Updated test case</desc>
            <filename>unmatrix.html</filename>
            <type>text/html</type>
            <size>2137</size>
            <attacher name="Dean Jackson">dino</attacher>
            
              <data encoding="base64">PCFkb2N0eXBlIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPCEtLQogICAgICAgIFRo
aXMgdGVzdCBwZXJmb3JtcyBhbiBhbmltYXRpb24gb2YgdGhlIG1hdHJpeCBvcGVyYXRvci4gVGhl
IG1hdHJpeCBpcyBkZWZpbmVkIHNvIHRoYXQgdGhlCiAgICAgICAgZGVjb21wb3NpdGlvbiAodW5t
YXRyaXgpIGFsZ29yaXRobSBpcyB0ZXN0ZWQgb24gdGhlIHBhdGggd2hlcmUgdGhlIG1hdHJpeCBp
cyBuZWdhdGVkIGFuZCB0aGUKICAgICAgICB0aGUgc2NhbGluZyBmYWN0b3JzIGFyZSBhbHNvIG5l
Z2F0ZWQuCiAgICAgICAgVGhlIGFuaW1hdGlvbiBpcyBzdGFydGVkIGFuZCBhIHNuYXBzaG90IGlz
IHRha2VuIGFmdGVyIHN0YXJ0LiBUaGUgImQiIGNvbXBvbmVudCBvZiBtYXRyaXgKICAgICAgICBz
aG91bGQgYmUgbmVnYXRpdmUuCiAgICAgICAgLS0+CiAgICAgICAgPHN0eWxlIHR5cGU9InRleHQv
Y3NzIiBtZWRpYT0ic2NyZWVuIj4KICAgICAgICAgICAgI2JveCB7CiAgICAgICAgICAgICAgICB3
aWR0aDogMTAwcHg7CiAgICAgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OwogICAgICAgICAgICAg
ICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKICAgICAgICAgICAgICAgIC13ZWJraXQtYW5pbWF0
aW9uLWR1cmF0aW9uOiAxczsKICAgICAgICAgICAgfQoKICAgICAgICAgICAgQC13ZWJraXQta2V5
ZnJhbWVzIGFuaW0gewogICAgICAgICAgICAgICAgZnJvbSB7IC13ZWJraXQtdHJhbnNmb3JtOiBt
YXRyaXgoMSwgMCwgMCwgLTEsIDAsIDApOyB9CiAgICAgICAgICAgICAgICB0byB7IC13ZWJraXQt
dHJhbnNmb3JtOiBtYXRyaXgoMSwgMCwgMCwgMSwgMCwgMCk7IH0KICAgICAgICAgICAgfQogICAg
ICAgIDwvc3R5bGU+CiAgICAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJz
ZXQ9InV0Zi04Ij4KICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg
ewogICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAg
ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogICAgICAg
ICAgICB9CgogICAgICAgICAgICByZXN1bHQgPSAiUEFTUyI7CgogICAgICAgICAgICBmdW5jdGlv
biBzbmFwc2hvdCgpCiAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgIHZhciBib3hDb21wdXRl
ZFN0eWxlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo
J2JveCcpKTsKICAgICAgICAgICAgICAgIHZhciBtYXRyaXggPSBuZXcgV2ViS2l0Q1NTTWF0cml4
KGJveENvbXB1dGVkU3R5bGUud2Via2l0VHJhbnNmb3JtKTsKCiAgICAgICAgICAgICAgICAvLyAi
ZCIgY29tcG9uZW50IChzY2FsZVkpIHNob3VsZCBiZSBuZWdhdGl2ZS4KICAgICAgICAgICAgICAg
IGlmIChtYXRyaXhbImQiXSA+IDApCiAgICAgICAgICAgICAgICAgICAgcmVzdWx0ID0gIkZBSUwo
c2NhbGVZIHdhcyBwb3NpdGl2ZSwgZXhwZWN0ZWQgdG8gYmUgbmVnYXRpdmUpIjsKCiAgICAgICAg
ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gcmVz
dWx0OwogICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAg
ICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAg
ICAgICAgIH0KCiAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0QW5pbWF0aW9uKCkKICAgICAgICAg
ICAgewogICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJveCIpLnN0eWxl
LndlYmtpdEFuaW1hdGlvbk5hbWUgPSAiYW5pbSI7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAg
IGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoJ3dlYmtpdEFuaW1hdGlvblN0YXJ0Jywgc25hcHNo
b3QsIGZhbHNlKTsKICAgICAgICA8L3NjcmlwdD4KICAgIDwvaGVhZD4KICAgIDxib2R5PgogICAg
ICAgIDxkaXYgaWQ9ImJveCI+PC9kaXY+CiAgICAgICAgPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4K
ICAgICAgICA8c2NyaXB0PgogICAgICAgICAgICBzdGFydEFuaW1hdGlvbigpOwogICAgICAgIDwv
c2NyaXB0PgogICAgPC9ib2R5Pgo8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>104015</attachid>
            <date>2011-08-16 01:26:54 -0700</date>
            <delta_ts>2011-08-16 13:45:05 -0700</delta_ts>
            <desc>Patch 3</desc>
            <filename>66080-3.patch</filename>
            <type>text/plain</type>
            <size>5202</size>
            <attacher name="Mihnea Ovidenie">mihnea</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAyNDNlZWNlLi44ZGMxN2U1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgt
MTYgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgVW5tYXRy
aXggYWxnb3JpdGhtIGltcGxlbWVudGF0aW9uIGlzIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA4MAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4
LW5lZ2F0aXZlLXNjYWxlLXVubWF0cml4LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog
YW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4LW5lZ2F0aXZlLXNjYWxlLXVubWF0cml4Lmh0bWw6
IEFkZGVkLgorCiAyMDExLTA4LTE1ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29t
PgogCiAgICAgICAgIFJFR1JFU1NJT04ocjcwNTk4KTogW0Nocm9taXVtXSBTdHlsZSBjaGFuZ2Vz
IGluIHRleHRJbnB1dCBldmVudCBjYW4gcHJldmVudCBmcm9tIHVwZGF0aW5nIDx0ZXh0YXJlYT4g
dmFsdWUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1tYXRy
aXgtbmVnYXRpdmUtc2NhbGUtdW5tYXRyaXgtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYW5p
bWF0aW9ucy9hbmltYXRpb24tbWF0cml4LW5lZ2F0aXZlLXNjYWxlLXVubWF0cml4LWV4cGVjdGVk
LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43ZWYyMmU5Ci0tLSAvZGV2
L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tbWF0cml4LW5lZ2F0
aXZlLXNjYWxlLXVubWF0cml4LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1tYXRyaXgtbmVnYXRpdmUt
c2NhbGUtdW5tYXRyaXguaHRtbCBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLW1h
dHJpeC1uZWdhdGl2ZS1zY2FsZS11bm1hdHJpeC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu
ZGV4IDAwMDAwMDAuLjQ5ODZiM2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmlt
YXRpb25zL2FuaW1hdGlvbi1tYXRyaXgtbmVnYXRpdmUtc2NhbGUtdW5tYXRyaXguaHRtbApAQCAt
MCwwICsxLDYxIEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAg
ICA8IS0tCisgICAgICAgIFRoaXMgdGVzdCBwZXJmb3JtcyBhbiBhbmltYXRpb24gb2YgdGhlIG1h
dHJpeCBvcGVyYXRvci4gVGhlIG1hdHJpeCBpcyBkZWZpbmVkIHNvIHRoYXQgdGhlCisgICAgICAg
IGRlY29tcG9zaXRpb24gKHVubWF0cml4KSBhbGdvcml0aG0gaXMgdGVzdGVkIG9uIHRoZSBwYXRo
IHdoZXJlIHRoZSBtYXRyaXggaXMgbmVnYXRlZCBhbmQgdGhlCisgICAgICAgIHRoZSBzY2FsaW5n
IGZhY3RvcnMgYXJlIGFsc28gbmVnYXRlZC4KKyAgICAgICAgVGhlIGFuaW1hdGlvbiBpcyBzdGFy
dGVkIGFuZCBhIHNuYXBzaG90IGlzIHRha2VuIGFmdGVyIHN0YXJ0LiBUaGUgImQiIGNvbXBvbmVu
dCBvZiBtYXRyaXgKKyAgICAgICAgc2hvdWxkIGJlIG5lZ2F0aXZlLgorICAgICAgICAtLT4KKyAg
ICAgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KKyAgICAgICAgICAg
ICNib3ggeworICAgICAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAgICAgICAgICBo
ZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7Cisg
ICAgICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb24tZHVyYXRpb246IDFzOworICAgICAgICAg
ICAgfQorCisgICAgICAgICAgICBALXdlYmtpdC1rZXlmcmFtZXMgYW5pbSB7CisgICAgICAgICAg
ICAgICAgZnJvbSB7IC13ZWJraXQtdHJhbnNmb3JtOiBtYXRyaXgoMSwgMCwgMCwgLTEsIDAsIDAp
OyB9CisgICAgICAgICAgICAgICAgdG8geyAtd2Via2l0LXRyYW5zZm9ybTogbWF0cml4KDEsIDAs
IDAsIDEsIDAsIDApOyB9CisgICAgICAgICAgICB9CisgICAgICAgIDwvc3R5bGU+CisgICAgICAg
IDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+CisgICAgICAg
ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICAgICAg
bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgICAgIGxheW91
dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgICAgIH0KKworICAgICAg
ICAgICAgcmVzdWx0ID0gIlBBU1MiOworCisgICAgICAgICAgICBmdW5jdGlvbiBzbmFwc2hvdCgp
CisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgdmFyIGJveENvbXB1dGVkU3R5bGUgPSB3
aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94JykpOwor
ICAgICAgICAgICAgICAgIHZhciBtYXRyaXggPSBuZXcgV2ViS2l0Q1NTTWF0cml4KGJveENvbXB1
dGVkU3R5bGUud2Via2l0VHJhbnNmb3JtKTsKKworICAgICAgICAgICAgICAgIC8vICJkIiBjb21w
b25lbnQgKHNjYWxlWSkgc2hvdWxkIGJlIG5lZ2F0aXZlLgorICAgICAgICAgICAgICAgIGlmICht
YXRyaXhbImQiXSA+IDApCisgICAgICAgICAgICAgICAgICAgIHJlc3VsdCA9ICJGQUlMKHNjYWxl
WSB3YXMgcG9zaXRpdmUsIGV4cGVjdGVkIHRvIGJlIG5lZ2F0aXZlKSI7CisKKyAgICAgICAgICAg
ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gcmVzdWx0
OworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg
ICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAg
ICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gc3RhcnRBbmltYXRpb24oKQorICAgICAg
ICAgICAgeworICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib3giKS5z
dHlsZS53ZWJraXRBbmltYXRpb25OYW1lID0gImFuaW0iOworICAgICAgICAgICAgfQorCisgICAg
ICAgICAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCd3ZWJraXRBbmltYXRpb25TdGFydCcs
IHNuYXBzaG90LCBmYWxzZSk7CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8
Ym9keT4KKyAgICAgICAgPGRpdiBpZD0iYm94Ij48L2Rpdj4KKyAgICAgICAgPGRpdiBpZD0icmVz
dWx0Ij48L2Rpdj4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIHN0YXJ0QW5pbWF0aW9u
KCk7CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl
eCBjM2VkMzk1Li5lMjkyNGUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgt
MTYgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgVW5tYXRy
aXggYWxnb3JpdGhtIGltcGxlbWVudGF0aW9uIGlzIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA4MAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnQgdmVyc2lvbiBvZiB0aGUgYWxnb3Jp
dGhtIG5lZ2F0ZXMgb25seSB0aGUgc2NhbGVYIHdoaWxlCisgICAgICAgIGl0IHNob3VsZCBuZWdh
dGUgYWxzbyBzY2FsZVkgYW5kIHNjYWxlWiB3aGVuIGFwcHJvcHJpYXRlLgorCisgICAgICAgIFRl
c3Q6IGFuaW1hdGlvbnMvYW5pbWF0aW9uLW1hdHJpeC1uZWdhdGl2ZS1zY2FsZS11bm1hdHJpeC5o
dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0
aW9uTWF0cml4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRlY29tcG9zZSk6CisKIDIwMTEtMDgt
MTUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUkVHUkVT
U0lPTihyNzA1OTgpOiBbQ2hyb21pdW1dIFN0eWxlIGNoYW5nZXMgaW4gdGV4dElucHV0IGV2ZW50
IGNhbiBwcmV2ZW50IGZyb20gdXBkYXRpbmcgPHRleHRhcmVhPiB2YWx1ZS4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRp
b25NYXRyaXguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jt
cy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAKaW5kZXggMmViNjg3MC4uNjM2NjM0MiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zv
cm1hdGlvbk1hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
dHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAKQEAgLTM5NSw4ICszOTUsMTIgQEAg
c3RhdGljIGJvb2wgZGVjb21wb3NlKGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4OjpNYXRyaXg0
JiBtYXQsIFRyYW5zZm9ybWF0aW9uTWEKICAgICAvLyBpcyAtMSwgdGhlbiBuZWdhdGUgdGhlIG1h
dHJpeCBhbmQgdGhlIHNjYWxpbmcgZmFjdG9ycy4KICAgICB2M0Nyb3NzKHJvd1sxXSwgcm93WzJd
LCBwZHVtMyk7CiAgICAgaWYgKHYzRG90KHJvd1swXSwgcGR1bTMpIDwgMCkgeworCisgICAgICAg
IHJlc3VsdC5zY2FsZVggKj0gLTE7CisgICAgICAgIHJlc3VsdC5zY2FsZVkgKj0gLTE7CisgICAg
ICAgIHJlc3VsdC5zY2FsZVogKj0gLTE7CisKICAgICAgICAgZm9yIChpID0gMDsgaSA8IDM7IGkr
KykgewotICAgICAgICAgICAgcmVzdWx0LnNjYWxlWCAqPSAtMTsKICAgICAgICAgICAgIHJvd1tp
XVswXSAqPSAtMTsKICAgICAgICAgICAgIHJvd1tpXVsxXSAqPSAtMTsKICAgICAgICAgICAgIHJv
d1tpXVsyXSAqPSAtMTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>