66067 2011-08-11 09:35:20 -0700 Expose pageScaleFactor() to Chromium's WebViewImpl 2011-08-12 15:56:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fsamuel fsamuel fishd fsamuel rjkroege webkit.review.bot oldest_to_newest 449825 0 fsamuel 2011-08-11 09:35:20 -0700 Expose pageScaleFactor() to Chromium's WebViewImpl 449826 1 103637 fsamuel 2011-08-11 09:35:56 -0700 Created attachment 103637 Patch 449911 2 103637 fishd 2011-08-11 11:51:31 -0700 Comment on attachment 103637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103637&action=review > Source/WebKit/chromium/public/WebView.h:206 > + virtual double pageScaleFactor() const = 0; it seems odd that this returns double when scalePage takes a float. one of these should change to match the other. zoom uses double. maybe page scaling should use double too? 449918 3 103653 fsamuel 2011-08-11 12:15:44 -0700 Created attachment 103653 Patch 450466 4 fsamuel 2011-08-12 09:31:52 -0700 (In reply to comment #3) > Created an attachment (id=103653) [details] > Patch Fixed as suggested by fishd 450729 5 103653 webkit.review.bot 2011-08-12 15:56:49 -0700 Comment on attachment 103653 Patch Clearing flags on attachment: 103653 Committed r93007: <http://trac.webkit.org/changeset/93007> 450732 6 webkit.review.bot 2011-08-12 15:56:53 -0700 All reviewed patches have been landed. Closing bug. 103637 2011-08-11 09:35:56 -0700 2011-08-11 12:15:39 -0700 Patch bug-66067-20110811123554.patch text/plain 2964 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4NTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDNkNDI1MDBmZjc3NDk0MGM2YmFhNjgwZjQzMTZjNDA5YTM5N2MyOS4uZDFkN2ZmYWJjMTYzMDUx NzJhZjczZWZkZDU5MjVhMTgwYmNhOThjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0xMSAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBFeHBvc2UgcGFnZVNjYWxlRmFjdG9yKCkgdG8gQ2hyb21pdW0ncyBX ZWJWaWV3SW1wbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjYwNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHB1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBhZ2VTY2FsZUZhY3Rvcik6CisgICAgICAgICog c3JjL1dlYlZpZXdJbXBsLmg6CisKIDIwMTEtMDgtMTAgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFt QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFVwZGF0ZSBXZWJTY3JvbGxiYXIg c28gdGhhdCBpdCB3b3JrcyB3aXRoIG92ZXJsYXkgc2Nyb2xsYmFycyBvbiBMaW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmggYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKaW5kZXggMjY1OTlhYzMwMTk5ZjhlNDVlYWY2 YjRiM2NhNWU5N2NkNmMwNzBiOC4uMzIwNjAxNGVmMWFkY2Q4NTgxMmU3YjBkYTg4ZTI1YzAwMWIx ZjY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaApAQCAtMjAzLDYg KzIwMyw4IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JUIHN0YXRpYyBkb3VibGUgem9vbUxl dmVsVG9ab29tRmFjdG9yKGRvdWJsZSB6b29tTGV2ZWwpOwogICAgIFdFQktJVF9FWFBPUlQgc3Rh dGljIGRvdWJsZSB6b29tRmFjdG9yVG9ab29tTGV2ZWwoZG91YmxlIGZhY3Rvcik7CiAKKyAgICB2 aXJ0dWFsIGRvdWJsZSBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdCA9IDA7CisKICAgICAvLyBTY2Fs ZXMgYSBwYWdlIGJ5IGEgZmFjdG9yIG9mIHNjYWxlRmFjdG9yIGFuZCB0aGVuIHNldHMgYSBzY3Jv bGwgcG9zaXRpb24gdG8gKHgsIHkpLgogICAgIC8vIHNjYWxlUGFnZSgpIG1hZ25pZmllcyBhbmQg c2hyaW5rcyBhIHBhZ2Ugd2l0aG91dCBhZmZlY3RpbmcgbGF5b3V0LgogICAgIC8vIE9uIHRoZSBv dGhlciBoYW5kLCB6b29taW5nIGFmZmVjdHMgbGF5b3V0IG9mIHRoZSBwYWdlLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDdkMmRmNDMxZTRiMzY2NDY0 MTk1OWM2YjRkZmU0MGNiMzQ3MjRjMjYuLmRmNDJlNjA4MmQ0Njc2Y2UxZWFlYTg2OTk5OWU3ZTM5 Yzk3ODJmYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAK QEAgLTE4NjYsNiArMTg2NiwxOCBAQCBkb3VibGUgV2ViVmlldzo6em9vbUZhY3RvclRvWm9vbUxl dmVsKGRvdWJsZSBmYWN0b3IpCiAgICAgcmV0dXJuIGxvZyhmYWN0b3IpIC8gbG9nKHRleHRTaXpl TXVsdGlwbGllclJhdGlvKTsKIH0KIAorZG91YmxlIFdlYlZpZXdJbXBsOjpwYWdlU2NhbGVGYWN0 b3IoKSBjb25zdAoreworICAgIGlmICghcGFnZSgpKQorICAgICAgICByZXR1cm4gMS4wOworCisg ICAgRnJhbWUqIGZyYW1lID0gcGFnZSgpLT5tYWluRnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQor ICAgICAgICByZXR1cm4gMS4wOworCisgICAgcmV0dXJuIGZyYW1lLT5wYWdlU2NhbGVGYWN0b3Io KTsKK30KKwogdm9pZCBXZWJWaWV3SW1wbDo6c2NhbGVQYWdlKGZsb2F0IHNjYWxlRmFjdG9yLCBX ZWJQb2ludCBvcmlnaW4pCiB7CiAgICAgaWYgKCFwYWdlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuaAppbmRleCA2ZWUyMjZiOTM2YTFmNjkwZDBkMjRjZGJhZGMxMWU5 ZmIzMWMxOGJlLi41OWM3ZThmNzRiZjY3YjFmZThiYjJjOWVmODZlYjA3ZmZlNDMwZDIyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTE1NSw2ICsxNTUsNyBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCBkb3VibGUgc2V0Wm9vbUxldmVsKGJvb2wgdGV4dE9ubHks IGRvdWJsZSB6b29tTGV2ZWwpOwogICAgIHZpcnR1YWwgdm9pZCB6b29tTGltaXRzQ2hhbmdlZChk b3VibGUgbWluaW11bVpvb21MZXZlbCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZG91YmxlIG1heGltdW1ab29tTGV2ZWwpOworICAgIHZpcnR1YWwgZG91YmxlIHBhZ2VTY2Fs ZUZhY3RvcigpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCBzY2FsZVBhZ2UoZmxvYXQgc2NhbGVG YWN0b3IsIFdlYlBvaW50IG9yaWdpbik7CiAgICAgdmlydHVhbCB2b2lkIHBlcmZvcm1NZWRpYVBs YXllckFjdGlvbigKICAgICAgICAgY29uc3QgV2ViTWVkaWFQbGF5ZXJBY3Rpb24mIGFjdGlvbiwK 103653 2011-08-11 12:15:44 -0700 2011-08-12 15:56:49 -0700 Patch bug-66067-20110811151542.patch text/plain 3085 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4NTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDNkNDI1MDBmZjc3NDk0MGM2YmFhNjgwZjQzMTZjNDA5YTM5N2MyOS4uZDFkN2ZmYWJjMTYzMDUx NzJhZjczZWZkZDU5MjVhMTgwYmNhOThjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0xMSAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBFeHBvc2UgcGFnZVNjYWxlRmFjdG9yKCkgdG8gQ2hyb21pdW0ncyBX ZWJWaWV3SW1wbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjYwNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHB1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBhZ2VTY2FsZUZhY3Rvcik6CisgICAgICAgICog c3JjL1dlYlZpZXdJbXBsLmg6CisKIDIwMTEtMDgtMTAgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFt QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFVwZGF0ZSBXZWJTY3JvbGxiYXIg c28gdGhhdCBpdCB3b3JrcyB3aXRoIG92ZXJsYXkgc2Nyb2xsYmFycyBvbiBMaW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmggYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKaW5kZXggMjY1OTlhYzMwMTk5ZjhlNDVlYWY2 YjRiM2NhNWU5N2NkNmMwNzBiOC4uNTJjOWE2ZGUxOTAzNDRiZTNkNTk5MzQzODA4ZjFjZjk1MDdl OTM5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaApAQCAtMjAzLDYg KzIwMywxMCBAQCBwdWJsaWM6CiAgICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgZG91YmxlIHpvb21M ZXZlbFRvWm9vbUZhY3Rvcihkb3VibGUgem9vbUxldmVsKTsKICAgICBXRUJLSVRfRVhQT1JUIHN0 YXRpYyBkb3VibGUgem9vbUZhY3RvclRvWm9vbUxldmVsKGRvdWJsZSBmYWN0b3IpOwogCisgICAg Ly8gR2V0cyB0aGUgc2NhbGUgZmFjdG9yIG9mIHRoZSBwYWdlLCB3aGVyZSAxLjAgaXMgdGhlIG5v cm1hbCBzaXplLCA+IDEuMAorICAgIC8vIGlzIHNjYWxlZCB1cCwgPCAxLjAgaXMgc2NhbGVkIGRv d24uCisgICAgdmlydHVhbCBmbG9hdCBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdCA9IDA7CisKICAg ICAvLyBTY2FsZXMgYSBwYWdlIGJ5IGEgZmFjdG9yIG9mIHNjYWxlRmFjdG9yIGFuZCB0aGVuIHNl dHMgYSBzY3JvbGwgcG9zaXRpb24gdG8gKHgsIHkpLgogICAgIC8vIHNjYWxlUGFnZSgpIG1hZ25p ZmllcyBhbmQgc2hyaW5rcyBhIHBhZ2Ugd2l0aG91dCBhZmZlY3RpbmcgbGF5b3V0LgogICAgIC8v IE9uIHRoZSBvdGhlciBoYW5kLCB6b29taW5nIGFmZmVjdHMgbGF5b3V0IG9mIHRoZSBwYWdlLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDdkMmRmNDMx ZTRiMzY2NDY0MTk1OWM2YjRkZmU0MGNiMzQ3MjRjMjYuLmRmNjI4MjNkNzYyNTc2M2NiMjcxYWZh NDM0NGVhMzhlZDA0NDA0YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKQEAgLTE4NjYsNiArMTg2NiwxOCBAQCBkb3VibGUgV2ViVmlldzo6em9vbUZhY3Rv clRvWm9vbUxldmVsKGRvdWJsZSBmYWN0b3IpCiAgICAgcmV0dXJuIGxvZyhmYWN0b3IpIC8gbG9n KHRleHRTaXplTXVsdGlwbGllclJhdGlvKTsKIH0KIAorZmxvYXQgV2ViVmlld0ltcGw6OnBhZ2VT Y2FsZUZhY3RvcigpIGNvbnN0Cit7CisgICAgaWYgKCFwYWdlKCkpCisgICAgICAgIHJldHVybiAx LjA7CisKKyAgICBGcmFtZSogZnJhbWUgPSBwYWdlKCktPm1haW5GcmFtZSgpOworICAgIGlmICgh ZnJhbWUpCisgICAgICAgIHJldHVybiAxLjA7CisKKyAgICByZXR1cm4gZnJhbWUtPnBhZ2VTY2Fs ZUZhY3RvcigpOworfQorCiB2b2lkIFdlYlZpZXdJbXBsOjpzY2FsZVBhZ2UoZmxvYXQgc2NhbGVG YWN0b3IsIFdlYlBvaW50IG9yaWdpbikKIHsKICAgICBpZiAoIXBhZ2UoKSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IDZlZTIyNmI5MzZhMWY2OTBkMGQyNGNk YmFkYzExZTlmYjMxYzE4YmUuLjg2Y2EyN2Q2ODQzMDllOWUxNzQ5NjNkYmEwMjRkMmRiMzBiOTIx YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtMTU1LDYg KzE1NSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGRvdWJsZSBzZXRab29tTGV2ZWwoYm9vbCB0 ZXh0T25seSwgZG91YmxlIHpvb21MZXZlbCk7CiAgICAgdmlydHVhbCB2b2lkIHpvb21MaW1pdHND aGFuZ2VkKGRvdWJsZSBtaW5pbXVtWm9vbUxldmVsLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBkb3VibGUgbWF4aW11bVpvb21MZXZlbCk7CisgICAgdmlydHVhbCBmbG9hdCBw YWdlU2NhbGVGYWN0b3IoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgc2NhbGVQYWdlKGZsb2F0 IHNjYWxlRmFjdG9yLCBXZWJQb2ludCBvcmlnaW4pOwogICAgIHZpcnR1YWwgdm9pZCBwZXJmb3Jt TWVkaWFQbGF5ZXJBY3Rpb24oCiAgICAgICAgIGNvbnN0IFdlYk1lZGlhUGxheWVyQWN0aW9uJiBh Y3Rpb24sCg==