66060 2011-08-11 07:53:42 -0700 Web Inspector: [refactoring] make tabbed pane a view 2011-08-11 09:36:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 449767 0 caseq 2011-08-11 07:53:42 -0700 This is a one of several steps of refactoring aimed as making handling of resize/activate/deactivate events uniform across different panels and views. 449770 1 103622 caseq 2011-08-11 07:55:31 -0700 Created attachment 103622 patch 449827 2 103622 caseq 2011-08-11 09:36:11 -0700 Comment on attachment 103622 patch Clearing flags on attachment: 103622 Committed r92855: <http://trac.webkit.org/changeset/92855> 449828 3 caseq 2011-08-11 09:36:18 -0700 All reviewed patches have been landed. Closing bug. 103622 2011-08-11 07:55:31 -0700 2011-08-11 09:36:11 -0700 patch tabbed-view.diff text/plain 5827 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzI3ZDE5Li5mMGZhMDg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDgtMTEgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBbcmVmYWN0b3JpbmddIG1ha2UgdGFiYmVkIHBhbmUgYSB2 aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjA2 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrSXRlbVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuTmV0d29ya0l0ZW1WaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrSXRlbVZp ZXcucHJvdG90eXBlLnNob3cpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtJdGVtVmll dy5wcm90b3R5cGUuX3NlbGVjdFRhYi5nZXQgaWYpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5l dHdvcmtJdGVtVmlldy5wcm90b3R5cGUuX3NlbGVjdFRhYik6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZFBh bmUpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmh0bWw6CisKIDIw MTEtMDgtMTEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIFF0LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrSXRlbVZpZXcuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtJdGVtVmlldy5qcwppbmRleCAxZmQ4 OTAxLi4zYzMyNTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL05ldHdvcmtJdGVtVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL05ldHdvcmtJdGVtVmlldy5qcwpAQCAtMzAsMzcgKzMwLDM2IEBACiAKIFdlYkluc3Bl Y3Rvci5OZXR3b3JrSXRlbVZpZXcgPSBmdW5jdGlvbihyZXNvdXJjZSkKIHsKLSAgICBXZWJJbnNw ZWN0b3IuVmlldy5jYWxsKHRoaXMpOworICAgIFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lLmNhbGwo dGhpcyk7CiAKICAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygibmV0d29yay1pdGVtLXZp ZXciKTsKLSAgICB0aGlzLl90YWJiZWRQYW5lID0gbmV3IFdlYkluc3BlY3Rvci5UYWJiZWRQYW5l KHRoaXMuZWxlbWVudCk7CiAKICAgICB2YXIgaGVhZGVyc1ZpZXcgPSBuZXcgV2ViSW5zcGVjdG9y LlJlc291cmNlSGVhZGVyc1ZpZXcocmVzb3VyY2UpOwotICAgIHRoaXMuX3RhYmJlZFBhbmUuYXBw ZW5kVGFiKCJoZWFkZXJzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJIZWFkZXJzIiksIGhlYWRl cnNWaWV3KTsKKyAgICB0aGlzLmFwcGVuZFRhYigiaGVhZGVycyIsIFdlYkluc3BlY3Rvci5VSVN0 cmluZygiSGVhZGVycyIpLCBoZWFkZXJzVmlldyk7CiAKICAgICB2YXIgcmVzcG9uc2VWaWV3ID0g bmV3IFdlYkluc3BlY3Rvci5SZXNvdXJjZVJlc3BvbnNlVmlldyhyZXNvdXJjZSk7CiAgICAgdmFy IHByZXZpZXdWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5SZXNvdXJjZVByZXZpZXdWaWV3KHJlc291 cmNlLCByZXNwb25zZVZpZXcpOwogCi0gICAgdGhpcy5fdGFiYmVkUGFuZS5hcHBlbmRUYWIoInBy ZXZpZXciLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlByZXZpZXciKSwgcHJldmlld1ZpZXcpOwot ICAgIHRoaXMuX3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJyZXNwb25zZSIsIFdlYkluc3BlY3Rvci5V SVN0cmluZygiUmVzcG9uc2UiKSwgcmVzcG9uc2VWaWV3KTsKKyAgICB0aGlzLmFwcGVuZFRhYigi cHJldmlldyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiUHJldmlldyIpLCBwcmV2aWV3Vmlldyk7 CisgICAgdGhpcy5hcHBlbmRUYWIoInJlc3BvbnNlIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJS ZXNwb25zZSIpLCByZXNwb25zZVZpZXcpOwogCiAgICAgaWYgKFByZWZlcmVuY2VzLnNob3dDb29r aWVzVGFiKSB7CiAgICAgICAgIHRoaXMuX2Nvb2tpZXNWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5S ZXNvdXJjZUNvb2tpZXNWaWV3KHJlc291cmNlKTsKLSAgICAgICAgdGhpcy5fdGFiYmVkUGFuZS5h cHBlbmRUYWIoImNvb2tpZXMiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNvb2tpZXMiKSwgdGhp cy5fY29va2llc1ZpZXcpOworICAgICAgICB0aGlzLmFwcGVuZFRhYigiY29va2llcyIsIFdlYklu c3BlY3Rvci5VSVN0cmluZygiQ29va2llcyIpLCB0aGlzLl9jb29raWVzVmlldyk7CiAgICAgfQog CiAgICAgaWYgKFByZWZlcmVuY2VzLnNob3dUaW1pbmdUYWIpIHsKICAgICAgICAgdmFyIHRpbWlu Z1ZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlJlc291cmNlVGltaW5nVmlldyhyZXNvdXJjZSk7Ci0g ICAgICAgIHRoaXMuX3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJ0aW1pbmciLCBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIlRpbWluZyIpLCB0aW1pbmdWaWV3KTsKKyAgICAgICAgdGhpcy5hcHBlbmRUYWIo InRpbWluZyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiVGltaW5nIiksIHRpbWluZ1ZpZXcpOwog ICAgIH0KIAotICAgIHRoaXMuX3RhYmJlZFBhbmUuYWRkRXZlbnRMaXN0ZW5lcigidGFiLXNlbGVj dGVkIiwgdGhpcy5fdGFiU2VsZWN0ZWQsIHRoaXMpOworICAgIHRoaXMuYWRkRXZlbnRMaXN0ZW5l cigidGFiLXNlbGVjdGVkIiwgdGhpcy5fdGFiU2VsZWN0ZWQsIHRoaXMpOwogfQogCiBXZWJJbnNw ZWN0b3IuTmV0d29ya0l0ZW1WaWV3LnByb3RvdHlwZSA9IHsKICAgICBzaG93OiBmdW5jdGlvbihw YXJlbnRFbGVtZW50KQogICAgIHsKLSAgICAgICAgV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBl LnNob3cuY2FsbCh0aGlzLCBwYXJlbnRFbGVtZW50KTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLlRh YmJlZFBhbmUucHJvdG90eXBlLnNob3cuY2FsbCh0aGlzLCBwYXJlbnRFbGVtZW50KTsKICAgICAg ICAgdGhpcy5fc2VsZWN0VGFiKCk7CiAgICAgfSwKIApAQCAtNjksOSArNjgsOSBAQCBXZWJJbnNw ZWN0b3IuTmV0d29ya0l0ZW1WaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCF0YWJJZCkK ICAgICAgICAgICAgIHRhYklkID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLnJlc291cmNlVmlld1Rh Yi5nZXQoKTsKIAotICAgICAgICBpZiAoIXRoaXMuX3RhYmJlZFBhbmUuc2VsZWN0VGFiKHRhYklk KSkgeworICAgICAgICBpZiAoIXRoaXMuc2VsZWN0VGFiKHRhYklkKSkgewogICAgICAgICAgICAg dGhpcy5faXNJbkZhbGxiYWNrU2VsZWN0aW9uID0gdHJ1ZTsKLSAgICAgICAgICAgIHRoaXMuX3Rh YmJlZFBhbmUuc2VsZWN0VGFiKCJoZWFkZXJzIik7CisgICAgICAgICAgICB0aGlzLnNlbGVjdFRh YigiaGVhZGVycyIpOwogICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2lzSW5GYWxsYmFja1NlbGVj dGlvbjsKICAgICAgICAgfQogICAgIH0sCkBAIC05OCw3ICs5Nyw3IEBAIFdlYkluc3BlY3Rvci5O ZXR3b3JrSXRlbVZpZXcucHJvdG90eXBlID0gewogICAgIH0KIH0KIAotV2ViSW5zcGVjdG9yLk5l dHdvcmtJdGVtVmlldy5wcm90b3R5cGUuX19wcm90b19fID0gV2ViSW5zcGVjdG9yLlZpZXcucHJv dG90eXBlOworV2ViSW5zcGVjdG9yLk5ldHdvcmtJdGVtVmlldy5wcm90b3R5cGUuX19wcm90b19f ID0gV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmUucHJvdG90eXBlOwogCiBXZWJJbnNwZWN0b3IuUmVz b3VyY2VDb250ZW50VmlldyA9IGZ1bmN0aW9uKHJlc291cmNlKQogewpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRQYW5lLmpzCmluZGV4IDEzOTgwMWMuLjEz N2Q5YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFi YmVkUGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJl ZFBhbmUuanMKQEAgLTMwLDcgKzMwLDcgQEAKIAogV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmUgPSBm dW5jdGlvbihlbGVtZW50KQogewotICAgIHRoaXMuZWxlbWVudCA9IGVsZW1lbnQgfHwgZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgV2ViSW5zcGVjdG9yLlZpZXcuY2FsbCh0aGlz LCBlbGVtZW50KTsKICAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygidGFiYmVkLXBhbmUi KTsKICAgICB0aGlzLl90YWJzRWxlbWVudCA9IHRoaXMuZWxlbWVudC5jcmVhdGVDaGlsZCgiZGl2 IiwgInRhYmJlZC1wYW5lLWhlYWRlciIpOwogICAgIHRoaXMuX2NvbnRlbnRFbGVtZW50ID0gdGhp cy5lbGVtZW50LmNyZWF0ZUNoaWxkKCJkaXYiLCAidGFiYmVkLXBhbmUtY29udGVudCIpOwpAQCAt ODEsNCArODEsNCBAQCBXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZS5wcm90b3R5cGUgPSB7CiAgICAg fQogfQogCi1XZWJJbnNwZWN0b3IuVGFiYmVkUGFuZS5wcm90b3R5cGUuX19wcm90b19fID0gV2Vi SW5zcGVjdG9yLk9iamVjdC5wcm90b3R5cGU7CitXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZS5wcm90 b3R5cGUuX19wcm90b19fID0gV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBlOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuaHRtbCBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmh0bWwKaW5kZXggY2Mx OTEzNy4uYTc4OTYwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9pbnNwZWN0b3IuaHRtbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL2luc3BlY3Rvci5odG1sCkBAIC01NCw5ICs1NCw5IEBAIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgICAgPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iS2V5Ym9hcmRTaG9ydGN1dC5qcyI+PC9zY3Jp cHQ+CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iVGV4dFByb21wdC5q cyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iUG9w b3Zlci5qcyI+PC9zY3JpcHQ+Ci0gICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNy Yz0iVGFiYmVkUGFuZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFz Y3JpcHQiIHNyYz0iUGxhY2FyZC5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0 L2phdmFzY3JpcHQiIHNyYz0iVmlldy5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0 ZXh0L2phdmFzY3JpcHQiIHNyYz0iVGFiYmVkUGFuZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iSUZyYW1lVmlldy5qcyI+PC9zY3JpcHQ+CiAg ICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iRHJhd2VyLmpzIj48L3Njcmlw dD4KICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJDb25zb2xlVmlldy5q cyI+PC9zY3JpcHQ+Cg==