66059 2011-08-11 07:39:40 -0700 [GTK] create pot files in builddir, not (read only) srcdir 2011-08-11 09:04:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez xan.lopez alex gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 449761 0 xan.lopez 2011-08-11 07:39:40 -0700 Summary says it all. We try to create the pot files in the srcdir, this fails during distcheck, which creates a read-only copy of the source dir. 449764 1 103620 xan.lopez 2011-08-11 07:41:02 -0700 Created attachment 103620 Patch 449768 2 103620 gustavo 2011-08-11 07:54:01 -0700 Comment on attachment 103620 Patch LGTM 449805 3 103620 xan.lopez 2011-08-11 08:57:09 -0700 Comment on attachment 103620 Patch Clearing flags on attachment: 103620 Committed r92854: <http://trac.webkit.org/changeset/92854> 449806 4 xan.lopez 2011-08-11 08:57:15 -0700 All reviewed patches have been landed. Closing bug. 449811 5 mrobinson 2011-08-11 09:03:21 -0700 Yay! 449812 6 xan.lopez 2011-08-11 09:04:10 -0700 (In reply to comment #5) > Yay! Martin, get back to work. 103620 2011-08-11 07:41:02 -0700 2011-08-11 08:57:09 -0700 Patch bug-66059-20110811164056.patch text/plain 3823 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4NDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L3BvL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3BvL0NoYW5nZUxvZwppbmRleCBmMWQ2 N2NmNjEzNDE0ZGI5YzYyNGQyOGU2ZWQwYmIzOWZjNmNmNGMzLi5hYjAyMjllYmE5M2QyODk3MjBk NTU1MWU5MDI1NDdkMDYzZjg4YjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9wby9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvcG8vQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTEtMDgtMTEgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIGNyZWF0ZSBwb3QgZmlsZXMgaW4gYnVpbGRkaXIsIG5vdCAocmVhZCBvbmx5KSBz cmNkaXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2 MDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBH TlVtYWtlZmlsZS5hbTogd3JpdGUgYW5kIHJlYWQgcG90IGZpbGVzIGZyb20gdGhlIGJ1aWxkIGRp ci4KKwogMjAxMS0wNy0xMSAgWXVyaSBDaG9ybm9pdmFuICA8eXVyY2hvckB1a3IubmV0PgogCiAg ICAgICAgIFVrcmFpbmlhbiB0cmFuc2xhdGlvbiBmb3IgV2ViS2l0R1RLKwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ndGsvcG8vR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0L2d0ay9w by9HTlVtYWtlZmlsZS5hbQppbmRleCA5MWExMGM0OTViMDI5NDkxOGMwYjBlNTFmYWZiZTczODRm NzliNDI5Li4yZWMxYzI3MzE5NjlmYzg0ZmVjNTJlMTE2YjNkMTQyOWNmODIwNjdlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9wby9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2Vi S2l0L2d0ay9wby9HTlVtYWtlZmlsZS5hbQpAQCAtNDgsMTAgKzQ4LDEwIEBAIE1PRklMRVMgKz0g JChzaGVsbCBlY2hvICQoUE9GSUxFUykgfCB0ciAnICcgJ1xuJyB8IHNlZCAicyxeJChzcmNkaXIp LywsZyIgfCBzZWQKICMgaWYgdXBkYXRpbmcgdGhlICQoQ0FUQUxPR1MpIHdvdWxkIGFsd2F5cyB0 b3VjaCB0aGVtOyBob3dldmVyLCB0aGUgcnVsZSBmb3IKICMgJChQT0ZJTEVTKSBoYXMgYmVlbiBk ZXNpZ25lZCB0byBub3QgdG91Y2ggZmlsZXMgdGhhdCBkb24ndCBuZWVkIHRvIGJlCiAjIGNoYW5n ZWQuCi1zdGFtcC1wbzogJChzcmNkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5w b3QgJChNT0ZJTEVTKQotCXRlc3QgISAtZiAkKHNyY2RpcikvU291cmNlL1dlYktpdC9ndGsvcG8v JChET01BSU4pLnBvdCB8fCBcCitzdGFtcC1wbzogJCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9XZWJL aXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QgJChNT0ZJTEVTKQorCXRlc3QgISAtZiAkKHRvcF9idWls ZGRpcikvU291cmNlL1dlYktpdC9ndGsvcG8vJChET01BSU4pLnBvdCB8fCBcCiAJICB0ZXN0IC16 ICIkKE1PRklMRVMpIiB8fCAkKE1BS0UpICQoTU9GSUxFUykKLQlAdGVzdCAhIC1mICQoc3JjZGly KS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8kKERPTUFJTikucG90IHx8IHsgXAorCUB0ZXN0ICEgLWYg JCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QgfHwgeyBc CiAJICBlY2hvICJ0b3VjaCBzdGFtcC1wbyIgJiYgXAogCSAgZWNobyB0aW1lc3RhbXAgPiBzdGFt cC1wb1QgJiYgXAogCSAgbXYgc3RhbXAtcG9UIHN0YW1wLXBvOyBcCkBAIC03Myw3ICs3Myw3IEBA ICQoRE9NQUlOKS5wb3QtdXBkYXRlOiAkKFBPVEZJTEVTKSAkKHNyY2RpcikvU291cmNlL1dlYktp dC9ndGsvcG8vUE9URklMRVMKIAkgICAgICAtLWZpbGVzLWZyb209JChzcmNkaXIpL1NvdXJjZS9X ZWJLaXQvZ3RrL3BvL1BPVEZJTEVTIFwKIAkgICAgICAtLWNvcHlyaWdodC1ob2xkZXI9JyQoQ09Q WVJJR0hUX0hPTERFUiknIFwKIAkgICAgICAtLW1zZ2lkLWJ1Z3MtYWRkcmVzcz0iJCRtc2dpZF9i dWdzX2FkZHJlc3MiIFwKLQkgICAgICAtLWtleXdvcmQ9XyAtLWtleXdvcmQ9Tl8gLW8gJChzcmNk aXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QgXAorCSAgICAgIC0ta2V5d29y ZD1fIC0ta2V5d29yZD1OXyAtbyAkKHRvcF9idWlsZGRpcikvU291cmNlL1dlYktpdC9ndGsvcG8v JChET01BSU4pLnBvdCBcCiAJICAgIDs7IFwKIAkgICopIFwKIAkgICAgJChYR0VUVEVYVCkgLS1k ZWZhdWx0LWRvbWFpbj0kKERPTUFJTikgLS1kaXJlY3Rvcnk9JChzcmNkaXIpIFwKQEAgLTgzLDE5 ICs4MywxOSBAQCAkKERPTUFJTikucG90LXVwZGF0ZTogJChQT1RGSUxFUykgJChzcmNkaXIpL1Nv dXJjZS9XZWJLaXQvZ3RrL3BvL1BPVEZJTEVTCiAJICAgICAgLS1wYWNrYWdlLW5hbWU9IiQke3Bh Y2thZ2VfZ251fUBQQUNLQUdFQCIgXAogCSAgICAgIC0tcGFja2FnZS12ZXJzaW9uPSdAVkVSU0lP TkAnIFwKIAkgICAgICAtLW1zZ2lkLWJ1Z3MtYWRkcmVzcz0iJCRtc2dpZF9idWdzX2FkZHJlc3Mi IFwKLQkgICAgICAtLWtleXdvcmQ9XyAtLWtleXdvcmQ9Tl8gLW8gJChzcmNkaXIpL1NvdXJjZS9X ZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QgXAorCSAgICAgIC0ta2V5d29yZD1fIC0ta2V5d29y ZD1OXyAtbyAkKHRvcF9idWlsZGRpcikvU291cmNlL1dlYktpdC9ndGsvcG8vJChET01BSU4pLnBv dCBcCiAJICAgIDs7IFwKIAllc2FjCiAKICMgVGhpcyBydWxlIGhhcyBubyBkZXBlbmRlbmNpZXM6 IHdlIGRvbid0IG5lZWQgdG8gdXBkYXRlICQoRE9NQUlOKS5wb3QgYXQKICMgZXZlcnkgIm1ha2Ui IGludm9jYXRpb24sIG9ubHkgY3JlYXRlIGl0IHdoZW4gaXQgaXMgbWlzc2luZy4KICMgT25seSAi bWFrZSAkKERPTUFJTikucG90LXVwZGF0ZSIgb3IgIm1ha2UgZGlzdCIgd2lsbCBmb3JjZSBhbiB1 cGRhdGUuCi0kKHNyY2RpcikvU291cmNlL1dlYktpdC9ndGsvcG8vJChET01BSU4pLnBvdDoKKyQo dG9wX2J1aWxkZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8kKERPTUFJTikucG90OgogCSQoTUFL RSkgJChET01BSU4pLnBvdC11cGRhdGUKIAogIyBUaGlzIHRhcmdldCByZWJ1aWxkcyBhIFBPIGZp bGUgaWYgJChET01BSU4pLnBvdCBoYXMgY2hhbmdlZC4KICMgTm90ZSB0aGF0IGEgUE8gZmlsZSBp cyBub3QgdG91Y2hlZCBpZiBpdCBkb2Vzbid0IG5lZWQgdG8gYmUgY2hhbmdlZC4KLXVwZGF0ZS1w by1maWxlczogJChzcmNkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QKK3Vw ZGF0ZS1wby1maWxlczogJCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9N QUlOKS5wb3QKIAlAZm9yIHBvZmlsZSBpbiAkKFBPRklMRVMpOyBkbyBcCiAJICBsYW5nPWBlY2hv ICQkcG9maWxlIHwgc2VkIC1lICdzLC4qLywsJyAtZSAncy9cLnBvJCQvLydgOyBcCiAJICBpZiB0 ZXN0IC1mICIkKHNyY2RpcikvU291cmNlL1dlYktpdC9ndGsvcG8vJCR7bGFuZ30ucG8iOyB0aGVu IFwKQEAgLTEyMywxMCArMTIzLDEyIEBAIENMRUFORklMRVMgKz0gXAogCSQodG9wX2J1aWxkZGly KS9zdGFtcC1wbwogCiBNQUlOVEFJTkVSQ0xFQU5GSUxFUyArPSBcCi0JJChNT0ZJTEVTKQorCSQo TU9GSUxFUykgXAorCSQodG9wX2J1aWxkZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9wby8kKERPTUFJ TikucG90CiAKIERJU1RDTEVBTkZJTEVTICs9IFwKLQkkKE1PRklMRVMpCisJJChNT0ZJTEVTKSBc CisJJCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QKIAog cG8taW5zdGFsbC1kYXRhLWxvY2FsOiBhbGwKIAkkKG1rZGlyX3ApICQoREVTVERJUikkKGRhdGFk aXIpCg==