66054 2011-08-11 06:43:44 -0700 [Qt] PageSerializer is specific to MHTML, we should not compile it 2011-08-13 03:26:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 benjamin benjamin jcivelli webkit.review.bot oldest_to_newest 449738 0 benjamin 2011-08-11 06:43:44 -0700 The compilation time is already slow enough to not compile files for fun ;) 449746 1 103617 benjamin 2011-08-11 07:05:40 -0700 Created attachment 103617 Patch 449748 2 benjamin 2011-08-11 07:12:29 -0700 Jay, what is your intention with PageSerializer? Does this patch make sense or you plan to use the class elsewhere? 449818 3 jcivelli 2011-08-11 09:24:21 -0700 It is safe to remove it from the Qt build if you don't need MHTML support. There is no plan I am aware of to use it anywhere else at this time. 449820 4 103617 benjamin 2011-08-11 09:27:28 -0700 Comment on attachment 103617 Patch (In reply to comment #3) > It is safe to remove it from the Qt build if you don't need MHTML support. > There is no plan I am aware of to use it anywhere else at this time. Cool, thanks for looking at this. 449830 5 103617 webkit.review.bot 2011-08-11 09:38:07 -0700 Comment on attachment 103617 Patch Clearing flags on attachment: 103617 Committed r92856: <http://trac.webkit.org/changeset/92856> 449831 6 webkit.review.bot 2011-08-11 09:38:11 -0700 All reviewed patches have been landed. Closing bug. 103617 2011-08-11 07:05:40 -0700 2011-08-11 09:38:07 -0700 Patch bug-66054-20110811161206.patch text/plain 1983 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4NDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YzI3ZDE5Mzk0YWM3YjQw ZmRjYmZiNDgzZDE4MTJjNDMxZGNjY2RhLi5mOGJkOWE3ZTE5NWYyOWRiZGYxOWZhZWMwMzRkZGNm NTcwMjJiZjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTEgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gUGFnZVNl cmlhbGl6ZXIgaXMgc3BlY2lmaWMgdG8gTUhUTUwsIHdlIHNob3VsZCBub3QgY29tcGlsZSBpdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYwNTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYWdlU2VyaWFs aXplciBpcyBzcGVjaWZpYyB0byBNSFRNTC4gRG8gbm90IGJ1aWxkIFBhZ2VTZXJpYWxpemVyIHVu bGVzcyBNSFRNTCBpcyBlbmFibGVkLgorCisgICAgICAgICogV2ViQ29yZS5wcm86CisKIDIwMTEt MDgtMTEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIFF0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5wcm8gYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCA5OTVj MGE5ZGFiZTAxYjJkMTY4ZWJlNjNlZWI5NDkyYTlmNGM1NTcwLi5iNzYzMDM3MGZjY2FmYWYyODUy MWVlNjU2OWYxYTg0ODExYThiZjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl LnBybworKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtOTM4LDcgKzkzOCw2IEBA IFNPVVJDRVMgKz0gXAogICAgIHBhZ2UvUGFnZS5jcHAgXAogICAgIHBhZ2UvUGFnZUdyb3VwLmNw cCBcCiAgICAgcGFnZS9QYWdlR3JvdXBMb2FkRGVmZXJyZXIuY3BwIFwKLSAgICBwYWdlL1BhZ2VT ZXJpYWxpemVyLmNwcCBcCiAgICAgcGFnZS9QYWdlVmlzaWJpbGl0eVN0YXRlLmNwcCBcCiAgICAg cGFnZS9QZXJmb3JtYW5jZS5jcHAgXAogICAgIHBhZ2UvUGVyZm9ybWFuY2VOYXZpZ2F0aW9uLmNw cCBcCkBAIC0xOTE1LDcgKzE5MTQsNiBAQCBIRUFERVJTICs9IFwKICAgICBwYWdlL1BhZ2VHcm91 cC5oIFwKICAgICBwYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5oIFwKICAgICBwYWdlL1BhZ2Uu aCBcCi0gICAgcGFnZS9QYWdlU2VyaWFsaXplci5oIFwKICAgICBwYWdlL1BhZ2VWaXNpYmlsaXR5 U3RhdGUuaCBcCiAgICAgcGFnZS9QcmludENvbnRleHQuaCBcCiAgICAgcGFnZS9TY3JlZW4uaCBc CkBAIC0zNzk0LDEzICszNzkyLDE1IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9XRUJHTD0x KSB7CiAKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9NSFRNTD0xKSB7CiAgICAgSEVBREVSUyAr PSBcCi0gICAgICAgIGxvYWRlci9hcmNoaXZlL0FyY2hpdmUuaAorICAgICAgICBsb2FkZXIvYXJj aGl2ZS9BcmNoaXZlLmggXAorICAgICAgICBwYWdlL1BhZ2VTZXJpYWxpemVyLmgKIAogICAgIFNP VVJDRVMgKz0gXAogICAgICAgICBsb2FkZXIvYXJjaGl2ZS9BcmNoaXZlLmNwcCBcCiAgICAgICAg IGxvYWRlci9hcmNoaXZlL0FyY2hpdmVGYWN0b3J5LmNwcCBcCiAgICAgICAgIGxvYWRlci9hcmNo aXZlL21odG1sL01IVE1MQXJjaGl2ZS5jcHAgXAotICAgICAgICBsb2FkZXIvYXJjaGl2ZS9taHRt bC9NSFRNTFBhcnNlci5jcHAKKyAgICAgICAgbG9hZGVyL2FyY2hpdmUvbWh0bWwvTUhUTUxQYXJz ZXIuY3BwIFwKKyAgICAgICAgcGFnZS9QYWdlU2VyaWFsaXplci5jcHAKIH0KIAogd2luMzI6IXdp bjMyLWcrKyo6Y29udGFpbnMoUU1BS0VfSE9TVC5hcmNoLCB4ODZfNjQpOnsK