66047 2011-08-11 05:07:53 -0700 WebSocket: Use PassRefPtr<> in function arguments in WorkerThreadableWebSocketChannel.cpp 2011-08-11 07:01:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yutak yutak abarth ap tkent webkit.review.bot oldest_to_newest 449702 0 yutak 2011-08-11 05:07:53 -0700 Spin-off of bug 65248. Let's make check-webkit-style happy. 449704 1 103604 yutak 2011-08-11 05:20:29 -0700 Created attachment 103604 Patch 449743 2 103604 webkit.review.bot 2011-08-11 07:01:11 -0700 Comment on attachment 103604 Patch Clearing flags on attachment: 103604 Committed r92843: <http://trac.webkit.org/changeset/92843> 449744 3 webkit.review.bot 2011-08-11 07:01:16 -0700 All reviewed patches have been landed. Closing bug. 103604 2011-08-11 05:20:29 -0700 2011-08-11 07:01:11 -0700 Patch bug-66047-20110811212027.patch text/plain 5680 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTI3NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZTc0Y2Q2M2QyZWM0MjJj YTI5MTE2OTQyMGJmZWY3ZGIwYTIzMWJkLi42MjRiNDgxZTg0MzZjM2ZhYmI1MTU3MTc1NDVhMWNm MzA0MmRkOTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDgtMTEgIFl1dGEg S2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViU29ja2V0OiBVc2Ug UGFzc1JlZlB0cjw+IGluIGZ1bmN0aW9uIGFyZ3VtZW50cyBpbiBXb3JrZXJUaHJlYWRhYmxlV2Vi U29ja2V0Q2hhbm5lbC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY2MDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSXQncyBzYWZlIHRvIHVzZSBQYXNzUmVmUHRyPD4gaW4gdGhlc2UgZnVuY3Rpb25z IGJlY2F1c2U6CisgICAgICAgIC0gQ3Jvc3NUaHJlYWRUYXNrIGtub3dzIGhvdyB0byBwYXNzIGEg UmVmUHRyPD4gYWNyb3NzIHRocmVhZHMsIGFuZAorICAgICAgICAtIENhbGwgc2l0ZXMgZG8gbm90 IHBhc3MgdGhlIHBvaW50ZXJzIHRvIGFueXdoZXJlIGVsc2UuCisKKyAgICAgICAgTm8gY2hhbmdl IGluIGZ1bmN0aW9uYWxpdHksIHRodXMgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogd2Vic29j a2V0cy9Xb3JrZXJUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbC5jcHA6CisgICAgICAgIChXZWJD b3JlOjp3b3JrZXJDb250ZXh0RGlkU2VuZCk6CisgICAgICAgIChXZWJDb3JlOjp3b3JrZXJDb250 ZXh0RGlkR2V0QnVmZmVyZWRBbW91bnQpOgorICAgICAgICAoV2ViQ29yZTo6d29ya2VyQ29udGV4 dERpZENvbm5lY3QpOgorICAgICAgICAoV2ViQ29yZTo6d29ya2VyQ29udGV4dERpZFJlY2VpdmVN ZXNzYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OndvcmtlckNvbnRleHREaWRTdGFydENsb3NpbmdI YW5kc2hha2UpOgorICAgICAgICAoV2ViQ29yZTo6d29ya2VyQ29udGV4dERpZENsb3NlKToKKwog MjAxMS0wOC0xMCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogYXV0by1jb21wbGV0aW9uIGZvciBzdHJpbmcgbGl0ZXJhbHMgZG9l c24ndCB3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dvcmtlclRo cmVhZGFibGVXZWJTb2NrZXRDaGFubmVsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMv V29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwCmluZGV4IGQyOWY1N2U0YmZkMjhj YTg5MmYxMzk0ZTA2OWNkMGFjYTcwNTFhM2IuLmFmMGM2MDZmZGI5YTk5NWY5YTFlNjcwNDAwMzc1 MWZmOTEwOWZlN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV29ya2Vy VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYnNv Y2tldHMvV29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwCkBAIC0xNTEsNyArMTUx LDcgQEAgdm9pZCBXb3JrZXJUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6UGVlcjo6Y29ubmVj dChjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFN0cmkKICAgICBtX21haW5XZWJTb2NrZXRDaGFubmVs LT5jb25uZWN0KHVybCwgcHJvdG9jb2wpOwogfQogCi1zdGF0aWMgdm9pZCB3b3JrZXJDb250ZXh0 RGlkU2VuZChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBSZWZQdHI8VGhyZWFkYWJs ZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyPiB3b3JrZXJDbGllbnRXcmFwcGVyLCBib29s IHNlbnQpCitzdGF0aWMgdm9pZCB3b3JrZXJDb250ZXh0RGlkU2VuZChTY3JpcHRFeGVjdXRpb25D b250ZXh0KiBjb250ZXh0LCBQYXNzUmVmUHRyPFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsQ2xp ZW50V3JhcHBlcj4gd29ya2VyQ2xpZW50V3JhcHBlciwgYm9vbCBzZW50KQogewogICAgIEFTU0VS VF9VTlVTRUQoY29udGV4dCwgY29udGV4dC0+aXNXb3JrZXJDb250ZXh0KCkpOwogICAgIHdvcmtl ckNsaWVudFdyYXBwZXItPnNldFNlbnQoc2VudCk7CkBAIC0xNjYsNyArMTY2LDcgQEAgdm9pZCBX b3JrZXJUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6UGVlcjo6c2VuZChjb25zdCBTdHJpbmcm IG1lc3NhZ2UpCiAgICAgbV9sb2FkZXJQcm94eS5wb3N0VGFza0Zvck1vZGVUb1dvcmtlckNvbnRl eHQoY3JlYXRlQ2FsbGJhY2tUYXNrKCZ3b3JrZXJDb250ZXh0RGlkU2VuZCwgbV93b3JrZXJDbGll bnRXcmFwcGVyLCBzZW50KSwgbV90YXNrTW9kZSk7CiB9CiAKLXN0YXRpYyB2b2lkIHdvcmtlckNv bnRleHREaWRHZXRCdWZmZXJlZEFtb3VudChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 LCBSZWZQdHI8VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyPiB3b3JrZXJD bGllbnRXcmFwcGVyLCB1bnNpZ25lZCBsb25nIGJ1ZmZlcmVkQW1vdW50KQorc3RhdGljIHZvaWQg d29ya2VyQ29udGV4dERpZEdldEJ1ZmZlcmVkQW1vdW50KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IGNvbnRleHQsIFBhc3NSZWZQdHI8VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFw cGVyPiB3b3JrZXJDbGllbnRXcmFwcGVyLCB1bnNpZ25lZCBsb25nIGJ1ZmZlcmVkQW1vdW50KQog ewogICAgIEFTU0VSVF9VTlVTRUQoY29udGV4dCwgY29udGV4dC0+aXNXb3JrZXJDb250ZXh0KCkp OwogICAgIHdvcmtlckNsaWVudFdyYXBwZXItPnNldEJ1ZmZlcmVkQW1vdW50KGJ1ZmZlcmVkQW1v dW50KTsKQEAgLTIyMiw3ICsyMjIsNyBAQCB2b2lkIFdvcmtlclRocmVhZGFibGVXZWJTb2NrZXRD aGFubmVsOjpQZWVyOjpyZXN1bWUoKQogICAgIG1fbWFpbldlYlNvY2tldENoYW5uZWwtPnJlc3Vt ZSgpOwogfQogCi1zdGF0aWMgdm9pZCB3b3JrZXJDb250ZXh0RGlkQ29ubmVjdChTY3JpcHRFeGVj dXRpb25Db250ZXh0KiBjb250ZXh0LCBSZWZQdHI8VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxD bGllbnRXcmFwcGVyPiB3b3JrZXJDbGllbnRXcmFwcGVyKQorc3RhdGljIHZvaWQgd29ya2VyQ29u dGV4dERpZENvbm5lY3QoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgUGFzc1JlZlB0 cjxUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXI+IHdvcmtlckNsaWVudFdy YXBwZXIpCiB7CiAgICAgQVNTRVJUX1VOVVNFRChjb250ZXh0LCBjb250ZXh0LT5pc1dvcmtlckNv bnRleHQoKSk7CiAgICAgd29ya2VyQ2xpZW50V3JhcHBlci0+ZGlkQ29ubmVjdCgpOwpAQCAtMjM0 LDcgKzIzNCw3IEBAIHZvaWQgV29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWw6OlBlZXI6 OmRpZENvbm5lY3QoKQogICAgIG1fbG9hZGVyUHJveHkucG9zdFRhc2tGb3JNb2RlVG9Xb3JrZXJD b250ZXh0KGNyZWF0ZUNhbGxiYWNrVGFzaygmd29ya2VyQ29udGV4dERpZENvbm5lY3QsIG1fd29y a2VyQ2xpZW50V3JhcHBlciksIG1fdGFza01vZGUpOwogfQogCi1zdGF0aWMgdm9pZCB3b3JrZXJD b250ZXh0RGlkUmVjZWl2ZU1lc3NhZ2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwg UmVmUHRyPFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsQ2xpZW50V3JhcHBlcj4gd29ya2VyQ2xp ZW50V3JhcHBlciwgY29uc3QgU3RyaW5nJiBtZXNzYWdlKQorc3RhdGljIHZvaWQgd29ya2VyQ29u dGV4dERpZFJlY2VpdmVNZXNzYWdlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIFBh c3NSZWZQdHI8VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWxDbGllbnRXcmFwcGVyPiB3b3JrZXJD bGllbnRXcmFwcGVyLCBjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiB7CiAgICAgQVNTRVJUX1VOVVNF RChjb250ZXh0LCBjb250ZXh0LT5pc1dvcmtlckNvbnRleHQoKSk7CiAgICAgd29ya2VyQ2xpZW50 V3JhcHBlci0+ZGlkUmVjZWl2ZU1lc3NhZ2UobWVzc2FnZSk7CkBAIC0yNDYsNyArMjQ2LDcgQEAg dm9pZCBXb3JrZXJUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6UGVlcjo6ZGlkUmVjZWl2ZU1l c3NhZ2UoY29uc3QgU3RyaW5nJiBtZXMKICAgICBtX2xvYWRlclByb3h5LnBvc3RUYXNrRm9yTW9k ZVRvV29ya2VyQ29udGV4dChjcmVhdGVDYWxsYmFja1Rhc2soJndvcmtlckNvbnRleHREaWRSZWNl aXZlTWVzc2FnZSwgbV93b3JrZXJDbGllbnRXcmFwcGVyLCBtZXNzYWdlKSwgbV90YXNrTW9kZSk7 CiB9CiAKLXN0YXRpYyB2b2lkIHdvcmtlckNvbnRleHREaWRTdGFydENsb3NpbmdIYW5kc2hha2Uo U2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgUmVmUHRyPFRocmVhZGFibGVXZWJTb2Nr ZXRDaGFubmVsQ2xpZW50V3JhcHBlcj4gd29ya2VyQ2xpZW50V3JhcHBlcikKK3N0YXRpYyB2b2lk IHdvcmtlckNvbnRleHREaWRTdGFydENsb3NpbmdIYW5kc2hha2UoU2NyaXB0RXhlY3V0aW9uQ29u dGV4dCogY29udGV4dCwgUGFzc1JlZlB0cjxUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVu dFdyYXBwZXI+IHdvcmtlckNsaWVudFdyYXBwZXIpCiB7CiAgICAgQVNTRVJUX1VOVVNFRChjb250 ZXh0LCBjb250ZXh0LT5pc1dvcmtlckNvbnRleHQoKSk7CiAgICAgd29ya2VyQ2xpZW50V3JhcHBl ci0+ZGlkU3RhcnRDbG9zaW5nSGFuZHNoYWtlKCk7CkBAIC0yNTgsNyArMjU4LDcgQEAgdm9pZCBX b3JrZXJUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6UGVlcjo6ZGlkU3RhcnRDbG9zaW5nSGFu ZHNoYWtlKCkKICAgICBtX2xvYWRlclByb3h5LnBvc3RUYXNrRm9yTW9kZVRvV29ya2VyQ29udGV4 dChjcmVhdGVDYWxsYmFja1Rhc2soJndvcmtlckNvbnRleHREaWRTdGFydENsb3NpbmdIYW5kc2hh a2UsIG1fd29ya2VyQ2xpZW50V3JhcHBlciksIG1fdGFza01vZGUpOwogfQogCi1zdGF0aWMgdm9p ZCB3b3JrZXJDb250ZXh0RGlkQ2xvc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwg UmVmUHRyPFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsQ2xpZW50V3JhcHBlcj4gd29ya2VyQ2xp ZW50V3JhcHBlciwgdW5zaWduZWQgbG9uZyB1bmhhbmRsZWRCdWZmZXJlZEFtb3VudCwgV2ViU29j a2V0Q2hhbm5lbENsaWVudDo6Q2xvc2luZ0hhbmRzaGFrZUNvbXBsZXRpb25TdGF0dXMgY2xvc2lu Z0hhbmRzaGFrZUNvbXBsZXRpb24pCitzdGF0aWMgdm9pZCB3b3JrZXJDb250ZXh0RGlkQ2xvc2Uo U2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgUGFzc1JlZlB0cjxUaHJlYWRhYmxlV2Vi U29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXI+IHdvcmtlckNsaWVudFdyYXBwZXIsIHVuc2lnbmVk IGxvbmcgdW5oYW5kbGVkQnVmZmVyZWRBbW91bnQsIFdlYlNvY2tldENoYW5uZWxDbGllbnQ6OkNs b3NpbmdIYW5kc2hha2VDb21wbGV0aW9uU3RhdHVzIGNsb3NpbmdIYW5kc2hha2VDb21wbGV0aW9u KQogewogICAgIEFTU0VSVF9VTlVTRUQoY29udGV4dCwgY29udGV4dC0+aXNXb3JrZXJDb250ZXh0 KCkpOwogICAgIHdvcmtlckNsaWVudFdyYXBwZXItPmRpZENsb3NlKHVuaGFuZGxlZEJ1ZmZlcmVk QW1vdW50LCBjbG9zaW5nSGFuZHNoYWtlQ29tcGxldGlvbik7Cg==