66045 2011-08-11 04:08:31 -0700 The code generators behave differently for overloaded and non-overloaded functions 2012-04-02 02:20:41 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED LATER P2 Normal --- 56459 65925 1 tommyw tommyw abarth dglazkov donggwan.kim harald pnormand webkit.review.bot oldest_to_newest 449684 0 tommyw 2011-08-11 04:08:31 -0700 Make the code generator for overloaded functions to behave more like non-overloaded functions regarding missing parameters. If one has just this in the IDL: TYPE function(in TYPE1 arg1) the generated code throws a specialized type error "Not enough parameters" if one calls function without any parameters. If one has this in the IDL: TYPE function(in TYPE1 arg) TYPE function(in TYPE2 arg) and calls function without any parameters the generated code throws just a generic TypeError. This patch counts the number of mandatory parameters for each overloaded function and if the number of arguments is less than the smallest of them throws the specialized type error, otherwise the generic. 449692 1 103600 tommyw 2011-08-11 04:48:18 -0700 Created attachment 103600 Patch 449708 2 103600 webkit.review.bot 2011-08-11 05:25:27 -0700 Comment on attachment 103600 Patch Attachment 103600 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9352159 New failing tests: fast/canvas/canvas-overloads-setFillColor.html fast/canvas/canvas-overloads-setStrokeColor.html fast/canvas/canvas-overloads-setShadow.html fast/canvas/canvas-overloads-drawImage.html fast/canvas/webgl/texImageTest.html 449843 3 103600 abarth 2011-08-11 09:53:11 -0700 Comment on attachment 103600 Patch Looks like landing this patch would cause test failures. It looks like a good approach, however. 454520 4 tommyw 2011-08-22 03:51:41 -0700 Do you think I should go ahead with this patch, even though it breaks several tests? (Of course I will fix the tests). 454663 5 abarth 2011-08-22 10:24:46 -0700 We need to look at how our behavior is changing on those tests and decide whether the new behavior is better or worse than the old behavior. For example, is our new behavior more or less consistent with the specifications and other browsers? Is the change likely to cause compatibility problems? 469983 6 pnormand 2011-09-20 04:50:29 -0700 I skipped fast/files/create-blob-url-crash.html on GTK in http://trac.webkit.org/changeset/95528. It'd be great if the test could be unskipped when this bug is fixed. 486682 7 pnormand 2011-10-19 04:59:20 -0700 (In reply to comment #6) > I skipped fast/files/create-blob-url-crash.html on GTK in http://trac.webkit.org/changeset/95528. It'd be great if the test could be unskipped when this bug is fixed. fast/files/url-required-arguments.html is also affected by this issue... Skipping in GTK like the test above. 103600 2011-08-11 04:48:18 -0700 2011-08-11 09:53:11 -0700 Patch bug-66045-20110811134816.patch text/plain 7430 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4MzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5OWFiMWE1MGJjYzQ0NDQ0 MDcwMjhkNjMyNGZmZWI1NDlmNzUyNTBhLi4xMTc1MjhmOThkM2FlZmY3ZjE1NGZiODY2ZWM0Y2Uz YjA5M2YzNWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDgtMTEgIFRvbW15 IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CisKKyAgICAgICAgVGhlIGNvZGUgZ2Vu ZXJhdG9ycyBiZWhhdmUgZGlmZmVyZW50bHkgZm9yIG92ZXJsb2FkZWQgYW5kIG5vbi1vdmVybG9h ZGVkIGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjYwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBFeGlzdGluZyB0ZXN0cyBoYXZlIGJlZW4gdXBkYXRlZCB0byBjb3ZlciB0aGlzIGNoYW5n ZS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAg ICAgICAoR2VuZXJhdGVGdW5jdGlvblBhcmFtZXRlcnNDaGVjayk6CisgICAgICAgIChHZW5lcmF0 ZU92ZXJsb2FkZWRQcm90b3R5cGVGdW5jdGlvbik6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChHZW5lcmF0ZUZ1bmN0aW9uUGFyYW1ldGVy c0NoZWNrKToKKyAgICAgICAgKEdlbmVyYXRlT3ZlcmxvYWRlZEZ1bmN0aW9uQ2FsbGJhY2spOgor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwOgorICAgICAg ICAoV2ViQ29yZTo6anNUZXN0T2JqUHJvdG90eXBlRnVuY3Rpb25PdmVybG9hZGVkTWV0aG9kKToK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlRlc3RPYmpJbnRlcm5hbDo6b3ZlcmxvYWRlZE1ldGhvZENhbGxiYWNrKToK KwogMjAxMS0wOC0xMSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0gUmVzb3VyY2VzIHBhbmVsIHNlYXJj aCBmYWlscyB3aGVuIHNlYXJjaCByZXN1bHQgaXMgZm91bmQgaW4gYSByZXNvdXJjZSB1c2VkIGlu IHNldmVyYWwgZnJhbWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCA3NGYwZDA4N2Q3YjFiNGY4MWEwMTdlMzdhNGFlMWI4 ZTI5OTNkM2JkLi40NWIxYjcxYjQ0NGRlNmE2ZTRjNWQ2MzI3ZDJhM2ViZGY2ZDc4N2FhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQpAQCAtMTIxNSw2ICsxMjE1LDcgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25QYXJhbWV0ZXJzQ2hl Y2sKIAogICAgIG15IEBvckV4cHJlc3Npb24gPSAoKTsKICAgICBteSAkbnVtUGFyYW1ldGVycyA9 IDA7CisgICAgbXkgJG51bVJlcXVpcmVkUGFyYW1zID0gMDsKICAgICBteSBAbmVlZGVkQXJndW1l bnRzID0gKCk7CiAKICAgICBmb3JlYWNoICRwYXJhbWV0ZXIgKEB7JGZ1bmN0aW9uLT5wYXJhbWV0 ZXJzfSkgewpAQCAtMTIyMiwxMyArMTIyMywxNSBAQCBzdWIgR2VuZXJhdGVGdW5jdGlvblBhcmFt ZXRlcnNDaGVjawogICAgICAgICAgICAgbXkgKCRleHByZXNzaW9uLCBAdXNlZEFyZ3VtZW50cykg PSBHZW5lcmF0ZVBhcmFtZXRlcnNDaGVja0V4cHJlc3Npb24oJG51bVBhcmFtZXRlcnMsICRmdW5j dGlvbik7CiAgICAgICAgICAgICBwdXNoKEBvckV4cHJlc3Npb24sICRleHByZXNzaW9uKTsKICAg ICAgICAgICAgIHB1c2goQG5lZWRlZEFyZ3VtZW50cywgQHVzZWRBcmd1bWVudHMpOworICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgJG51bVJlcXVpcmVkUGFyYW1zKys7CiAgICAgICAgIH0K ICAgICAgICAgJG51bVBhcmFtZXRlcnMrKzsKICAgICB9CiAgICAgbXkgKCRleHByZXNzaW9uLCBA dXNlZEFyZ3VtZW50cykgPSBHZW5lcmF0ZVBhcmFtZXRlcnNDaGVja0V4cHJlc3Npb24oJG51bVBh cmFtZXRlcnMsICRmdW5jdGlvbik7CiAgICAgcHVzaChAb3JFeHByZXNzaW9uLCAkZXhwcmVzc2lv bik7CiAgICAgcHVzaChAbmVlZGVkQXJndW1lbnRzLCBAdXNlZEFyZ3VtZW50cyk7Ci0gICAgcmV0 dXJuIChqb2luKCIgfHwgIiwgQG9yRXhwcmVzc2lvbiksIEBuZWVkZWRBcmd1bWVudHMpOworICAg IHJldHVybiAoJG51bVJlcXVpcmVkUGFyYW1zLCBqb2luKCIgfHwgIiwgQG9yRXhwcmVzc2lvbiks IEBuZWVkZWRBcmd1bWVudHMpOwogfQogCiBzdWIgR2VuZXJhdGVPdmVybG9hZGVkUHJvdG90eXBl RnVuY3Rpb24KQEAgLTEyNTIsOSArMTI1NSwxMyBAQCBzdWIgR2VuZXJhdGVPdmVybG9hZGVkUHJv dG90eXBlRnVuY3Rpb24KIEVORAogCiAgICAgbXkgJWZldGNoZWRBcmd1bWVudHMgPSAoKTsKKyAg ICBteSAkbWluUmVxdWlyZWRQYXJhbXMgPSAtMTsKIAogICAgIGZvcmVhY2ggbXkgJG92ZXJsb2Fk IChAeyRmdW5jdGlvbi0+e292ZXJsb2Fkc319KSB7Ci0gICAgICAgIG15ICgkcGFyYW1ldGVyc0No ZWNrLCBAbmVlZGVkQXJndW1lbnRzKSA9IEdlbmVyYXRlRnVuY3Rpb25QYXJhbWV0ZXJzQ2hlY2so JG92ZXJsb2FkKTsKKyAgICAgICAgbXkgKCRudW1SZXF1aXJlZFBhcmFtcywgJHBhcmFtZXRlcnND aGVjaywgQG5lZWRlZEFyZ3VtZW50cykgPSBHZW5lcmF0ZUZ1bmN0aW9uUGFyYW1ldGVyc0NoZWNr KCRvdmVybG9hZCk7CisgICAgICAgIGlmICgkbWluUmVxdWlyZWRQYXJhbXMgPCAwIHx8ICRudW1S ZXF1aXJlZFBhcmFtcyA8ICRtaW5SZXF1aXJlZFBhcmFtcykgeworICAgICAgICAgICAgJG1pblJl cXVpcmVkUGFyYW1zID0gJG51bVJlcXVpcmVkUGFyYW1zOworICAgICAgICB9CiAKICAgICAgICAg Zm9yZWFjaCBteSAkcGFyYW1ldGVySW5kZXggKEBuZWVkZWRBcmd1bWVudHMpIHsKICAgICAgICAg ICAgIG5leHQgaWYgZXhpc3RzICRmZXRjaGVkQXJndW1lbnRzeyRwYXJhbWV0ZXJJbmRleH07CkBA IC0xMjY2LDYgKzEyNzMsOCBAQCBFTkQKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAg ICAgIHJldHVybiAke2Z1bmN0aW9uTmFtZX0kb3ZlcmxvYWQtPntvdmVybG9hZEluZGV4fShleGVj KTtcbiIpOwogICAgIH0KICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOworICAgIGlmIChh cmdzQ291bnQgPCAkbWluUmVxdWlyZWRQYXJhbXMpCisgICAgICAgIHJldHVybiB0aHJvd1ZNRXJy b3IoZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMsICJOb3QgZW5vdWdoIGFyZ3VtZW50cyIpKTsK ICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihleGVjKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBkNmMwZmUw ZTA0NGQ0ZWU0ZGE5ZThlNjRhMTFmYjA5NGJlNTMyNTIyLi45NDFiYjYyMzI2NzA1NDRjNzIxNjBi ZDM1YmRjNTdmYzQ2YzFhM2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMTE3MywxNCArMTE3MywxNyBAQCBzdWIgR2Vu ZXJhdGVGdW5jdGlvblBhcmFtZXRlcnNDaGVjawogCiAgICAgbXkgQG9yRXhwcmVzc2lvbiA9ICgp OwogICAgIG15ICRudW1QYXJhbWV0ZXJzID0gMDsKKyAgICBteSAkbnVtUmVxdWlyZWRQYXJhbXMg PSAwOwogICAgIGZvcmVhY2ggJHBhcmFtZXRlciAoQHskZnVuY3Rpb24tPnBhcmFtZXRlcnN9KSB7 CiAgICAgICAgIGlmICgkcGFyYW1ldGVyLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiT3B0aW9uYWwi fSkgewogICAgICAgICAgICAgcHVzaChAb3JFeHByZXNzaW9uLCBHZW5lcmF0ZVBhcmFtZXRlcnND aGVja0V4cHJlc3Npb24oJG51bVBhcmFtZXRlcnMsICRmdW5jdGlvbikpOworICAgICAgICB9IGVs c2UgeworICAgICAgICAgICAgJG51bVJlcXVpcmVkUGFyYW1zKys7CiAgICAgICAgIH0KICAgICAg ICAgJG51bVBhcmFtZXRlcnMrKzsKICAgICB9CiAgICAgcHVzaChAb3JFeHByZXNzaW9uLCBHZW5l cmF0ZVBhcmFtZXRlcnNDaGVja0V4cHJlc3Npb24oJG51bVBhcmFtZXRlcnMsICRmdW5jdGlvbikp OwotICAgIHJldHVybiBqb2luKCIgfHwgIiwgQG9yRXhwcmVzc2lvbik7CisgICAgcmV0dXJuICgk bnVtUmVxdWlyZWRQYXJhbXMsIGpvaW4oIiB8fCAiLCBAb3JFeHByZXNzaW9uKSk7CiB9CiAKIHN1 YiBHZW5lcmF0ZU92ZXJsb2FkZWRGdW5jdGlvbkNhbGxiYWNrCkBAIC0xMjAyLDE2ICsxMjA1LDI0 IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gJHtuYW1lfUNhbGxiYWNrKGNvbnN0IHY4 OjpBcmd1bWVudHMmIGFyZ3MpCiAgICAgSU5DX1NUQVRTKFwiRE9NLiRpbXBsQ2xhc3NOYW1lLiRu YW1lXCIpOwogRU5ECiAKKyAgICBteSAkbWluUmVxdWlyZWRQYXJhbXMgPSAtMTsKICAgICBmb3Jl YWNoIG15ICRvdmVybG9hZCAoQHskZnVuY3Rpb24tPntvdmVybG9hZHN9fSkgewotICAgICAgICBt eSAkcGFyYW1ldGVyc0NoZWNrID0gR2VuZXJhdGVGdW5jdGlvblBhcmFtZXRlcnNDaGVjaygkb3Zl cmxvYWQpOworICAgICAgICBteSAoJG51bVJlcXVpcmVkUGFyYW1zLCAkcGFyYW1ldGVyc0NoZWNr KSA9IEdlbmVyYXRlRnVuY3Rpb25QYXJhbWV0ZXJzQ2hlY2soJG92ZXJsb2FkKTsKKyAgICAgICAg aWYgKCRtaW5SZXF1aXJlZFBhcmFtcyA8IDAgfHwgJG51bVJlcXVpcmVkUGFyYW1zIDwgJG1pblJl cXVpcmVkUGFyYW1zKSB7CisgICAgICAgICAgICAkbWluUmVxdWlyZWRQYXJhbXMgPSAkbnVtUmVx dWlyZWRQYXJhbXM7CisgICAgICAgIH0KICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiAgICBpZiAoJHBhcmFtZXRlcnNDaGVjaylcbiIpOwogICAgICAgICBwdXNoKEBpbXBsQ29udGVu dERlY2xzLCAiICAgICAgICByZXR1cm4gJHtuYW1lfSRvdmVybG9hZC0+e292ZXJsb2FkSW5kZXh9 Q2FsbGJhY2soYXJncyk7XG4iKTsKICAgICB9CisKKyAgICBteSAkbnVtUGFyYW1ldGVycyA9IEB7 JGZ1bmN0aW9uLT5wYXJhbWV0ZXJzfTsKICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCA8PEVO RCk7Ci0gICAgVjhQcm94eTo6dGhyb3dUeXBlRXJyb3IoKTsKLSAgICByZXR1cm4gbm90SGFuZGxl ZEJ5SW50ZXJjZXB0b3IoKTsKKyAgICBpZiAoYXJncy5MZW5ndGgoKSA8ICRtaW5SZXF1aXJlZFBh cmFtcykKKyAgICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJOb3QgZW5vdWdoIGFyZ3VtZW50cyIs IFY4UHJveHk6OlR5cGVFcnJvcik7CisgICAgcmV0dXJuIFY4UHJveHk6OnRocm93VHlwZUVycm9y KCk7Cit9CisKIEVORAotICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICJ9XG5cbiIpOwogfQog CiBzdWIgR2VuZXJhdGVGdW5jdGlvbkNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCmluZGV4IGZmZDIzYTg5YWQ0 MzA4YWJhMDIxMDM4NWEzOGM1YjFiYTZiNzQ5ZmUuLmNjMzY5MGMzZDBlZWQwNmJkZjI0Mzk3MGYw MThlZDFiYjVhZGEzZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCkBAIC0xNjQwLDYgKzE2NDAsOCBAQCBFbmNvZGVk SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRl ZE1ldGhvZChFeGVjU3RhdAogICAgICAgICByZXR1cm4ganNUZXN0T2JqUHJvdG90eXBlRnVuY3Rp b25PdmVybG9hZGVkTWV0aG9kNChleGVjKTsKICAgICBpZiAoKGFyZ3NDb3VudCA9PSAxICYmIChh cmcwLmlzTnVsbCgpIHx8IGFyZzAuaXNPYmplY3QoKSkpKQogICAgICAgICByZXR1cm4ganNUZXN0 T2JqUHJvdG90eXBlRnVuY3Rpb25PdmVybG9hZGVkTWV0aG9kNShleGVjKTsKKyAgICBpZiAoYXJn c0NvdW50IDwgMSkKKyAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVUeXBl RXJyb3IoZXhlYywgIk5vdCBlbm91Z2ggYXJndW1lbnRzIikpOwogICAgIHJldHVybiB0aHJvd1ZN VHlwZUVycm9yKGV4ZWMpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCmluZGV4IGY4ZjZjMmU4YzM1ZDQ1NTUwMzBi ODVlMDY0NGY3ZGYwOTI4MmQxMjguLmUzMjUxODhkZjM3OTI5NTlhNjFmODAyYThlYWRkODcwZDY4 N2QwMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9W OC9WOFRlc3RPYmouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9WOC9WOFRlc3RPYmouY3BwCkBAIC0xMTEwLDggKzExMTAsOSBAQCBzdGF0aWMgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IG92ZXJsb2FkZWRNZXRob2RDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRz JiBhcmdzKQogICAgICAgICByZXR1cm4gb3ZlcmxvYWRlZE1ldGhvZDRDYWxsYmFjayhhcmdzKTsK ICAgICBpZiAoKGFyZ3MuTGVuZ3RoKCkgPT0gMSAmJiAoYXJnc1swXS0+SXNOdWxsKCkgfHwgYXJn c1swXS0+SXNPYmplY3QoKSkpKQogICAgICAgICByZXR1cm4gb3ZlcmxvYWRlZE1ldGhvZDVDYWxs YmFjayhhcmdzKTsKLSAgICBWOFByb3h5Ojp0aHJvd1R5cGVFcnJvcigpOwotICAgIHJldHVybiBu b3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpOworICAgIGlmIChhcmdzLkxlbmd0aCgpIDwgMSkKKyAg ICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJOb3QgZW5vdWdoIGFyZ3VtZW50cyIsIFY4UHJveHk6 OlR5cGVFcnJvcik7CisgICAgcmV0dXJuIFY4UHJveHk6OnRocm93VHlwZUVycm9yKCk7CiB9CiAK IHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY2xhc3NNZXRob2RDYWxsYmFjayhjb25zdCB2 ODo6QXJndW1lbnRzJiBhcmdzKQo=