66041 2011-08-11 01:21:28 -0700 nrwt's results.html should show crashed tests before flaky tests 2011-10-14 15:39:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64491 1 rniwa rniwa abarth aroben eric ojan oldest_to_newest 449655 0 rniwa 2011-08-11 01:21:28 -0700 Since crashes are far more serious than flaky failures and turn the bots red unlike flaky tests, results.html should list them before flaky tests. 454344 1 ojan 2011-08-20 08:09:19 -0700 I have no problem with this. I'm happy to review a patch with a test. 482737 2 eric 2011-10-12 14:41:29 -0700 Easy to do. Just needs a small change to results.html (which is just an html page): http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/results.html 484353 3 111094 rniwa 2011-10-14 15:21:32 -0700 Created attachment 111094 fixes the bug 484362 4 111094 ojan 2011-10-14 15:34:12 -0700 Comment on attachment 111094 fixes the bug Yay. This has been driving me crazy. :) Thanks for writing tests! 484366 5 rniwa 2011-10-14 15:39:19 -0700 Committed r97522: <http://trac.webkit.org/changeset/97522> 111094 2011-10-14 15:21:32 -0700 2011-10-14 15:34:12 -0700 fixes the bug bug-66041-20111014152131.patch text/plain 3428 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk3NTE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTQgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgbnJ3dCdzIHJlc3VsdHMuaHRtbCBzaG91bGQgc2hv dyBjcmFzaGVkIHRlc3RzIGJlZm9yZSBmbGFreSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYwNDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGUgb3ZlciBieSBjaGFuZ2luZyB0aGUg b3JkZXIgaW4gd2hpY2ggd2UgYWdncmVnYXRlIHJlc3VsdHMuCisKKyAgICAgICAgKiBmYXN0L2hh cm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qczogQWRkZWQgYSB0ZXN0LgorICAgICAgICAq IGZhc3QvaGFybmVzcy9yZXN1bHRzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2hhcm5l c3MvcmVzdWx0cy5odG1sOgorCiAyMDExLTEwLTE0ICBDaGFuZyBTaHUgIDxjc2h1QHdlYmtpdC5v cmc+CiAKICAgICAgICAgW1F0XSBFbmFibGUgZnVsbHNjcmVlbiBhcGkgb24gUXQKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy1leHBlY3RlZC50eHQJKHJldmlzaW9u IDk3NDk5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMtZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC0xNTEsMyArMTUxLDcgQEAgVEVTVC0zMTogUEFTUwogVEVTVC0z MTogUEFTUwogVEVTVC0zMTogUEFTUwogVEVTVC0zMTogUEFTUworVEVTVC0zMjogUEFTUworVEVT VC0zMjogUEFTUworVEVTVC0zMjogUEFTUworVEVTVC0zMjogUEFTUwpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sCShyZXZpc2lvbiA5NzQ5OSkKKysrIExheW91dFRlc3Rz L2Zhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEwMzAsMTUgKzEw MzAsMTUgQEAgZnVuY3Rpb24gZ2VuZXJhdGVQYWdlKCkKICAgICBpZiAoZ2xvYmFsU3RhdGUoKS5y ZXN1bHRzLmludGVycnVwdGVkKQogICAgICAgICBodG1sICs9ICI8cCBjbGFzcz0nc3RvcHBlZC1y dW5uaW5nLWVhcmx5LW1lc3NhZ2UnPlRlc3RpbmcgZXhpdGVkIGVhcmx5LjwvcD4iCiAKKyAgICBp ZiAoZ2xvYmFsU3RhdGUoKS5jcmFzaFRlc3RzLmxlbmd0aCkKKyAgICAgICAgaHRtbCArPSB0ZXN0 TGlzdChnbG9iYWxTdGF0ZSgpLmNyYXNoVGVzdHMsICdUZXN0cyB0aGF0IGNyYXNoZWQnLCAnY3Jh c2gtdGVzdHMtdGFibGUnKTsKKwogICAgIGh0bWwgKz0gZmFpbGluZ1Rlc3RzVGFibGUoZ2xvYmFs U3RhdGUoKS5ub25GbGFreUZhaWxpbmdUZXN0cywKICAgICAgICAgJ1Rlc3RzIHdoZXJlIHJlc3Vs dHMgZGlkIG5vdCBtYXRjaCBleHBlY3RlZCByZXN1bHRzJywgJ3Jlc3VsdHMtdGFibGUnKTsKIAog ICAgIGh0bWwgKz0gZmFpbGluZ1Rlc3RzVGFibGUoZ2xvYmFsU3RhdGUoKS5mbGFreVRlc3RzLAog ICAgICAgICAnRmxha3kgdGVzdHMgKGZhaWxlZCB0aGUgZmlyc3QgcnVuIGFuZCBnb3QgYSBkaWZm ZXJlbnQgcmVzdWx0IG9uIHJldHJ5KScsICdmbGFreS10ZXN0cy10YWJsZScpOwogCi0gICAgaWYg KGdsb2JhbFN0YXRlKCkuY3Jhc2hUZXN0cy5sZW5ndGgpCi0gICAgICAgIGh0bWwgKz0gdGVzdExp c3QoZ2xvYmFsU3RhdGUoKS5jcmFzaFRlc3RzLCAnVGVzdHMgdGhhdCBjcmFzaGVkJywgJ2NyYXNo LXRlc3RzLXRhYmxlJyk7Ci0KICAgICBpZiAoZ2xvYmFsU3RhdGUoKS50aW1lb3V0VGVzdHMubGVu Z3RoKQogICAgICAgICBodG1sICs9IHRlc3RMaXN0KGdsb2JhbFN0YXRlKCkudGltZW91dFRlc3Rz LCAnVGVzdHMgdGhhdCB0aW1lZCBvdXQnLCAndGltZW91dC10ZXN0cy10YWJsZScpOwogCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVz dC5qcwkocmV2aXNpb24gOTc0OTkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3Vy Y2VzL3Jlc3VsdHMtdGVzdC5qcwkod29ya2luZyBjb3B5KQpAQCAtNDk1LDYgKzQ5NSwyMCBAQCBm dW5jdGlvbiBydW5UZXN0cygpCiAgICAgICAgIGFzc2VydFRydWUoZW5jbG9zaW5nTm9kZVdpdGhU YWdOYW1lSGFzQ2xhc3NOYW1lKHRlc3RMaW5rc1syXSwgJ3RhYmxlJywgJ2V4cGVjdGVkJykpOwog ICAgIH0pOwogCisgICAgcmVzdWx0cyA9IG1vY2tSZXN1bHRzKCk7CisgICAgdmFyIHN1YnRyZWUg PSByZXN1bHRzLnRlc3RzWydmb28nXSA9IHt9CisgICAgc3VidHJlZVsnYmFyLmh0bWwnXSA9IG1v Y2tFeHBlY3RhdGlvbignVEVYVCcsICdQQVNTJyk7CisgICAgc3VidHJlZVsnY3Jhc2guaHRtbCdd ID0gbW9ja0V4cGVjdGF0aW9uKCdJTUFHRScsICdDUkFTSCcpOworICAgIHN1YnRyZWVbJ2ZsYWt5 LWZhaWwuaHRtbCddID0gbW9ja0V4cGVjdGF0aW9uKCdQQVNTIFRFWFQnLCAnSU1BR0UgUEFTUycp OworICAgIHJ1blRlc3QocmVzdWx0cywgZnVuY3Rpb24oKSB7CisgICAgICAgIGFzc2VydFRydWUo IWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHRzLXRhYmxlJykpOworCisgICAgICAgIHZh ciByZXN1bHRUZXh0ID0gZG9jdW1lbnQuYm9keS50ZXh0Q29udGVudDsKKyAgICAgICAgYXNzZXJ0 VHJ1ZShyZXN1bHRUZXh0LmluZGV4T2YoJ2NyYXNoLmh0bWwnKSAhPSAtMSk7CisgICAgICAgIGFz c2VydFRydWUocmVzdWx0VGV4dC5pbmRleE9mKCdmbGFreS1mYWlsLmh0bWwnKSAhPSAtMSk7Cisg ICAgICAgIGFzc2VydFRydWUocmVzdWx0VGV4dC5pbmRleE9mKCdjcmFzaC5odG1sJykgPCByZXN1 bHRUZXh0LmluZGV4T2YoJ2ZsYWt5LWZhaWwuaHRtbCcpKTsKKyAgICB9KTsKKwogICAgIGRvY3Vt ZW50LmJvZHkuaW5uZXJIVE1MID0gJzxwcmU+JyArIGdfbG9nLmpvaW4oJ1xuJykgKyAnPC9wcmU+ JzsKIH0KIAo=