66030 2011-08-10 22:07:45 -0700 [Chromium] New windows opened in javascript are named "_blank" 2011-08-30 13:33:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 shinyak webkit-unassigned fishd japhet shinyak oldest_to_newest 449593 0 shinyak 2011-08-10 22:07:45 -0700 A window created in javascript like window.open('', '_blank') has name '_blank'. The name of the window should be empty. http://code.google.com/p/chromium/issues/detail?id=88129 449601 1 shinyak 2011-08-10 22:41:32 -0700 This is Chromium bug. http://code.google.com/p/chromium/issues/detail?id=88129 449619 2 103583 shinyak 2011-08-10 23:41:12 -0700 Created attachment 103583 Patch 450149 3 103583 japhet 2011-08-11 16:37:01 -0700 Comment on attachment 103583 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103583&action=review > Source/WebCore/ChangeLog:12 > + > + No new tests because this bug occurs only in Chromium. > + Please include a test if at all possible. Even port-specific bugs typically receive a new layout test, since other ports might regress this behavior at some point :) > Source/WebCore/loader/FrameLoader.cpp:3265 > + if (request.frameName() == "_blank") > + requestWithReferrer.setFrameName(""); This code isn't chromium-specific, so it seems odd that we're fixing this bug here. How do the other ports avoid reaching this point with frame mame of "_blank"? Is this a v8/jsc difference? It's possible this is the right place to fix the bug, but it would be good to understand what chromium is doing differently before committing to this solution. 451037 4 103904 shinyak 2011-08-15 05:14:33 -0700 Created attachment 103904 Patch 451041 5 103906 shinyak 2011-08-15 05:19:09 -0700 Created attachment 103906 Layout Test 451042 6 shinyak 2011-08-15 05:22:46 -0700 (In reply to comment #5) > Created an attachment (id=103906) [details] > Layout Test This bug occurs only in chromium. I don't know the reason but it did not occur in layout tests (even in chromium port...) So I would like to add tests on chromium side if permitted. 451905 7 japhet 2011-08-16 15:15:47 -0700 (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=103906) [details] [details] > > Layout Test > > This bug occurs only in chromium. > > I don't know the reason but it did not occur in layout tests (even in chromium port...) > So I would like to add tests on chromium side if permitted. So what has me curious is: why doesn't the check at http://trac.webkit.org/browser/trunk/Source/WebCore/loader/FrameLoader.cpp#L2854 prevent the frame name getting set to "_blank"? I think it might be because of http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/render_view.cc&exact_package=chromium&l=403 . Perhaps we should see if that fixes this issue, and whether it breaks anything else? 452837 8 fishd 2011-08-17 20:49:33 -0700 (In reply to comment #7) > I think it might be because of http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/render_view.cc&exact_package=chromium&l=403 . Perhaps we should see if that fixes this issue, and whether it breaks anything else? Oh, are you suggesting that maybe we should just delete that line of code in render_view.cc? That makes sense since TestShell and DRT don't have any code like that. Yeah, I bet you are correct that we could just remove that line of code. 453081 9 japhet 2011-08-18 09:14:46 -0700 (In reply to comment #8) > (In reply to comment #7) > > I think it might be because of http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/render_view.cc&exact_package=chromium&l=403 . Perhaps we should see if that fixes this issue, and whether it breaks anything else? > > Oh, are you suggesting that maybe we should just delete that line of code in render_view.cc? That makes sense since TestShell and DRT don't have any code like that. Yeah, I bet you are correct that we could just remove that line of code. Yeah, that is what I was suggesting, sorry if it wasn't sufficiently clear. I don't know whether that'll cause any problems for chromium, but it feels to me like render_view.cc is reaching into things that it shouldn't. 453661 10 shinyak 2011-08-18 23:06:14 -0700 Sorry if I miss the point. Do you mean removing the line from render_view.cc after adding this patch? If not so, could you inform me more precise direction? I would like to do that. (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > I think it might be because of http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/render_view.cc&exact_package=chromium&l=403 . Perhaps we should see if that fixes this issue, and whether it breaks anything else? > > > > Oh, are you suggesting that maybe we should just delete that line of code in render_view.cc? That makes sense since TestShell and DRT don't have any code like that. Yeah, I bet you are correct that we could just remove that line of code. > > Yeah, that is what I was suggesting, sorry if it wasn't sufficiently clear. > > I don't know whether that'll cause any problems for chromium, but it feels to me like render_view.cc is reaching into things that it shouldn't. 453852 11 japhet 2011-08-19 08:50:46 -0700 (In reply to comment #10) > Sorry if I miss the point. > Do you mean removing the line from render_view.cc after adding this patch? > > If not so, could you inform me more precise direction? I would like to do that. > I was thinking that just removing those 2 lines from render_view.cc (and not modifying ChromeClientImpl.cpp) might fix the problem. (I could be wrong, of course) :) 453868 12 fishd 2011-08-19 09:11:14 -0700 I suspect that Nate is correct. That might be all it takes to fix this bug. 458272 13 fishd 2011-08-29 10:37:05 -0700 Can we close this bug given that the solution is happening on the Chromium side? 458643 14 shinyak 2011-08-29 18:50:22 -0700 (In reply to comment #13) > Can we close this bug given that the solution is happening on the Chromium side? I think so. 103583 2011-08-10 23:41:12 -0700 2011-08-15 05:14:26 -0700 Patch bug-66030-20110811154110.patch text/plain 1831 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZWI3ZmM5ZTQxYTRjOGE3 OGE4OWQxNDljMjZlYTljMjNjOWQ3NzVjLi4xYTU5ZTIwZDgxNzc0ZjFlZTQ3ZjcyN2YzNWFlZTgz ZjBjYzY0NWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMTAgIFNoaW55 YSBLYXdhbmFrYSAgPHNoaW55YWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21pdW1dIElm IHRoZSBmcmFtZSBuYW1lIGlzICdfYmxhbmsnLCB0aGUgbmFtZSBzaG91bGQgYmUgY2hhbmdlZCB0 byBlbXB0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY2MDMwCisKKyAgICAgICAgV2hlbiB0aGUgd2luZG93IG5hbWUgaXMgJ19ibGFuaycsIGl0IHNo b3VsZCBub3QgYmUgdXNlZCBpbiBGcmFtZUxvYWRSZXF1ZXN0LgorICAgICAgICBUaGUgcHJldmlv dXMgY29kZSBpbmNvbnNpc3RlbnRseSBzZXRzIGZyYW1lTmFtZSBhbmQgYmUgZXJyb3ItcHJvbmUu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIGJlY2F1c2UgdGhpcyBidWcgb2NjdXJzIG9ubHkgaW4gQ2hyb21pdW0uCisKKyAgICAg ICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlV2lu ZG93KToKKyAgICAgICAgICAgSWYgdGhlIGZyYW1lIG5hbWUgaXMgJ19ibGFuaycsIGFuIGVtcHR5 IG5hbWVkIGlzIHVzZWQgaW5zdGVhZC4KKwogMjAxMS0wOC0xMCAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBTVkdBRWxlbWVudCBjaGVjayBmb3IgaW50 ZXJuYWwgbm9uLXZpZXcgYW5jaG9ycyBpcyBpbnNpZGUgRU5BQkxFKFNWR19BTklNQVRJT04pCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBlNWM5OGRiM2E5NTYzMTcwZjdh YjMyOTBiNzkzZTlkNzdkODk5NmQ0Li43ZjJlOTY1M2ZkNzU1ZWUwNWM5MmMyODExNzAyMzNiODA1 MTU5Y2U1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTMyNjEsNiAr MzI2MSw4IEBAIEZyYW1lKiBjcmVhdGVXaW5kb3coRnJhbWUqIG9wZW5lckZyYW1lLCBGcmFtZSog bG9va3VwRnJhbWUsIGNvbnN0IEZyYW1lTG9hZFJlcXVlCiAgICAgRnJhbWVMb2FkUmVxdWVzdCBy ZXF1ZXN0V2l0aFJlZmVycmVyID0gcmVxdWVzdDsKICAgICByZXF1ZXN0V2l0aFJlZmVycmVyLnJl c291cmNlUmVxdWVzdCgpLnNldEhUVFBSZWZlcnJlcihvcGVuZXJGcmFtZS0+bG9hZGVyKCktPm91 dGdvaW5nUmVmZXJyZXIoKSk7CiAgICAgRnJhbWVMb2FkZXI6OmFkZEhUVFBPcmlnaW5JZk5lZWRl ZChyZXF1ZXN0V2l0aFJlZmVycmVyLnJlc291cmNlUmVxdWVzdCgpLCBvcGVuZXJGcmFtZS0+bG9h ZGVyKCktPm91dGdvaW5nT3JpZ2luKCkpOworICAgIGlmIChyZXF1ZXN0LmZyYW1lTmFtZSgpID09 ICJfYmxhbmsiKQorICAgICAgICByZXF1ZXN0V2l0aFJlZmVycmVyLnNldEZyYW1lTmFtZSgiIik7 CiAKICAgICBQYWdlKiBvbGRQYWdlID0gb3BlbmVyRnJhbWUtPnBhZ2UoKTsKICAgICBpZiAoIW9s ZFBhZ2UpCg== 103904 2011-08-15 05:14:33 -0700 2011-08-29 06:03:05 -0700 Patch bug-66030-20110815211432.patch text/plain 1688 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogOTMwMzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZjA1NDIwYzhmNTYyNDExZDc1MjQ5ZmJlODEyNmFjYjkyNDk5MmMzOC4uNzc3YmE1ZTJmYWI1ZWVh OTgxNWQ5YWEwMDU1YmQxMTBlMTBjMTVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0xNSAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0Bnb29n bGUuY29tPgorCisgICAgICAgIEEgd2luZG93IG9wZW5lZCBpbiBqYXZhc2NyaXB0IGFyZSBuYW1l ZCAnX2JsYW5rJy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY2MDMwCisKKyAgICAgICAgQ2hlY2tzIGZyYW1lIG5hbWUgbm90IHRvIHNldCB3aW5kb3cg bmFtZSAnX2JsYW5rJworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJv bWVDbGllbnRJbXBsOjpjcmVhdGVXaW5kb3cpOiBDaGVja3MgZnJhbWUgbmFtZS4KKwogMjAxMS0w OC0xMiAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZWZh Y3RvcmluZyBvZiBQb3B1cE1lbnVDaHJvbWl1bSBGb3IgUmVhZGFiaWxpdHkgYW5kIE1haW50YWlu YWJpbGl0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xp ZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBs LmNwcAppbmRleCAwYjIxYzliOWYzZDk0NWVjYmI1NWQ4NTM1YmE5N2FmZTRiYzM0MDZkLi43ZGIz Y2Q4MTJjZDA2OWI0MGQ3NDc1YjBiNzlkZWQ0Mzk2YzEzZDgzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtMjc2LDggKzI3Niw5IEBA IFBhZ2UqIENocm9tZUNsaWVudEltcGw6OmNyZWF0ZVdpbmRvdygKICAgICBXcmFwcGVkUmVzb3Vy Y2VSZXF1ZXN0IHJlcXVlc3Q7CiAgICAgaWYgKCFyLnJlc291cmNlUmVxdWVzdCgpLmlzRW1wdHko KSkKICAgICAgICAgcmVxdWVzdC5iaW5kKHIucmVzb3VyY2VSZXF1ZXN0KCkpOworICAgIFN0cmlu ZyBmcmFtZU5hbWUgPSByLmZyYW1lTmFtZSgpID09ICJfYmxhbmsiID8gU3RyaW5nKCkgOiByLmZy YW1lTmFtZSgpOwogICAgIFdlYlZpZXdJbXBsKiBuZXdWaWV3ID0gc3RhdGljX2Nhc3Q8V2ViVmll d0ltcGwqPigKLSAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+Y3JlYXRlVmlldyhXZWJGcmFt ZUltcGw6OmZyb21GcmFtZShmcmFtZSksIHJlcXVlc3QsIGZlYXR1cmVzLCByLmZyYW1lTmFtZSgp KSk7CisgICAgICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmNyZWF0ZVZpZXcoV2ViRnJhbWVJbXBs Ojpmcm9tRnJhbWUoZnJhbWUpLCByZXF1ZXN0LCBmZWF0dXJlcywgZnJhbWVOYW1lKSk7CiAgICAg aWYgKCFuZXdWaWV3KQogICAgICAgICByZXR1cm4gMDsKIAo= 103906 2011-08-15 05:19:09 -0700 2011-08-15 05:19:09 -0700 Layout Test test.diff application/octet-stream 1105 shinyak ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3dpbmRvdy1uYW1lLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3dpbmRvdy1uYW1lLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5iN2FjZTNiCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvd2luZG93LW5hbWUtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsNSBAQAorUEFTUyB3Lm5hbWUgaXMgJycKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2xvYWRlci93aW5kb3ctbmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvd2luZG93 LW5hbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jMzc2NWY5Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvd2luZG93LW5hbWUuaHRt bApAQCAtMCwwICsxLDIzIEBACis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNv bnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgoraWYgKGxheW91dFRlc3RDb250cm9sbGVyKSB7Cisg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0Q2FuT3BlbldpbmRvd3MoKTsKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5zZXRDbG9zZVJlbWFpbmluZ1dpbmRvd3NXaGVuQ29tcGxldGUoKTsKK30K KwordmFyIHcgPSB3aW5kb3cub3BlbignJywgJ19ibGFuaycpOworc2hvdWxkQmUoIncubmFtZSIs ICInJyIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNj cmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3Jp cHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==