66028 2011-08-10 19:16:32 -0700 [EFL] Change condition checking logic related with both change of position and offset for backing store. 2011-08-19 08:19:50 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 hyuki.kim webkit-unassigned antognolli+webkit aroben gyuyoung.kim gyuyoung.kim leandro lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 449560 0 hyuki.kim 2011-08-10 19:16:32 -0700 As backing store's position and offset change can be occurred at the same time, the checking of offset change shouldn't be a "else if" statement. 449561 1 103569 hyuki.kim 2011-08-10 19:17:55 -0700 Created attachment 103569 Patch, 449562 2 webkit.review.bot 2011-08-10 19:20:20 -0700 Attachment 103569 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 449564 3 103571 hyuki.kim 2011-08-10 19:26:08 -0700 Created attachment 103571 Patch, 450415 4 103571 leandro 2011-08-12 07:05:33 -0700 Comment on attachment 103571 Patch, Informal r+. 452042 5 gyuyoung.kim 2011-08-16 18:05:38 -0700 LGTM also. 453762 6 103571 aroben 2011-08-19 05:30:21 -0700 Comment on attachment 103571 Patch, View in context: https://bugs.webkit.org/attachment.cgi?id=103571&action=review > Source/WebKit/efl/ChangeLog:7 > + As backing store's position and offset change can be occurred at the same time, > + the checking of offset change shouldn't be a "else if" statement. "can be occurred" should just be "can occur". 'a "else if"' should be 'an "else if"'. 453764 7 104494 hyuki.kim 2011-08-19 05:42:43 -0700 Created attachment 104494 Patch. 453783 8 hyuki.kim 2011-08-19 06:21:08 -0700 >"can be occurred" should just be "can occur". >'a "else if"' should be 'an "else if"'. Patched. :-) Thank you for your review again. 453838 9 104494 webkit.review.bot 2011-08-19 08:19:45 -0700 Comment on attachment 104494 Patch. Clearing flags on attachment: 104494 Committed r93409: <http://trac.webkit.org/changeset/93409> 453839 10 webkit.review.bot 2011-08-19 08:19:50 -0700 All reviewed patches have been landed. Closing bug. 103569 2011-08-10 19:17:55 -0700 2011-08-10 19:26:08 -0700 Patch, 0811_pos_and_offset.patch text/plain 1581 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiNWEzMmUyLi4xYzk1N2UxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTAgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ2hhbmdlIGNvbmRpdGlvbiBjaGVja2luZyBsb2dp YyByZWxhdGVkIHdpdGggYm90aCBjaGFuZ2Ugb2YgcG9zaXRpb24gYW5kIG9mZnNldCBmb3IgYmFj a2luZyBzdG9yZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPXh4eHh4CisKKyAgICAgICAgQXMgYmFja2luZyBzdG9yZSdzIHBvc2l0aW9uIGFuZCBvZmZz ZXQgY2hhbmdlIGNhbiBiZSBvY2N1cnJlZCBhdCB0aGUgc2FtZSB0aW1lLAorICAgICAgICB0aGUg Y2hlY2tpbmcgb2Ygb2Zmc2V0IGNoYW5nZSBzaG91bGRuJ3QgYmUgYSAiZWxzZSBpZiIgc3RhdGVt ZW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmM6CisgICAgICAgIChfZXdrX3RpbGVkX2JhY2tp bmdfc3RvcmVfc21hcnRfY2FsY3VsYXRlKToKKwogMjAxMS0wOC0xMCAgR3J6ZWdvcnogQ3phamtv d3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBSZXR1cm4g ZnJvbSBfZXdrX3ZpZXdfc21hcnRfYWRkIGlmIHNtYXJ0IGRhdGEgY2FuIG5vdCBiZSBhbGxvY2F0 ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19z dG9yZS5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMK aW5kZXggMjVjYzEyYy4uNDY4NjQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9iYWNraW5nX3N0b3JlLmMKQEAgLTEzMzgsNyArMTMzOCw4IEBAIHN0YXRpYyB2b2lk IF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9zbWFydF9jYWxjdWxhdGUoRXZhc19PYmplY3QgKm8p CiAgICAgaWYgKHByaXYtPmNoYW5nZWQucG9zICYmIChwcml2LT52aWV3LnggIT0geCB8fCBwcml2 LT52aWV3LnkgIT0geSkpIHsKICAgICAgICAgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX3NtYXJ0 X2NhbGN1bGF0ZV9wb3MocHJpdiwgeCwgeSk7CiAgICAgICAgIHByaXYtPmNoYW5nZWQucG9zID0g RUlOQV9GQUxTRTsKLSAgICB9IGVsc2UgaWYgKHByaXYtPmNoYW5nZWQub2Zmc2V0KSB7CisgICAg fQorICAgIGlmIChwcml2LT5jaGFuZ2VkLm9mZnNldCkgewogICAgICAgICBfZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmVfc21hcnRfY2FsY3VsYXRlX29mZnNldChwcml2LCB4LCB5KTsKICAgICAgICAg cHJpdi0+Y2hhbmdlZC5vZmZzZXQgPSBFSU5BX0ZBTFNFOwogICAgIH0K 103571 2011-08-10 19:26:08 -0700 2011-08-19 05:42:43 -0700 Patch, 0811_pos_and_offset_2.patch text/plain 1581 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiNWEzMmUyLi44NDU3MjM5IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTAgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ2hhbmdlIGNvbmRpdGlvbiBjaGVja2luZyBsb2dp YyByZWxhdGVkIHdpdGggYm90aCBjaGFuZ2Ugb2YgcG9zaXRpb24gYW5kIG9mZnNldCBmb3IgYmFj a2luZyBzdG9yZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY2MDI4CisKKyAgICAgICAgQXMgYmFja2luZyBzdG9yZSdzIHBvc2l0aW9uIGFuZCBvZmZz ZXQgY2hhbmdlIGNhbiBiZSBvY2N1cnJlZCBhdCB0aGUgc2FtZSB0aW1lLAorICAgICAgICB0aGUg Y2hlY2tpbmcgb2Ygb2Zmc2V0IGNoYW5nZSBzaG91bGRuJ3QgYmUgYSAiZWxzZSBpZiIgc3RhdGVt ZW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmM6CisgICAgICAgIChfZXdrX3RpbGVkX2JhY2tp bmdfc3RvcmVfc21hcnRfY2FsY3VsYXRlKToKKwogMjAxMS0wOC0xMCAgR3J6ZWdvcnogQ3phamtv d3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBSZXR1cm4g ZnJvbSBfZXdrX3ZpZXdfc21hcnRfYWRkIGlmIHNtYXJ0IGRhdGEgY2FuIG5vdCBiZSBhbGxvY2F0 ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19z dG9yZS5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMK aW5kZXggMjVjYzEyYy4uNDY4NjQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9iYWNraW5nX3N0b3JlLmMKQEAgLTEzMzgsNyArMTMzOCw4IEBAIHN0YXRpYyB2b2lk IF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9zbWFydF9jYWxjdWxhdGUoRXZhc19PYmplY3QgKm8p CiAgICAgaWYgKHByaXYtPmNoYW5nZWQucG9zICYmIChwcml2LT52aWV3LnggIT0geCB8fCBwcml2 LT52aWV3LnkgIT0geSkpIHsKICAgICAgICAgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX3NtYXJ0 X2NhbGN1bGF0ZV9wb3MocHJpdiwgeCwgeSk7CiAgICAgICAgIHByaXYtPmNoYW5nZWQucG9zID0g RUlOQV9GQUxTRTsKLSAgICB9IGVsc2UgaWYgKHByaXYtPmNoYW5nZWQub2Zmc2V0KSB7CisgICAg fQorICAgIGlmIChwcml2LT5jaGFuZ2VkLm9mZnNldCkgewogICAgICAgICBfZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmVfc21hcnRfY2FsY3VsYXRlX29mZnNldChwcml2LCB4LCB5KTsKICAgICAgICAg cHJpdi0+Y2hhbmdlZC5vZmZzZXQgPSBFSU5BX0ZBTFNFOwogICAgIH0K 104494 2011-08-19 05:42:43 -0700 2011-08-19 08:19:45 -0700 Patch. 0811_pos_and_offset_3.patch text/plain 1553 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwMjZjYTI1Li5hYjNlYjgxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTkgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ2hhbmdlIGNvbmRpdGlvbiBjaGVja2luZyBsb2dp YyByZWxhdGVkIHdpdGggYm90aCBjaGFuZ2Ugb2YgcG9zaXRpb24gYW5kIG9mZnNldCBmb3IgYmFj a2luZyBzdG9yZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY2MDI4CisKKyAgICAgICAgQXMgYmFja2luZyBzdG9yZSdzIHBvc2l0aW9uIGFuZCBvZmZz ZXQgY2hhbmdlIGNhbiBvY2N1ciBhdCB0aGUgc2FtZSB0aW1lLAorICAgICAgICB0aGUgY2hlY2tp bmcgb2Ygb2Zmc2V0IGNoYW5nZSBzaG91bGRuJ3QgYmUgImVsc2UgaWYiIHN0YXRlbWVudC4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGV3ay9ld2tf dGlsZWRfYmFja2luZ19zdG9yZS5jOgorICAgICAgICAoX2V3a190aWxlZF9iYWNraW5nX3N0b3Jl X3NtYXJ0X2NhbGN1bGF0ZSk6CisKIDIwMTEtMDgtMTggIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9p QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEJyb2tlbiByZW5kZXJpbmcgb2NjdXJlZCB3 aGVuIHJlc2l6ZWQgaW4gZXdrX3ZpZXdfc2luZ2xlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYwppbmRleCAyNWNjMTJjLi40Njg2NDBmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYwor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYwpAQCAt MTMzOCw3ICsxMzM4LDggQEAgc3RhdGljIHZvaWQgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX3Nt YXJ0X2NhbGN1bGF0ZShFdmFzX09iamVjdCAqbykKICAgICBpZiAocHJpdi0+Y2hhbmdlZC5wb3Mg JiYgKHByaXYtPnZpZXcueCAhPSB4IHx8IHByaXYtPnZpZXcueSAhPSB5KSkgewogICAgICAgICBf ZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfc21hcnRfY2FsY3VsYXRlX3Bvcyhwcml2LCB4LCB5KTsK ICAgICAgICAgcHJpdi0+Y2hhbmdlZC5wb3MgPSBFSU5BX0ZBTFNFOwotICAgIH0gZWxzZSBpZiAo cHJpdi0+Y2hhbmdlZC5vZmZzZXQpIHsKKyAgICB9CisgICAgaWYgKHByaXYtPmNoYW5nZWQub2Zm c2V0KSB7CiAgICAgICAgIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9zbWFydF9jYWxjdWxhdGVf b2Zmc2V0KHByaXYsIHgsIHkpOwogICAgICAgICBwcml2LT5jaGFuZ2VkLm9mZnNldCA9IEVJTkFf RkFMU0U7CiAgICAgfQo=