66022 2011-08-10 17:07:15 -0700 Only set m_fontDirty if TextSizeAdjust is actually changed. 2011-08-17 16:10:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson darin macpherson mitz simon.fraser webkit.review.bot oldest_to_newest 449501 0 macpherson 2011-08-10 17:07:15 -0700 Only set m_fontDirty if TextSizeAdjust is actually changed. 449509 1 103562 macpherson 2011-08-10 17:13:21 -0700 Created attachment 103562 Patch 451958 2 macpherson 2011-08-16 16:21:56 -0700 Weekly ping. Please review this patch! 452299 3 103562 darin 2011-08-17 09:46:22 -0700 Comment on attachment 103562 Patch Is there some way to test the performance benefit here? Maybe we could do a performance test that checks that changing the value back and forth and forcing style recalculation is significantly slower than setting the value to the same thing over and over again. It would be great to have a test like that! 452350 4 103562 webkit.review.bot 2011-08-17 10:45:58 -0700 Comment on attachment 103562 Patch Clearing flags on attachment: 103562 Committed r93218: <http://trac.webkit.org/changeset/93218> 452351 5 webkit.review.bot 2011-08-17 10:46:02 -0700 All reviewed patches have been landed. Closing bug. 452677 6 macpherson 2011-08-17 16:10:55 -0700 Even if this were slower I think it would be worth doing. When I first started touching the m_fontDirtry logic it was really because I wanted it to not be spread all over the place, because I figured it would be too easy to accidentally not set m_fontDirty. It still is, but at least the logic is constrained to fewer places. Thanks for the review! 103562 2011-08-10 17:13:21 -0700 2011-08-17 10:45:57 -0700 Patch bug-66022-20110811101319.patch text/plain 3869 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyODAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDgtMTAgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBPbmx5IHNldCBt X2ZvbnREaXJ0eSBpZiBUZXh0U2l6ZUFkanVzdCBpcyBhY3R1YWxseSBjaGFuZ2VkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYwMjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFJl ZmFjdG9yaW5nIG9ubHkuCisKKyAgICAgICAgUmVkdWNlcyBpbnN0YW5jZXMgd2hlcmUgdGhlIGZv bnQgaW5mb3JtYXRpb24gaXMgZGlydGllZCB0byBzYXZlIHJlY2FsY3VsYXRpb24gd2hlcmUgaXQg aXMgbm90IG5lY2Vzc2FyeS4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOgorICAg ICAgICBDYWxsIG5ldyBzZXRUZXh0U2l6ZUFkanVzdCBmdW5jdGlvbi4KKyAgICAgICAgKiBjc3Mv Q1NTU3R5bGVTZWxlY3Rvci5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6 c2V0VGV4dFNpemVBZGp1c3QpOgorICAgICAgICBBZGQgd3JhcHBlciBmb3IgUmVuZGVyU3R5bGU6 OnNldFRleHRTaXplQWRqdXN0KCkgdGhhdCBhdXRvbWF0aWNhbGx5IHVwZGF0ZXMgbV9mb250RGly dHkuCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJTdHlsZTo6c2V0VGV4dFNpemVBZGp1c3QpOgorICAgICAgICBNYWtlIHNl dFRleHRTaXplQWRqdXN0IHJldHVybiB0cnVlIGlmIHRoZSB1bmxkZXJseWluZyB2YWx1ZSB3YXMg Y2hhbmdlZC4KKwogMjAxMS0wOC0xMCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIENoZWNrIHRoYXQgd2UgZG8gbm90IG5lZWQgbGF5b3V0IGJlZm9yZSB0 cnlpbmcgdG8gZGlydHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5j cHAJKHJldmlzaW9uIDkyODAxKQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0 b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Nzc0LDkgKzQ3NzQsOSBAQCB2b2lkIENTU1N0eWxl U2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAgICAgICAgIHJldHVybjsKICAgICBjYXNlIENT U1Byb3BlcnR5V2Via2l0VGV4dFNpemVBZGp1c3Q6IHsKICAgICAgICAgSEFORExFX0lOSEVSSVRf QU5EX0lOSVRJQUwodGV4dFNpemVBZGp1c3QsIFRleHRTaXplQWRqdXN0KQotICAgICAgICBpZiAo IXByaW1pdGl2ZVZhbHVlIHx8ICFwcmltaXRpdmVWYWx1ZS0+Z2V0SWRlbnQoKSkgcmV0dXJuOwot ICAgICAgICBtX3N0eWxlLT5zZXRUZXh0U2l6ZUFkanVzdChwcmltaXRpdmVWYWx1ZS0+Z2V0SWRl bnQoKSA9PSBDU1NWYWx1ZUF1dG8pOwotICAgICAgICBtX2ZvbnREaXJ0eSA9IHRydWU7CisgICAg ICAgIGlmICghcHJpbWl0aXZlVmFsdWUgfHwgIXByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpKQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBzZXRUZXh0U2l6ZUFkanVzdChwcmltaXRpdmVW YWx1ZS0+Z2V0SWRlbnQoKSA9PSBDU1NWYWx1ZUF1dG8pOwogICAgICAgICByZXR1cm47CiAgICAg fQogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0U2VjdXJpdHk6CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmgJKHJldmlzaW9uIDkyODAxKQorKysgU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTE4LDYgKzEx OCw3IEBAIHB1YmxpYzoKICAgICAgICAgdm9pZCBzZXRGb250RGVzY3JpcHRpb24oRm9udERlc2Ny aXB0aW9uIGZvbnREZXNjcmlwdGlvbikgeyBtX2ZvbnREaXJ0eSB8PSBzdHlsZSgpLT5zZXRGb250 RGVzY3JpcHRpb24oZm9udERlc2NyaXB0aW9uKTsgfQogICAgICAgICB2b2lkIHNldFpvb20oZmxv YXQgZikgeyBtX2ZvbnREaXJ0eSB8PSBzdHlsZSgpLT5zZXRab29tKGYpOyB9CiAgICAgICAgIHZv aWQgc2V0RWZmZWN0aXZlWm9vbShmbG9hdCBmKSB7IG1fZm9udERpcnR5IHw9IHN0eWxlKCktPnNl dEVmZmVjdGl2ZVpvb20oZik7IH0KKyAgICAgICAgdm9pZCBzZXRUZXh0U2l6ZUFkanVzdChib29s IGIpIHsgbV9mb250RGlydHkgfD0gc3R5bGUoKS0+c2V0VGV4dFNpemVBZGp1c3QoYik7IH0KIAog ICAgIHByaXZhdGU6CiAgICAgICAgIHZvaWQgaW5pdEZvclN0eWxlUmVzb2x2ZShFbGVtZW50Kiwg UmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlID0gMCwgUHNldWRvSWQgPSBOT1BTRVVETyk7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAkocmV2aXNp b24gOTI4MDEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUu aAkod29ya2luZyBjb3B5KQpAQCAtMTE0OSw3ICsxMTQ5LDcgQEAgcHVibGljOgogCiAgICAgdm9p ZCBzZXRMaW5lQm94Q29udGFpbihMaW5lQm94Q29udGFpbiBjKSB7IFNFVF9WQVIocmFyZUluaGVy aXRlZERhdGEsIG1fbGluZUJveENvbnRhaW4sIGMpOyB9CiAgICAgdm9pZCBzZXRMaW5lQ2xhbXAo TGluZUNsYW1wVmFsdWUgYykgeyBTRVRfVkFSKHJhcmVOb25Jbmhlcml0ZWREYXRhLCBsaW5lQ2xh bXAsIGMpOyB9Ci0gICAgdm9pZCBzZXRUZXh0U2l6ZUFkanVzdChib29sIGIpIHsgU0VUX1ZBUihy YXJlSW5oZXJpdGVkRGF0YSwgdGV4dFNpemVBZGp1c3QsIGIpOyB9CisgICAgYm9vbCBzZXRUZXh0 U2l6ZUFkanVzdChib29sKTsKICAgICB2b2lkIHNldFRleHRTZWN1cml0eShFVGV4dFNlY3VyaXR5 IGFUZXh0U2VjdXJpdHkpIHsgU0VUX1ZBUihyYXJlSW5oZXJpdGVkRGF0YSwgdGV4dFNlY3VyaXR5 LCBhVGV4dFNlY3VyaXR5KTsgfQogCiAjaWYgRU5BQkxFKFNWRykKQEAgLTE0NDEsNiArMTQ0MSwx NCBAQCBpbmxpbmUgYm9vbCBSZW5kZXJTdHlsZTo6c2V0RWZmZWN0aXZlWm9vCiAgICAgcmV0dXJu IHRydWU7CiB9CiAKK2lubGluZSBib29sIFJlbmRlclN0eWxlOjpzZXRUZXh0U2l6ZUFkanVzdChi b29sIGIpCit7CisgICAgaWYgKGNvbXBhcmVFcXVhbChyYXJlSW5oZXJpdGVkRGF0YS0+dGV4dFNp emVBZGp1c3QsIGIpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmFyZUluaGVyaXRlZERh dGEuYWNjZXNzKCktPnRleHRTaXplQWRqdXN0ID0gYjsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gUmVuZGVyU3R5bGVfaAo=