66013 2011-08-10 14:43:26 -0700 [chromium] Add WebThread to WebKitClient 2011-08-12 09:29:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca fishd nduca oldest_to_newest 449406 0 nduca 2011-08-10 14:43:26 -0700 [chromium] Add WebThread to WebKitClient 449407 1 103536 nduca 2011-08-10 14:44:35 -0700 Created attachment 103536 Patch 449417 2 103536 fishd 2011-08-10 14:56:44 -0700 Comment on attachment 103536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103536&action=review > Source/WebKit/chromium/public/WebKitClient.h:182 > + virtual WebThread* createThread(const char* name) { return 0; } nit: probably best to avoid mentioning Chrome specific implementation details like messageloop. it also seems like this documentation, if we were to have it, would be better on the WebThread interface. here, you might just say "Creates an embedder defined thread." Also, the "createFoo" function naming convention in the WebKit API implies that the caller will have to manage the lifetime of the returned object and know to delete it when they are done with it. you probably want to document that upon deletion of a WebThread, all pending tasks will be run before the thread is terminated. this documentation should probably be in WebThread.h. > Source/WebKit/chromium/public/WebKitClient.h:183 > + nit: two new lines between sections. > Source/WebKit/chromium/public/WebThread.h:32 > +// Provides an interface to a message loop. Deleting the message loop blocks s/message loop/thread/. s/until the message loop drains/until all pending, non-deferred tasks have been run/. do we care that the context pointed to by a delayed task will leak? would it be helpful to also provide a context_dtor function? we might struggle to support this on the chrome side. 449551 3 nduca 2011-08-10 18:36:05 -0700 > do we care that the context pointed to by a delayed task will leak? would it be helpful > to also provide a context_dtor function? we might struggle to support this on the > chrome side. Ergh, great point. Howabout... class WebThread { public: class Task { public: virtual ~Task() { } virtual void performTask() = 0; }; void postTask(Task*) = 0; void postDelayedTask(Task*) = 0; } 449566 4 103572 nduca 2011-08-10 20:14:49 -0700 Created attachment 103572 Pass tasks not fnptrs. 450303 5 103572 fishd 2011-08-11 22:48:54 -0700 Comment on attachment 103572 Pass tasks not fnptrs. View in context: https://bugs.webkit.org/attachment.cgi?id=103572&action=review > Source/WebKit/chromium/public/WebKitClient.h:182 > + nit: insert an extra new line here to preserve spacing between sections > Source/WebKit/chromium/public/WebThread.h:34 > +// Deleting the thread blocks until all pending, non-deferred tasks have been nit: deferred -> delayed (to use the same jargon as the method name) > Source/WebKit/chromium/public/WebThread.h:41 > + virtual void performTask() = 0; maybe: s/performTask/run/ or just "perform" since it would be task->perform() (the extra "task" in the function name seems a bit redundant)? 450465 6 nduca 2011-08-12 09:29:37 -0700 Committed r92965: <http://trac.webkit.org/changeset/92965> 103536 2011-08-10 14:44:35 -0700 2011-08-10 20:14:45 -0700 Patch bug-66013-20110810144434.patch text/plain 3910 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTI2ODcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg Y2E4Zjc1MjMyZTliMDQ1MzBjMTBjZmQ4NTRhMTA2NDlhYWI1NWE4ZC4uZWY0MWNjNmIxOGRiZWRk NWJlNTkwMTQ2MmQ4YWM2MDE3MjczODBmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0xMCAgTmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgV2ViVGhyZWFkIHRvIFdlYktpdENsaWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYwMTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJL aXRDbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViS2l0Q2xpZW50OjpjcmVhdGVUaHJlYWQp OgorICAgICAgICAqIHB1YmxpYy9XZWJUaHJlYWQuaDogQWRkZWQuCisgICAgICAgIChXZWJLaXQ6 OldlYlRocmVhZDo6fldlYlRocmVhZCk6CisKIDIwMTEtMDgtMDkgIEpvY2hlbiBFaXNpbmdlciAg PGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSByZW1vdmUgdGVtcG9y YXJ5ICNkZWZpbmUgZnJvbSBXZWJVUkxSZXF1ZXN0LmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViS2l0Q2xpZW50LmgKaW5kZXggMjAxM2VjMmFhOWJhNGUwN2NkN2Y4MzVlNmFh NDQ2MWQ3ZWNmYzkwNS4uMzA2NzgwNDlkNmNmZDJiNjFiNjBlZDViNzdiNjY1MmJhMzNmZDQ0ZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Q2xpZW50LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Q2xpZW50LmgKQEAgLTcw LDYgKzcwLDcgQEAgY2xhc3MgV2ViU2hhcmVkV29ya2VyUmVwb3NpdG9yeTsKIGNsYXNzIFdlYlNv Y2tldFN0cmVhbUhhbmRsZTsKIGNsYXNzIFdlYlN0b3JhZ2VOYW1lc3BhY2U7CiBjbGFzcyBXZWJU aGVtZUVuZ2luZTsKK2NsYXNzIFdlYlRocmVhZDsKIGNsYXNzIFdlYlVSTExvYWRlcjsKIAogY2xh c3MgV2ViS2l0Q2xpZW50IHsKQEAgLTE3NCw2ICsxNzUsMTIgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgc2l6ZV90IGFjdHVhbE1lbW9yeVVzYWdlTUIoKSB7IHJldHVybiAwOyB9CiAKIAorICAgIC8v IFRocmVhZHMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQorCisgICAgLy8gQ3JlYXRlcyBhIG5ldyBtZXNzYWdlbG9vcC1iYXNlZCB0aHJlYWQu IENhbGxlciBpcyByZXNwb25zaWJsZSBmb3IKKyAgICAvLyBtYW5hZ2luZyB0aGUgcmV0dXJuZWQg dGhyZWFkLgorICAgIHZpcnR1YWwgV2ViVGhyZWFkKiBjcmVhdGVUaHJlYWQoY29uc3QgY2hhciog bmFtZSkgeyByZXR1cm4gMDsgfQorCiAgICAgLy8gTWVzc2FnZSBQb3J0cyAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKICAgICAvLyBDcmVh dGVzIGEgTWVzc2FnZSBQb3J0IENoYW5uZWwuICBUaGlzIGNhbiBiZSBjYWxsZWQgb24gYW55IHRo cmVhZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlRocmVh ZC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVGhyZWFkLmgKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uNGM5YTI1OWEwNDRjZWE3NDE4MWQ3MzNjMjY2Y2VhMjU4ZTZmYTMzNwotLS0gL2Rldi9udWxs CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlRocmVhZC5oCkBAIC0wLDAg KzEsNDUgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1p dHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoK KyAqCisgKiAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRo ZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiAgUmVkaXN0cmlidXRpb25zIGlu IGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCisgKiAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHBy b3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBS T1ZJREVEIEJZIEFQUExFIEFORCBJVFMgQ09OVFJJQlVUT1JTICJBUyBJUyIgQU5EIEFOWQorICog RVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVE IFRPLCBUSEUgSU1QTElFRAorICogV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorICogRElTQ0xBSU1FRC4gSU4gTk8g RVZFTlQgU0hBTEwgQVBQTEUgT1IgSVRTIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWQor ICogRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBD T05TRVFVRU5USUFMIERBTUFHRVMKKyAqIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywg UFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyAqIExPU1MgT0Yg VVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIg Q0FVU0VEIEFORAorICogT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09O VFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5D RSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRgorICog VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI IERBTUFHRS4KKyAqLworI2lmbmRlZiBXZWJUaHJlYWRfaAorI2RlZmluZSBXZWJUaHJlYWRfaAor CisjaW5jbHVkZSAiV2ViQ29tbW9uLmgiCisKK25hbWVzcGFjZSBXZWJLaXQgeworCisvLyBQcm92 aWRlcyBhbiBpbnRlcmZhY2UgdG8gYSBtZXNzYWdlIGxvb3AuIERlbGV0aW5nIHRoZSBtZXNzYWdl IGxvb3AgYmxvY2tzCisvLyB1bnRpbCB0aGUgbWVzc2FnZSBsb29wIGRyYWlucyBhbmQgc3RvcHMu CitjbGFzcyBXZWJUaHJlYWQgeworcHVibGljOgorICAgIHZpcnR1YWwgdm9pZCBwb3N0VGFzayh2 b2lkICgqZnVuYykodm9pZCopLCB2b2lkKiBjb250ZXh0KSA9IDA7CisgICAgdmlydHVhbCB2b2lk IHBvc3REZWxheWVkVGFzayh2b2lkICgqZnVuYykodm9pZCopLCB2b2lkKiBjb250ZXh0LCBpbnQ2 NCBkZWxheU1zKSA9IDA7CisKK3Byb3RlY3RlZDoKKyAgICB+V2ViVGhyZWFkKCkgeyB9Cit9Owor Cit9IC8vIG5hbWVzcGFjZSBXZWJLaXQKKworI2VuZGlmCg== 103572 2011-08-10 20:14:49 -0700 2011-08-11 22:48:53 -0700 Pass tasks not fnptrs. bug-66013-20110810201447.patch text/plain 3943 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTI3NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OTI3MjgzOWFjMGU3YWU2MzBiYzRiY2M4YTQ0YzMzYmY5NzFiMWRkMS4uMDFlMDNlY2NiNWY0NzIx YWRmMWYwYWIyYzViNGMzNjBkNjlmZjA2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wOC0xMCAgTmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgV2ViVGhyZWFkIHRvIFdlYktpdENsaWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjYwMTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJL aXRDbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViS2l0Q2xpZW50OjpjcmVhdGVUaHJlYWQp OgorICAgICAgICAqIHB1YmxpYy9XZWJUaHJlYWQuaDogQWRkZWQuCisgICAgICAgIChXZWJLaXQ6 OldlYlRocmVhZDo6fldlYlRocmVhZCk6CisKIDIwMTEtMDgtMTAgIEFuZHJleSBLb3N5YWtvdiAg PGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBSb2xsZWQgREVQUyA5 NTgxMzo5NjAwOSB0byBwaWNrIGRhdGEgdXJsIHRpbWluZyBmaXguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCmluZGV4IDIwMTNlYzJhYTliYTRlMDdjZDdm ODM1ZTZhYTQ0NjFkN2VjZmM5MDUuLjQ5MDRkMTUxZjZmYTRiZThkMzEzMTg0YTBmNjU1ZDQxMmMx N2JhNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENs aWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5o CkBAIC03MCw2ICs3MCw3IEBAIGNsYXNzIFdlYlNoYXJlZFdvcmtlclJlcG9zaXRvcnk7CiBjbGFz cyBXZWJTb2NrZXRTdHJlYW1IYW5kbGU7CiBjbGFzcyBXZWJTdG9yYWdlTmFtZXNwYWNlOwogY2xh c3MgV2ViVGhlbWVFbmdpbmU7CitjbGFzcyBXZWJUaHJlYWQ7CiBjbGFzcyBXZWJVUkxMb2FkZXI7 CiAKIGNsYXNzIFdlYktpdENsaWVudCB7CkBAIC0xNzQsNiArMTc1LDExIEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIHNpemVfdCBhY3R1YWxNZW1vcnlVc2FnZU1CKCkgeyByZXR1cm4gMDsgfQogCiAK KyAgICAvLyBUaHJlYWRzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KKworICAgIC8vIENyZWF0ZXMgYW4gZW1iZWRkZXItZGVmaW5lZCB0aHJl YWQuCisgICAgdmlydHVhbCBXZWJUaHJlYWQqIGNyZWF0ZVRocmVhZChjb25zdCBjaGFyKiBuYW1l KSB7IHJldHVybiAwOyB9CisKICAgICAvLyBNZXNzYWdlIFBvcnRzIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogICAgIC8vIENyZWF0ZXMg YSBNZXNzYWdlIFBvcnQgQ2hhbm5lbC4gIFRoaXMgY2FuIGJlIGNhbGxlZCBvbiBhbnkgdGhyZWFk LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVGhyZWFkLmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJUaHJlYWQuaApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4w ZjU3Y2I4NjI0MDdiZDU0MmFiYTA4MjdkZmYwZmU1MDM2ZjRkNDQyCi0tLSAvZGV2L251bGwKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVGhyZWFkLmgKQEAgLTAsMCArMSw1 MyBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICoK KyAqIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5k IHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmlu YXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBp biB0aGUKKyAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlk ZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklE RUQgQlkgQVBQTEUgQU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCisgKiBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s IFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVNDTEFJTUVELiBJTiBOTyBFVkVO VCBTSEFMTCBBUFBMRSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisgKiBE SVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNF UVVFTlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9D VVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworICogTE9TUyBPRiBVU0Us IERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5ECisgKiBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFD VCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCisgKiBUSElT IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLgorICovCisjaWZuZGVmIFdlYlRocmVhZF9oCisjZGVmaW5lIFdlYlRocmVhZF9oCisKKyNp bmNsdWRlICJXZWJDb21tb24uaCIKKworbmFtZXNwYWNlIFdlYktpdCB7CisKKy8vIFByb3ZpZGVz IGFuIGludGVyZmFjZSB0byBhbiBlbWJlZGRlci1kZWZpbmVkIHRocmVhZCBpbXBsZW1lbnRhdGlv bi4KKy8vCisvLyBEZWxldGluZyB0aGUgdGhyZWFkIGJsb2NrcyB1bnRpbCBhbGwgcGVuZGluZywg bm9uLWRlZmVycmVkIHRhc2tzIGhhdmUgYmVlbgorLy8gcnVuLgorY2xhc3MgV2ViVGhyZWFkIHsK K3B1YmxpYzoKKyAgICBjbGFzcyBUYXNrIHsKKyAgICBwdWJsaWM6CisgICAgICAgIHZpcnR1YWwg flRhc2soKSB7IH0KKyAgICAgICAgdmlydHVhbCB2b2lkIHBlcmZvcm1UYXNrKCkgPSAwOworICAg IH07CisKKyAgICB2aXJ0dWFsIHZvaWQgcG9zdFRhc2soVGFzayopID0gMDsKKyAgICB2aXJ0dWFs IHZvaWQgcG9zdERlbGF5ZWRUYXNrKFRhc2sqLCBpbnQ2NCBkZWxheU1zKSA9IDA7CisKK3Byb3Rl Y3RlZDoKKyAgICB+V2ViVGhyZWFkKCkgeyB9Cit9OworCit9IC8vIG5hbWVzcGFjZSBXZWJLaXQK KworI2VuZGlmCg==