66006 2011-08-10 13:07:01 -0700 The PageSerializer should always use absolute URL 2011-08-11 15:02:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin webkit-unassigned abarth jcivelli webkit.review.bot oldest_to_newest 449336 0 benjamin 2011-08-10 13:07:01 -0700 In http://trac.webkit.org/changeset/92769/trunk/Source/WebCore/page/PageSerializer.cpp I added a Fixme for the URL resolution method. I am pretty sure the existing resolving behavior is wrong or the code of the PageSerializer is wrong. The url resources fetched are all stored with resolved URLs. 449849 1 103640 benjamin 2011-08-11 10:00:42 -0700 Created attachment 103640 Patch 449853 2 benjamin 2011-08-11 10:04:42 -0700 This is a purely speculative patch that is completely untested :) I left apart the privacy issues of exposing the local directory as this is not addressed by the current PageSerializer. 449974 3 benjamin 2011-08-11 13:13:18 -0700 Jay, any opinion? I don't mind you guys reject the patch and the Chromium team take over to fix that with a test. I just wanted to point out a problem that become visible due to r92769. 449978 4 abarth 2011-08-11 13:15:53 -0700 Thanks Ben. Let's see what Jay thinks we should do here. 450020 5 jcivelli 2011-08-11 14:01:24 -0700 Yes, this patch is right. We want to resolve all URLs including local ones. 450025 6 103640 abarth 2011-08-11 14:02:56 -0700 Comment on attachment 103640 Patch Ok. 450063 7 103640 webkit.review.bot 2011-08-11 15:02:46 -0700 Comment on attachment 103640 Patch Clearing flags on attachment: 103640 Committed r92883: <http://trac.webkit.org/changeset/92883> 450064 8 webkit.review.bot 2011-08-11 15:02:50 -0700 All reviewed patches have been landed. Closing bug. 103640 2011-08-11 10:00:42 -0700 2011-08-11 15:02:46 -0700 Patch bug-66006-20110811190038.patch text/plain 1738 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4NDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YzI3ZDE5Mzk0YWM3YjQw ZmRjYmZiNDgzZDE4MTJjNDMxZGNjY2RhLi42YzkzNTAwNmRlMmIyOTU2YjlmNWJjMjlkZWVmZjlk MDAwMjk2NWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMTEgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFRoZSBQYWdlU2Vy aWFsaXplciBzaG91bGQgYWx3YXlzIHVzZSBhYnNvbHV0ZSBVUkwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2MDA2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFnZSBzZXJpYWxpemVyIHJlc29sdmVzIGV2 ZXJ5IFVSTCBmb3Igc3RvcmluZyB0aGUgcmVzb3VyY2VzLgorICAgICAgICBUaGUgTWFya3VwQWNj dW11bGF0b3IgdXNlZCB0aGVyZSBzaG91bGQgdXNlIHRoZSBzYW1lIHJ1bGVzIGluIG9yZGVyIHRv CisgICAgICAgIGNyZWF0ZSBhIHZhbGlkIGZpbGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJl Y2F1c2UgdGhlIHRlc3QgaW5mcmFzdHJ1Y3R1cmUgZm9yIHRoaXMKKyAgICAgICAgZG9lcyBub3Qg ZXhpc3Qgd2l0aCBsYXlvdXQgdGVzdHMgYW5kIHRoZSBDaHJvbWl1bSB1bml0IHRlc3QgZm9yCisg ICAgICAgIHRoZSBzZXJpYWxpemVyIGFyZSBkaXNhYmxlZC4KKworICAgICAgICAqIHBhZ2UvUGFn ZVNlcmlhbGl6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFsaXplck1hcmt1cEFjY3Vt dWxhdG9yOjpTZXJpYWxpemVyTWFya3VwQWNjdW11bGF0b3IpOgorCiAyMDExLTA4LTExICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgZml4IGZvciBRdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv UGFnZVNlcmlhbGl6ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlU2VyaWFsaXplci5j cHAKaW5kZXggNGRmMzNiNzA1MmNhYjY3YmUzNGZmZWI0MGU3YjE1ZGIzMDk4MTg4Ni4uYzlhNzg0 ZDM3NmZlMGI5MjQyZTBmNDU1MDFjYjEyZjc5ZDUwNzVlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9QYWdlU2VyaWFsaXplci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Q YWdlU2VyaWFsaXplci5jcHAKQEAgLTEwNiw5ICsxMDYsOCBAQCBwcml2YXRlOgogICAgIERvY3Vt ZW50KiBtX2RvY3VtZW50OwogfTsKIAotLy8gRklYTUU6IHNob3VsZCB0aGF0IHJlYWxseSB1c2Ug UmVzb2x2ZU5vbkxvY2FsVVJMcz8KIFNlcmlhbGl6ZXJNYXJrdXBBY2N1bXVsYXRvcjo6U2VyaWFs aXplck1hcmt1cEFjY3VtdWxhdG9yKFBhZ2VTZXJpYWxpemVyKiBzZXJpYWxpemVyLCBEb2N1bWVu dCogZG9jdW1lbnQsIFZlY3RvcjxOb2RlKj4qIG5vZGVzKQotICAgIDogTWFya3VwQWNjdW11bGF0 b3Iobm9kZXMsIFJlc29sdmVOb25Mb2NhbFVSTHMpCisgICAgOiBNYXJrdXBBY2N1bXVsYXRvcihu b2RlcywgUmVzb2x2ZUFsbFVSTHMpCiAgICAgLCBtX3NlcmlhbGl6ZXIoc2VyaWFsaXplcikKICAg ICAsIG1fZG9jdW1lbnQoZG9jdW1lbnQpCiB7Cg==