65998 2011-08-10 10:50:12 -0700 [Qt] Enable WebGL by default for QtWebKit (except on Windows) 2011-09-26 00:18:37 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 noam webkit-unassigned benjamin laszlo.gombos ossy webkit.review.bot oldest_to_newest 449237 0 noam 2011-08-10 10:50:12 -0700 It's time to make building WebGL on Qt an opt-out instead of an opt-in. We'd still keep it opt-in in the settings. 449439 1 103542 noam 2011-08-10 15:33:18 -0700 Created attachment 103542 Patch 449504 2 103542 benjamin 2011-08-10 17:08:26 -0700 Comment on attachment 103542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103542&action=review > Source/WebCore/features.pri:125 > +contains(QT_CONFIG, opengl) { Before you land, could you check if that still work on Qt5? ...since gl is always available there? 449507 3 noam 2011-08-10 17:11:05 -0700 (In reply to comment #2) > (From update of attachment 103542 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103542&action=review > > > Source/WebCore/features.pri:125 > > +contains(QT_CONFIG, opengl) { > > Before you land, could you check if that still work on Qt5? ...since gl is always available there? You mean does the flag work? Checked. Works. 449515 4 103542 webkit.review.bot 2011-08-10 17:28:01 -0700 Comment on attachment 103542 Patch Clearing flags on attachment: 103542 Committed r92805: <http://trac.webkit.org/changeset/92805> 449516 5 webkit.review.bot 2011-08-10 17:28:05 -0700 All reviewed patches have been landed. Closing bug. 449663 6 ossy 2011-08-11 01:52:39 -0700 It broke all fast/canvas/webgl tests ... I skipped them: https://trac.webkit.org/changeset/92805 Reopen to fix them or file a bug report. 449664 7 ossy 2011-08-11 01:54:24 -0700 And it broke Windows build too ... Reni had to disable WebGL on Windows: https://trac.webkit.org/changeset/92830 449670 8 benjamin 2011-08-11 02:21:07 -0700 (In reply to comment #7) > And it broke Windows build too ... > Reni had to disable WebGL on Windows: https://trac.webkit.org/changeset/92830 Interesting. I guess we will have to investigate ANGLE sooner than expected. 472912 9 ossy 2011-09-25 15:14:51 -0700 Why did you close it? WebGL is still disabled on Windows ... 472976 10 noam 2011-09-25 23:30:14 -0700 (In reply to comment #9) > Why did you close it? WebGL is still disabled on Windows ... It's confusing. We should create a new bug specificly for windows. 472977 11 ossy 2011-09-25 23:37:50 -0700 Reni filed a new bug report about it, but missed to mention it here: https://bugs.webkit.org/show_bug.cgi?id=66042 472992 12 noam 2011-09-26 00:18:37 -0700 Thanks for changing the bug desc. - I should have done that when closing the bug. 103542 2011-08-10 15:33:18 -0700 2011-08-10 17:28:01 -0700 Patch patch-webgl.diff text/plain 1731 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMjA5ZTM2Li5kZjk5ZjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDgtMTAgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdIEVuYWJsZSBXZWJHTCBieSBkZWZhdWx0IGZvciBRdFdlYktpdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU5OTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIEVOQUJM RV9XRUJHTCB0cnVlIGJ5IGRlZmF1bHQgd2hlbiBRdCBpcyBjb25maWd1cmVkIHdpdGggT3BlbkdM LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQnVpbGQgY2hhbmdlIG9ubHkuCisKKyAgICAgICAg KiBmZWF0dXJlcy5wcmk6CisKIDIwMTEtMDgtMTAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBtaXNzaW5nIHJlZ2lvbnMvZXhjbHVzaW9ucy1yZWxhdGVkIGZp bGVzIHRvIEVGTC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaSBiL1Nv dXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaQppbmRleCBkZGE2MTVlLi5hNmI2ODg3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvZmVh dHVyZXMucHJpCkBAIC04OCw3ICs4OCw2IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9TSU5H TEVfVEhSRUFERUQ9MSkgewogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9JTlNQRUNUT1I9Lik6 IERFRklORVMgKz0gRU5BQkxFX0lOU1BFQ1RPUj0xCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxF XzNEX1JFTkRFUklORz0uKTogREVGSU5FUyArPSBFTkFCTEVfM0RfUkVOREVSSU5HPTEKICFjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCX0FVRElPPS4pOiBERUZJTkVTICs9IEVOQUJMRV9XRUJf QVVESU89MAotIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9XRUJHTD0uKTogREVGSU5FUyArPSBF TkFCTEVfV0VCR0w9MAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9NRURJQV9TVEFUSVNUSUNT PS4pOiBERUZJTkVTICs9IEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTPTAKICFjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfTUVESUFfU1RSRUFNPS4pOiBERUZJTkVTICs9IEVOQUJMRV9NRURJQV9TVFJF QU09MAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9WSURFT19UUkFDSz0uKTogREVGSU5FUyAr PSBFTkFCTEVfVklERU9fVFJBQ0s9MApAQCAtMTIyLDYgKzEyMSwxMyBAQCBjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVBREVEPTEpIHsKICAgICB9CiB9CiAKKyMgV2ViR0wgc3Vw cG9ydAorY29udGFpbnMoUVRfQ09ORklHLCBvcGVuZ2wpIHsKKyAgICAhY29udGFpbnMoREVGSU5F UywgRU5BQkxFX1dFQkdMPS4pOiBERUZJTkVTICs9IEVOQUJMRV9XRUJHTD0xCit9IGVsc2Ugewor ICAgIERFRklORVMgKz0gRU5BQkxFX1dFQkdMPTAKK30KKwogIyBXZWIgU29ja2V0IHN1cHBvcnQu CiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1dFQl9TT0NLRVRTPS4pOiBERUZJTkVTICs9IEVO QUJMRV9XRUJfU09DS0VUUz0xCiAK