65989 2011-08-10 09:00:31 -0700 Accidentally commented out an assertion in BackingStore::incorporateUpdate 2011-08-10 11:30:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 449184 0 ap 2011-08-10 09:00:31 -0700 This wasn't reviewed, and definitely shouldn't have been landed: <http://trac.webkit.org/changeset/78426/trunk/Source/WebKit2/UIProcess/BackingStore.cpp>. Clearly, the assertion was firing a lot, but I don't remember if that had anything to do with r78426, or was just something I already had in my tree for livability. I'm going to uncomment it locally and live with that for a while to see if the assertion fires. See also: <rdar://problem/8994456>. 449221 1 103502 ap 2011-08-10 10:27:27 -0700 Created attachment 103502 proposed patch 449257 2 103502 webkit.review.bot 2011-08-10 11:30:23 -0700 Comment on attachment 103502 proposed patch Clearing flags on attachment: 103502 Committed r92778: <http://trac.webkit.org/changeset/92778> 449258 3 webkit.review.bot 2011-08-10 11:30:27 -0700 All reviewed patches have been landed. Closing bug. 103502 2011-08-10 10:27:27 -0700 2011-08-10 11:30:22 -0700 proposed patch CommentedAssertion.txt text/plain 1296 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNzc1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTAgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgQWNjaWRlbnRhbGx5IGNvbW1l bnRlZCBvdXQgYW4gYXNzZXJ0aW9uIGluIEJhY2tpbmdTdG9yZTo6aW5jb3Jwb3JhdGVVcGRhdGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1OTg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBjb3VsZG4n dCBnZXQgdGhpcyBhc3NlcnRpb24gdG8gZmlyZSBpbiBxdWljayB0ZXN0aW5nLCBsZXQncyBicmlu ZyBpdCBiYWNrLgorCisgICAgICAgICogVUlQcm9jZXNzL0JhY2tpbmdTdG9yZS5jcHA6IChXZWJL aXQ6OkJhY2tpbmdTdG9yZTo6aW5jb3Jwb3JhdGVVcGRhdGUpOgorCiAyMDExLTA4LTEwICBMYXJz IEtudWRzZW4gIDxsYXJzLmtudWRzZW5Abm9raWEuY29tPgogCiAgICAgICAgIEFkZCBkZXZpY2Ug c3BlY2lmaWMgc2V0dGluZ3MgdG8gc3VwcG9ydCB2aWV3cG9ydCBjb21wdXRpbmcKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCShyZXZpc2lvbiA5MjY5MikK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01Miw3ICs1Miw3IEBAIEJhY2tpbmdTdG9yZTo6fkJhY2tpbmdTdG9yZSgpCiAKIHZv aWQgQmFja2luZ1N0b3JlOjppbmNvcnBvcmF0ZVVwZGF0ZShjb25zdCBVcGRhdGVJbmZvJiB1cGRh dGVJbmZvKQogewotLy8gICAgQVNTRVJUKG1fc2l6ZSA9PSB1cGRhdGVJbmZvLnZpZXdTaXplKTsK KyAgICBBU1NFUlQobV9zaXplID09IHVwZGF0ZUluZm8udmlld1NpemUpOwogICAgIAogICAgIFJl ZlB0cjxTaGFyZWFibGVCaXRtYXA+IGJpdG1hcCA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlKHVw ZGF0ZUluZm8uYml0bWFwSGFuZGxlKTsKICAgICBpZiAoIWJpdG1hcCkK