65986 2011-08-10 08:07:26 -0700 [Qt] autotests shouldn't require config.h in the style check 2014-02-03 03:18:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED INVALID Qt, QtTriaged P3 Minor --- 66070 65237 1 pierre.rossi pierre.rossi benjamin dglazkov ossy robert webkit.review.bot oldest_to_newest 449154 0 pierre.rossi 2011-08-10 08:07:26 -0700 It seems for the most part, our autotests fit pretty wel in the category "consumers of the WebKit API", so they should probably undergo the appropriate style checks. 449158 1 103494 pierre.rossi 2011-08-10 08:16:36 -0700 Created attachment 103494 Patch 449378 2 103494 robert 2011-08-10 13:49:42 -0700 Comment on attachment 103494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103494&action=review > Tools/ChangeLog:7 > + This essentially prevents Qt tests from being style-checked > + against the same rules that apply to WebCore (e.g. config.h). I think it's better to have them style-checked myself. 449656 3 pierre.rossi 2011-08-11 01:24:16 -0700 (In reply to comment #2) > (From update of attachment 103494 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103494&action=review > > > Tools/ChangeLog:7 > > + This essentially prevents Qt tests from being style-checked > > + against the same rules that apply to WebCore (e.g. config.h). > > I think it's better to have them style-checked myself. Hi Robert, I'm not sure to follow you. The point of this change is to allow things like what Benjamin suggested in https://bugs.webkit.org/show_bug.cgi?id=65237 In the case of these tests (apart for the special case of mime type sniffing), we are in the position of being consumers of the API provided by QtWebKit, so it seems to me that rules that enforce including config.h don't belong here. Maybe I should rephrase the ChangeLog message. 449678 4 103596 pierre.rossi 2011-08-11 03:05:00 -0700 Created attachment 103596 Patch 449683 5 103596 benjamin 2011-08-11 04:03:04 -0700 Comment on attachment 103596 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103596&action=review You must also modify the tests accordingly. And you should add a new test for Source/WebKit/qt/tests/MIMESniffing. > Tools/Scripts/webkitpy/style/checker.py:137 > + ([# The MIMESniffing test tests the code directly rather than the API, > + # let's enable the include check for this one. > + "Source/WebKit/qt/tests/MIMESniffing"], > + ["+build/include"]), This list is order sensitive. Only the first path substring match is used. -> Source/WebKit/qt/tests/MIMESniffing will never match 449734 6 103614 pierre.rossi 2011-08-11 06:31:23 -0700 Created attachment 103614 Patch Benjamin: oops ! looks like I didn't read the comment up there properly. 449750 7 103614 benjamin 2011-08-11 07:14:59 -0700 Comment on attachment 103614 Patch Good idea for a patch. I am glad those warning will disappear. 449762 8 103614 webkit.review.bot 2011-08-11 07:40:42 -0700 Comment on attachment 103614 Patch Clearing flags on attachment: 103614 Committed r92847: <http://trac.webkit.org/changeset/92847> 449763 9 webkit.review.bot 2011-08-11 07:40:46 -0700 All reviewed patches have been landed. Closing bug. 449835 10 dglazkov 2011-08-11 09:45:04 -0700 Reverted r92847 for reason: Broke check-webkit-style Committed r92857: <http://trac.webkit.org/changeset/92857> 449836 11 dglazkov 2011-08-11 09:45:53 -0700 Sorry guys, this broke the style elf, which is kind of a big deal -- I rolled it out. 449880 12 103646 pierre.rossi 2011-08-11 11:02:09 -0700 Created attachment 103646 Patch Sorry again about that guys. Since Benjamin mentioned the warnings happened in other places, I figured I'd add the WebKit2 qt tests in this. 449906 13 robert 2011-08-11 11:41:18 -0700 (In reply to comment #3) > Hi Robert, I'm not sure to follow you. The point of this change is to allow things like what Benjamin suggested in https://bugs.webkit.org/show_bug.cgi?id=65237 In the case of these tests (apart for the special case of mime type sniffing), we are in the position of being consumers of the API provided by QtWebKit, so it seems to me that rules that enforce including config.h don't belong here. Maybe I should rephrase the ChangeLog message. What I meant was: "The style check keeps the code clean, which is a good thing." If noise like the warnings about config.h are annoying, maybe we should target those instead. 452972 14 103646 kling 2011-08-18 05:36:06 -0700 Comment on attachment 103646 Patch rs=me 452978 15 103646 pierre.rossi 2011-08-18 05:58:50 -0700 Comment on attachment 103646 Patch Let's just hold it for now. I still need to check if that's not messing with alphabetical sorting thingy that was brought up earlier. 657602 16 ossy 2012-06-26 07:47:32 -0700 Is this bug still valid? 658685 17 pierre.rossi 2012-06-27 10:03:00 -0700 (In reply to comment #16) > Is this bug still valid? Yes, it still is AFAICT, but it's more of a "nice to have" kind of thing though, and I never got back to it. I think I remember the concern raised by Robert turned out to be right and a rule specific to config.h should be introduced and only that should be disabled for autotests. 975282 18 jturcotte 2014-02-03 03:18:33 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 103494 2011-08-10 08:16:36 -0700 2011-08-11 03:04:49 -0700 Patch bug-65986-20110810171634.patch text/plain 1708 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogOTI1NDkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODRiZDM5ZTRjYTM5OTU0ZWVjZTA3MWM2MzQyNGQ3MGU0 MDUyMjc3Li5lMjZjODA2Y2I1ZjFkZDIzN2RmNDVjM2M4OTEzZjRlOTJkYTNjOGRjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDgtMTAgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisK KyAgICAgICAgW1F0XSBhdXRvdGVzdHMgc2hvdWxkbid0IHJlcXVpcmUgY29uZmlnLmggaW4gdGhl IHN0eWxlIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTk4NgorCisgICAgICAgIFRoaXMgZXNzZW50aWFsbHkgcHJldmVudHMgUXQgdGVzdHMg ZnJvbSBiZWluZyBzdHlsZS1jaGVja2VkCisgICAgICAgIGFnYWluc3QgdGhlIHNhbWUgcnVsZXMg dGhhdCBhcHBseSB0byBXZWJDb3JlIChlLmcuIGNvbmZpZy5oKS4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlci5weToKKwogMjAxMS0wOC0wNSAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEZpeCB1bml0IHRlc3QgYnJlYWthZ2UgYnkgcGx1bWJpbmcg Y29udmVydF80MDRfdG9fTm9uZSBpbiBNb2NrV2ViLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyLnB5CmluZGV4IDFiNDI2YjczN2RiYTNjZWJiYmY1NTQ2OWU0MmJjZjU4Mjk1ZDY4 NGYuLmYzMGI4ODZiY2U5YWIxMjY4ZDFkYzhlM2IzZWZkYjA3YmE2NjJiMmMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKQEAgLTEyOCw3ICsxMjgsNyBAQCBfUEFUSF9S VUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICAjIFRFU1RfQ0xBU1NfTkFNRS4KICAgICAgICJUb29s cy9XZWJLaXRBUElUZXN0LyIsCiAgICAgICAiVG9vbHMvVGVzdFdlYktpdEFQSS8iLAotICAgICAg IlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2VidmlldyJdLAorICAgICAgIlNv dXJjZS9XZWJLaXQvcXQvdGVzdHMvIl0sCiAgICAgIFsiLWJ1aWxkL2luY2x1ZGUiLAogICAgICAg Ii1yZWFkYWJpbGl0eS9uYW1pbmciXSksCiAgICAgKFsjIFRoZXJlIGlzIG5vIGNsZWFuIHdheSB0 byBhdm9pZCAieXlfKiIgbmFtZXMgdXNlZCBieSBmbGV4LgpAQCAtMTM3LDcgKzEzNyw2IEBAIF9Q QVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKICAgICAgICMgYW5kIG9uIHRlc3QgeHh4X2RhdGEgbWV0 aG9zIG9uIHRlc3RzKQogICAgICAgIlNvdXJjZS9KYXZhU2NyaXB0Q29yZS9xdC8iLAogICAgICAg IlNvdXJjZS9XZWJLaXQvcXQvQXBpLyIsCi0gICAgICAiU291cmNlL1dlYktpdC9xdC90ZXN0cy8i LAogICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvIiwKICAgICAgICJTb3VyY2Uv V2ViS2l0L3F0L2V4YW1wbGVzLyJdLAogICAgICBbIi1yZWFkYWJpbGl0eS9uYW1pbmciXSksCg== 103596 2011-08-11 03:05:00 -0700 2011-08-11 05:43:11 -0700 Patch bug-65986-20110811120457.patch text/plain 2102 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogOTI1NDkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODRiZDM5ZTRjYTM5OTU0ZWVjZTA3MWM2MzQyNGQ3MGU0 MDUyMjc3Li4xOTIzNGIyYzM3YWI4NTBkNDZiNzM2NTIzOTZhOGFkODNjN2Q1ZWNjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDgtMTAgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisK KyAgICAgICAgW1F0XSBhdXRvdGVzdHMgc2hvdWxkbid0IHJlcXVpcmUgY29uZmlnLmggaW4gdGhl IHN0eWxlIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTk4NgorCisgICAgICAgIFJlbW92ZSB0aGUgaW5jbHVkZSBydWxlcyBmcm9tIHRoZSBz dHlsZS1jaGVjayBmb3IgUXQgdGVzdHMuCisgICAgICAgIFNpbmNlIGZvciB0aGUgbW9zdCBwYXJ0 IGl0J3MganVzdCBhIG1hdHRlciBvZiB1c2luZyB0aGUKKyAgICAgICAgQVBJIHByb3ZpZGVkIGJ5 IFF0V2ViS2l0LCBlbmZvcmNpbmcgdGhlIFdlYkNvcmUgc2V0IG9mIHJ1bGVzCisgICAgICAgIG9u bHkgc2VlbXMgdG8gbWFrZSBzZW5zZSBpbiB0aGUgY2FzZSBvZiBNSU1FU25pZmZpbmcuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6CisKIDIwMTEtMDgtMDUgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggdW5pdCB0ZXN0IGJyZWFrYWdl IGJ5IHBsdW1iaW5nIGNvbnZlcnRfNDA0X3RvX05vbmUgaW4gTW9ja1dlYi4KZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQppbmRleCAxYjQyNmI3MzdkYmEzY2ViYmJmNTU0Njll NDJiY2Y1ODI5NWQ2ODRmLi4wMDE0ZGVhMzU5ZTc0YjdiY2QwNzFhNjBlZGNlOTI1NzJiNTM3Y2M3 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CkBAIC0xMjgsMTYgKzEy OCwxOSBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICAjIFRFU1RfQ0xBU1NfTkFN RS4KICAgICAgICJUb29scy9XZWJLaXRBUElUZXN0LyIsCiAgICAgICAiVG9vbHMvVGVzdFdlYktp dEFQSS8iLAotICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2Vidmll dyJdLAorICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvIl0sCiAgICAgIFsiLWJ1aWxkL2lu Y2x1ZGUiLAogICAgICAgIi1yZWFkYWJpbGl0eS9uYW1pbmciXSksCisgICAgKFsjIFRoZSBNSU1F U25pZmZpbmcgdGVzdCB0ZXN0cyB0aGUgY29kZSBkaXJlY3RseSByYXRoZXIgdGhhbiB0aGUgQVBJ LAorICAgICAgIyBsZXQncyBlbmFibGUgdGhlIGluY2x1ZGUgY2hlY2sgZm9yIHRoaXMgb25lLgor ICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvTUlNRVNuaWZmaW5nIl0sCisgICAgIFsiK2J1 aWxkL2luY2x1ZGUiXSksCiAgICAgKFsjIFRoZXJlIGlzIG5vIGNsZWFuIHdheSB0byBhdm9pZCAi eXlfKiIgbmFtZXMgdXNlZCBieSBmbGV4LgogICAgICAgIlNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwIiwKICAgICAgICMgUXQgY29kZSB1c2VzICdfJyBpbiBzb21lIHBsYWNlcyAoc3Vj aCBhcyBwcml2YXRlIHNsb3RzCiAgICAgICAjIGFuZCBvbiB0ZXN0IHh4eF9kYXRhIG1ldGhvcyBv biB0ZXN0cykKICAgICAgICJTb3VyY2UvSmF2YVNjcmlwdENvcmUvcXQvIiwKICAgICAgICJTb3Vy Y2UvV2ViS2l0L3F0L0FwaS8iLAotICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvIiwKICAg ICAgICJTb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlLyIsCiAgICAgICAiU291cmNlL1dlYktp dC9xdC9leGFtcGxlcy8iXSwKICAgICAgWyItcmVhZGFiaWxpdHkvbmFtaW5nIl0pLAo= 103614 2011-08-11 06:31:23 -0700 2011-08-11 11:01:58 -0700 Patch bug-65986-20110811153105.patch text/plain 3144 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogOTI1NDkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODRiZDM5ZTRjYTM5OTU0ZWVjZTA3MWM2MzQyNGQ3MGU0 MDUyMjc3Li40ZjU0Nzc4ODVkY2Q2ZTQ4NzgzOWY3NGVlYWZiMDgzMDQ0NTE0ZTlhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMTAgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisK KyAgICAgICAgW1F0XSBhdXRvdGVzdHMgc2hvdWxkbid0IHJlcXVpcmUgY29uZmlnLmggaW4gdGhl IHN0eWxlIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTk4NgorCisgICAgICAgIFJlbW92ZSB0aGUgaW5jbHVkZSBydWxlcyBmcm9tIHRoZSBz dHlsZS1jaGVjayBmb3IgUXQgdGVzdHMuCisgICAgICAgIFNpbmNlIGZvciB0aGUgbW9zdCBwYXJ0 IGl0J3MganVzdCBhIG1hdHRlciBvZiB1c2luZyB0aGUKKyAgICAgICAgQVBJIHByb3ZpZGVkIGJ5 IFF0V2ViS2l0LCBlbmZvcmNpbmcgdGhlIFdlYkNvcmUgc2V0IG9mIHJ1bGVzCisgICAgICAgIG9u bHkgc2VlbXMgdG8gbWFrZSBzZW5zZSBpbiB0aGUgY2FzZSBvZiBNSU1FU25pZmZpbmcuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyX3VuaXR0ZXN0LnB5OgorCiAyMDExLTA4LTA1ICBEaW1pdHJpIEdsYXprb3YgIDxk Z2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHVuaXQgdGVzdCBicmVha2FnZSBi eSBwbHVtYmluZyBjb252ZXJ0XzQwNF90b19Ob25lIGluIE1vY2tXZWIuCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggMWI0MjZiNzM3ZGJhM2NlYmJiZjU1NDY5ZTQy YmNmNTgyOTVkNjg0Zi4uNDg0MjMxMWM0ZDZjOGM5OTIyNDM2NWIwMTBiNjllNmQ2YzdhMjI3MSAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTI0LDExICsxMjQs MTUgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgIChbIyBUZXN0TmV0c2NhcGVQbHVn SW4gaGFzIG5vIGNvbmZpZy5oIGFuZCB1c2VzIGZ1bm55IG5hbWVzIGxpa2UKICAgICAgICMgTlBQ X1NldFdpbmRvdy4KICAgICAgICJUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVn SW4vIiwKKyAgICAoWyMgVGhlIE1JTUVTbmlmZmluZyB0ZXN0IHRlc3RzIHRoZSBjb2RlIGRpcmVj dGx5IHJhdGhlciB0aGFuIHRoZSBBUEksCisgICAgICAjIGxldCdzIGVuYWJsZSB0aGUgaW5jbHVk ZSBjaGVjayBmb3IgdGhpcyBvbmUuCisgICAgICAiU291cmNlL1dlYktpdC9xdC90ZXN0cy9NSU1F U25pZmZpbmciXSwKKyAgICAgWyIrYnVpbGQvaW5jbHVkZSJdKSwKICAgICAgICMgVGhlIEFQSSB0 ZXN0IGhhcm5lc3NlcyBoYXZlIG5vIGNvbmZpZy5oIGFuZCB1c2UgZnVubnkgbWFjcm9zIGxpa2UK ICAgICAgICMgVEVTVF9DTEFTU19OQU1FLgogICAgICAgIlRvb2xzL1dlYktpdEFQSVRlc3QvIiwK ICAgICAgICJUb29scy9UZXN0V2ViS2l0QVBJLyIsCi0gICAgICAiU291cmNlL1dlYktpdC9xdC90 ZXN0cy9xZGVjbGFyYXRpdmV3ZWJ2aWV3Il0sCisgICAgICAiU291cmNlL1dlYktpdC9xdC90ZXN0 cy8iXSwKICAgICAgWyItYnVpbGQvaW5jbHVkZSIsCiAgICAgICAiLXJlYWRhYmlsaXR5L25hbWlu ZyJdKSwKICAgICAoWyMgVGhlcmUgaXMgbm8gY2xlYW4gd2F5IHRvIGF2b2lkICJ5eV8qIiBuYW1l cyB1c2VkIGJ5IGZsZXguCkBAIC0xMzcsNyArMTQxLDYgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVS ID0gWwogICAgICAgIyBhbmQgb24gdGVzdCB4eHhfZGF0YSBtZXRob3Mgb24gdGVzdHMpCiAgICAg ICAiU291cmNlL0phdmFTY3JpcHRDb3JlL3F0LyIsCiAgICAgICAiU291cmNlL1dlYktpdC9xdC9B cGkvIiwKLSAgICAgICJTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzLyIsCiAgICAgICAiU291cmNlL1dl YktpdC9xdC9kZWNsYXJhdGl2ZS8iLAogICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvZXhhbXBsZXMv Il0sCiAgICAgIFsiLXJlYWRhYmlsaXR5L25hbWluZyJdKSwKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQppbmRleCAzZTlkN2VjODI0NGNhMWQ5 MTczOTQ5ODgzNzY2MzAwOTU5ZGNiOWI3Li5lZDA5MWFiZDEwNzkzZDg4MjVjYWQ1NDdkZDBjYTE0 YTcyODgyOTdhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy X3VuaXR0ZXN0LnB5CkBAIC0yNTYsNiArMjU2LDEwIEBAIGNsYXNzIEdsb2JhbFZhcmlhYmxlc1Rl c3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgICAgIGFzc2VydE5vQ2hlY2soIlRvb2xzL01p bmlCcm93c2VyL3F0L1VybExvYWRlci5jcHAiLAogICAgICAgICAgICAgICAgICAgICAiYnVpbGQv aW5jbHVkZSIpCisgICAgICAgIGFzc2VydE5vQ2hlY2soIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMv dXRpbC5jcHAiLAorICAgICAgICAgICAgICAgICAgICAiYnVpbGQvaW5jbHVkZSIpCisgICAgICAg IGFzc2VydENoZWNrKCJTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL01JTUVTbmlmZmluZy90c3RfTUlN RVNuaWZmaW5nLmNwcCIsCisgICAgICAgICAgICAgICAgICAgICJidWlsZC9pbmNsdWRlIikKIAog ICAgICAgICBhc3NlcnROb0NoZWNrKCJTb3VyY2UvV2ViQ29yZS9Gb3J3YXJkaW5nSGVhZGVycy9k ZWJ1Z2dlci9EZWJ1Z2dlci5oIiwKICAgICAgICAgICAgICAgICAgICAgICAiYnVpbGQvaGVhZGVy X2d1YXJkIikK 103646 2011-08-11 11:02:09 -0700 2011-08-18 05:58:50 -0700 Patch bug-65986-20110811200206.patch text/plain 3400 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogOTI1NDkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODRiZDM5ZTRjYTM5OTU0ZWVjZTA3MWM2MzQyNGQ3MGU0 MDUyMjc3Li40ZjU0Nzc4ODVkY2Q2ZTQ4NzgzOWY3NGVlYWZiMDgzMDQ0NTE0ZTlhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMTAgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisK KyAgICAgICAgW1F0XSBhdXRvdGVzdHMgc2hvdWxkbid0IHJlcXVpcmUgY29uZmlnLmggaW4gdGhl IHN0eWxlIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTk4NgorCisgICAgICAgIFJlbW92ZSB0aGUgaW5jbHVkZSBydWxlcyBmcm9tIHRoZSBz dHlsZS1jaGVjayBmb3IgUXQgdGVzdHMuCisgICAgICAgIFNpbmNlIGZvciB0aGUgbW9zdCBwYXJ0 IGl0J3MganVzdCBhIG1hdHRlciBvZiB1c2luZyB0aGUKKyAgICAgICAgQVBJIHByb3ZpZGVkIGJ5 IFF0V2ViS2l0LCBlbmZvcmNpbmcgdGhlIFdlYkNvcmUgc2V0IG9mIHJ1bGVzCisgICAgICAgIG9u bHkgc2VlbXMgdG8gbWFrZSBzZW5zZSBpbiB0aGUgY2FzZSBvZiBNSU1FU25pZmZpbmcuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyX3VuaXR0ZXN0LnB5OgorCiAyMDExLTA4LTA1ICBEaW1pdHJpIEdsYXprb3YgIDxk Z2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHVuaXQgdGVzdCBicmVha2FnZSBi eSBwbHVtYmluZyBjb252ZXJ0XzQwNF90b19Ob25lIGluIE1vY2tXZWIuCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggMWI0MjZiNzM3ZGJhM2NlYmJiZjU1NDY5ZTQy YmNmNTgyOTVkNjg0Zi4uOGFmYjk4ZDA4OTk4N2NhMjFlODY4YTY0YTBmMDAzY2M4MDA2NmE4YyAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTE3LDYgKzExNywx MCBAQCBfQkFTRV9GSUxURVJfUlVMRVMgPSBbCiAjIGZvciBleGFtcGxlLCBpbiB0aGUgdGVzdF9w YXRoX3J1bGVzX3NwZWNpZmllcigpIHVuaXQgdGVzdCBtZXRob2Qgb2YKICMgY2hlY2tlcl91bml0 dGVzdC5weS4KIF9QQVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKKyAgICAjIFRoZSBNSU1FU25pZmZp bmcgdGVzdCB0ZXN0cyB0aGUgY29kZSBkaXJlY3RseSByYXRoZXIgdGhhbiB0aGUgQVBJLAorICAg ICMgbGV0J3MgZW5hYmxlIHRoZSBpbmNsdWRlIGNoZWNrIGZvciB0aGlzIG9uZS4KKyAgICAoWyJT b3VyY2UvV2ViS2l0L3F0L3Rlc3RzL01JTUVTbmlmZmluZyJdLAorICAgICBbIitidWlsZC9pbmNs dWRlIl0pLAogICAgICMgRmlsZXMgaW4gdGhlc2UgZGlyZWN0b3JpZXMgYXJlIGNvbnN1bWVycyBv ZiB0aGUgV2ViS2l0CiAgICAgIyBBUEkgYW5kIHRoZXJlZm9yZSBkbyBub3QgZm9sbG93IHRoZSBz YW1lIGhlYWRlciBpbmNsdWRpbmcKICAgICAjIGRpc2NpcGxpbmUgYXMgV2ViQ29yZS4KQEAgLTEy OCw3ICsxMzIsOCBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICAjIFRFU1RfQ0xB U1NfTkFNRS4KICAgICAgICJUb29scy9XZWJLaXRBUElUZXN0LyIsCiAgICAgICAiVG9vbHMvVGVz dFdlYktpdEFQSS8iLAotICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZl d2VidmlldyJdLAorICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvIiwKKyAgICAgICJTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzIl0sCiAgICAgIFsiLWJ1aWxkL2luY2x1 ZGUiLAogICAgICAgIi1yZWFkYWJpbGl0eS9uYW1pbmciXSksCiAgICAgKFsjIFRoZXJlIGlzIG5v IGNsZWFuIHdheSB0byBhdm9pZCAieXlfKiIgbmFtZXMgdXNlZCBieSBmbGV4LgpAQCAtMTM3LDcg KzE0Miw2IEBAIF9QQVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKICAgICAgICMgYW5kIG9uIHRlc3Qg eHh4X2RhdGEgbWV0aG9zIG9uIHRlc3RzKQogICAgICAgIlNvdXJjZS9KYXZhU2NyaXB0Q29yZS9x dC8iLAogICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvQXBpLyIsCi0gICAgICAiU291cmNlL1dlYktp dC9xdC90ZXN0cy8iLAogICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvIiwKICAg ICAgICJTb3VyY2UvV2ViS2l0L3F0L2V4YW1wbGVzLyJdLAogICAgICBbIi1yZWFkYWJpbGl0eS9u YW1pbmciXSksCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5p dHRlc3QucHkKaW5kZXggM2U5ZDdlYzgyNDRjYTFkOTE3Mzk0OTg4Mzc2NjMwMDk1OWRjYjliNy4u MGNlZmMwMmNiMDBjNTI1YTBjN2FjOTA0ZjJlODEzOGM4NDNiYjQ1MSAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQpAQCAtMjU2LDYgKzI1 NiwxMiBAQCBjbGFzcyBHbG9iYWxWYXJpYWJsZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKIAog ICAgICAgICBhc3NlcnROb0NoZWNrKCJUb29scy9NaW5pQnJvd3Nlci9xdC9VcmxMb2FkZXIuY3Bw IiwKICAgICAgICAgICAgICAgICAgICAgImJ1aWxkL2luY2x1ZGUiKQorICAgICAgICBhc3NlcnRO b0NoZWNrKCJTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3V0aWwuY3BwIiwKKyAgICAgICAgICAgICAg ICAgICAgImJ1aWxkL2luY2x1ZGUiKQorICAgICAgICBhc3NlcnROb0NoZWNrKCJTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3V0aWwuY3BwIiwKKyAgICAgICAgICAgICAgICAg ICAgImJ1aWxkL2luY2x1ZGUiKQorICAgICAgICBhc3NlcnRDaGVjaygiU291cmNlL1dlYktpdC9x dC90ZXN0cy9NSU1FU25pZmZpbmcvdHN0X01JTUVTbmlmZmluZy5jcHAiLAorICAgICAgICAgICAg ICAgICAgICAiYnVpbGQvaW5jbHVkZSIpCiAKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygiU291cmNl L1dlYkNvcmUvRm9yd2FyZGluZ0hlYWRlcnMvZGVidWdnZXIvRGVidWdnZXIuaCIsCiAgICAgICAg ICAgICAgICAgICAgICAgImJ1aWxkL2hlYWRlcl9ndWFyZCIpCg==