65944 2011-08-09 14:35:53 -0700 Crash in QuotesData::operator== when compiled with RVCT 2016-08-24 16:09:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned ap dglazkov gustavo jbedard webkit.review.bot xan.lopez oldest_to_newest 448816 0 yong.li.webkit 2011-08-09 14:35:53 -0700 "if (!this || !&other)" in QuotesData::operator==() doesn't generate expected code when being compiled with RVCT. This can cause crashes 448829 1 103403 yong.li.webkit 2011-08-09 14:56:39 -0700 Created attachment 103403 the patch 448830 2 webkit.review.bot 2011-08-09 14:58:36 -0700 Attachment 103403 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/style/QuotesData.h:37: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 448832 3 103403 gyuyoung.kim 2011-08-09 15:02:16 -0700 Comment on attachment 103403 the patch Attachment 103403 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9340314 448833 4 103403 webkit.review.bot 2011-08-09 15:02:18 -0700 Comment on attachment 103403 the patch Attachment 103403 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9338347 448838 5 103403 webkit.review.bot 2011-08-09 15:12:08 -0700 Comment on attachment 103403 the patch Attachment 103403 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9332544 448841 6 103403 gustavo 2011-08-09 15:13:02 -0700 Comment on attachment 103403 the patch Attachment 103403 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9340320 448847 7 103403 webkit.review.bot 2011-08-09 15:24:46 -0700 Comment on attachment 103403 the patch Attachment 103403 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9338352 448875 8 103403 webkit-ews 2011-08-09 16:19:09 -0700 Comment on attachment 103403 the patch Attachment 103403 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9337415 449128 9 103484 yong.li.webkit 2011-08-10 07:10:20 -0700 Created attachment 103484 updated 449129 10 webkit.review.bot 2011-08-10 07:12:02 -0700 Attachment 103484 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/style/QuotesData.h:37: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 449137 11 103489 yong.li.webkit 2011-08-10 07:36:10 -0700 Created attachment 103489 Fix style issue No more "a" 449139 12 103489 tonikitoo 2011-08-10 07:43:44 -0700 Comment on attachment 103489 Fix style issue View in context: https://bugs.webkit.org/attachment.cgi?id=103489&action=review > Source/WebCore/rendering/style/QuotesData.h:37 > - bool operator==(const QuotesData&) const; > void operator delete(void* p) { delete[] static_cast<char*>(p); } > + static bool equal(const QuotesData*, const QuotesData*); Should we add a comment about avoiding "==" so no one tries to get it back in? 449151 13 yong.li.webkit 2011-08-10 08:02:24 -0700 (In reply to comment #12) > (From update of attachment 103489 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103489&action=review > > > Source/WebCore/rendering/style/QuotesData.h:37 > > - bool operator==(const QuotesData&) const; > > void operator delete(void* p) { delete[] static_cast<char*>(p); } > > + static bool equal(const QuotesData*, const QuotesData*); > > Should we add a comment about avoiding "==" so no one tries to get it back in? operator== is not a problem. The problem is the old operator== is bad written. It checks "this" pointer and the address of a reference (QuotesData&), and expects to work with null "this" and a reference deferencing a null pointer. If someone in the future wants to write a normal operator==, and doesn't use operator== on null pointers, it should be fine. 449449 14 ap 2011-08-10 15:46:05 -0700 > The problem is the old operator== is bad written Are you sure that the blame is pointed correctly here? Seems like a bug in this particular compiler to me. 449749 15 yong.li.webkit 2011-08-11 07:14:47 -0700 (In reply to comment #14) > > The problem is the old operator== is bad written > > Are you sure that the blame is pointed correctly here? Seems like a bug in this particular compiler to me. This was discussed @ https://bugs.webkit.org/show_bug.cgi?id=36901 from [Daniel Bates]: By 8.3.2 (5) of the C++ standard <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2010/n3092.pdf>: A reference shall be initialized to refer to a valid object or function. [ Note: in particular, a null reference cannot exist in a well-defined program, because the only way to create such a reference would be to bind it to the “object” obtained by dereferencing a null pointer, which causes undefined behavior....] RVCT uses a strict interpretation of the standard (compared to GCC) and assumes a reference must always be initialized with a valid object. Hence it optimizes away !&other. Another one is "!this". Although RVCT has a compiler option "--allow_null_this", we should still avoid writing such code. 449895 16 103489 yong.li.webkit 2011-08-11 11:22:44 -0700 Comment on attachment 103489 Fix style issue Thanks Alexey! 449924 17 103489 webkit.review.bot 2011-08-11 12:23:10 -0700 Comment on attachment 103489 Fix style issue Clearing flags on attachment: 103489 Committed r92871: <http://trac.webkit.org/changeset/92871> 449925 18 webkit.review.bot 2011-08-11 12:23:15 -0700 All reviewed patches have been landed. Closing bug. 103403 2011-08-09 14:56:39 -0700 2011-08-10 06:47:10 -0700 the patch 65944.patch text/plain 4885 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTM2OGFhLi43NDAzMGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMDgtMDkgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1OTQ0CisgICAgICAgIFJlcGxhY2Ug UXVvdGVzRGF0YTo6b3BlcmF0b3I9PSgpIHdpdGggUXVvdGVzRGF0YTo6ZXF1YWwoY29uc3QgUXVv dGVzRGF0YSoKKyAgICAgICAgLCBjb25zdCBRdW90ZXNEYXRhKikgYmVjYXVzZSBRdW90ZXNEYXRh OjpvcGVyYXRvcj09KCkgd2VyZSB1c2luZyBub24tc3RhbmRhcmQKKyAgICAgICAgQysrIGNvZGUg dGhhdCBpcyBub3Qgc3VwcG9ydGVkIGJ5IGFsbCBjb21waWxlcnMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugc29t ZSBleGlzdGluZyB0ZXN0IGNhc2VzIGNhbiBzaG93IHRoZSBpc3N1ZSwKKyAgICAgICAgZm9yIGV4 YW1wbGUsIGZhc3QvY3NzL2NvbnRlbnQvY29udGVudC1xdW90ZXMtMDEuaHRtbC4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJRdW90ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJR dW90ZTo6c3R5bGVEaWRDaGFuZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9RdW90ZXNE YXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1b3Rlc0RhdGE6OmVxdWFsKToKKyAgICAgICAg KiByZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oOgorICAgICAgICAqIHJlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTdHlsZTo6c2V0UXVv dGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJhcmVJbmhlcml0ZWREYXRhOjpvcGVyYXRvcj09 KToKKwogMjAxMS0wNy0yOCAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJRdW90ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUXVv dGUuY3BwCmluZGV4IDQ1MjNkZjguLjQ1ZTU5OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJRdW90ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclF1b3RlLmNwcApAQCAtMzIzLDcgKzMyMyw3IEBAIHZvaWQgUmVuZGVyUXVvdGU6OnN0 eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xk U3R5CiB7CiAgICAgY29uc3QgUXVvdGVzRGF0YSogbmV3UXVvdGVzID0gc3R5bGUoKS0+cXVvdGVz KCk7CiAgICAgY29uc3QgUXVvdGVzRGF0YSogb2xkUXVvdGVzID0gb2xkU3R5bGUgPyBvbGRTdHls ZS0+cXVvdGVzKCkgOiAwOwotICAgIGlmICghKChuZXdRdW90ZXMgJiYgb2xkUXVvdGVzICYmICgq bmV3UXVvdGVzID09ICpvbGRRdW90ZXMpKSB8fCAoIW5ld1F1b3RlcyAmJiAhb2xkUXVvdGVzKSkp CisgICAgaWYgKCFRdW90ZXNEYXRhOjplcXVhbChuZXdRdW90ZXMsIG9sZFF1b3RlcykpCiAgICAg ICAgIHNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2FsYygpOwogICAgIFJlbmRlclRleHQ6 OnN0eWxlRGlkQ2hhbmdlKGRpZmYsIG9sZFN0eWxlKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcAppbmRleCA4MjlmZTNmLi44ZTY1MmRlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuY3BwCkBAIC0zNCwx OCArMzQsMTggQEAgUXVvdGVzRGF0YSogUXVvdGVzRGF0YTo6Y3JlYXRlKGludCBzdHJpbmdDb3Vu dCkKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxRdW90ZXNEYXRhKj4odG1wKTsKIH0KIAot Ym9vbCBRdW90ZXNEYXRhOjpvcGVyYXRvcj09KGNvbnN0IFF1b3Rlc0RhdGEmIG90aGVyKSBjb25z dAorYm9vbCBRdW90ZXNEYXRhOjplcXVhbChjb25zdCBRdW90ZXNEYXRhKiBhLCBjb25zdCBRdW90 ZXNEYXRhKiBiKQogewotICAgIGlmICh0aGlzID09ICZvdGhlcikKKyAgICBpZiAoYSA9PSBiKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAoISZvdGhlciB8fCAhdGhpcykKKyAgICBpZiAo IWEgfHwgIWIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAobGVuZ3RoICE9IG90aGVy Lmxlbmd0aCkKKyAgICBpZiAoYS0+bGVuZ3RoICE9IGItPmxlbmd0aCkKICAgICAgICAgcmV0dXJu IGZhbHNlOwotICAgIGNvbnN0IFN0cmluZyogbXlEYXRhID0gZGF0YSgpOwotICAgIGNvbnN0IFN0 cmluZyogb3RoZXJEYXRhID0gb3RoZXIuZGF0YSgpOwotICAgIGZvciAoaW50IGkgPSBsZW5ndGgt MTsgaSA+PSAwOyAtLWkpCi0gICAgICAgIGlmIChteURhdGFbaV0gIT0gb3RoZXJEYXRhW2ldKQor ICAgIGNvbnN0IFN0cmluZyogYURhdGEgPSBhLT5kYXRhKCk7CisgICAgY29uc3QgU3RyaW5nKiBi RGF0YSA9IGItPmRhdGEoKTsKKyAgICBmb3IgKGludCBpID0gYS0+bGVuZ3RoIC0gMTsgaSA+PSAw OyAtLWkpCisgICAgICAgIGlmIChhRGF0YVtpXSAhPSBiRGF0YVtpXSkKICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvUXVvdGVzRGF0YS5oCmluZGV4IGRmOGE2ZGQuLjhjMzgzNjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuaApAQCAtMzMsOCArMzMsOCBAQCBw dWJsaWM6CiAgICAgU3RyaW5nKiBkYXRhKCkgeyByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxTdHJp bmcqPih0aGlzKzEpOyB9CiAgICAgY29uc3QgU3RyaW5nKiBkYXRhKCkgY29uc3QgeyByZXR1cm4g cmVpbnRlcnByZXRfY2FzdDxjb25zdCBTdHJpbmcqPih0aGlzKzEpOyB9CiAgICAgaW50IGxlbmd0 aDsKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgUXVvdGVzRGF0YSYpIGNvbnN0OwogICAgIHZv aWQgb3BlcmF0b3IgZGVsZXRlKHZvaWQqIHApIHsgZGVsZXRlW10gc3RhdGljX2Nhc3Q8Y2hhcio+ KHApOyB9CisgICAgc3RhdGljIGJvb2wgZXF1YWwoY29uc3QgUXVvdGVzRGF0YSogYSwgY29uc3Qg UXVvdGVzRGF0YSogYik7CiBwcml2YXRlOgogICAgIFF1b3Rlc0RhdGEoaW50IHN0cmluZ0NvdW50 KSA6IGxlbmd0aChzdHJpbmdDb3VudCkge30KIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCBmNGVkM2ZiLi44MDhiYTY4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKQEAgLTYzMCw3 ICs2MzAsNyBAQCB2b2lkIFJlbmRlclN0eWxlOjpzZXRDdXJzb3JMaXN0KFBhc3NSZWZQdHI8Q3Vy c29yTGlzdD4gb3RoZXIpCiAKIHZvaWQgUmVuZGVyU3R5bGU6OnNldFF1b3RlcyhQYXNzUmVmUHRy PFF1b3Rlc0RhdGE+IHEpCiB7Ci0gICAgaWYgKCpyYXJlSW5oZXJpdGVkRGF0YS0+cXVvdGVzLmdl dCgpID09ICpxLmdldCgpKQorICAgIGlmIChRdW90ZXNEYXRhOjplcXVhbChyYXJlSW5oZXJpdGVk RGF0YS0+cXVvdGVzLmdldCgpLCBxLmdldCgpKSkKICAgICAgICAgcmV0dXJuOwogICAgIHJhcmVJ bmhlcml0ZWREYXRhLmFjY2VzcygpLT5xdW90ZXMgPSBxOwogfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuY3BwCmlu ZGV4IDExNjA2YjEuLjA2MjFjZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5jcHAKQEAgLTE0Myw3ICsxNDMs NyBAQCBib29sIFN0eWxlUmFyZUluaGVyaXRlZERhdGE6Om9wZXJhdG9yPT0oY29uc3QgU3R5bGVS YXJlSW5oZXJpdGVkRGF0YSYgbykgY29uc3QKICAgICAgICAgJiYgaHlwaGVuYXRpb25TdHJpbmcg PT0gby5oeXBoZW5hdGlvblN0cmluZwogICAgICAgICAmJiBsb2NhbGUgPT0gby5sb2NhbGUKICAg ICAgICAgJiYgdGV4dEVtcGhhc2lzQ3VzdG9tTWFyayA9PSBvLnRleHRFbXBoYXNpc0N1c3RvbU1h cmsKLSAgICAgICAgJiYgKnF1b3RlcyA9PSAqby5xdW90ZXMKKyAgICAgICAgJiYgUXVvdGVzRGF0 YTo6ZXF1YWwocXVvdGVzLmdldCgpLCBvLnF1b3Rlcy5nZXQoKSk7CiAgICAgICAgICYmIG1faW1h Z2VSZW5kZXJpbmcgPT0gby5tX2ltYWdlUmVuZGVyaW5nOwogfQogCg== 103484 2011-08-10 07:10:20 -0700 2011-08-10 07:36:10 -0700 updated 65944.patch text/plain 4884 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTM2OGFhLi43NDAzMGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMDgtMDkgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1OTQ0CisgICAgICAgIFJlcGxhY2Ug UXVvdGVzRGF0YTo6b3BlcmF0b3I9PSgpIHdpdGggUXVvdGVzRGF0YTo6ZXF1YWwoY29uc3QgUXVv dGVzRGF0YSoKKyAgICAgICAgLCBjb25zdCBRdW90ZXNEYXRhKikgYmVjYXVzZSBRdW90ZXNEYXRh OjpvcGVyYXRvcj09KCkgd2VyZSB1c2luZyBub24tc3RhbmRhcmQKKyAgICAgICAgQysrIGNvZGUg dGhhdCBpcyBub3Qgc3VwcG9ydGVkIGJ5IGFsbCBjb21waWxlcnMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugc29t ZSBleGlzdGluZyB0ZXN0IGNhc2VzIGNhbiBzaG93IHRoZSBpc3N1ZSwKKyAgICAgICAgZm9yIGV4 YW1wbGUsIGZhc3QvY3NzL2NvbnRlbnQvY29udGVudC1xdW90ZXMtMDEuaHRtbC4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJRdW90ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJR dW90ZTo6c3R5bGVEaWRDaGFuZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9RdW90ZXNE YXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1b3Rlc0RhdGE6OmVxdWFsKToKKyAgICAgICAg KiByZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oOgorICAgICAgICAqIHJlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTdHlsZTo6c2V0UXVv dGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJhcmVJbmhlcml0ZWREYXRhOjpvcGVyYXRvcj09 KToKKwogMjAxMS0wNy0yOCAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJRdW90ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUXVv dGUuY3BwCmluZGV4IDQ1MjNkZjguLjQ1ZTU5OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJRdW90ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclF1b3RlLmNwcApAQCAtMzIzLDcgKzMyMyw3IEBAIHZvaWQgUmVuZGVyUXVvdGU6OnN0 eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xk U3R5CiB7CiAgICAgY29uc3QgUXVvdGVzRGF0YSogbmV3UXVvdGVzID0gc3R5bGUoKS0+cXVvdGVz KCk7CiAgICAgY29uc3QgUXVvdGVzRGF0YSogb2xkUXVvdGVzID0gb2xkU3R5bGUgPyBvbGRTdHls ZS0+cXVvdGVzKCkgOiAwOwotICAgIGlmICghKChuZXdRdW90ZXMgJiYgb2xkUXVvdGVzICYmICgq bmV3UXVvdGVzID09ICpvbGRRdW90ZXMpKSB8fCAoIW5ld1F1b3RlcyAmJiAhb2xkUXVvdGVzKSkp CisgICAgaWYgKCFRdW90ZXNEYXRhOjplcXVhbChuZXdRdW90ZXMsIG9sZFF1b3RlcykpCiAgICAg ICAgIHNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2FsYygpOwogICAgIFJlbmRlclRleHQ6 OnN0eWxlRGlkQ2hhbmdlKGRpZmYsIG9sZFN0eWxlKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcAppbmRleCA4MjlmZTNmLi44ZTY1MmRlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuY3BwCkBAIC0zNCwx OCArMzQsMTggQEAgUXVvdGVzRGF0YSogUXVvdGVzRGF0YTo6Y3JlYXRlKGludCBzdHJpbmdDb3Vu dCkKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxRdW90ZXNEYXRhKj4odG1wKTsKIH0KIAot Ym9vbCBRdW90ZXNEYXRhOjpvcGVyYXRvcj09KGNvbnN0IFF1b3Rlc0RhdGEmIG90aGVyKSBjb25z dAorYm9vbCBRdW90ZXNEYXRhOjplcXVhbChjb25zdCBRdW90ZXNEYXRhKiBhLCBjb25zdCBRdW90 ZXNEYXRhKiBiKQogewotICAgIGlmICh0aGlzID09ICZvdGhlcikKKyAgICBpZiAoYSA9PSBiKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAoISZvdGhlciB8fCAhdGhpcykKKyAgICBpZiAo IWEgfHwgIWIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAobGVuZ3RoICE9IG90aGVy Lmxlbmd0aCkKKyAgICBpZiAoYS0+bGVuZ3RoICE9IGItPmxlbmd0aCkKICAgICAgICAgcmV0dXJu IGZhbHNlOwotICAgIGNvbnN0IFN0cmluZyogbXlEYXRhID0gZGF0YSgpOwotICAgIGNvbnN0IFN0 cmluZyogb3RoZXJEYXRhID0gb3RoZXIuZGF0YSgpOwotICAgIGZvciAoaW50IGkgPSBsZW5ndGgt MTsgaSA+PSAwOyAtLWkpCi0gICAgICAgIGlmIChteURhdGFbaV0gIT0gb3RoZXJEYXRhW2ldKQor ICAgIGNvbnN0IFN0cmluZyogYURhdGEgPSBhLT5kYXRhKCk7CisgICAgY29uc3QgU3RyaW5nKiBi RGF0YSA9IGItPmRhdGEoKTsKKyAgICBmb3IgKGludCBpID0gYS0+bGVuZ3RoIC0gMTsgaSA+PSAw OyAtLWkpCisgICAgICAgIGlmIChhRGF0YVtpXSAhPSBiRGF0YVtpXSkKICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvUXVvdGVzRGF0YS5oCmluZGV4IGRmOGE2ZGQuLjhjMzgzNjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuaApAQCAtMzMsOCArMzMsOCBAQCBw dWJsaWM6CiAgICAgU3RyaW5nKiBkYXRhKCkgeyByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxTdHJp bmcqPih0aGlzKzEpOyB9CiAgICAgY29uc3QgU3RyaW5nKiBkYXRhKCkgY29uc3QgeyByZXR1cm4g cmVpbnRlcnByZXRfY2FzdDxjb25zdCBTdHJpbmcqPih0aGlzKzEpOyB9CiAgICAgaW50IGxlbmd0 aDsKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgUXVvdGVzRGF0YSYpIGNvbnN0OwogICAgIHZv aWQgb3BlcmF0b3IgZGVsZXRlKHZvaWQqIHApIHsgZGVsZXRlW10gc3RhdGljX2Nhc3Q8Y2hhcio+ KHApOyB9CisgICAgc3RhdGljIGJvb2wgZXF1YWwoY29uc3QgUXVvdGVzRGF0YSogYSwgY29uc3Qg UXVvdGVzRGF0YSogYik7CiBwcml2YXRlOgogICAgIFF1b3Rlc0RhdGEoaW50IHN0cmluZ0NvdW50 KSA6IGxlbmd0aChzdHJpbmdDb3VudCkge30KIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCBmNGVkM2ZiLi44MDhiYTY4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKQEAgLTYzMCw3 ICs2MzAsNyBAQCB2b2lkIFJlbmRlclN0eWxlOjpzZXRDdXJzb3JMaXN0KFBhc3NSZWZQdHI8Q3Vy c29yTGlzdD4gb3RoZXIpCiAKIHZvaWQgUmVuZGVyU3R5bGU6OnNldFF1b3RlcyhQYXNzUmVmUHRy PFF1b3Rlc0RhdGE+IHEpCiB7Ci0gICAgaWYgKCpyYXJlSW5oZXJpdGVkRGF0YS0+cXVvdGVzLmdl dCgpID09ICpxLmdldCgpKQorICAgIGlmIChRdW90ZXNEYXRhOjplcXVhbChyYXJlSW5oZXJpdGVk RGF0YS0+cXVvdGVzLmdldCgpLCBxLmdldCgpKSkKICAgICAgICAgcmV0dXJuOwogICAgIHJhcmVJ bmhlcml0ZWREYXRhLmFjY2VzcygpLT5xdW90ZXMgPSBxOwogfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuY3BwCmlu ZGV4IDExNjA2YjEuLmZhMDlhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5jcHAKQEAgLTE0Myw3ICsxNDMs NyBAQCBib29sIFN0eWxlUmFyZUluaGVyaXRlZERhdGE6Om9wZXJhdG9yPT0oY29uc3QgU3R5bGVS YXJlSW5oZXJpdGVkRGF0YSYgbykgY29uc3QKICAgICAgICAgJiYgaHlwaGVuYXRpb25TdHJpbmcg PT0gby5oeXBoZW5hdGlvblN0cmluZwogICAgICAgICAmJiBsb2NhbGUgPT0gby5sb2NhbGUKICAg ICAgICAgJiYgdGV4dEVtcGhhc2lzQ3VzdG9tTWFyayA9PSBvLnRleHRFbXBoYXNpc0N1c3RvbU1h cmsKLSAgICAgICAgJiYgKnF1b3RlcyA9PSAqby5xdW90ZXMKKyAgICAgICAgJiYgUXVvdGVzRGF0 YTo6ZXF1YWwocXVvdGVzLmdldCgpLCBvLnF1b3Rlcy5nZXQoKSkKICAgICAgICAgJiYgbV9pbWFn ZVJlbmRlcmluZyA9PSBvLm1faW1hZ2VSZW5kZXJpbmc7CiB9CiAK 103489 2011-08-10 07:36:10 -0700 2011-08-11 12:23:10 -0700 Fix style issue 65944.patch text/plain 4990 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTM2OGFhLi43NDAzMGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMDgtMDkgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1OTQ0CisgICAgICAgIFJlcGxhY2Ug UXVvdGVzRGF0YTo6b3BlcmF0b3I9PSgpIHdpdGggUXVvdGVzRGF0YTo6ZXF1YWwoY29uc3QgUXVv dGVzRGF0YSoKKyAgICAgICAgLCBjb25zdCBRdW90ZXNEYXRhKikgYmVjYXVzZSBRdW90ZXNEYXRh OjpvcGVyYXRvcj09KCkgd2VyZSB1c2luZyBub24tc3RhbmRhcmQKKyAgICAgICAgQysrIGNvZGUg dGhhdCBpcyBub3Qgc3VwcG9ydGVkIGJ5IGFsbCBjb21waWxlcnMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugc29t ZSBleGlzdGluZyB0ZXN0IGNhc2VzIGNhbiBzaG93IHRoZSBpc3N1ZSwKKyAgICAgICAgZm9yIGV4 YW1wbGUsIGZhc3QvY3NzL2NvbnRlbnQvY29udGVudC1xdW90ZXMtMDEuaHRtbC4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJRdW90ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJR dW90ZTo6c3R5bGVEaWRDaGFuZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9RdW90ZXNE YXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1b3Rlc0RhdGE6OmVxdWFsKToKKyAgICAgICAg KiByZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oOgorICAgICAgICAqIHJlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTdHlsZTo6c2V0UXVv dGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJhcmVJbmhlcml0ZWREYXRhOjpvcGVyYXRvcj09 KToKKwogMjAxMS0wNy0yOCAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJRdW90ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUXVv dGUuY3BwCmluZGV4IDQ1MjNkZjguLjQ1ZTU5OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJRdW90ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclF1b3RlLmNwcApAQCAtMzIzLDcgKzMyMyw3IEBAIHZvaWQgUmVuZGVyUXVvdGU6OnN0 eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xk U3R5CiB7CiAgICAgY29uc3QgUXVvdGVzRGF0YSogbmV3UXVvdGVzID0gc3R5bGUoKS0+cXVvdGVz KCk7CiAgICAgY29uc3QgUXVvdGVzRGF0YSogb2xkUXVvdGVzID0gb2xkU3R5bGUgPyBvbGRTdHls ZS0+cXVvdGVzKCkgOiAwOwotICAgIGlmICghKChuZXdRdW90ZXMgJiYgb2xkUXVvdGVzICYmICgq bmV3UXVvdGVzID09ICpvbGRRdW90ZXMpKSB8fCAoIW5ld1F1b3RlcyAmJiAhb2xkUXVvdGVzKSkp CisgICAgaWYgKCFRdW90ZXNEYXRhOjplcXVhbChuZXdRdW90ZXMsIG9sZFF1b3RlcykpCiAgICAg ICAgIHNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2FsYygpOwogICAgIFJlbmRlclRleHQ6 OnN0eWxlRGlkQ2hhbmdlKGRpZmYsIG9sZFN0eWxlKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9RdW90ZXNEYXRhLmNwcAppbmRleCA4MjlmZTNmLi4wM2EyNTU0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuY3BwCkBAIC0zNCwx OCArMzQsMTggQEAgUXVvdGVzRGF0YSogUXVvdGVzRGF0YTo6Y3JlYXRlKGludCBzdHJpbmdDb3Vu dCkKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxRdW90ZXNEYXRhKj4odG1wKTsKIH0KIAot Ym9vbCBRdW90ZXNEYXRhOjpvcGVyYXRvcj09KGNvbnN0IFF1b3Rlc0RhdGEmIG90aGVyKSBjb25z dAorYm9vbCBRdW90ZXNEYXRhOjplcXVhbChjb25zdCBRdW90ZXNEYXRhKiBxdW90ZXNEYXRhMSwg Y29uc3QgUXVvdGVzRGF0YSogcXVvdGVzRGF0YTIpCiB7Ci0gICAgaWYgKHRoaXMgPT0gJm90aGVy KQorICAgIGlmIChxdW90ZXNEYXRhMSA9PSBxdW90ZXNEYXRhMikKICAgICAgICAgcmV0dXJuIHRy dWU7Ci0gICAgaWYgKCEmb3RoZXIgfHwgIXRoaXMpCisgICAgaWYgKCFxdW90ZXNEYXRhMSB8fCAh cXVvdGVzRGF0YTIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAobGVuZ3RoICE9IG90 aGVyLmxlbmd0aCkKKyAgICBpZiAocXVvdGVzRGF0YTEtPmxlbmd0aCAhPSBxdW90ZXNEYXRhMi0+ bGVuZ3RoKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgY29uc3QgU3RyaW5nKiBteURhdGEg PSBkYXRhKCk7Ci0gICAgY29uc3QgU3RyaW5nKiBvdGhlckRhdGEgPSBvdGhlci5kYXRhKCk7Ci0g ICAgZm9yIChpbnQgaSA9IGxlbmd0aC0xOyBpID49IDA7IC0taSkKLSAgICAgICAgaWYgKG15RGF0 YVtpXSAhPSBvdGhlckRhdGFbaV0pCisgICAgY29uc3QgU3RyaW5nKiBkYXRhMSA9IHF1b3Rlc0Rh dGExLT5kYXRhKCk7CisgICAgY29uc3QgU3RyaW5nKiBkYXRhMiA9IHF1b3Rlc0RhdGEyLT5kYXRh KCk7CisgICAgZm9yIChpbnQgaSA9IHF1b3Rlc0RhdGExLT5sZW5ndGggLSAxOyBpID49IDA7IC0t aSkKKyAgICAgICAgaWYgKGRhdGExW2ldICE9IGRhdGEyW2ldKQogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIHJldHVybiB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dHlsZS9RdW90ZXNEYXRhLmgKaW5kZXggZGY4YTZkZC4uNTc0NDcwYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1F1b3Rlc0RhdGEuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvUXVvdGVzRGF0YS5oCkBAIC0zMyw4ICszMyw4IEBAIHB1Ymxp YzoKICAgICBTdHJpbmcqIGRhdGEoKSB7IHJldHVybiByZWludGVycHJldF9jYXN0PFN0cmluZyo+ KHRoaXMrMSk7IH0KICAgICBjb25zdCBTdHJpbmcqIGRhdGEoKSBjb25zdCB7IHJldHVybiByZWlu dGVycHJldF9jYXN0PGNvbnN0IFN0cmluZyo+KHRoaXMrMSk7IH0KICAgICBpbnQgbGVuZ3RoOwot ICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBRdW90ZXNEYXRhJikgY29uc3Q7CiAgICAgdm9pZCBv cGVyYXRvciBkZWxldGUodm9pZCogcCkgeyBkZWxldGVbXSBzdGF0aWNfY2FzdDxjaGFyKj4ocCk7 IH0KKyAgICBzdGF0aWMgYm9vbCBlcXVhbChjb25zdCBRdW90ZXNEYXRhKiwgY29uc3QgUXVvdGVz RGF0YSopOwogcHJpdmF0ZToKICAgICBRdW90ZXNEYXRhKGludCBzdHJpbmdDb3VudCkgOiBsZW5n dGgoc3RyaW5nQ291bnQpIHt9CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHAKaW5kZXggZjRlZDNmYi4uODA4YmE2OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCkBAIC02MzAsNyArNjMwLDcg QEAgdm9pZCBSZW5kZXJTdHlsZTo6c2V0Q3Vyc29yTGlzdChQYXNzUmVmUHRyPEN1cnNvckxpc3Q+ IG90aGVyKQogCiB2b2lkIFJlbmRlclN0eWxlOjpzZXRRdW90ZXMoUGFzc1JlZlB0cjxRdW90ZXNE YXRhPiBxKQogewotICAgIGlmICgqcmFyZUluaGVyaXRlZERhdGEtPnF1b3Rlcy5nZXQoKSA9PSAq cS5nZXQoKSkKKyAgICBpZiAoUXVvdGVzRGF0YTo6ZXF1YWwocmFyZUluaGVyaXRlZERhdGEtPnF1 b3Rlcy5nZXQoKSwgcS5nZXQoKSkpCiAgICAgICAgIHJldHVybjsKICAgICByYXJlSW5oZXJpdGVk RGF0YS5hY2Nlc3MoKS0+cXVvdGVzID0gcTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcAppbmRleCAxMTYw NmIxLi5mYTA5YTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUv U3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuY3BwCkBAIC0xNDMsNyArMTQzLDcgQEAgYm9v bCBTdHlsZVJhcmVJbmhlcml0ZWREYXRhOjpvcGVyYXRvcj09KGNvbnN0IFN0eWxlUmFyZUluaGVy aXRlZERhdGEmIG8pIGNvbnN0CiAgICAgICAgICYmIGh5cGhlbmF0aW9uU3RyaW5nID09IG8uaHlw aGVuYXRpb25TdHJpbmcKICAgICAgICAgJiYgbG9jYWxlID09IG8ubG9jYWxlCiAgICAgICAgICYm IHRleHRFbXBoYXNpc0N1c3RvbU1hcmsgPT0gby50ZXh0RW1waGFzaXNDdXN0b21NYXJrCi0gICAg ICAgICYmICpxdW90ZXMgPT0gKm8ucXVvdGVzCisgICAgICAgICYmIFF1b3Rlc0RhdGE6OmVxdWFs KHF1b3Rlcy5nZXQoKSwgby5xdW90ZXMuZ2V0KCkpCiAgICAgICAgICYmIG1faW1hZ2VSZW5kZXJp bmcgPT0gby5tX2ltYWdlUmVuZGVyaW5nOwogfQogCg==