65943 2011-08-09 14:26:41 -0700 DFG JIT passes the this argument to constructors even though it's not necessary 2011-08-09 17:31:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 448808 0 fpizlo 2011-08-09 14:26:41 -0700 The DFG JIT passes the this argument to constructors, even though constructors create this themselves. The DFG should not pass this to constructors. 448811 1 103399 fpizlo 2011-08-09 14:29:16 -0700 Created attachment 103399 the patch 448909 2 103399 webkit.review.bot 2011-08-09 17:31:04 -0700 Comment on attachment 103399 the patch Clearing flags on attachment: 103399 Committed r92732: <http://trac.webkit.org/changeset/92732> 448910 3 webkit.review.bot 2011-08-09 17:31:09 -0700 All reviewed patches have been landed. Closing bug. 103399 2011-08-09 14:29:16 -0700 2011-08-09 17:31:04 -0700 the patch nopassthis_patch_1.diff text/plain 1550 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTI3MDgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDgtMDkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHBhc3NlcyB0aGUgdGhpcyBhcmd1bWVudCB0byBjb25zdHJ1Y3RvcnMgZXZlbiB0aG91 Z2gKKyAgICAgICAgaXQncyBub3QgbmVjZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTk0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuY3BwOgorICAg ICAgICAoSlNDOjpERkc6OkpJVENvZGVHZW5lcmF0b3I6OmVtaXRDYWxsKToKKwogMjAxMS0wOC0w OSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZCBQYXJlbnRDbGFzcyB0eXBlZGVmIGluIGFsbCBKU0MgY2xhc3NlcwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lv biA5MjY2NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVyYXRv ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk5OSw3ICs5OTksNyBAQCB2b2lkIEpJVENvZGVHZW5l cmF0b3I6OmVtaXRDYWxsKE5vZGUmIG5vCiAgICAgbV9qaXQuc3RvcmVQdHIoTWFjcm9Bc3NlbWJs ZXI6OlRydXN0ZWRJbW1QdHIoSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKG51bUFyZ3MpKSksIGFk ZHJlc3NPZkNhbGxEYXRhKFJlZ2lzdGVyRmlsZTo6QXJndW1lbnRDb3VudCkpOwogICAgIG1faml0 LnN0b3JlUHRyKEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBhZGRyZXNzT2ZDYWxsRGF0YShS ZWdpc3RlckZpbGU6OkNhbGxlckZyYW1lKSk7CiAgICAgCi0gICAgZm9yIChpbnQgYXJnSWR4ID0g MDsgYXJnSWR4IDwgbnVtQXJnczsgYXJnSWR4KyspIHsKKyAgICBmb3IgKGludCBhcmdJZHggPSAo bm9kZS5vcCA9PSBDYWxsID8gMCA6IDEpOyBhcmdJZHggPCBudW1BcmdzOyBhcmdJZHgrKykgewog ICAgICAgICBOb2RlSW5kZXggYXJnTm9kZUluZGV4ID0gbV9qaXQuZ3JhcGgoKS5tX3ZhckFyZ0No aWxkcmVuW25vZGUuZmlyc3RDaGlsZCgpICsgMSArIGFyZ0lkeF07CiAgICAgICAgIEpTVmFsdWVP cGVyYW5kIGFyZyh0aGlzLCBhcmdOb2RlSW5kZXgpOwogICAgICAgICBHUFJSZWcgYXJnR1BSID0g YXJnLmdwcigpOwo=