<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65918</bug_id>
          
          <creation_ts>2011-08-09 06:47:07 -0700</creation_ts>
          <short_desc>Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style</short_desc>
          <delta_ts>2011-08-10 06:38:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexander Pavlov (apavlov)">apavlov</reporter>
          <assigned_to name="Alexander Pavlov (apavlov)">apavlov</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>448561</commentid>
    <comment_count>0</comment_count>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2011-08-09 06:47:07 -0700</bug_when>
    <thetext>1. Bring up Web Inspector for any element
2. Start editing new/existing CSS property value in the Styles pane (Elements panel)
3. Press Enter or Tab to commit the property.

What is the expected output?
A new property editor appears

What do you see instead?
Oftentimes, no property editor appears. This works fine for non-inline styles and seems to be a regression introduced in http://trac.webkit.org/changeset/91070 (essentially, a race condition mostly seen with large stylesheets and/or Debug builds).

Upstreaming http://code.google.com/p/chromium/issues/detail?id=91822</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>448617</commentid>
    <comment_count>1</comment_count>
      <attachid>103366</attachid>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2011-08-09 09:19:00 -0700</bug_when>
    <thetext>Created attachment 103366
[PATCH] Suggested fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449065</commentid>
    <comment_count>2</comment_count>
      <attachid>103366</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2011-08-10 03:08:55 -0700</bug_when>
    <thetext>Comment on attachment 103366
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=103366&amp;action=review

Looks promising!

&gt; Source/WebCore/inspector/front-end/StylesSidebarPane.js:936
&gt; +    update: function(full, callback)

Is this change needed?

&gt; Source/WebCore/inspector/front-end/StylesSidebarPane.js:1623
&gt; +    _updateAll: function(userCallback)

What does updateAll actually do?

&gt; Source/WebCore/inspector/front-end/StylesSidebarPane.js:2100
&gt; +            --parentPane._userOperation;

You should keep userOperation&apos;s logging + invent a new flag for this &quot;transitioning between the values&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449086</commentid>
    <comment_count>3</comment_count>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2011-08-10 05:04:21 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 103366 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=103366&amp;action=review
&gt; 
&gt; Looks promising!
&gt; 
&gt; &gt; Source/WebCore/inspector/front-end/StylesSidebarPane.js:936
&gt; &gt; +    update: function(full, callback)
&gt; 
&gt; Is this change needed?

Good point, rewrote the call site.

&gt; &gt; Source/WebCore/inspector/front-end/StylesSidebarPane.js:1623
&gt; &gt; +    _updateAll: function(userCallback)
&gt; 
&gt; What does updateAll actually do?

It attempts to update the biggest possible scope accessible from this tree element (i.e., the Styles pane (the parent section has the &quot;pane&quot; field set), the parent section (no &quot;pane&quot; field), or the element&apos;s title (no parent section)). After some experimenting, I failed to hit the second and the third cases, so I&apos;ve cleaned them up and renamed the method to _updatePane().

&gt; &gt; Source/WebCore/inspector/front-end/StylesSidebarPane.js:2100
&gt; &gt; +            --parentPane._userOperation;
&gt; 
&gt; You should keep userOperation&apos;s logging + invent a new flag for this &quot;transitioning between the values&quot;.

logging -&gt; logic. I&apos;ve managed to get rid of this counting merely by avoiding the flag modification in the !updateInterface case (since in the !updateInterface case the _isEditingStyle flag is true, and we are safe).

Attaching an updated patch shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449093</commentid>
    <comment_count>4</comment_count>
      <attachid>103466</attachid>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2011-08-10 05:17:56 -0700</bug_when>
    <thetext>Created attachment 103466
[PATCH] Comments addressed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>449119</commentid>
    <comment_count>5</comment_count>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2011-08-10 06:38:47 -0700</bug_when>
    <thetext>Committed r92764: &lt;http://trac.webkit.org/changeset/92764&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103366</attachid>
            <date>2011-08-09 09:19:00 -0700</date>
            <delta_ts>2011-08-10 05:17:56 -0700</delta_ts>
            <desc>[PATCH] Suggested fix</desc>
            <filename>regressiontab.patch</filename>
            <type>text/plain</type>
            <size>7900</size>
            <attacher name="Alexander Pavlov (apavlov)">apavlov</attacher>
            
              <data encoding="base64">Y29tbWl0IGUxNDk3MjFjOTVmYWNjMzlhMGRhODE1YmFhN2VhODU2NmQyMjJkNTUKQXV0aG9yOiBB
bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUdWUgQXVnIDkg
MTU6NDg6MzAgMjAxMSArMDQwMAoKICAgIEZpeAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No
YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmOTRmYzQxLi5kNWJlYjMwIDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDkgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2
bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0g
RWRpdG9yIGxvc3QgYWZ0ZXIgY29tbWl0dGluZyBhIENTUyBwcm9wZXJ0eSB2YWx1ZSBmb3IgaW5s
aW5lIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02NTkxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtY29tbWl0LWVkaXRpbmcuaHRtbDoKKwogMjAxMS0w
OC0wOSAgQW5kcmVpIFBvcGVzY3UgIDxhbmRyZWlwQGdvb2dsZS5jb20+CiAKICAgICAgICAgW0No
cm9taXVtXSBVcGRhdGUgdGVzdCBleHBlY3RhdGlvbnMgZm9yIGZhc3Qvd3JpdGluZy1tb2RlL2ph
cGFuZXNlLXJsLXRleHQtd2l0aC1icm9rZW4tZm9udC5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRU
ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1jb21taXQtZWRpdGluZy5odG1sIGIvTGF5b3V0
VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtY29tbWl0LWVkaXRpbmcuaHRtbAppbmRleCAz
ZDczZWRkLi5mN2YzZDYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVz
L3N0eWxlcy1jb21taXQtZWRpdGluZy5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9z
dHlsZXMvc3R5bGVzLWNvbW1pdC1lZGl0aW5nLmh0bWwKQEAgLTM0LDYgKzM0LDEwIEBAIGZ1bmN0
aW9uIHRlc3QoKQogCiAgICAgZnVuY3Rpb24gc3RlcDIoKQogICAgIHsKKyAgICAgICAgaWYgKCFX
ZWJJbnNwZWN0b3IuaXNFZGl0aW5nQW55RmllbGQoKSkgeworICAgICAgICAgICAgSW5zcGVjdG9y
VGVzdC5hZGRSZXN1bHQoIk5vIG5ldyBwcm9wZXJ0eSBlZGl0b3IgYWN0aXZlISIpOworICAgICAg
ICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAgICAgICAgfQogICAgICAgICBJ
bnNwZWN0b3JUZXN0LnNlbGVjdE5vZGVXaXRoSWQoIm90aGVyIik7CiAgICAgICAgIEluc3BlY3Rv
clRlc3QucnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyhzdGVwMyk7CiAgICAgfQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu
ZGV4IGMzYmM5YmMuLjVhZWI3MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0w
OC0wOSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAg
IFdlYiBJbnNwZWN0b3I6IFtSRUdSRVNTSU9OXSBFZGl0b3IgbG9zdCBhZnRlciBjb21taXR0aW5n
IGEgQ1NTIHByb3BlcnR5IHZhbHVlIGZvciBpbmxpbmUgc3R5bGUKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1OTE4CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxl
c1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5l
LnByb3RvdHlwZS5faW5uZXJVcGRhdGUuc3R5bGVzQ2FsbGJhY2spOgorICAgICAgICAoV2ViSW5z
cGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLnByb3RvdHlwZS5faW5uZXJVcGRhdGUuY29tcHV0ZWRT
dHlsZUNhbGxiYWNrKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5w
cm90b3R5cGUuX2lubmVyVXBkYXRlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3Bl
cnRpZXNTZWN0aW9uLnByb3RvdHlwZS51cGRhdGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0
eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9y
LlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUuc3R5bGVUZXh0LnVwZGF0ZUludGVy
ZmFjZS5tYWpvckNoYW5nZS5pc1JldmVydC5wYXJlbnRQYW5lKToKKyAgICAgICAgKFdlYkluc3Bl
Y3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlLnN0eWxlVGV4dC51cGRhdGVJ
bnRlcmZhY2UubWFqb3JDaGFuZ2UuaXNSZXZlcnQudXNlckNhbGxiYWNrKToKKwogMjAxMS0wOC0w
OSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg
SW5zcGVjdG9yOiBBZGQgIlJlZnJlc2giIHRvIGNvbnRleHQgbWVudSBvZiByZXNvdXJjZXMgcGFu
ZWwgY29va2llcyB2aWV3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy
b250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m
cm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggMDA0Mjg5ZS4uNDhmYTI0NSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFy
UGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1Np
ZGViYXJQYW5lLmpzCkBAIC0yMzgsMTMgKzIzOCwxNSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lk
ZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9pbm5lclVwZGF0ZShyZWZyZXNo
LCBudWxsKTsKICAgICB9LAogCi0gICAgX2lubmVyVXBkYXRlOiBmdW5jdGlvbihyZWZyZXNoLCBl
ZGl0ZWRTZWN0aW9uKQorICAgIF9pbm5lclVwZGF0ZTogZnVuY3Rpb24ocmVmcmVzaCwgZWRpdGVk
U2VjdGlvbiwgdXNlckNhbGxiYWNrKQogICAgIHsKICAgICAgICAgdmFyIG5vZGUgPSB0aGlzLm5v
ZGU7CiAgICAgICAgIGlmICghbm9kZSkgewogICAgICAgICAgICAgdGhpcy5fc2VjdGlvbnNDb250
YWluZXIucmVtb3ZlQ2hpbGRyZW4oKTsKICAgICAgICAgICAgIHRoaXMuX2NvbXB1dGVkU3R5bGVQ
YW5lLmJvZHlFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgICAgICB0aGlzLnNlY3Rp
b25zID0ge307CisgICAgICAgICAgICBpZiAodXNlckNhbGxiYWNrKQorICAgICAgICAgICAgICAg
IHVzZXJDYWxsYmFjaygpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKQEAgLTI1
MiwxMiArMjU0LDE2IEBAIFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUg
PSB7CiAgICAgICAgIHsKICAgICAgICAgICAgIGlmICh0aGlzLm5vZGUgPT09IG5vZGUgJiYgc3R5
bGVzKQogICAgICAgICAgICAgICAgIHRoaXMuX3JlYnVpbGRVcGRhdGUobm9kZSwgc3R5bGVzKTsK
KyAgICAgICAgICAgIGlmICh1c2VyQ2FsbGJhY2spCisgICAgICAgICAgICAgICAgdXNlckNhbGxi
YWNrKCk7CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiBjb21wdXRlZFN0eWxlQ2FsbGJh
Y2soY29tcHV0ZWRTdHlsZSkKICAgICAgICAgewogICAgICAgICAgICAgaWYgKHRoaXMubm9kZSA9
PT0gbm9kZSAmJiBjb21wdXRlZFN0eWxlKQogICAgICAgICAgICAgICAgIHRoaXMuX3JlZnJlc2hV
cGRhdGUobm9kZSwgY29tcHV0ZWRTdHlsZSwgZWRpdGVkU2VjdGlvbik7CisgICAgICAgICAgICBp
ZiAodXNlckNhbGxiYWNrKQorICAgICAgICAgICAgICAgIHVzZXJDYWxsYmFjaygpOwogICAgICAg
ICB9CiAKICAgICAgICAgaWYgKHJlZnJlc2gpCkBAIC05MjcsNyArOTMzLDcgQEAgV2ViSW5zcGVj
dG9yLlN0eWxlUHJvcGVydGllc1NlY3Rpb24ucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4g
Y3VyU2VjdGlvbjsKICAgICB9LAogCi0gICAgdXBkYXRlOiBmdW5jdGlvbihmdWxsKQorICAgIHVw
ZGF0ZTogZnVuY3Rpb24oZnVsbCwgY2FsbGJhY2spCiAgICAgewogICAgICAgICBpZiAoZnVsbCkg
ewogICAgICAgICAgICAgdGhpcy5wcm9wZXJ0aWVzVHJlZU91dGxpbmUucmVtb3ZlQ2hpbGRyZW4o
KTsKQEAgLTk0MCw2ICs5NDYsOCBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlv
bi5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgdGhpcy5h
ZnRlclVwZGF0ZSgpOworICAgICAgICBpZiAoY2FsbGJhY2spCisgICAgICAgICAgICBjYWxsYmFj
aygpOwogICAgIH0sCiAKICAgICBhZnRlclVwZGF0ZTogZnVuY3Rpb24oKQpAQCAtMTYxMiwxNiAr
MTYyMCwyMiBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlw
ZSA9IHsKICAgICAgICAgdGhpcy50b29sdGlwID0gdGhpcy5wcm9wZXJ0eS5wcm9wZXJ0eVRleHQ7
CiAgICAgfSwKIAotICAgIF91cGRhdGVBbGw6IGZ1bmN0aW9uKCkKKyAgICBfdXBkYXRlQWxsOiBm
dW5jdGlvbih1c2VyQ2FsbGJhY2spCiAgICAgewotICAgICAgICBpZiAoIXRoaXMudHJlZU91dGxp
bmUpCisgICAgICAgIGlmICghdGhpcy50cmVlT3V0bGluZSkgeworICAgICAgICAgICAgaWYgKHVz
ZXJDYWxsYmFjaykKKyAgICAgICAgICAgICAgICB1c2VyQ2FsbGJhY2soKTsKICAgICAgICAgICAg
IHJldHVybjsKKyAgICAgICAgfQogICAgICAgICBpZiAodGhpcy50cmVlT3V0bGluZS5zZWN0aW9u
ICYmIHRoaXMudHJlZU91dGxpbmUuc2VjdGlvbi5wYW5lKQotICAgICAgICAgICAgdGhpcy50cmVl
T3V0bGluZS5zZWN0aW9uLnBhbmUuX2lubmVyVXBkYXRlKHRydWUsIHRoaXMudHJlZU91dGxpbmUu
c2VjdGlvbik7CisgICAgICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb24ucGFuZS5faW5u
ZXJVcGRhdGUodHJ1ZSwgdGhpcy50cmVlT3V0bGluZS5zZWN0aW9uLCB1c2VyQ2FsbGJhY2spOwog
ICAgICAgICBlbHNlIGlmICh0aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb24pCi0gICAgICAgICAgICB0
aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb24udXBkYXRlKHRydWUpOwotICAgICAgICBlbHNlCisgICAg
ICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb24udXBkYXRlKHRydWUsIHVzZXJDYWxsYmFj
ayk7CisgICAgICAgIGVsc2UgewogICAgICAgICAgICAgdGhpcy51cGRhdGVUaXRsZSgpOyAvLyBG
SVhNRTogdGhpcyB3aWxsIG5vdCBzaG93IG5ldyBwcm9wZXJ0aWVzLiBCdXQgd2UgZG9uJ3QgaGl0
IHRoaXMgY2FzZSB5ZXQuCisgICAgICAgICAgICBpZiAodXNlckNhbGxiYWNrKQorICAgICAgICAg
ICAgICAgIHVzZXJDYWxsYmFjaygpOworICAgICAgICB9CiAgICAgfSwKIAogICAgIHRvZ2dsZUVu
YWJsZWQ6IGZ1bmN0aW9uKGV2ZW50KQpAQCAtMjA4MSw2ICsyMDk1LDExIEBAIFdlYkluc3BlY3Rv
ci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgYXBwbHlTdHls
ZVRleHQ6IGZ1bmN0aW9uKHN0eWxlVGV4dCwgdXBkYXRlSW50ZXJmYWNlLCBtYWpvckNoYW5nZSwg
aXNSZXZlcnQpCiAgICAgeworICAgICAgICBmdW5jdGlvbiB1c2VyT3BlcmF0aW9uRmluaXNoZWRD
YWxsYmFjayhwYXJlbnRQYW5lLCB1cGRhdGVJbnRlcmZhY2UpCisgICAgICAgIHsKKyAgICAgICAg
ICAgIC0tcGFyZW50UGFuZS5fdXNlck9wZXJhdGlvbjsKKyAgICAgICAgfQorCiAgICAgICAgIC8v
IExlYXZlIGEgd2F5IHRvIGNhbmNlbCBlZGl0aW5nIGFmdGVyIGluY3JlbWVudGFsIGNoYW5nZXMu
CiAgICAgICAgIGlmICghaXNSZXZlcnQgJiYgIXVwZGF0ZUludGVyZmFjZSAmJiAhdGhpcy5faGFz
QmVlbk1vZGlmaWVkSW5jcmVtZW50YWxseSgpKSB7CiAgICAgICAgICAgICAvLyBSZW1lbWJlciB0
aGUgcnVsZSdzIG9yaWdpbmFsIENTUyB0ZXh0IG9uIFtQYWdlXShVcHxEb3duKSwgc28gaXQgY2Fu
IGJlIHJlc3RvcmVkCkBAIC0yMTAwLDE2ICsyMTE5LDE2IEBAIFdlYkluc3BlY3Rvci5TdHlsZVBy
b3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICB9CiAKICAgICAgICAgdmFy
IGN1cnJlbnROb2RlID0gdGhpcy5fcGFyZW50UGFuZS5ub2RlOwotICAgICAgICB0aGlzLl9wYXJl
bnRQYW5lLl91c2VyT3BlcmF0aW9uID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5fcGFyZW50UGFuZS5f
dXNlck9wZXJhdGlvbiA9ICh0aGlzLl9wYXJlbnRQYW5lLl91c2VyT3BlcmF0aW9uIHx8IDApICsg
MTsKIAotICAgICAgICBmdW5jdGlvbiBjYWxsYmFjayhvcmlnaW5hbFByb3BlcnR5VGV4dCwgbmV3
U3R5bGUpCisgICAgICAgIGZ1bmN0aW9uIGNhbGxiYWNrKHVzZXJDYWxsYmFjaywgb3JpZ2luYWxQ
cm9wZXJ0eVRleHQsIG5ld1N0eWxlKQogICAgICAgICB7Ci0gICAgICAgICAgICBkZWxldGUgdGhp
cy5fcGFyZW50UGFuZS5fdXNlck9wZXJhdGlvbjsKICAgICAgICAgICAgIGlmICghbmV3U3R5bGUp
IHsKICAgICAgICAgICAgICAgICBpZiAodXBkYXRlSW50ZXJmYWNlKSB7CiAgICAgICAgICAgICAg
ICAgICAgIC8vIEl0IGRpZCBub3QgYXBwbHksIGNhbmNlbCBlZGl0aW5nLgogICAgICAgICAgICAg
ICAgICAgICB0aGlzLl9yZXZlcnRTdHlsZVVwb25FZGl0aW5nQ2FuY2VsZWQob3JpZ2luYWxQcm9w
ZXJ0eVRleHQpOwogICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB1c2VyQ2FsbGJh
Y2soKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKQEAgLTIxMjAs
MTUgKzIxMzksMTkgQEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90
b3R5cGUgPSB7CiAgICAgICAgICAgICBpZiAoc2VjdGlvbiAmJiBzZWN0aW9uLnBhbmUpCiAgICAg
ICAgICAgICAgICAgc2VjdGlvbi5wYW5lLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycygic3R5bGUg
ZWRpdGVkIik7CiAKLSAgICAgICAgICAgIGlmICh1cGRhdGVJbnRlcmZhY2UgJiYgY3VycmVudE5v
ZGUgPT09IHNlY3Rpb24ucGFuZS5ub2RlKQotICAgICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUFs
bCgpOworICAgICAgICAgICAgaWYgKHVwZGF0ZUludGVyZmFjZSAmJiBjdXJyZW50Tm9kZSA9PT0g
c2VjdGlvbi5wYW5lLm5vZGUpIHsKKyAgICAgICAgICAgICAgICB0aGlzLl91cGRhdGVBbGwodXNl
ckNhbGxiYWNrKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisKKyAg
ICAgICAgICAgIHVzZXJDYWxsYmFjaygpOwogICAgICAgICB9CiAKICAgICAgICAgLy8gQXBwZW5k
IGEgIjsiIGlmIHRoZSBuZXcgdGV4dCBkb2VzIG5vdCBlbmQgaW4gIjsiLgogICAgICAgICAvLyBG
SVhNRTogdGhpcyBkb2VzIG5vdCBoYW5kbGUgdHJhaWxpbmcgY29tbWVudHMuCiAgICAgICAgIGlm
IChzdHlsZVRleHQubGVuZ3RoICYmICEvO1xzKiQvLnRlc3Qoc3R5bGVUZXh0KSkKICAgICAgICAg
ICAgIHN0eWxlVGV4dCArPSAiOyI7Ci0gICAgICAgIHRoaXMucHJvcGVydHkuc2V0VGV4dChzdHls
ZVRleHQsIG1ham9yQ2hhbmdlLCBjYWxsYmFjay5iaW5kKHRoaXMsIHRoaXMub3JpZ2luYWxQcm9w
ZXJ0eVRleHQpKTsKKyAgICAgICAgdGhpcy5wcm9wZXJ0eS5zZXRUZXh0KHN0eWxlVGV4dCwgbWFq
b3JDaGFuZ2UsIGNhbGxiYWNrLmJpbmQodGhpcywgdXNlck9wZXJhdGlvbkZpbmlzaGVkQ2FsbGJh
Y2suYmluZChudWxsLCB0aGlzLl9wYXJlbnRQYW5lLCB1cGRhdGVJbnRlcmZhY2UpLCB0aGlzLm9y
aWdpbmFsUHJvcGVydHlUZXh0KSk7CiAgICAgfQogfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103466</attachid>
            <date>2011-08-10 05:17:56 -0700</date>
            <delta_ts>2011-08-10 05:21:48 -0700</delta_ts>
            <desc>[PATCH] Comments addressed</desc>
            <filename>regressiontab.patch</filename>
            <type>text/plain</type>
            <size>7724</size>
            <attacher name="Alexander Pavlov (apavlov)">apavlov</attacher>
            
              <data encoding="base64">Y29tbWl0IGI3NjUxOTMyYjY4Yzc1ZDMxY2U0Yjg5MmFlMzQyN2I0Yzk5OTE5ZjMKQXV0aG9yOiBB
bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUdWUgQXVnIDkg
MTU6NDg6MzAgMjAxMSArMDQwMAoKICAgIEZpeAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No
YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0YzViNWNlLi44NWEzYzFhIDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMTAgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2
bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0g
RWRpdG9yIGxvc3QgYWZ0ZXIgY29tbWl0dGluZyBhIENTUyBwcm9wZXJ0eSB2YWx1ZSBmb3IgaW5s
aW5lIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02NTkxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtY29tbWl0LWVkaXRpbmcuaHRtbDoKKwogMjAxMS0w
OC0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtR
dF0gaHR0cC90ZXN0cy9taXNjL29iamVjdC1lbWJlZGRpbmctc3ZnLWRlbGF5ZWQtc2l6ZS1uZWdv
dGlhdGlvbi0yLmh0bSBmYWlscyBpbnRlcm1pdHRlbnRseQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtY29tbWl0LWVkaXRpbmcuaHRtbCBiL0xheW91dFRl
c3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5bGVzLWNvbW1pdC1lZGl0aW5nLmh0bWwKaW5kZXggM2Q3
M2VkZC4uZjdmM2Q2MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9z
dHlsZXMtY29tbWl0LWVkaXRpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5
bGVzL3N0eWxlcy1jb21taXQtZWRpdGluZy5odG1sCkBAIC0zNCw2ICszNCwxMCBAQCBmdW5jdGlv
biB0ZXN0KCkKIAogICAgIGZ1bmN0aW9uIHN0ZXAyKCkKICAgICB7CisgICAgICAgIGlmICghV2Vi
SW5zcGVjdG9yLmlzRWRpdGluZ0FueUZpZWxkKCkpIHsKKyAgICAgICAgICAgIEluc3BlY3RvclRl
c3QuYWRkUmVzdWx0KCJObyBuZXcgcHJvcGVydHkgZWRpdG9yIGFjdGl2ZSEiKTsKKyAgICAgICAg
ICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7CisgICAgICAgIH0KICAgICAgICAgSW5z
cGVjdG9yVGVzdC5zZWxlY3ROb2RlV2l0aElkKCJvdGhlciIpOwogICAgICAgICBJbnNwZWN0b3JU
ZXN0LnJ1bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMoc3RlcDMpOwogICAgIH0KZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl
eCA1Y2M4YzNkLi43NGY1Mzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgt
MTAgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBX
ZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0gRWRpdG9yIGxvc3QgYWZ0ZXIgY29tbWl0dGluZyBh
IENTUyBwcm9wZXJ0eSB2YWx1ZSBmb3IgaW5saW5lIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTkxOAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNT
aWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5w
cm90b3R5cGUuX2lubmVyVXBkYXRlLnN0eWxlc0NhbGxiYWNrKToKKyAgICAgICAgKFdlYkluc3Bl
Y3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUuX2lubmVyVXBkYXRlLmNvbXB1dGVkU3R5
bGVDYWxsYmFjayk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJv
dG90eXBlLl9pbm5lclVwZGF0ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0
eVRyZWVFbGVtZW50LnByb3RvdHlwZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9w
ZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZS5ldmVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu
U3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZS5zdHlsZVRleHQudXBkYXRlSW50ZXJm
YWNlLm1ham9yQ2hhbmdlLmlzUmV2ZXJ0LnBhcmVudFBhbmUpOgorICAgICAgICAoV2ViSW5zcGVj
dG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUuc3R5bGVUZXh0LnVwZGF0ZUlu
dGVyZmFjZS5tYWpvckNoYW5nZS5pc1JldmVydCk6CisKIDIwMTEtMDgtMTAgIFl1dGEgS2l0YW11
cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU29ja2V0OiBBZGQgYmluYXJ5
VHlwZSBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u
dC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv
bnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmluZGV4IGYzNzhmZjkuLjJiMDY5MDQgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh
bmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRl
YmFyUGFuZS5qcwpAQCAtMjM5LDEzICsyMzksMTUgQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGVi
YXJQYW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5faW5uZXJVcGRhdGUocmVmcmVzaCwg
bnVsbCk7CiAgICAgfSwKIAotICAgIF9pbm5lclVwZGF0ZTogZnVuY3Rpb24ocmVmcmVzaCwgZWRp
dGVkU2VjdGlvbikKKyAgICBfaW5uZXJVcGRhdGU6IGZ1bmN0aW9uKHJlZnJlc2gsIGVkaXRlZFNl
Y3Rpb24sIHVzZXJDYWxsYmFjaykKICAgICB7CiAgICAgICAgIHZhciBub2RlID0gdGhpcy5ub2Rl
OwogICAgICAgICBpZiAoIW5vZGUpIHsKICAgICAgICAgICAgIHRoaXMuX3NlY3Rpb25zQ29udGFp
bmVyLnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgICAgICB0aGlzLl9jb21wdXRlZFN0eWxlUGFu
ZS5ib2R5RWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwogICAgICAgICAgICAgdGhpcy5zZWN0aW9u
cyA9IHt9OworICAgICAgICAgICAgaWYgKHVzZXJDYWxsYmFjaykKKyAgICAgICAgICAgICAgICB1
c2VyQ2FsbGJhY2soKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC0yNTMs
MTIgKzI1NSwxNiBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlID0g
ewogICAgICAgICB7CiAgICAgICAgICAgICBpZiAodGhpcy5ub2RlID09PSBub2RlICYmIHN0eWxl
cykKICAgICAgICAgICAgICAgICB0aGlzLl9yZWJ1aWxkVXBkYXRlKG5vZGUsIHN0eWxlcyk7Cisg
ICAgICAgICAgICBpZiAodXNlckNhbGxiYWNrKQorICAgICAgICAgICAgICAgIHVzZXJDYWxsYmFj
aygpOwogICAgICAgICB9CiAKICAgICAgICAgZnVuY3Rpb24gY29tcHV0ZWRTdHlsZUNhbGxiYWNr
KGNvbXB1dGVkU3R5bGUpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmICh0aGlzLm5vZGUgPT09
IG5vZGUgJiYgY29tcHV0ZWRTdHlsZSkKICAgICAgICAgICAgICAgICB0aGlzLl9yZWZyZXNoVXBk
YXRlKG5vZGUsIGNvbXB1dGVkU3R5bGUsIGVkaXRlZFNlY3Rpb24pOworICAgICAgICAgICAgaWYg
KHVzZXJDYWxsYmFjaykKKyAgICAgICAgICAgICAgICB1c2VyQ2FsbGJhY2soKTsKICAgICAgICAg
fQogCiAgICAgICAgIGlmIChyZWZyZXNoKQpAQCAtMTYyMywxNiArMTYyOSwxNCBAQCBXZWJJbnNw
ZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhp
cy50b29sdGlwID0gdGhpcy5wcm9wZXJ0eS5wcm9wZXJ0eVRleHQ7CiAgICAgfSwKIAotICAgIF91
cGRhdGVBbGw6IGZ1bmN0aW9uKCkKKyAgICBfdXBkYXRlUGFuZTogZnVuY3Rpb24odXNlckNhbGxi
YWNrKQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLnRyZWVPdXRsaW5lKQotICAgICAgICAgICAg
cmV0dXJuOwotICAgICAgICBpZiAodGhpcy50cmVlT3V0bGluZS5zZWN0aW9uICYmIHRoaXMudHJl
ZU91dGxpbmUuc2VjdGlvbi5wYW5lKQotICAgICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5zZWN0
aW9uLnBhbmUuX2lubmVyVXBkYXRlKHRydWUsIHRoaXMudHJlZU91dGxpbmUuc2VjdGlvbik7Ci0g
ICAgICAgIGVsc2UgaWYgKHRoaXMudHJlZU91dGxpbmUuc2VjdGlvbikKLSAgICAgICAgICAgIHRo
aXMudHJlZU91dGxpbmUuc2VjdGlvbi51cGRhdGUodHJ1ZSk7Ci0gICAgICAgIGVsc2UKLSAgICAg
ICAgICAgIHRoaXMudXBkYXRlVGl0bGUoKTsgLy8gRklYTUU6IHRoaXMgd2lsbCBub3Qgc2hvdyBu
ZXcgcHJvcGVydGllcy4gQnV0IHdlIGRvbid0IGhpdCB0aGlzIGNhc2UgeWV0LgorICAgICAgICBp
ZiAodGhpcy50cmVlT3V0bGluZSAmJiB0aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb24gJiYgdGhpcy50
cmVlT3V0bGluZS5zZWN0aW9uLnBhbmUpCisgICAgICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLnNl
Y3Rpb24ucGFuZS5faW5uZXJVcGRhdGUodHJ1ZSwgdGhpcy50cmVlT3V0bGluZS5zZWN0aW9uLCB1
c2VyQ2FsbGJhY2spOworICAgICAgICBlbHNlICB7CisgICAgICAgICAgICBpZiAodXNlckNhbGxi
YWNrKQorICAgICAgICAgICAgICAgIHVzZXJDYWxsYmFjaygpOworICAgICAgICB9CiAgICAgfSwK
IAogICAgIHRvZ2dsZUVuYWJsZWQ6IGZ1bmN0aW9uKGV2ZW50KQpAQCAtMTY1MCw3ICsxNjU0LDcg
QEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAg
ICAgICAgICAgICBpZiAodGhpcy50cmVlT3V0bGluZS5zZWN0aW9uICYmIHRoaXMudHJlZU91dGxp
bmUuc2VjdGlvbi5wYW5lKQogICAgICAgICAgICAgICAgIHRoaXMudHJlZU91dGxpbmUuc2VjdGlv
bi5wYW5lLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycygic3R5bGUgcHJvcGVydHkgdG9nZ2xlZCIp
OwogCi0gICAgICAgICAgICB0aGlzLl91cGRhdGVBbGwoKTsKKyAgICAgICAgICAgIHRoaXMuX3Vw
ZGF0ZVBhbmUoKTsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMucHJvcGVydHkuc2V0RGlzYWJs
ZWQoZGlzYWJsZWQsIGNhbGxiYWNrLmJpbmQodGhpcykpOwpAQCAtMjA5Miw2ICsyMDk2LDEyIEBA
IFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAg
ICAgYXBwbHlTdHlsZVRleHQ6IGZ1bmN0aW9uKHN0eWxlVGV4dCwgdXBkYXRlSW50ZXJmYWNlLCBt
YWpvckNoYW5nZSwgaXNSZXZlcnQpCiAgICAgeworICAgICAgICBmdW5jdGlvbiB1c2VyT3BlcmF0
aW9uRmluaXNoZWRDYWxsYmFjayhwYXJlbnRQYW5lLCB1cGRhdGVJbnRlcmZhY2UpCisgICAgICAg
IHsKKyAgICAgICAgICAgIGlmICh1cGRhdGVJbnRlcmZhY2UpCisgICAgICAgICAgICAgICAgZGVs
ZXRlIHBhcmVudFBhbmUuX3VzZXJPcGVyYXRpb247CisgICAgICAgIH0KKwogICAgICAgICAvLyBM
ZWF2ZSBhIHdheSB0byBjYW5jZWwgZWRpdGluZyBhZnRlciBpbmNyZW1lbnRhbCBjaGFuZ2VzLgog
ICAgICAgICBpZiAoIWlzUmV2ZXJ0ICYmICF1cGRhdGVJbnRlcmZhY2UgJiYgIXRoaXMuX2hhc0Jl
ZW5Nb2RpZmllZEluY3JlbWVudGFsbHkoKSkgewogICAgICAgICAgICAgLy8gUmVtZW1iZXIgdGhl
IHJ1bGUncyBvcmlnaW5hbCBDU1MgdGV4dCBvbiBbUGFnZV0oVXB8RG93biksIHNvIGl0IGNhbiBi
ZSByZXN0b3JlZApAQCAtMjExMSwxNiArMjEyMSwxNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9w
ZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogCiAgICAgICAgIHZhciBj
dXJyZW50Tm9kZSA9IHRoaXMuX3BhcmVudFBhbmUubm9kZTsKLSAgICAgICAgdGhpcy5fcGFyZW50
UGFuZS5fdXNlck9wZXJhdGlvbiA9IHRydWU7CisgICAgICAgIGlmICh1cGRhdGVJbnRlcmZhY2Up
CisgICAgICAgICAgICB0aGlzLl9wYXJlbnRQYW5lLl91c2VyT3BlcmF0aW9uID0gdHJ1ZTsKIAot
ICAgICAgICBmdW5jdGlvbiBjYWxsYmFjayhvcmlnaW5hbFByb3BlcnR5VGV4dCwgbmV3U3R5bGUp
CisgICAgICAgIGZ1bmN0aW9uIGNhbGxiYWNrKHVzZXJDYWxsYmFjaywgb3JpZ2luYWxQcm9wZXJ0
eVRleHQsIG5ld1N0eWxlKQogICAgICAgICB7Ci0gICAgICAgICAgICBkZWxldGUgdGhpcy5fcGFy
ZW50UGFuZS5fdXNlck9wZXJhdGlvbjsKICAgICAgICAgICAgIGlmICghbmV3U3R5bGUpIHsKICAg
ICAgICAgICAgICAgICBpZiAodXBkYXRlSW50ZXJmYWNlKSB7CiAgICAgICAgICAgICAgICAgICAg
IC8vIEl0IGRpZCBub3QgYXBwbHksIGNhbmNlbCBlZGl0aW5nLgogICAgICAgICAgICAgICAgICAg
ICB0aGlzLl9yZXZlcnRTdHlsZVVwb25FZGl0aW5nQ2FuY2VsZWQob3JpZ2luYWxQcm9wZXJ0eVRl
eHQpOwogICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB1c2VyQ2FsbGJhY2soKTsK
ICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKQEAgLTIxMzEsMTUgKzIx
NDIsMTkgQEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUg
PSB7CiAgICAgICAgICAgICBpZiAoc2VjdGlvbiAmJiBzZWN0aW9uLnBhbmUpCiAgICAgICAgICAg
ICAgICAgc2VjdGlvbi5wYW5lLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycygic3R5bGUgZWRpdGVk
Iik7CiAKLSAgICAgICAgICAgIGlmICh1cGRhdGVJbnRlcmZhY2UgJiYgY3VycmVudE5vZGUgPT09
IHNlY3Rpb24ucGFuZS5ub2RlKQotICAgICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUFsbCgpOwor
ICAgICAgICAgICAgaWYgKHVwZGF0ZUludGVyZmFjZSAmJiBjdXJyZW50Tm9kZSA9PT0gc2VjdGlv
bi5wYW5lLm5vZGUpIHsKKyAgICAgICAgICAgICAgICB0aGlzLl91cGRhdGVQYW5lKHVzZXJDYWxs
YmFjayk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorCisgICAgICAg
ICAgICB1c2VyQ2FsbGJhY2soKTsKICAgICAgICAgfQogCiAgICAgICAgIC8vIEFwcGVuZCBhICI7
IiBpZiB0aGUgbmV3IHRleHQgZG9lcyBub3QgZW5kIGluICI7Ii4KICAgICAgICAgLy8gRklYTUU6
IHRoaXMgZG9lcyBub3QgaGFuZGxlIHRyYWlsaW5nIGNvbW1lbnRzLgogICAgICAgICBpZiAoc3R5
bGVUZXh0Lmxlbmd0aCAmJiAhLztccyokLy50ZXN0KHN0eWxlVGV4dCkpCiAgICAgICAgICAgICBz
dHlsZVRleHQgKz0gIjsiOwotICAgICAgICB0aGlzLnByb3BlcnR5LnNldFRleHQoc3R5bGVUZXh0
LCBtYWpvckNoYW5nZSwgY2FsbGJhY2suYmluZCh0aGlzLCB0aGlzLm9yaWdpbmFsUHJvcGVydHlU
ZXh0KSk7CisgICAgICAgIHRoaXMucHJvcGVydHkuc2V0VGV4dChzdHlsZVRleHQsIG1ham9yQ2hh
bmdlLCBjYWxsYmFjay5iaW5kKHRoaXMsIHVzZXJPcGVyYXRpb25GaW5pc2hlZENhbGxiYWNrLmJp
bmQobnVsbCwgdGhpcy5fcGFyZW50UGFuZSwgdXBkYXRlSW50ZXJmYWNlKSwgdGhpcy5vcmlnaW5h
bFByb3BlcnR5VGV4dCkpOwogICAgIH0KIH0KIAo=
</data>
<flag name="review"
          id="99089"
          type_id="1"
          status="+"
          setter="pfeldman"
    />
          </attachment>
      

    </bug>

</bugzilla>