65908 2011-08-09 04:40:20 -0700 Remove the temporary workaround added by http://trac.webkit.org/changeset/51338 2011-08-11 12:25:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 marja webkit-unassigned abarth ap jochen webkit.review.bot oldest_to_newest 448511 0 marja 2011-08-09 04:40:20 -0700 SecurityOrigin for a file URL returns "file://", and SecurityOrigin::createFromString("file://") creates a unique (null) security origin (because "file://" is first canonicalized to "file:///" and that is a directory). This means the conversion SecurityOrigin -> string -> SecurityOrigin doens't give back the same SecurityOrigin in case of file URLs. WebStorageNamespaceImpl::createStorageArea contains a workaround which changes the string "file://" into "file:///a" before giving it to SecurityOrigin::createFromString. If SecurityOrigin::m_enforceFilePathSeparation is true, then SecurityOrigin::toString() returns "null" for file URLs, and this problem does not exist, and the workaround code is not ran. This bug is for trying out what breaks if the workaround is removed. I'll submit a patch which just removes it, to see whether there are any tests that rely on the workaround code. 448513 1 103347 marja 2011-08-09 04:42:12 -0700 Created attachment 103347 Removing the workaround. 448534 2 jochen 2011-08-09 05:48:24 -0700 (In reply to comment #0) > This bug is for trying out what breaks if the workaround is removed. I'll submit a patch which just removes it, to see whether there are any tests that rely on the workaround code. I'd expect the test failures to be mainly when running layout tests in Chromium, so you'll need to apply this patch to a checkout of chromium and run the tests there (webkit/tools/layout_tests/run_webkit_tests.py and probably browser_tests) 449036 3 marja 2011-08-10 01:46:06 -0700 (In reply to comment #2) > I'd expect the test failures to be mainly when running layout tests in Chromium, so you'll need to apply this patch to a checkout of chromium and run the tests there (webkit/tools/layout_tests/run_webkit_tests.py and probably browser_tests) Yep. Removing the workaround didn't add any (relevant) test failures there either. 449040 4 jochen 2011-08-10 01:58:37 -0700 (In reply to comment #3) > (In reply to comment #2) > > I'd expect the test failures to be mainly when running layout tests in Chromium, so you'll need to apply this patch to a checkout of chromium and run the tests there (webkit/tools/layout_tests/run_webkit_tests.py and probably browser_tests) > > Yep. Removing the workaround didn't add any (relevant) test failures there either. ok, the patch looks good, you should mark it r? c?, maybe Adam can do the actual review then 449857 5 103347 abarth 2011-08-11 10:10:20 -0700 Comment on attachment 103347 Removing the workaround. This looks great, but we'll need a ChangeLog. 449897 6 103648 abarth 2011-08-11 11:24:22 -0700 Created attachment 103648 Patch for landing 449898 7 abarth 2011-08-11 11:25:15 -0700 I added a ChangeLog for you. 449927 8 103648 webkit.review.bot 2011-08-11 12:25:03 -0700 Comment on attachment 103648 Patch for landing Clearing flags on attachment: 103648 Committed r92872: <http://trac.webkit.org/changeset/92872> 449928 9 webkit.review.bot 2011-08-11 12:25:07 -0700 All reviewed patches have been landed. Closing bug. 103347 2011-08-09 04:42:12 -0700 2011-08-11 11:24:18 -0700 Removing the workaround. bug-65908-20110809134211.patch text/plain 1569 marja U3VidmVyc2lvbiBSZXZpc2lvbjogOTI2NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcAppbmRleCA1M2I0YTc1MjliOTBk YTM2NjdkYmYxOWU1ZWQyYTJhYmNiOWNkMjI3Li43NzkxOTQxNTY4ZTUxN2VjNGYyY2UyYWYzMmQx NTU5ZDY5ZDgyYTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJT dG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViU3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwCkBAIC02MSwyMCArNjEsNyBAQCBXZWJTdG9yYWdl TmFtZXNwYWNlSW1wbDo6fldlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsKCkKIAogV2ViU3RvcmFnZUFy ZWEqIFdlYlN0b3JhZ2VOYW1lc3BhY2VJbXBsOjpjcmVhdGVTdG9yYWdlQXJlYShjb25zdCBXZWJT dHJpbmcmIG9yaWdpblN0cmluZykKIHsKLSAgICBXVEY6OlN0cmluZyBvcmlnaW5XZWJDb3JlU3Ry aW5nID0gb3JpZ2luU3RyaW5nOwotICAgIGlmIChvcmlnaW5XZWJDb3JlU3RyaW5nID09ICJmaWxl Oi8vIikgewotICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHJlYWxseSBiZSBwYXNzaW5nIGFy b3VuZCBXZWJTZWN1cml0eU9yaWdpbiBvYmplY3RzCi0gICAgICAgIC8vICAgICAgICB0byByZXBy ZXNlbnQgc2VjdXJpdHkgb3JpZ2lucyBpbnN0ZWFkIG9mIHN0cmluZ3MuICBPbmUgaXNzdWUKLSAg ICAgICAgLy8gICAgICAgIHdpdGggdXNpbmcgc3RyaW5ncyBpcyB0aGF0IGNyZWF0ZUZyb21TdHJp bmcodG9TdHJpbmcpIGRvZXMKLSAgICAgICAgLy8gICAgICAgIG5vdCByb3VuZC10cmlwIGZvciBm aWxlIFVSTHMgYmVjYXVzZSBmaWxlOi8vIGxvb2tzIGxpa2UgYQotICAgICAgICAvLyAgICAgICAg ZGlyZWN0b3J5ICh3aGljaCBpcyBzYW5kYm94ZWQpLgotICAgICAgICAvLwotICAgICAgICAvLyBG b3IgdGhlIHRpbWUgYmVpbmcsIHdlIHdvcmsgYXJvdW5kIHRoaXMgaXNzdWUgYnkgdXNpbmcgImZp bGU6Ly8vYSIsCi0gICAgICAgIC8vIHdoaWNoIGRvZXMgbm90IGxvb2sgbGlrZSBhIGRpcmVjdG9y eS4gIFdlIHNob3VsZCBmaXggdGhpcyB3aGVuCi0gICAgICAgIC8vIGpvcmxvdyBnZXRzIGJhY2sg ZnJvbSB2YWN0YXRpb24uCi0gICAgICAgIG9yaWdpbldlYkNvcmVTdHJpbmcgPSAiZmlsZTovLy9h IjsKLSAgICB9Ci0gICAgUmVmUHRyPFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luPiBvcmlnaW4gPSBX ZWJDb3JlOjpTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbVN0cmluZyhvcmlnaW5XZWJDb3JlU3Ry aW5nKTsKKyAgICBSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+IG9yaWdpbiA9IFdlYkNv cmU6OlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5nKG9yaWdpblN0cmluZyk7CiAgICAg cmV0dXJuIG5ldyBXZWJTdG9yYWdlQXJlYUltcGwobV9zdG9yYWdlTmFtZXNwYWNlLT5zdG9yYWdl QXJlYShvcmlnaW4ucmVsZWFzZSgpKSk7CiB9CiAK 103648 2011-08-11 11:24:22 -0700 2011-08-11 12:25:03 -0700 Patch for landing bug-65908-20110811112421.patch text/plain 3195 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTI4NjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NDNkNDI1MDBmZjc3NDk0MGM2YmFhNjgwZjQzMTZjNDA5YTM5N2MyOS4uNjZmZmRhZmI3NWQ5MDYw OGQzMmE5MjdmZmQzZjdjODQ2Y2ExZDJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwzMCBAQAorMjAxMS0wOC0xMSAgTWFyamEgSMO2bHR0w6QgIDxtYXJqYUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHRoZSB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCBhZGRlZCBi eSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81MTMzOAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU5MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIFNlY3VyaXR5T3JpZ2luIGZvciBhIGZpbGUgVVJM IHJldHVybnMgImZpbGU6Ly8iLCBhbmQKKyAgICAgICAgU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZy b21TdHJpbmcoImZpbGU6Ly8iKSBjcmVhdGVzIGEgdW5pcXVlIChudWxsKQorICAgICAgICBzZWN1 cml0eSBvcmlnaW4gKGJlY2F1c2UgImZpbGU6Ly8iIGlzIGZpcnN0IGNhbm9uaWNhbGl6ZWQgdG8g ImZpbGU6Ly8vIgorICAgICAgICBhbmQgdGhhdCBpcyBhIGRpcmVjdG9yeSkuIFRoaXMgbWVhbnMg dGhlIGNvbnZlcnNpb24gU2VjdXJpdHlPcmlnaW4gLT4KKyAgICAgICAgc3RyaW5nIC0+IFNlY3Vy aXR5T3JpZ2luIGRvZW5zJ3QgZ2l2ZSBiYWNrIHRoZSBzYW1lIFNlY3VyaXR5T3JpZ2luIGluCisg ICAgICAgIGNhc2Ugb2YgZmlsZSBVUkxzLgorCisgICAgICAgIFdlYlN0b3JhZ2VOYW1lc3BhY2VJ bXBsOjpjcmVhdGVTdG9yYWdlQXJlYSBjb250YWlucyBhIHdvcmthcm91bmQgd2hpY2gKKyAgICAg ICAgY2hhbmdlcyB0aGUgc3RyaW5nICJmaWxlOi8vIiBpbnRvICJmaWxlOi8vL2EiIGJlZm9yZSBn aXZpbmcgaXQgdG8KKyAgICAgICAgU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21TdHJpbmcuCisK KyAgICAgICAgSWYgU2VjdXJpdHlPcmlnaW46Om1fZW5mb3JjZUZpbGVQYXRoU2VwYXJhdGlvbiBp cyB0cnVlLCB0aGVuCisgICAgICAgIFNlY3VyaXR5T3JpZ2luOjp0b1N0cmluZygpIHJldHVybnMg Im51bGwiIGZvciBmaWxlIFVSTHMsIGFuZCB0aGlzCisgICAgICAgIHByb2JsZW0gZG9lcyBub3Qg ZXhpc3QsIGFuZCB0aGUgd29ya2Fyb3VuZCBjb2RlIGlzIG5vdCByYW4uCisKKyAgICAgICAgVGhp cyBwYXRjaCByZW1vdmVzIHRoZSB3b3JrYXJvdW5kLgorCisgICAgICAgICogc3JjL1dlYlN0b3Jh Z2VOYW1lc3BhY2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU3RvcmFnZU5hbWVzcGFj ZUltcGw6OmNyZWF0ZVN0b3JhZ2VBcmVhKToKKwogMjAxMS0wOC0xMCAgSm9obiBBYmQtRWwtTWFs ZWsgIDxqYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVXBkYXRlIFdlYlNj cm9sbGJhciBzbyB0aGF0IGl0IHdvcmtzIHdpdGggb3ZlcmxheSBzY3JvbGxiYXJzIG9uIExpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlN0b3JhZ2VOYW1lc3Bh Y2VJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlN0b3JhZ2VOYW1lc3Bh Y2VJbXBsLmNwcAppbmRleCA1M2I0YTc1MjliOTBkYTM2NjdkYmYxOWU1ZWQyYTJhYmNiOWNkMjI3 Li43NzkxOTQxNTY4ZTUxN2VjNGYyY2UyYWYzMmQxNTU5ZDY5ZDgyYTFlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU3RvcmFnZU5hbWVzcGFjZUltcGwuY3Bw CkBAIC02MSwyMCArNjEsNyBAQCBXZWJTdG9yYWdlTmFtZXNwYWNlSW1wbDo6fldlYlN0b3JhZ2VO YW1lc3BhY2VJbXBsKCkKIAogV2ViU3RvcmFnZUFyZWEqIFdlYlN0b3JhZ2VOYW1lc3BhY2VJbXBs OjpjcmVhdGVTdG9yYWdlQXJlYShjb25zdCBXZWJTdHJpbmcmIG9yaWdpblN0cmluZykKIHsKLSAg ICBXVEY6OlN0cmluZyBvcmlnaW5XZWJDb3JlU3RyaW5nID0gb3JpZ2luU3RyaW5nOwotICAgIGlm IChvcmlnaW5XZWJDb3JlU3RyaW5nID09ICJmaWxlOi8vIikgewotICAgICAgICAvLyBGSVhNRTog V2Ugc2hvdWxkIHJlYWxseSBiZSBwYXNzaW5nIGFyb3VuZCBXZWJTZWN1cml0eU9yaWdpbiBvYmpl Y3RzCi0gICAgICAgIC8vICAgICAgICB0byByZXByZXNlbnQgc2VjdXJpdHkgb3JpZ2lucyBpbnN0 ZWFkIG9mIHN0cmluZ3MuICBPbmUgaXNzdWUKLSAgICAgICAgLy8gICAgICAgIHdpdGggdXNpbmcg c3RyaW5ncyBpcyB0aGF0IGNyZWF0ZUZyb21TdHJpbmcodG9TdHJpbmcpIGRvZXMKLSAgICAgICAg Ly8gICAgICAgIG5vdCByb3VuZC10cmlwIGZvciBmaWxlIFVSTHMgYmVjYXVzZSBmaWxlOi8vIGxv b2tzIGxpa2UgYQotICAgICAgICAvLyAgICAgICAgZGlyZWN0b3J5ICh3aGljaCBpcyBzYW5kYm94 ZWQpLgotICAgICAgICAvLwotICAgICAgICAvLyBGb3IgdGhlIHRpbWUgYmVpbmcsIHdlIHdvcmsg YXJvdW5kIHRoaXMgaXNzdWUgYnkgdXNpbmcgImZpbGU6Ly8vYSIsCi0gICAgICAgIC8vIHdoaWNo IGRvZXMgbm90IGxvb2sgbGlrZSBhIGRpcmVjdG9yeS4gIFdlIHNob3VsZCBmaXggdGhpcyB3aGVu Ci0gICAgICAgIC8vIGpvcmxvdyBnZXRzIGJhY2sgZnJvbSB2YWN0YXRpb24uCi0gICAgICAgIG9y aWdpbldlYkNvcmVTdHJpbmcgPSAiZmlsZTovLy9hIjsKLSAgICB9Ci0gICAgUmVmUHRyPFdlYkNv cmU6OlNlY3VyaXR5T3JpZ2luPiBvcmlnaW4gPSBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbjo6Y3Jl YXRlRnJvbVN0cmluZyhvcmlnaW5XZWJDb3JlU3RyaW5nKTsKKyAgICBSZWZQdHI8V2ViQ29yZTo6 U2VjdXJpdHlPcmlnaW4+IG9yaWdpbiA9IFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVG cm9tU3RyaW5nKG9yaWdpblN0cmluZyk7CiAgICAgcmV0dXJuIG5ldyBXZWJTdG9yYWdlQXJlYUlt cGwobV9zdG9yYWdlTmFtZXNwYWNlLT5zdG9yYWdlQXJlYShvcmlnaW4ucmVsZWFzZSgpKSk7CiB9 CiAK