65890 2011-08-08 16:55:58 -0700 [Chromium] Add a field for request identifier to Chromium's ResourceRequest. 2011-08-12 13:56:37 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 dimich webkit-unassigned fishd jam oldest_to_newest 448366 0 dimich 2011-08-08 16:55:58 -0700 This field will be used to plumb the unique WebCore identifier to the Chromium. We need the request's identifier associated with Chromium side structures to process WebCore notification that a resource in progress is transferred between pages. When this happens, WebCore informs the embedder about each request which is in progress, passing their unique identifier. In case of Chromium, the identifier will be used to map to the Chromium request representation, and it's routing_id should be updated to refer to the new RenderView object. If this is not doen, the request gets dropped when the original page closes. The http://crbug.com/55200 has more info on this. Most of the fix in in Chromium: http://codereview.chromium.org/7601011/, this patch is only a data field added to a ResourceRequest. Testing of this requires Chromium multiprocess architecture so the test is a part of the Chromium side of this fix. 448373 1 103318 dimich 2011-08-08 17:06:28 -0700 Created attachment 103318 Patch 449238 2 103318 dimich 2011-08-10 10:50:19 -0700 Comment on attachment 103318 Patch Removing r? after chat with Darin Fisher. I'll try to do it in a different way, passing ResourceLoader into existing transferLoadingResourceFromPage notification. 450643 3 dimich 2011-08-12 13:56:37 -0700 Bug 66163 is now tracking the issue. 103318 2011-08-08 17:06:28 -0700 2011-08-10 10:50:19 -0700 Patch patch.txt text/plain 7450 dimich ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxOTgzZWYzLi4zNzcwNjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDgtMDggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgW0Nocm9taXVtXSBBZGQgYSBmaWVsZCBmb3IgcmVxdWVzdCBpZGVudGlmaWVyIHRvIENo cm9taXVtJ3MgUmVzb3VyY2VSZXF1ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjU4OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0ZWQgYnkgQ2hyb21pdW0ncyBicm93c2VydGVzdCAobmVlZHMg bXVsdGlwcm9jZXNzIHRlc3QpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1 bS9SZXNvdXJjZVJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0 Ojpkb1BsYXRmb3JtQ29weURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0 Ojpkb1BsYXRmb3JtQWRvcHQpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0v UmVzb3VyY2VSZXF1ZXN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OlJl c291cmNlUmVxdWVzdCk6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OmlkZW50 aWZpZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpzZXRJZGVudGlmaWVy KToKKwogMjAxMS0wOC0wOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkyNjE5LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJjZVJlcXVl c3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJj ZVJlcXVlc3QuY3BwCmluZGV4IDI1NDFkZTcuLmU3MzUyYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVz dC5jcHAKQEAgLTM5LDYgKzM5LDcgQEAgdW5zaWduZWQgaW5pdGlhbGl6ZU1heGltdW1IVFRQQ29u bmVjdGlvbkNvdW50UGVySG9zdCgpCiAKIFBhc3NPd25QdHI8Q3Jvc3NUaHJlYWRSZXNvdXJjZVJl cXVlc3REYXRhPiBSZXNvdXJjZVJlcXVlc3Q6OmRvUGxhdGZvcm1Db3B5RGF0YShQYXNzT3duUHRy PENyb3NzVGhyZWFkUmVzb3VyY2VSZXF1ZXN0RGF0YT4gZGF0YSkgY29uc3QKIHsKKyAgICBkYXRh LT5tX2lkZW50aWZpZXIgPSBtX2lkZW50aWZpZXI7CiAgICAgZGF0YS0+bV9yZXF1ZXN0b3JJRCA9 IG1fcmVxdWVzdG9ySUQ7CiAgICAgZGF0YS0+bV9yZXF1ZXN0b3JQcm9jZXNzSUQgPSBtX3JlcXVl c3RvclByb2Nlc3NJRDsKICAgICBkYXRhLT5tX2FwcENhY2hlSG9zdElEID0gbV9hcHBDYWNoZUhv c3RJRDsKQEAgLTUwLDYgKzUxLDcgQEAgUGFzc093blB0cjxDcm9zc1RocmVhZFJlc291cmNlUmVx dWVzdERhdGE+IFJlc291cmNlUmVxdWVzdDo6ZG9QbGF0Zm9ybUNvcHlEYXRhKFAKIAogdm9pZCBS ZXNvdXJjZVJlcXVlc3Q6OmRvUGxhdGZvcm1BZG9wdChQYXNzT3duUHRyPENyb3NzVGhyZWFkUmVz b3VyY2VSZXF1ZXN0RGF0YT4gZGF0YSkKIHsKKyAgICBtX2lkZW50aWZpZXIgPSBkYXRhLT5tX2lk ZW50aWZpZXI7CiAgICAgbV9yZXF1ZXN0b3JJRCA9IGRhdGEtPm1fcmVxdWVzdG9ySUQ7CiAgICAg bV9yZXF1ZXN0b3JQcm9jZXNzSUQgPSBkYXRhLT5tX3JlcXVlc3RvclByb2Nlc3NJRDsKICAgICBt X2FwcENhY2hlSG9zdElEID0gZGF0YS0+bV9hcHBDYWNoZUhvc3RJRDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVz dC5oCmluZGV4IDAxZTM0MWMuLjMxODZjNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJjZVJlcXVlc3QuaApAQCAtNjUs NiArNjUsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgUmVzb3VyY2VSZXF1ZXN0 KGNvbnN0IFN0cmluZyYgdXJsKSAKICAgICAgICAgICAgIDogUmVzb3VyY2VSZXF1ZXN0QmFzZShL VVJMKFBhcnNlZFVSTFN0cmluZywgdXJsKSwgVXNlUHJvdG9jb2xDYWNoZVBvbGljeSkKKyAgICAg ICAgICAgICwgbV9pZGVudGlmaWVyKDApCiAgICAgICAgICAgICAsIG1fcmVxdWVzdG9ySUQoMCkK ICAgICAgICAgICAgICwgbV9yZXF1ZXN0b3JQcm9jZXNzSUQoMCkKICAgICAgICAgICAgICwgbV9h cHBDYWNoZUhvc3RJRCgwKQpAQCAtNzYsNiArNzcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ICAgICAgICAgUmVzb3VyY2VSZXF1ZXN0KGNvbnN0IEtVUkwmIHVybCkgCiAgICAgICAgICAgICA6 IFJlc291cmNlUmVxdWVzdEJhc2UodXJsLCBVc2VQcm90b2NvbENhY2hlUG9saWN5KQorICAgICAg ICAgICAgLCBtX2lkZW50aWZpZXIoMCkKICAgICAgICAgICAgICwgbV9yZXF1ZXN0b3JJRCgwKQog ICAgICAgICAgICAgLCBtX3JlcXVlc3RvclByb2Nlc3NJRCgwKQogICAgICAgICAgICAgLCBtX2Fw cENhY2hlSG9zdElEKDApCkBAIC04Nyw2ICs4OSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog ICAgICAgICBSZXNvdXJjZVJlcXVlc3QoY29uc3QgS1VSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHJl ZmVycmVyLCBSZXNvdXJjZVJlcXVlc3RDYWNoZVBvbGljeSBwb2xpY3kgPSBVc2VQcm90b2NvbENh Y2hlUG9saWN5KSAKICAgICAgICAgICAgIDogUmVzb3VyY2VSZXF1ZXN0QmFzZSh1cmwsIHBvbGlj eSkKKyAgICAgICAgICAgICwgbV9pZGVudGlmaWVyKDApCiAgICAgICAgICAgICAsIG1fcmVxdWVz dG9ySUQoMCkKICAgICAgICAgICAgICwgbV9yZXF1ZXN0b3JQcm9jZXNzSUQoMCkKICAgICAgICAg ICAgICwgbV9hcHBDYWNoZUhvc3RJRCgwKQpAQCAtOTksNiArMTAyLDcgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICAKICAgICAgICAgUmVzb3VyY2VSZXF1ZXN0KCkKICAgICAgICAgICAg IDogUmVzb3VyY2VSZXF1ZXN0QmFzZShLVVJMKCksIFVzZVByb3RvY29sQ2FjaGVQb2xpY3kpCisg ICAgICAgICAgICAsIG1faWRlbnRpZmllcigwKQogICAgICAgICAgICAgLCBtX3JlcXVlc3RvcklE KDApCiAgICAgICAgICAgICAsIG1fcmVxdWVzdG9yUHJvY2Vzc0lEKDApCiAgICAgICAgICAgICAs IG1fYXBwQ2FjaGVIb3N0SUQoMCkKQEAgLTEwOCw2ICsxMTIsMTAgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICB7CiAgICAgICAgIH0KIAorICAgICAgICAvLyBXZWJDb3JlLWFzc2lnbmVk IHVuaXF1ZSBpZGVudGlmaWVyLgorICAgICAgICBpbnQgaWRlbnRpZmllcigpIGNvbnN0IHsgcmV0 dXJuIG1faWRlbnRpZmllcjsgfQorICAgICAgICB2b2lkIHNldElkZW50aWZpZXIoaW50IGlkZW50 aWZpZXIpIHsgbV9pZGVudGlmaWVyID0gaWRlbnRpZmllcjsgfQorCiAgICAgICAgIC8vIEFsbG93 cyB0aGUgcmVxdWVzdCB0byBiZSBtYXRjaGVkIHVwIHdpdGggaXRzIHJlcXVlc3Rvci4KICAgICAg ICAgaW50IHJlcXVlc3RvcklEKCkgY29uc3QgeyByZXR1cm4gbV9yZXF1ZXN0b3JJRDsgfQogICAg ICAgICB2b2lkIHNldFJlcXVlc3RvcklEKGludCByZXF1ZXN0b3JJRCkgeyBtX3JlcXVlc3RvcklE ID0gcmVxdWVzdG9ySUQ7IH0KQEAgLTE0OCw2ICsxNTYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIFBhc3NPd25QdHI8Q3Jvc3NUaHJlYWRSZXNvdXJjZVJlcXVlc3REYXRhPiBkb1Bs YXRmb3JtQ29weURhdGEoUGFzc093blB0cjxDcm9zc1RocmVhZFJlc291cmNlUmVxdWVzdERhdGE+ KSBjb25zdDsKICAgICAgICAgdm9pZCBkb1BsYXRmb3JtQWRvcHQoUGFzc093blB0cjxDcm9zc1Ro cmVhZFJlc291cmNlUmVxdWVzdERhdGE+KTsKIAorICAgICAgICBpbnQgbV9pZGVudGlmaWVyOwog ICAgICAgICBpbnQgbV9yZXF1ZXN0b3JJRDsKICAgICAgICAgaW50IG1fcmVxdWVzdG9yUHJvY2Vz c0lEOwogICAgICAgICBpbnQgbV9hcHBDYWNoZUhvc3RJRDsKQEAgLTE1OCw2ICsxNjcsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgfTsKIAogICAgIHN0cnVjdCBDcm9zc1RocmVhZFJlc291 cmNlUmVxdWVzdERhdGEgOiBwdWJsaWMgQ3Jvc3NUaHJlYWRSZXNvdXJjZVJlcXVlc3REYXRhQmFz ZSB7CisgICAgICAgIGludCBtX2lkZW50aWZpZXI7CiAgICAgICAgIGludCBtX3JlcXVlc3RvcklE OwogICAgICAgICBpbnQgbV9yZXF1ZXN0b3JQcm9jZXNzSUQ7CiAgICAgICAgIGludCBtX2FwcENh Y2hlSG9zdElEOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBmMzQ0ZDQ0Li5jOGZlYjNk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA4LTA4 ICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gQWRkIGEgZmllbGQgZm9yIHJlcXVlc3QgaWRlbnRpZmllciB0byBDaHJvbWl1bSdzIFJlc291 cmNlUmVxdWVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY1ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwdWJsaWMvV2ViRnJhbWVDbGllbnQuaDoKKyAgICAgICAgKiBwdWJsaWMvV2ViVVJMUmVx dWVzdC5oOgorICAgICAgICAqIHNyYy9XZWJVUkxSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViVVJMUmVxdWVzdDo6aWRlbnRpZmllcik6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTFJl cXVlc3Q6OnNldElkZW50aWZpZXIpOgorCiAyMDExLTA4LTA4ICBTaGVyaWZmIEJvdCAgPHdlYmtp dC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByOTI2MTkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJG cmFtZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGll bnQuaAppbmRleCAwYWY5NmNhLi42MzY3MzQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKQEAgLTI0NSw2ICsyNDUsOCBAQCBwdWJsaWM6CiAK ICAgICAvLyBBbiBpZGVudGlmaWVyIHdhcyBhc3NpZ25lZCB0byB0aGUgc3BlY2lmaWVkIHJlcXVl c3QuICBUaGUgY2xpZW50CiAgICAgLy8gc2hvdWxkIHJlbWVtYmVyIHRoaXMgYXNzb2NpYXRpb24g aWYgaW50ZXJlc3RlZCBpbiBzdWJzZXF1ZW50IGV2ZW50cy4KKyAgICAvLyBJdCBpcyBhbHNvIGlu dm9rZWQgd2l0aCBhIHBlbmRpbmcgcmVxdWVzdCB0aGF0IHdhcyB0cmFuc2ZlcnJlZCB0byB0aGlz CisgICAgLy8gY2xpZW50IGZyb20gYW5vdGhlciBwYWdlIChhcyBpbiBpZnJhbWUgdHJhbnNmZXIg dmlhIGFkb3B0Tm9kZSgpIEpTIEFQSSkuCiAgICAgdmlydHVhbCB2b2lkIGFzc2lnbklkZW50aWZp ZXJUb1JlcXVlc3QoCiAgICAgICAgIFdlYkZyYW1lKiwgdW5zaWduZWQgaWRlbnRpZmllciwgY29u c3QgV2ViVVJMUmVxdWVzdCYpIHsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJVUkxSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJVUkxSZXF1ZXN0LmgKaW5kZXggOTU2ZWFlZS4uODBlYmI3YiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTFJlcXVlc3QuaApAQCAtMTU1LDYgKzE1NSwxMCBA QCBwdWJsaWM6CiAgICAgV0VCS0lUX0VYUE9SVCBib29sIGhhc1VzZXJHZXN0dXJlKCkgY29uc3Q7 CiAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIHNldEhhc1VzZXJHZXN0dXJlKGJvb2wpOwogCisgICAg Ly8gQSBjb25zdW1lciBjb250cm9sbGVkIHZhbHVlIGludGVuZGVkIHRvIGJlIHVzZWQgdG8gaWRl bnRpZnkgdGhlIHJlcXVlc3QuCisgICAgV0VCS0lUX0VYUE9SVCBpbnQgaWRlbnRpZmllcigpIGNv bnN0OworICAgIFdFQktJVF9FWFBPUlQgdm9pZCBzZXRJZGVudGlmaWVyKGludCk7CisKICAgICAv LyBBIGNvbnN1bWVyIGNvbnRyb2xsZWQgdmFsdWUgaW50ZW5kZWQgdG8gYmUgdXNlZCB0byBpZGVu dGlmeSB0aGUKICAgICAvLyByZXF1ZXN0b3IuCiAgICAgV0VCS0lUX0VYUE9SVCBpbnQgcmVxdWVz dG9ySUQoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlVSTFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVxdWVz dC5jcHAKaW5kZXggNjA1ZmI4Yy4uMmFhZGI2NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlVSTFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlVSTFJlcXVlc3QuY3BwCkBAIC0yNjAsNiArMjYwLDE2IEBAIHZvaWQgV2ViVVJM UmVxdWVzdDo6c2V0VGFyZ2V0VHlwZShUYXJnZXRUeXBlIHRhcmdldFR5cGUpCiAgICAgICAgIHN0 YXRpY19jYXN0PFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0VHlwZT4odGFyZ2V0VHlwZSkpOwogfQog CitpbnQgV2ViVVJMUmVxdWVzdDo6aWRlbnRpZmllcigpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1f cHJpdmF0ZS0+bV9yZXNvdXJjZVJlcXVlc3QtPmlkZW50aWZpZXIoKTsKK30KKwordm9pZCBXZWJV UkxSZXF1ZXN0OjpzZXRJZGVudGlmaWVyKGludCBpZGVudGlmaWVyKQoreworICAgIG1fcHJpdmF0 ZS0+bV9yZXNvdXJjZVJlcXVlc3QtPnNldElkZW50aWZpZXIoaWRlbnRpZmllcik7Cit9CisKIGlu dCBXZWJVUkxSZXF1ZXN0OjpyZXF1ZXN0b3JJRCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fcHJp dmF0ZS0+bV9yZXNvdXJjZVJlcXVlc3QtPnJlcXVlc3RvcklEKCk7Cg==