65859 2011-08-08 08:42:54 -0700 [chromium] Notify MemoryCache of decoded data access 2011-08-10 12:13:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonyg tonyg eric jamesr mnaganov satish webkit.review.bot oldest_to_newest 448020 0 tonyg 2011-08-08 08:42:54 -0700 [chromium] Notify MemoryCache of decoded data access 448031 1 103256 tonyg 2011-08-08 09:14:58 -0700 Created attachment 103256 Patch 448577 2 103256 eric 2011-08-09 07:24:46 -0700 Comment on attachment 103256 Patch So win comes from this causing the side effect of pruning *other* data by marking this data as recently used? 448627 3 tonyg 2011-08-09 09:51:21 -0700 (In reply to comment #2) > (From update of attachment 103256 [details]) > So win comes from this causing the side effect of pruning *other* data by marking this data as recently used? Yeah, properly populating the LRU so we prune wisely is half of it. The other half is just getting prune() to be called at all in cases like scrolling through a very large page of images where the decoded data doesn't fit within the target cache size. BTW, do you have any historical context here about why the chromium port doesn't do this like all the other ports? I'm curious if it is intentional or just an oversight. I couldn't dig up anything relevant in the ChangeLogs. 449233 4 103256 jamesr 2011-08-10 10:48:48 -0700 Comment on attachment 103256 Patch Yay! 449287 5 103256 webkit.review.bot 2011-08-10 12:13:21 -0700 Comment on attachment 103256 Patch Clearing flags on attachment: 103256 Committed r92782: <http://trac.webkit.org/changeset/92782> 449288 6 webkit.review.bot 2011-08-10 12:13:25 -0700 All reviewed patches have been landed. Closing bug. 103256 2011-08-08 09:14:58 -0700 2011-08-10 12:13:21 -0700 Patch bug-65859-20110808171456.patch text/plain 2592 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogOTI1OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZTlhYjBjOWZjMTlhNWVi MWVmMDdmZmFjMzkxNjBiODNkOTQ3NjkwLi45YTk4YzdjMWNhZDY2NzY3ZGU0N2JmOTU0ZTI2MTc3 MjUyYzdiOWMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDgtMDggIFRvbnkg R2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE5v dGlmeSBNZW1vcnlDYWNoZSBvZiBkZWNvZGVkIGRhdGEgYWNjZXNzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTg1OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2F1c2VzIHVzIHRvIGNhbGwgQ2Fj aGVkSW1hZ2U6OmRpZERyYXcoKSB3aGljaCBjYWxscyBDYWNoZWRSZXNvdXJjZTo6ZGlkQWNjZXNz RGVjb2RlZERhdGEoKQorICAgICAgICB3aGljaCB1cGRhdGVzIHRoZSBMUlUgZm9yIGRlY29kZWQg aW1hZ2UgZGF0YSBhbmQgcG90ZW50aWFsbHkgcHJ1bmVzIHRoZSBjYWNoZS4gVGhpcyBpcyBhbHJl YWR5IGRvbmUKKyAgICAgICAgYnkgYWxtb3N0IGFsbCBvZiB0aGUgb3RoZXIgcG9ydHMuCisKKyAg ICAgICAgVGhlIGRlY29kZWQgYml0bWFwcyBvYnZpb3VzbHkgdXNlIHF1aXRlIGEgYml0IG9mIG1l bW9yeSwgc28gcHJ1bmluZyB0aGVtIHdoZW4gbmVjZXNzYXJ5IGlzIGltcG9ydGFudC4KKyAgICAg ICAgSW4gbXkgdGVzdHMsIHRoaXMgc2F2ZXMgc2V2ZXJhbCBNQiBvbiBtYW55IHBvcHVsYXIgd2Vi IHBhZ2VzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG5vIG9ic2VydmFibGUgZGlm ZmVyZW5jZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9JbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2U6OmRyYXcp OgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNraWE6OmRyYXcpOgor CiAyMDExLTA4LTA4ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlZmFjdG9yIGxpbmtzIGNyZWF0aW9uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCmlu ZGV4IDUzODg4YzliM2MzZGYyNzA4MjgyZTFkZjk2NWM4MTlkMDUzMTVmYzkuLmM3NGE5OGI3NDlj ODRlYjY4NjY3NThjODRiM2FjMTg5NGEwYzI3NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAKQEAgLTM2LDYgKzM2LDcgQEAK ICNpbmNsdWRlICJGbG9hdENvbnZlcnNpb24uaCIKICNpbmNsdWRlICJGbG9hdFJlY3QuaCIKICNp bmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKKyNpbmNsdWRlICJJbWFnZU9ic2VydmVyLmgiCiAj aW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIk5hdGl2ZUltYWdlU2tpYS5oIgogI2luY2x1 ZGUgIlBsYXRmb3JtQ29udGV4dFNraWEuaCIKQEAgLTQ4OSw2ICs0OTAsOSBAQCB2b2lkIEJpdG1h cEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBkc3RS ZWN0LAogICAgICAgICAgICAgICAgICAgZW5jbG9zaW5nSW50UmVjdChub3JtU3JjUmVjdCksCiAg ICAgICAgICAgICAgICAgICBub3JtRHN0UmVjdCwKICAgICAgICAgICAgICAgICAgIFdlYkNvcmVD b21wb3NpdGVUb1NraWFDb21wb3NpdGUoY29tcG9zaXRlT3ApKTsKKworICAgIGlmIChJbWFnZU9i c2VydmVyKiBvYnNlcnZlciA9IGltYWdlT2JzZXJ2ZXIoKSkKKyAgICAgICAgb2JzZXJ2ZXItPmRp ZERyYXcodGhpcyk7CiB9CiAKIC8vIEZJWE1FOiBUaGVzZSBzaG91bGQgZ28gaW50byBCaXRtYXBJ bWFnZVNpbmdsZUZyYW1lU2tpYS5jcHAKQEAgLTUxMiw2ICs1MTYsOSBAQCB2b2lkIEJpdG1hcElt YWdlU2luZ2xlRnJhbWVTa2lhOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogY3R4dCwKICAgICAgICAg ICAgICAgICAgIGVuY2xvc2luZ0ludFJlY3Qobm9ybVNyY1JlY3QpLAogICAgICAgICAgICAgICAg ICAgbm9ybURzdFJlY3QsCiAgICAgICAgICAgICAgICAgICBXZWJDb3JlQ29tcG9zaXRlVG9Ta2lh Q29tcG9zaXRlKGNvbXBvc2l0ZU9wKSk7CisKKyAgICBpZiAoSW1hZ2VPYnNlcnZlciogb2JzZXJ2 ZXIgPSBpbWFnZU9ic2VydmVyKCkpCisgICAgICAgIG9ic2VydmVyLT5kaWREcmF3KHRoaXMpOwog fQogCiBCaXRtYXBJbWFnZVNpbmdsZUZyYW1lU2tpYTo6Qml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNr aWEoY29uc3QgU2tCaXRtYXAmIGJpdG1hcCkK