65853 2011-08-08 06:08:53 -0700 [EFL] Return from _ewk_view_smart_add if smart data can not be allocated 2011-08-10 17:54:59 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim hyuki.kim lucas.de.marchi webkit.review.bot oldest_to_newest 447972 0 g.czajkowski 2011-08-08 06:08:53 -0700 This patch prevents crash when malloc fails for sd structure. As you can see, only return statement in _ewk_view_smart_add wasn't enough. To display an empty window (without view) others NULL checks were needed. I tested the patch on both the backing stores. We should be aware that these checks may influence on performance. Anyway this defect has been marked as one of important bugs in WebKit-EFL. What is your opinion about that? 447973 1 103237 g.czajkowski 2011-08-08 06:10:10 -0700 Created attachment 103237 proposed patch 447994 2 103237 leandro 2011-08-08 07:44:49 -0700 Comment on attachment 103237 proposed patch Informal r+. 448384 3 103237 gyuyoung.kim 2011-08-08 17:35:11 -0700 Comment on attachment 103237 proposed patch LGTM also. 448568 4 leandro 2011-08-09 07:06:40 -0700 *** Bug 65408 has been marked as a duplicate of this bug. *** 448584 5 103237 kenneth 2011-08-09 07:35:51 -0700 Comment on attachment 103237 proposed patch LGTM 449524 6 103237 gyuyoung.kim 2011-08-10 17:42:42 -0700 Comment on attachment 103237 proposed patch LGTM. 449533 7 103237 webkit.review.bot 2011-08-10 17:54:54 -0700 Comment on attachment 103237 proposed patch Clearing flags on attachment: 103237 Committed r92808: <http://trac.webkit.org/changeset/92808> 449534 8 webkit.review.bot 2011-08-10 17:54:59 -0700 All reviewed patches have been landed. Closing bug. 103237 2011-08-08 06:10:10 -0700 2011-08-10 17:54:54 -0700 proposed patch smart_add_fix.patch text/plain 4555 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBlODY1NDA1Li5hNDg5ZGYzIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTEtMDgtMDggIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmV0dXJuIGZyb20gX2V3a192aWV3 X3NtYXJ0X2FkZCBpZiBzbWFydCBkYXRhIGNhbiBub3QgYmUgYWxsb2NhdGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTg1MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHByZXZlbnRzIHRoZSBjcmFz aCB3aGlsZSBhbGxvY2F0aW5nIGEgbWVtb3J5IGZvciB2aWV3J3Mgc21hcnQgZGF0YS4KKyAgICAg ICAgT3RoZXJzIGNoZWNraW5nIGFyZSBuZWVkZWQgZm9yIHN1cHBvcnQgc2luZ2xlIGFuZCB0aWxl ZCBiYWNraW5nIHN0b3JlLgorICAgICAgICBBcyBhIHJlc3VsdCBhbiBlbXB0eSB3aW5kb3cgd2ls bCBiZSBkaXNwbGF5ZWQuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAo X2V3a192aWV3X3NtYXJ0X2FkZCk6CisgICAgICAgIChfZXdrX3ZpZXdfc21hcnRfcmVzaXplKToK KyAgICAgICAgKF9ld2tfdmlld19zbWFydF9tb3ZlKToKKyAgICAgICAgKF9ld2tfdmlld19zbWFy dF9zaG93KToKKyAgICAgICAgKF9ld2tfdmlld19zbWFydF9oaWRlKToKKyAgICAgICAgKiBld2sv ZXdrX3ZpZXdfc2luZ2xlLmM6CisgICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2FkZCk6 CisgICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X3Jlc2l6ZSk6CisgICAgICAgICogZXdr L2V3a192aWV3X3RpbGVkLmM6CisgICAgICAgIChfZXdrX3ZpZXdfdGlsZWRfc21hcnRfYWRkKToK KwogMjAxMS0wOC0wNSAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbRUZMXSBNb3ZlIEFQSSBkb2N1bWVudGF0aW9uIG9mIGV3ayBmaWxl cyB0byB0aGUgaGVhZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggMDk5NGJk MC4uNmE2Zjk5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC03MDcsMTAgKzcw NywxMSBAQCBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc21hcnRfYWRkKEV2YXNfT2JqZWN0ICpvKQog CiAgICAgaWYgKCFzZCkgewogICAgICAgICBzZCA9IChFd2tfVmlld19TbWFydF9EYXRhICopY2Fs bG9jKDEsIHNpemVvZihFd2tfVmlld19TbWFydF9EYXRhKSk7Ci0gICAgICAgIGlmICghc2QpCisg ICAgICAgIGlmICghc2QpIHsKICAgICAgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3QgYWxsb2Nh dGUgRXdrX1ZpZXdfU21hcnRfRGF0YSIpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBldmFz X29iamVjdF9zbWFydF9kYXRhX3NldChvLCBzZCk7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KKyAgICAgICAgZXZhc19vYmplY3Rfc21hcnRfZGF0YV9zZXQobywgc2QpOwogICAgIH0K IAogICAgIHNkLT5iZ19jb2xvci5yID0gMjU1OwpAQCAtNzg4LDcgKzc4OSw3IEBAIHN0YXRpYyB2 b2lkIF9ld2tfdmlld19zbWFydF9kZWwoRXZhc19PYmplY3QgKm8pCiAKIHN0YXRpYyB2b2lkIF9l d2tfdmlld19zbWFydF9yZXNpemUoRXZhc19PYmplY3QgKm8sIEV2YXNfQ29vcmQgdywgRXZhc19D b29yZCBoKQogewotICAgIEVXS19WSUVXX1NEX0dFVChvLCBzZCk7CisgICAgRVdLX1ZJRVdfU0Rf R0VUX09SX1JFVFVSTihvLCBzZCk7CiAKICAgICAvLyB0aGVzZSBzaG91bGQgYmUgcXVldWVkIGFu ZCBwcm9jZXNzZWQgaW4gY2FsY3VsYXRlIGFzIHdlbGwhCiAgICAgZXZhc19vYmplY3RfcmVzaXpl KHNkLT5iYWNraW5nX3N0b3JlLCB3LCBoKTsKQEAgLTc5OSw3ICs4MDAsNyBAQCBzdGF0aWMgdm9p ZCBfZXdrX3ZpZXdfc21hcnRfcmVzaXplKEV2YXNfT2JqZWN0ICpvLCBFdmFzX0Nvb3JkIHcsIEV2 YXNfQ29vcmQgaCkKIAogc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X21vdmUoRXZhc19PYmpl Y3QgKm8sIEV2YXNfQ29vcmQgeCwgRXZhc19Db29yZCB5KQogewotICAgIEVXS19WSUVXX1NEX0dF VChvLCBzZCk7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCk7CiAgICAgc2Qt PmNoYW5nZWQucG9zaXRpb24gPSBFSU5BX1RSVUU7CiAgICAgX2V3a192aWV3X3NtYXJ0X2NoYW5n ZWQoc2QpOwogfQpAQCAtODcwLDcgKzg3MSw3IEBAIHN0YXRpYyB2b2lkIF9ld2tfdmlld19zbWFy dF9jYWxjdWxhdGUoRXZhc19PYmplY3QgKm8pCiAKIHN0YXRpYyB2b2lkIF9ld2tfdmlld19zbWFy dF9zaG93KEV2YXNfT2JqZWN0ICpvKQogewotICAgIEVXS19WSUVXX1NEX0dFVChvLCBzZCk7Cisg ICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCk7CiAKICAgICBpZiAoZXZhc19vYmpl Y3RfY2xpcGVlc19nZXQoc2QtPmJhc2UuY2xpcHBlcikpCiAgICAgICAgIGV2YXNfb2JqZWN0X3No b3coc2QtPmJhc2UuY2xpcHBlcik7CkBAIC04NzksNyArODgwLDcgQEAgc3RhdGljIHZvaWQgX2V3 a192aWV3X3NtYXJ0X3Nob3coRXZhc19PYmplY3QgKm8pCiAKIHN0YXRpYyB2b2lkIF9ld2tfdmll d19zbWFydF9oaWRlKEV2YXNfT2JqZWN0ICpvKQogewotICAgIEVXS19WSUVXX1NEX0dFVChvLCBz ZCk7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCk7CiAKICAgICBldmFzX29i amVjdF9oaWRlKHNkLT5iYXNlLmNsaXBwZXIpOwogICAgIGV2YXNfb2JqZWN0X2hpZGUoc2QtPmJh Y2tpbmdfc3RvcmUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 X3NpbmdsZS5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3NpbmdsZS5jCmluZGV4 IDBlNTUxODEuLmY1ZGE5NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf dmlld19zaW5nbGUuYworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xl LmMKQEAgLTQzLDYgKzQzLDggQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3NpbmdsZV9zbWFydF9h ZGQoRXZhc19PYmplY3QgKm8pCiAgICAgX3BhcmVudF9zYy5zYy5hZGQobyk7CiAKICAgICBzZCA9 IChFd2tfVmlld19TbWFydF9EYXRhICopZXZhc19vYmplY3Rfc21hcnRfZGF0YV9nZXQobyk7Cisg ICAgaWYgKCFzZCkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgRXZhc19PYmplY3QgKmNsaXAgPSBl dmFzX29iamVjdF9yZWN0YW5nbGVfYWRkKHNkLT5iYXNlLmV2YXMpOwogICAgIGV2YXNfb2JqZWN0 X2NsaXBfc2V0KHNkLT5iYWNraW5nX3N0b3JlLCBjbGlwKTsKQEAgLTY3LDYgKzY5LDkgQEAgc3Rh dGljIHZvaWQgX2V3a192aWV3X3NpbmdsZV9zbWFydF9yZXNpemUoRXZhc19PYmplY3QgKm8sIEV2 YXNfQ29vcmQgdywgRXZhc19Db28KICAgICBFd2tfVmlld19TbWFydF9EYXRhICpzZCA9IChFd2tf Vmlld19TbWFydF9EYXRhKilldmFzX29iamVjdF9zbWFydF9kYXRhX2dldChvKTsKICAgICBfcGFy ZW50X3NjLnNjLnJlc2l6ZShvLCB3LCBoKTsKIAorICAgIGlmICghc2QpCisgICAgICAgIHJldHVy bjsKKwogICAgIC8vIHRoZXNlIHNob3VsZCBiZSBxdWV1ZWQgYW5kIHByb2Nlc3NlZCBpbiBjYWxj dWxhdGUgYXMgd2VsbCEKICAgICBldmFzX29iamVjdF9pbWFnZV9zaXplX3NldChzZC0+YmFja2lu Z19zdG9yZSwgdywgaCk7CiAgICAgaWYgKHNkLT5hbmltYXRlZF96b29tLnpvb20uY3VycmVudCA8 IDAuMDAwMDEpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld190 aWxlZC5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmMKaW5kZXggN2Q4 YWVhOC4uNjNlYjE2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 X3RpbGVkLmMKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmMKQEAg LTcxLDYgKzcxLDkgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3RpbGVkX3NtYXJ0X2FkZChFdmFz X09iamVjdCAqbykKICAgICBfcGFyZW50X3NjLnNjLmFkZChvKTsKIAogICAgIHNkID0gKEV3a19W aWV3X1NtYXJ0X0RhdGEqKWV2YXNfb2JqZWN0X3NtYXJ0X2RhdGFfZ2V0KG8pOworICAgIGlmICgh c2QpCisgICAgICAgIHJldHVybjsKKwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2Fk ZCgKICAgICAgICAgc2QtPm1haW5fZnJhbWUsICJjb250ZW50cyxzaXplLGNoYW5nZWQiLAogICAg ICAgICBfZXdrX3ZpZXdfdGlsZWRfY29udGVudHNfc2l6ZV9jaGFuZ2VkX2NiLCBzZCk7Cg==