65844 2011-08-08 00:53:28 -0700 [EFL] API methods check NULL and return proper value 2011-08-10 04:53:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 447891 0 g.czajkowski 2011-08-08 00:53:28 -0700 Check NULL before access to the smart and private data of the view object and return the proper value if error occurred. 447892 1 103216 g.czajkowski 2011-08-08 00:54:14 -0700 Created attachment 103216 proposed patch 447895 2 103216 gyuyoung.kim 2011-08-08 01:04:52 -0700 Comment on attachment 103216 proposed patch LGTM 447985 3 103216 leandro 2011-08-08 07:26:37 -0700 Comment on attachment 103216 proposed patch LGTM also. 449042 4 103216 webkit.review.bot 2011-08-10 02:06:00 -0700 Comment on attachment 103216 proposed patch Rejecting attachment 103216 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: ctor/network-status-non-http.html = TEXT Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Regressions: Unexpected image and text mismatch : (1) svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT Full output: http://queues.webkit.org/results/9344110 449049 5 gyuyoung.kim 2011-08-10 02:19:46 -0700 It looks chromium port reports error during the LayoutTest. I think this patch doesn't influence on chromium port. Hello Grzegorz, Could you submit this patch again ? 449055 6 103457 g.czajkowski 2011-08-10 02:39:53 -0700 Created attachment 103457 updated patch Just added Kenneth Rohde Christiansen to the reviewer filed. Could you add this patch to commit-queue one more time, please? 449084 7 103457 webkit.review.bot 2011-08-10 04:53:44 -0700 Comment on attachment 103457 updated patch Clearing flags on attachment: 103457 Committed r92763: <http://trac.webkit.org/changeset/92763> 449085 8 webkit.review.bot 2011-08-10 04:53:49 -0700 All reviewed patches have been landed. Closing bug. 103216 2011-08-08 00:54:14 -0700 2011-08-10 02:39:53 -0700 proposed patch api_checks_null.patch text/plain 5242 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwZDE1Y2YxLi5jNGY2YTJhIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMDMgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQVBJIG1ldGhvZHMgY2hlY2sgTlVM TCBhbmQgcmV0dXJuIHByb3BlciB2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY1ODQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ2hlY2sgTlVMTCBiZWZvcmUgYWNjZXNzIHRvIHRoZSBzbWFydCBh bmQgcHJpdmF0ZSBkYXRhIG9mIHRoZSB2aWV3IG9iamVjdAorICAgICAgICBhbmQgcmV0dXJuIHRo ZSBwcm9wZXIgdmFsdWUgaWYgZXJyb3Igb2NjdXJyZWQuCisKKyAgICAgICAgKiBld2svZXdrX3Zp ZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfem9vbV9yYW5nZV9zZXQpOgorICAgICAgICAoZXdr X3ZpZXdfem9vbV9yYW5nZV9taW5fZ2V0KToKKyAgICAgICAgKGV3a192aWV3X3pvb21fcmFuZ2Vf bWF4X2dldCk6CisgICAgICAgIChld2tfdmlld191c2VyX3NjYWxhYmxlX3NldCk6CisgICAgICAg IChld2tfdmlld191c2VyX3NjYWxhYmxlX2dldCk6CisgICAgICAgIChld2tfdmlld19kZXZpY2Vf cGl4ZWxfcmF0aW9fZ2V0KToKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuaDoKKwogMjAxMS0wOC0w MiAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAg ICBbRUZMXSBJZ25vcmUgZW1wdHkgcmVxdWVzdHMgb24gcG9saWN5IGRlY2lzaW9ucy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDA5OTRiZDAuLjkxMTVjNjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMzQxMCw4ICszNDEwLDggQEAgdm9pZCBld2tfdmlld192 aWV3cG9ydF9hdHRyaWJ1dGVzX2dldChFdmFzX09iamVjdCAqbywgZmxvYXQgKncsIGZsb2F0ICpo LCBmbG9hdAogCiBFaW5hX0Jvb2wgZXdrX3ZpZXdfem9vbV9yYW5nZV9zZXQoRXZhc19PYmplY3Qg Km8sIGZsb2F0IG1pbl9zY2FsZSwgZmxvYXQgbWF4X3NjYWxlKQogewotICAgIEVXS19WSUVXX1NE X0dFVChvLCBzZCk7Ci0gICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2QsIHByaXYpOworICAgIEVXS19W SUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOworICAgIEVXS19WSUVXX1BS SVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlOQV9GQUxTRSk7CiAKICAgICBpZiAobWF4X3Nj YWxlIDwgbWluX3NjYWxlKSB7CiAgICAgICAgIFdSTigibWluX3NjYWxlIGlzIGxhcmdlciB0aGFu IG1heF9zY2FsZSIpOwpAQCAtMzQyNiw0MCArMzQyNiw0MiBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdf em9vbV9yYW5nZV9zZXQoRXZhc19PYmplY3QgKm8sIGZsb2F0IG1pbl9zY2FsZSwgZmxvYXQgbWF4 X3NjYQogCiBmbG9hdCBld2tfdmlld196b29tX3JhbmdlX21pbl9nZXQoRXZhc19PYmplY3QgKm8p CiB7Ci0gICAgRVdLX1ZJRVdfU0RfR0VUKG8sIHNkKTsKLSAgICBFV0tfVklFV19QUklWX0dFVChz ZCwgcHJpdik7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgLTEuMCk7Cisg ICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCAtMS4wKTsKIAogICAgIHJl dHVybiBwcml2LT5zZXR0aW5ncy56b29tX3JhbmdlLm1pbl9zY2FsZTsKIH0KIAogZmxvYXQgZXdr X3ZpZXdfem9vbV9yYW5nZV9tYXhfZ2V0KEV2YXNfT2JqZWN0ICpvKQogewotICAgIEVXS19WSUVX X1NEX0dFVChvLCBzZCk7Ci0gICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2QsIHByaXYpOworICAgIEVX S19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIC0xLjApOworICAgIEVXS19WSUVXX1BSSVZf R0VUX09SX1JFVFVSTihzZCwgcHJpdiwgLTEuMCk7CiAKICAgICByZXR1cm4gcHJpdi0+c2V0dGlu Z3Muem9vbV9yYW5nZS5tYXhfc2NhbGU7CiB9CiAKLXZvaWQgZXdrX3ZpZXdfdXNlcl9zY2FsYWJs ZV9zZXQoRXZhc19PYmplY3QgKm8sIEVpbmFfQm9vbCB1c2VyX3NjYWxhYmxlKQorRWluYV9Cb29s IGV3a192aWV3X3VzZXJfc2NhbGFibGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBFaW5hX0Jvb2wgdXNl cl9zY2FsYWJsZSkKIHsKLSAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVX X1BSSVZfR0VUKHNkLCBwcml2KTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNk LCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYs IEVJTkFfRkFMU0UpOwogCiAgICAgcHJpdi0+c2V0dGluZ3Muem9vbV9yYW5nZS51c2VyX3NjYWxh YmxlID0gdXNlcl9zY2FsYWJsZTsKKworICAgIHJldHVybiBFSU5BX1RSVUU7CiB9CiAKIEVpbmFf Qm9vbCBld2tfdmlld191c2VyX3NjYWxhYmxlX2dldChFdmFzX09iamVjdCAqbykKIHsKLSAgICBF V0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVXX1BSSVZfR0VUKHNkLCBwcml2KTsK KyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBF V0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIEVJTkFfRkFMU0UpOwogCiAgICAg cmV0dXJuIHByaXYtPnNldHRpbmdzLnpvb21fcmFuZ2UudXNlcl9zY2FsYWJsZTsKIH0KIAogZmxv YXQgZXdrX3ZpZXdfZGV2aWNlX3BpeGVsX3JhdGlvX2dldChFdmFzX09iamVjdCAqbykKIHsKLSAg ICBFV0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVXX1BSSVZfR0VUKHNkLCBwcml2 KTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCAtMS4wKTsKKyAgICBFV0tf VklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIC0xLjApOwogCiAgICAgcmV0dXJuIHBy aXYtPnNldHRpbmdzLmRldmljZV9waXhlbF9yYXRpbzsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmgKaW5kZXggYWZlOTEwNS4uMDZiNjA0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAg LTE2MjIsNyArMTYyMiw3IEBAIEVBUEkgRWluYV9Cb29sIGV3a192aWV3X3pvb21fcmFuZ2Vfc2V0 KEV2YXNfT2JqZWN0ICpvLCBmbG9hdCBtaW5fc2NhbGUsIGZsb2F0IG1hCiAgKgogICogQHBhcmFt IG8gdmlldy4KICAqCi0gKiBAcmV0dXJuIG1pbmltdW0gdmFsdWUgb2Ygem9vbSByYW5nZS4KKyAq IEByZXR1cm4gbWluaW11bSB2YWx1ZSBvZiB6b29tIHJhbmdlLCBvciBAYyAtMS4wIG9uIGZhaWx1 cmUuCiAgKi8KIEVBUEkgZmxvYXQgZXdrX3ZpZXdfem9vbV9yYW5nZV9taW5fZ2V0KEV2YXNfT2Jq ZWN0ICpvKTsKIApAQCAtMTYzMSw3ICsxNjMxLDcgQEAgRUFQSSBmbG9hdCBld2tfdmlld196b29t X3JhbmdlX21pbl9nZXQoRXZhc19PYmplY3QgKm8pOwogICoKICAqIEBwYXJhbSBvIHZpZXcuCiAg KgotICogQHJldHVybiBtYXhpbXVtIHZhbHVlIG9mIHpvb20gcmFuZ2UuCisgKiBAcmV0dXJuIG1h eGltdW0gdmFsdWUgb2Ygem9vbSByYW5nZSwgb3IgQGMgLTEuMCBvbiBmYWlsdXJlLgogICovCiBF QVBJIGZsb2F0IGV3a192aWV3X3pvb21fcmFuZ2VfbWF4X2dldChFdmFzX09iamVjdCAqbyk7CiAK QEAgLTE2NDEsOCArMTY0MSwxMCBAQCBFQVBJIGZsb2F0IGV3a192aWV3X3pvb21fcmFuZ2VfbWF4 X2dldChFdmFzX09iamVjdCAqbyk7CiAgKiBAcGFyYW0gbyB2aWV3LgogICogQHBhcmFtIHVzZXJf c2NhbGFibGUgYm9vbGVhbiBwb2ludGVyIGluIHdoaWNoIHRvIGVuYWJsZSB6b29tLiBJdCBkZWZh dWx0cwogICogdG8gQGMgRUlOQV9UUlVFLgorICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIG9u IHN1Y2Nlc3MsIG9yIEBjIEVJTkFfRkFMU0Ugb24gZmFpbHVyZQogICovCi1FQVBJIHZvaWQgZXdr X3ZpZXdfdXNlcl9zY2FsYWJsZV9zZXQoRXZhc19PYmplY3QgKm8sIEVpbmFfQm9vbCB1c2VyX3Nj YWxhYmxlKTsKK0VBUEkgRWluYV9Cb29sIGV3a192aWV3X3VzZXJfc2NhbGFibGVfc2V0KEV2YXNf T2JqZWN0ICpvLCBFaW5hX0Jvb2wgdXNlcl9zY2FsYWJsZSk7CiAKIC8qKgogICogR2V0cyBpZiB6 b29tIGlzIGVuYWJsZWQuCkBAIC0xNjUwLDcgKzE2NTIsNyBAQCBFQVBJIHZvaWQgZXdrX3ZpZXdf dXNlcl9zY2FsYWJsZV9zZXQoRXZhc19PYmplY3QgKm8sIEVpbmFfQm9vbCB1c2VyX3NjYWxhYmxl KTsKICAqIEBwYXJhbSBvIHZpZXcuCiAgKiBAcGFyYW0gdXNlcl9zY2FsYWJsZSB3aGVyZSB0byBy ZXR1cm4gdGhlIGN1cnJlbnQgdXNlciBzY2FsYWJsZSB2YWx1ZS4KICAqCi0gKiBAcmV0dXJuIEBj IEVJTkFfVFJVRSBpZiB6b29tIGlzIGVuYWJsZWQsIEBjIEVJTkFfRkFMU0UgaWYgbm90LgorICog QHJldHVybiBAYyBFSU5BX1RSVUUgaWYgem9vbSBpcyBlbmFibGVkLCBAYyBFSU5BX0ZBTFNFIGlm IG5vdCBvciBvbiBmYWlsdXJlLgogICovCiBFQVBJIEVpbmFfQm9vbCBld2tfdmlld191c2VyX3Nj YWxhYmxlX2dldChFdmFzX09iamVjdCAqbyk7CiAKQEAgLTE2NjAsNyArMTY2Miw3IEBAIEVBUEkg RWluYV9Cb29sIGV3a192aWV3X3VzZXJfc2NhbGFibGVfZ2V0KEV2YXNfT2JqZWN0ICpvKTsKICAq IEBwYXJhbSBvIHZpZXcuCiAgKiBAcGFyYW0gdXNlcl9zY2FsYWJsZSB3aGVyZSB0byByZXR1cm4g dGhlIGN1cnJlbnQgdXNlciBzY2FsYWJsZSB2YWx1ZS4KICAqCi0gKiBAcmV0dXJuIEBjIEVJTkFf VFJVRSBpZiB6b29tIGlzIGVuYWJsZWQsIEBjIEVJTkFfRkFMU0UgaWYgbm90LgorICogQHJldHVy biBkZXZpY2UgcGl4ZWwgcmF0aW8gb3IgQGMgLTEuMCBvbiBmYWlsdXJlLgogICovCiBFQVBJIGZs b2F0IGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19nZXQoRXZhc19PYmplY3QgKm8pOwogCg== 103457 2011-08-10 02:39:53 -0700 2011-08-10 04:53:44 -0700 updated patch api_checks_null.patch text/plain 5254 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwZDE1Y2YxLi5jNGY2YTJhIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMDMgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQVBJIG1ldGhvZHMgY2hlY2sgTlVM TCBhbmQgcmV0dXJuIHByb3BlciB2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY1ODQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBS b2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgQ2hlY2sgTlVMTCBiZWZvcmUgYWNjZXNzIHRv IHRoZSBzbWFydCBhbmQgcHJpdmF0ZSBkYXRhIG9mIHRoZSB2aWV3IG9iamVjdAorICAgICAgICBh bmQgcmV0dXJuIHRoZSBwcm9wZXIgdmFsdWUgaWYgZXJyb3Igb2NjdXJyZWQuCisKKyAgICAgICAg KiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfem9vbV9yYW5nZV9zZXQpOgor ICAgICAgICAoZXdrX3ZpZXdfem9vbV9yYW5nZV9taW5fZ2V0KToKKyAgICAgICAgKGV3a192aWV3 X3pvb21fcmFuZ2VfbWF4X2dldCk6CisgICAgICAgIChld2tfdmlld191c2VyX3NjYWxhYmxlX3Nl dCk6CisgICAgICAgIChld2tfdmlld191c2VyX3NjYWxhYmxlX2dldCk6CisgICAgICAgIChld2tf dmlld19kZXZpY2VfcGl4ZWxfcmF0aW9fZ2V0KToKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuaDoK KwogMjAxMS0wOC0wMiAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9mdXNpb24ubW9i aT4KIAogICAgICAgICBbRUZMXSBJZ25vcmUgZW1wdHkgcmVxdWVzdHMgb24gcG9saWN5IGRlY2lz aW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDA5OTRiZDAuLjkxMTVjNjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMzQxMCw4ICszNDEwLDggQEAgdm9p ZCBld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2dldChFdmFzX09iamVjdCAqbywgZmxvYXQg KncsIGZsb2F0ICpoLCBmbG9hdAogCiBFaW5hX0Jvb2wgZXdrX3ZpZXdfem9vbV9yYW5nZV9zZXQo RXZhc19PYmplY3QgKm8sIGZsb2F0IG1pbl9zY2FsZSwgZmxvYXQgbWF4X3NjYWxlKQogewotICAg IEVXS19WSUVXX1NEX0dFVChvLCBzZCk7Ci0gICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2QsIHByaXYp OworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOworICAg IEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlOQV9GQUxTRSk7CiAKICAg ICBpZiAobWF4X3NjYWxlIDwgbWluX3NjYWxlKSB7CiAgICAgICAgIFdSTigibWluX3NjYWxlIGlz IGxhcmdlciB0aGFuIG1heF9zY2FsZSIpOwpAQCAtMzQyNiw0MCArMzQyNiw0MiBAQCBFaW5hX0Jv b2wgZXdrX3ZpZXdfem9vbV9yYW5nZV9zZXQoRXZhc19PYmplY3QgKm8sIGZsb2F0IG1pbl9zY2Fs ZSwgZmxvYXQgbWF4X3NjYQogCiBmbG9hdCBld2tfdmlld196b29tX3JhbmdlX21pbl9nZXQoRXZh c19PYmplY3QgKm8pCiB7Ci0gICAgRVdLX1ZJRVdfU0RfR0VUKG8sIHNkKTsKLSAgICBFV0tfVklF V19QUklWX0dFVChzZCwgcHJpdik7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBz ZCwgLTEuMCk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCAtMS4w KTsKIAogICAgIHJldHVybiBwcml2LT5zZXR0aW5ncy56b29tX3JhbmdlLm1pbl9zY2FsZTsKIH0K IAogZmxvYXQgZXdrX3ZpZXdfem9vbV9yYW5nZV9tYXhfZ2V0KEV2YXNfT2JqZWN0ICpvKQogewot ICAgIEVXS19WSUVXX1NEX0dFVChvLCBzZCk7Ci0gICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2QsIHBy aXYpOworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIC0xLjApOworICAgIEVX S19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgLTEuMCk7CiAKICAgICByZXR1cm4g cHJpdi0+c2V0dGluZ3Muem9vbV9yYW5nZS5tYXhfc2NhbGU7CiB9CiAKLXZvaWQgZXdrX3ZpZXdf dXNlcl9zY2FsYWJsZV9zZXQoRXZhc19PYmplY3QgKm8sIEVpbmFfQm9vbCB1c2VyX3NjYWxhYmxl KQorRWluYV9Cb29sIGV3a192aWV3X3VzZXJfc2NhbGFibGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBF aW5hX0Jvb2wgdXNlcl9zY2FsYWJsZSkKIHsKLSAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwot ICAgIEVXS19WSUVXX1BSSVZfR0VUKHNkLCBwcml2KTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1Jf UkVUVVJOKG8sIHNkLCBFSU5BX0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRV Uk4oc2QsIHByaXYsIEVJTkFfRkFMU0UpOwogCiAgICAgcHJpdi0+c2V0dGluZ3Muem9vbV9yYW5n ZS51c2VyX3NjYWxhYmxlID0gdXNlcl9zY2FsYWJsZTsKKworICAgIHJldHVybiBFSU5BX1RSVUU7 CiB9CiAKIEVpbmFfQm9vbCBld2tfdmlld191c2VyX3NjYWxhYmxlX2dldChFdmFzX09iamVjdCAq bykKIHsKLSAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVXX1BSSVZfR0VU KHNkLCBwcml2KTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBFSU5BX0ZB TFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIEVJTkFfRkFM U0UpOwogCiAgICAgcmV0dXJuIHByaXYtPnNldHRpbmdzLnpvb21fcmFuZ2UudXNlcl9zY2FsYWJs ZTsKIH0KIAogZmxvYXQgZXdrX3ZpZXdfZGV2aWNlX3BpeGVsX3JhdGlvX2dldChFdmFzX09iamVj dCAqbykKIHsKLSAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwotICAgIEVXS19WSUVXX1BSSVZf R0VUKHNkLCBwcml2KTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCAtMS4w KTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIC0xLjApOwogCiAg ICAgcmV0dXJuIHByaXYtPnNldHRpbmdzLmRldmljZV9waXhlbF9yYXRpbzsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmgKaW5kZXggYWZlOTEwNS4uMDZiNjA0NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmgKQEAgLTE2MjIsNyArMTYyMiw3IEBAIEVBUEkgRWluYV9Cb29sIGV3a192aWV3X3pv b21fcmFuZ2Vfc2V0KEV2YXNfT2JqZWN0ICpvLCBmbG9hdCBtaW5fc2NhbGUsIGZsb2F0IG1hCiAg KgogICogQHBhcmFtIG8gdmlldy4KICAqCi0gKiBAcmV0dXJuIG1pbmltdW0gdmFsdWUgb2Ygem9v bSByYW5nZS4KKyAqIEByZXR1cm4gbWluaW11bSB2YWx1ZSBvZiB6b29tIHJhbmdlLCBvciBAYyAt MS4wIG9uIGZhaWx1cmUuCiAgKi8KIEVBUEkgZmxvYXQgZXdrX3ZpZXdfem9vbV9yYW5nZV9taW5f Z2V0KEV2YXNfT2JqZWN0ICpvKTsKIApAQCAtMTYzMSw3ICsxNjMxLDcgQEAgRUFQSSBmbG9hdCBl d2tfdmlld196b29tX3JhbmdlX21pbl9nZXQoRXZhc19PYmplY3QgKm8pOwogICoKICAqIEBwYXJh bSBvIHZpZXcuCiAgKgotICogQHJldHVybiBtYXhpbXVtIHZhbHVlIG9mIHpvb20gcmFuZ2UuCisg KiBAcmV0dXJuIG1heGltdW0gdmFsdWUgb2Ygem9vbSByYW5nZSwgb3IgQGMgLTEuMCBvbiBmYWls dXJlLgogICovCiBFQVBJIGZsb2F0IGV3a192aWV3X3pvb21fcmFuZ2VfbWF4X2dldChFdmFzX09i amVjdCAqbyk7CiAKQEAgLTE2NDEsOCArMTY0MSwxMCBAQCBFQVBJIGZsb2F0IGV3a192aWV3X3pv b21fcmFuZ2VfbWF4X2dldChFdmFzX09iamVjdCAqbyk7CiAgKiBAcGFyYW0gbyB2aWV3LgogICog QHBhcmFtIHVzZXJfc2NhbGFibGUgYm9vbGVhbiBwb2ludGVyIGluIHdoaWNoIHRvIGVuYWJsZSB6 b29tLiBJdCBkZWZhdWx0cwogICogdG8gQGMgRUlOQV9UUlVFLgorICoKKyAqIEByZXR1cm4gQGMg RUlOQV9UUlVFIG9uIHN1Y2Nlc3MsIG9yIEBjIEVJTkFfRkFMU0Ugb24gZmFpbHVyZQogICovCi1F QVBJIHZvaWQgZXdrX3ZpZXdfdXNlcl9zY2FsYWJsZV9zZXQoRXZhc19PYmplY3QgKm8sIEVpbmFf Qm9vbCB1c2VyX3NjYWxhYmxlKTsKK0VBUEkgRWluYV9Cb29sIGV3a192aWV3X3VzZXJfc2NhbGFi bGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBFaW5hX0Jvb2wgdXNlcl9zY2FsYWJsZSk7CiAKIC8qKgog ICogR2V0cyBpZiB6b29tIGlzIGVuYWJsZWQuCkBAIC0xNjUwLDcgKzE2NTIsNyBAQCBFQVBJIHZv aWQgZXdrX3ZpZXdfdXNlcl9zY2FsYWJsZV9zZXQoRXZhc19PYmplY3QgKm8sIEVpbmFfQm9vbCB1 c2VyX3NjYWxhYmxlKTsKICAqIEBwYXJhbSBvIHZpZXcuCiAgKiBAcGFyYW0gdXNlcl9zY2FsYWJs ZSB3aGVyZSB0byByZXR1cm4gdGhlIGN1cnJlbnQgdXNlciBzY2FsYWJsZSB2YWx1ZS4KICAqCi0g KiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBpZiB6b29tIGlzIGVuYWJsZWQsIEBjIEVJTkFfRkFMU0Ug aWYgbm90LgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgem9vbSBpcyBlbmFibGVkLCBAYyBF SU5BX0ZBTFNFIGlmIG5vdCBvciBvbiBmYWlsdXJlLgogICovCiBFQVBJIEVpbmFfQm9vbCBld2tf dmlld191c2VyX3NjYWxhYmxlX2dldChFdmFzX09iamVjdCAqbyk7CiAKQEAgLTE2NjAsNyArMTY2 Miw3IEBAIEVBUEkgRWluYV9Cb29sIGV3a192aWV3X3VzZXJfc2NhbGFibGVfZ2V0KEV2YXNfT2Jq ZWN0ICpvKTsKICAqIEBwYXJhbSBvIHZpZXcuCiAgKiBAcGFyYW0gdXNlcl9zY2FsYWJsZSB3aGVy ZSB0byByZXR1cm4gdGhlIGN1cnJlbnQgdXNlciBzY2FsYWJsZSB2YWx1ZS4KICAqCi0gKiBAcmV0 dXJuIEBjIEVJTkFfVFJVRSBpZiB6b29tIGlzIGVuYWJsZWQsIEBjIEVJTkFfRkFMU0UgaWYgbm90 LgorICogQHJldHVybiBkZXZpY2UgcGl4ZWwgcmF0aW8gb3IgQGMgLTEuMCBvbiBmYWlsdXJlLgog ICovCiBFQVBJIGZsb2F0IGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19nZXQoRXZhc19PYmpl Y3QgKm8pOwogCg==