65842 2011-08-08 00:09:24 -0700 [EFL] Allow to skip count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get 2011-09-28 01:01:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 447874 0 g.czajkowski 2011-08-08 00:09:24 -0700 Makes the count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get as an optional parameter. Developer may pass NULL to skip returning the number of elements of the requested array. 447875 1 103211 g.czajkowski 2011-08-08 00:10:58 -0700 Created attachment 103211 proposed patch 447993 2 103211 leandro 2011-08-08 07:42:31 -0700 Comment on attachment 103211 proposed patch Informal r+. 448051 3 103211 leandro 2011-08-08 09:54:20 -0700 Comment on attachment 103211 proposed patch Informal r+. 455118 4 gyuyoung.kim 2011-08-22 17:58:14 -0700 LGTM also. 474583 5 103211 webkit.review.bot 2011-09-28 01:01:21 -0700 Comment on attachment 103211 proposed patch Clearing flags on attachment: 103211 Committed r96202: <http://trac.webkit.org/changeset/96202> 474584 6 webkit.review.bot 2011-09-28 01:01:26 -0700 All reviewed patches have been landed. Closing bug. 103211 2011-08-08 00:10:58 -0700 2011-09-28 01:01:21 -0700 proposed patch skip_count_parameter.patch text/plain 2622 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBlODY1NDA1Li44YmUwN2Y4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWxsb3cgdG8gc2tpcCBjb3VudCBw YXJhbWV0ZXIgaW4gZXdrX3ZpZXdfcmVwYWludHNfZ2V0IGFuZCBld2tfdmlld19zY3JvbGxfcmVx dWVzdHNfZ2V0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjU4NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYWtlcyB0aGUgY291bnQgcGFyYW1ldGVyIGluIGV3a192aWV3X3JlcGFpbnRzX2dldCBhbmQg ZXdrX3ZpZXdfc2Nyb2xsX3JlcXVlc3RzX2dldAorICAgICAgICBhcyBhbiBvcHRpb25hbCBwYXJh bWV0ZXIuIERldmVsb3BlciBtYXkgcGFzcyBOVUxMIHRvIHNraXAgcmV0dXJuaW5nIHRoZSBudW1i ZXIgb2YgZWxlbWVudHMKKyAgICAgICAgb2YgdGhlIHJlcXVlc3RlZCBhcnJheS4KKworICAgICAg ICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19yZXBhaW50c19nZXQpOgor ICAgICAgICAoZXdrX3ZpZXdfc2Nyb2xsX3JlcXVlc3RzX2dldCk6CisKIDIwMTEtMDgtMDUgIEdy emVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAg W0VGTF0gTW92ZSBBUEkgZG9jdW1lbnRhdGlvbiBvZiBld2sgZmlsZXMgdG8gdGhlIGhlYWRlcnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDA5OTRiZDAuLjQxN2M2MWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMjM0OSw3ICsyMzQ5LDcgQEAgRXdrX1ZpZXdf U21hcnRfRGF0YSAqZXdrX3ZpZXdfc21hcnRfZGF0YV9nZXQoY29uc3QgRXZhc19PYmplY3QgKm8p CiAgKiBvdGhlcndpc2UgY29weSB0aGUgYXJyYXkuCiAgKgogICogQHBhcmFtIHByaXYgcHJpdmF0 ZSBoYW5kbGUgcG9pbnRlciBvZiB0aGUgdmlldyB0byBnZXQgcmVwYWludHMuCi0gKiBAcGFyYW0g Y291bnQgd2hlcmUgdG8gcmV0dXJuIHRoZSBudW1iZXIgb2YgZWxlbWVudHMgb2YgcmV0dXJuZWQg YXJyYXkuCisgKiBAcGFyYW0gY291bnQgd2hlcmUgdG8gcmV0dXJuIHRoZSBudW1iZXIgb2YgZWxl bWVudHMgb2YgcmV0dXJuZWQgYXJyYXksIG1heSBiZSBAYyAwLgogICoKICAqIEByZXR1cm4gcmVm ZXJlbmNlIHRvIGFycmF5IG9mIHJlcXVlc3RlZCByZXBhaW50cy4KICAqCkBAIC0yMzU4LDcgKzIz NTgsNiBAQCBFd2tfVmlld19TbWFydF9EYXRhICpld2tfdmlld19zbWFydF9kYXRhX2dldChjb25z dCBFdmFzX09iamVjdCAqbykKICAqLwogY29uc3QgRWluYV9SZWN0YW5nbGUgKmV3a192aWV3X3Jl cGFpbnRzX2dldChjb25zdCBFd2tfVmlld19Qcml2YXRlX0RhdGEgKnByaXYsIHNpemVfdCAqY291 bnQpCiB7Ci0gICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKGNvdW50LCAwKTsKICAg ICBpZiAoY291bnQpCiAgICAgICAgICpjb3VudCA9IDA7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVM TF9SRVRVUk5fVkFMKHByaXYsIDApOwpAQCAtMjM3Nyw3ICsyMzc2LDcgQEAgY29uc3QgRWluYV9S ZWN0YW5nbGUgKmV3a192aWV3X3JlcGFpbnRzX2dldChjb25zdCBFd2tfVmlld19Qcml2YXRlX0Rh dGEgKnByaXYsIHMKICAqIG90aGVyd2lzZSBjb3B5IHRoZSBhcnJheS4KICAqCiAgKiBAcGFyYW0g cHJpdiBwcml2YXRlIGhhbmRsZSBwb2ludGVyIG9mIHRoZSB2aWV3IHRvIGdldCBzY3JvbGxzLgot ICogQHBhcmFtIGNvdW50IHdoZXJlIHRvIHJldHVybiB0aGUgbnVtYmVyIG9mIGVsZW1lbnRzIG9m IHJldHVybmVkIGFycmF5LgorICogQHBhcmFtIGNvdW50IHdoZXJlIHRvIHJldHVybiB0aGUgbnVt YmVyIG9mIGVsZW1lbnRzIG9mIHJldHVybmVkIGFycmF5LCBtYXkgYmUgQGMgMC4KICAqCiAgKiBA cmV0dXJuIHJlZmVyZW5jZSB0byBhcnJheSBvZiByZXF1ZXN0ZWQgc2Nyb2xscy4KICAqCkBAIC0y Mzg2LDcgKzIzODUsNiBAQCBjb25zdCBFaW5hX1JlY3RhbmdsZSAqZXdrX3ZpZXdfcmVwYWludHNf Z2V0KGNvbnN0IEV3a19WaWV3X1ByaXZhdGVfRGF0YSAqcHJpdiwgcwogICovCiBjb25zdCBFd2tf U2Nyb2xsX1JlcXVlc3QgKmV3a192aWV3X3Njcm9sbF9yZXF1ZXN0c19nZXQoY29uc3QgRXdrX1Zp ZXdfUHJpdmF0ZV9EYXRhICpwcml2LCBzaXplX3QgKmNvdW50KQogewotICAgIEVJTkFfU0FGRVRZ X09OX05VTExfUkVUVVJOX1ZBTChjb3VudCwgMCk7CiAgICAgaWYgKGNvdW50KQogICAgICAgICAq Y291bnQgPSAwOwogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChwcml2LCAwKTsK