65816 2011-08-06 12:52:49 -0700 Test how AudioBufferSourceNode reacts when given too few arguments 2011-08-10 21:01:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65787 1 abarth abarth crogers dglazkov webkit.review.bot oldest_to_newest 447639 0 abarth 2011-08-06 12:52:49 -0700 Test how AudioBufferSourceNode reacts when given too few arguments 447642 1 103158 abarth 2011-08-06 12:55:28 -0700 Created attachment 103158 Patch 448144 2 103158 webkit.review.bot 2011-08-08 11:50:11 -0700 Comment on attachment 103158 Patch Attachment 103158 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9329944 New failing tests: webaudio/audionode.html 448217 3 103282 abarth 2011-08-08 13:19:02 -0700 Created attachment 103282 Patch 449280 4 crogers 2011-08-10 11:58:13 -0700 Hi Adam, thanks for the patch. This seems fine to me. I few of my demos were passing in no argument to noteOn(), which I was intending to support (meaning "play now"). But, thinking about this a bit more, I think it's a good idea for people to think about these APIs (especially noteOn()) as they relate to time. So, the time value should always be explicit (even if 0 is passed in which means "play now"). 449342 5 abarth 2011-08-10 13:12:12 -0700 Chris, it's entirely up to you. I'm happy to mark the arguments as optional if that's what you'd prefer. 449361 6 crogers 2011-08-10 13:33:01 -0700 Hi Adam, I think the requirement for the argument is fine. I've already updated my two samples with the change. The specification doesn't mark the argument as optional, and I don't think there are any significant demos other people have done which this will break. In general, though, I'd always appreciate a "heads-up" for any (potentially breaking) API change. 449395 7 abarth 2011-08-10 14:12:02 -0700 > In general, though, I'd always appreciate a "heads-up" for any (potentially breaking) API change. Definitely. There was some miscommunication. I thought you had already signed off. 449579 8 103282 webkit.review.bot 2011-08-10 21:01:03 -0700 Comment on attachment 103282 Patch Clearing flags on attachment: 103282 Committed r92817: <http://trac.webkit.org/changeset/92817> 449580 9 webkit.review.bot 2011-08-10 21:01:08 -0700 All reviewed patches have been landed. Closing bug. 103158 2011-08-06 12:55:28 -0700 2011-08-08 13:18:59 -0700 Patch bug-65816-20110806125527.patch text/plain 2281 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkyNTU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMDYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBUZXN0IGhvdyBBdWRpb0J1ZmZlclNvdXJjZU5vZGUg cmVhY3RzIHdoZW4gZ2l2ZW4gdG9vIGZldyBhcmd1bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1ODE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFdlYkF1ZGlvIEFQSSBpcyBleHRyZW1lbHkg bmV3LiAgSXQgaGFzIG9ubHkgYmVlbiBhdmFpbGFibGUgYXMgYW4KKyAgICAgICAgZXhwZXJpbWVu dGFsIEFQSSBpbiBhIHNpbmdsZSBicm93c2VyLiAgVGhlIGNvbXBhdGliaWxpdHkgY29zdCBvZgor ICAgICAgICB0aWdodGVuaW5nIHVwIHRoZXNlIEFQSXMgaXMgdGlueSBhbmQgdGhlc2UgQVBJcyBt YWtlIHZlcnkgbGl0dGxlIHNlbnNlCisgICAgICAgIHRvIGNhbGwgd2l0aCB0b28tZmV3IGFyZ3Vt ZW50cy4KKworICAgICAgICAqIHdlYmF1ZGlvL2F1ZGlvbm9kZS1leHBlY3RlZC50eHQ6CisgICAg ICAgICogd2ViYXVkaW8vYXVkaW9ub2RlLmh0bWw6CisKIDIwMTEtMDgtMDYgIE5pa29sYXMgWmlt bWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgc3ZnL3pvb20vcGFnZS96 b29tLXN2Zy10aHJvdWdoLW9iamVjdC13aXRoLSoueGh0bWwgYXJlIGZsYWt5CkluZGV4OiBMYXlv dXRUZXN0cy93ZWJhdWRpby9hdWRpb25vZGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDkyNTUy KQorKysgTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9ub2RlLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtMiw2ICsyLDkgQEAgQmFzaWMgdGVzdHMgZm9yIEF1ZGlvTm9kZSBBUEkuCiAK IE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAorUEFTUyBhdWRpb05vZGUubm90ZU9uKCkgdGhy ZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIGF1ZGlv Tm9kZS5ub3RlR3JhaW5PbigpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2gg YXJndW1lbnRzLgorUEFTUyBhdWRpb05vZGUubm90ZU9mZigpIHRocmV3IGV4Y2VwdGlvbiBUeXBl RXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgogUEFTUyBTb3VyY2UgQXVkaW9Ob2RlIGhhcyBu byBpbnB1dHMuCiBQQVNTIFNvdXJjZSBBdWRpb05vZGUgaGFzIG9uZSBvdXRwdXQuCiBQQVNTIGNv bm5lY3QoKSBleGNlcHRpb24gdGhyb3duIGZvciBpbGxlZ2FsIGRlc3RpbmF0aW9uIEF1ZGlvTm9k ZS4KSW5kZXg6IExheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS5odG1sCShyZXZpc2lvbiA5MjU1MikK KysrIExheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0yNyw2ICsyNywxMCBAQCBmdW5jdGlvbiBydW5UZXN0KCkgewogICAgIGNvbnRleHQgPSBuZXcg d2Via2l0QXVkaW9Db250ZXh0KCk7CiAgICAgdmFyIGF1ZGlvTm9kZSA9IGNvbnRleHQuY3JlYXRl QnVmZmVyU291cmNlKCk7CiAKKyAgICBzaG91bGRUaHJvdygiYXVkaW9Ob2RlLm5vdGVPbigpIik7 CisgICAgc2hvdWxkVGhyb3coImF1ZGlvTm9kZS5ub3RlR3JhaW5PbigpIik7CisgICAgc2hvdWxk VGhyb3coImF1ZGlvTm9kZS5ub3RlT2ZmKCkiKTsKKwogICAgIC8vIENoZWNrIG51bWJlciBvZiBp bnB1dHMgYW5kIG91dHB1dHMuCiAgICAgaWYgKGF1ZGlvTm9kZS5udW1iZXJPZklucHV0cyA9PSAw KQogICAgICAgICB0ZXN0UGFzc2VkKCJTb3VyY2UgQXVkaW9Ob2RlIGhhcyBubyBpbnB1dHMuIik7 Cg== 103282 2011-08-08 13:19:02 -0700 2011-08-10 21:01:03 -0700 Patch bug-65816-20110808131901.patch text/plain 2310 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkyNTg1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMDggIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBUZXN0IGhvdyBBdWRpb0J1ZmZlclNvdXJjZU5vZGUg cmVhY3RzIHdoZW4gZ2l2ZW4gdG9vIGZldyBhcmd1bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1ODE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFdlYkF1ZGlvIEFQSSBpcyBleHRyZW1lbHkg bmV3LiAgSXQgaGFzIG9ubHkgYmVlbiBhdmFpbGFibGUgYXMgYW4KKyAgICAgICAgZXhwZXJpbWVu dGFsIEFQSSBpbiBhIHNpbmdsZSBicm93c2VyLiAgVGhlIGNvbXBhdGliaWxpdHkgY29zdCBvZgor ICAgICAgICB0aWdodGVuaW5nIHVwIHRoZXNlIEFQSXMgaXMgdGlueSBhbmQgdGhlc2UgQVBJcyBt YWtlIHZlcnkgbGl0dGxlIHNlbnNlCisgICAgICAgIHRvIGNhbGwgd2l0aCB0b28tZmV3IGFyZ3Vt ZW50cy4KKworICAgICAgICAqIHdlYmF1ZGlvL2F1ZGlvbm9kZS1leHBlY3RlZC50eHQ6CisgICAg ICAgICogd2ViYXVkaW8vYXVkaW9ub2RlLmh0bWw6CisKIDIwMTEtMDctMjggIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gTWFrZSBmb3JtIHZh bGlkYXRpb24gYnViYmxlIGZpdCB3aXRoIENocm9tZSBVSSBzdHlsZQpJbmRleDogTGF5b3V0VGVz dHMvd2ViYXVkaW8vYXVkaW9ub2RlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy93ZWJhdWRpby9hdWRpb25vZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5MjU4NSkKKysr IExheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvbm9kZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTIsNiArMiw5IEBAIEJhc2ljIHRlc3RzIGZvciBBdWRpb05vZGUgQVBJLgogCiBPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCiAKK1BBU1MgYXVkaW9Ob2RlLm5vdGVPbigpIHRocmV3IGV4 Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyBhdWRpb05vZGUu bm90ZUdyYWluT24oKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3Vt ZW50cy4KK1BBU1MgYXVkaW9Ob2RlLm5vdGVPZmYoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9y OiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KIFBBU1MgU291cmNlIEF1ZGlvTm9kZSBoYXMgbm8gaW5w dXRzLgogUEFTUyBTb3VyY2UgQXVkaW9Ob2RlIGhhcyBvbmUgb3V0cHV0LgogUEFTUyBjb25uZWN0 KCkgZXhjZXB0aW9uIHRocm93biBmb3IgaWxsZWdhbCBkZXN0aW5hdGlvbiBBdWRpb05vZGUuCklu ZGV4OiBMYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb25vZGUuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb25vZGUuaHRtbAkocmV2aXNpb24gOTI1ODUpCisrKyBM YXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb25vZGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjUs NyArMjUsMTEgQEAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICB3aW5kb3cuanNUZXN0SXNBc3lu YyA9IHRydWU7CiAKICAgICBjb250ZXh0ID0gbmV3IHdlYmtpdEF1ZGlvQ29udGV4dCgpOwotICAg IHZhciBhdWRpb05vZGUgPSBjb250ZXh0LmNyZWF0ZUJ1ZmZlclNvdXJjZSgpOworICAgIHdpbmRv dy5hdWRpb05vZGUgPSBjb250ZXh0LmNyZWF0ZUJ1ZmZlclNvdXJjZSgpOworCisgICAgc2hvdWxk VGhyb3coImF1ZGlvTm9kZS5ub3RlT24oKSIpOworICAgIHNob3VsZFRocm93KCJhdWRpb05vZGUu bm90ZUdyYWluT24oKSIpOworICAgIHNob3VsZFRocm93KCJhdWRpb05vZGUubm90ZU9mZigpIik7 CiAKICAgICAvLyBDaGVjayBudW1iZXIgb2YgaW5wdXRzIGFuZCBvdXRwdXRzLgogICAgIGlmIChh dWRpb05vZGUubnVtYmVyT2ZJbnB1dHMgPT0gMCkK