65812 2011-08-06 12:12:24 -0700 Test how SpeechInputResultList behaves with not enough arguments 2011-08-11 01:11:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65787 1 abarth abarth dglazkov webkit.review.bot oldest_to_newest 447627 0 abarth 2011-08-06 12:12:24 -0700 Test how SpeechInputResultList behaves with not enough arguments 447628 1 103154 abarth 2011-08-06 12:15:10 -0700 Created attachment 103154 Patch 447630 2 abarth 2011-08-06 12:15:50 -0700 I don't have a build with speech enabled, but hopefully the cr-linux-ews will provide me with the expected.txt file. 447765 3 103154 webkit.review.bot 2011-08-07 13:13:03 -0700 Comment on attachment 103154 Patch Attachment 103154 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9329547 New failing tests: fast/speech/speech-input-result-list-not-enough-arguments.html 448186 4 103277 abarth 2011-08-08 12:42:44 -0700 Created attachment 103277 Patch 449565 5 103277 sam 2011-08-10 19:53:34 -0700 Comment on attachment 103277 Patch Does this need to be added to some skipped lists, or is the speech directory already in them? 449573 6 abarth 2011-08-10 20:52:52 -0700 > Does this need to be added to some skipped lists, or is the speech directory already in them? Good question. I believe the directory is skipped, but I will check before landing. 449636 7 103277 abarth 2011-08-11 00:09:43 -0700 Comment on attachment 103277 Patch Verified for Mac, Win, GTK, and Qt. 449651 8 103277 webkit.review.bot 2011-08-11 01:11:01 -0700 Comment on attachment 103277 Patch Clearing flags on attachment: 103277 Committed r92828: <http://trac.webkit.org/changeset/92828> 449652 9 webkit.review.bot 2011-08-11 01:11:06 -0700 All reviewed patches have been landed. Closing bug. 103154 2011-08-06 12:15:10 -0700 2011-08-08 12:42:40 -0700 Patch bug-65812-20110806121508.patch text/plain 3387 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkyNTU0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMDYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBUZXN0IGhvdyBTcGVlY2hJbnB1dFJlc3VsdExpc3Qg YmVoYXZlcyB3aXRoIG5vdCBlbm91Z2ggYXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWVjaElucHV0UmVzdWx0TGlzdCBpcyBvbmx5IGV4 cG9zZWQgdmlhIHRoZSB4LXdlYmtpdC1zcGVlY2gKKyAgICAgICAgYXR0cmlidXRlLCB3aGljaCBt ZWFucyB0aGVyZSBpcyBsaXR0bGUgY29tcGF0aWJpbGl0eSByaXNrIGluIGFsaWduaW5nCisgICAg ICAgIG91ciB0b28tZmV3LWFyZ3VtZW50cyBiZWhhdmlvciB3aXRoIHRoZSBzcGVjaWZpY2F0aW9u LiAgVGhlcmUncyBhCisgICAgICAgIHF1ZXN0aW9uIGFib3V0IHdoZXRoZXIgYWxsIHRoZXNlICJm YWtlIGFycmF5IiBvYmplY3RzIHNob3VsZCB3b3JrCisgICAgICAgIGNvbnNpc3RlbnRseSwgYnV0 IHdlJ2xsIHByb2JhYmx5IHdhbnQgdGhlICJmYWtlIGFycmF5IiBvYmplY3RzIHdlCisgICAgICAg IGNyZWF0ZSBpbiB0aGUgZnV0dXJlIHRvIG1hdGNoIHRoZSBzcGVjLCBzbyBldmVuIGlmIHdlJ3Jl IGNvbnNpc3RlbnQKKyAgICAgICAgbm93LCB3ZSdsbCBlbmQgdXAgbm90IGJlaW5nIGNvbnNpc3Rl bnQgaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICAqIGZhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1y ZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFyZ3VtZW50cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1yZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFy Z3VtZW50cy5odG1sOiBBZGRlZC4KKwogMjAxMS0wOC0wNiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8 bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBzdmcvem9vbS9wYWdlL3pvb20tc3ZnLXRo cm91Z2gtb2JqZWN0LXdpdGgtKi54aHRtbCBhcmUgZmxha3kKSW5kZXg6IExheW91dFRlc3RzL2Zh c3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1yZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFyZ3VtZW50cy1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9zcGVlY2gvc3BlZWNo LWlucHV0LXJlc3VsdC1saXN0LW5vdC1lbm91Z2gtYXJndW1lbnRzLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1yZXN1bHQt bGlzdC1ub3QtZW5vdWdoLWFyZ3VtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsNiBAQAorVGVzdHMgZm9yIFNwZWVjaElucHV0UmVzdWx0TGlzdCcgYmVoYXZpb3Igd2l0 aCB0b28gZmV3IGFyZ3VtZW50cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCitORUVE UyBSRVNVTFRTCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1y ZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFyZ3VtZW50cy5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1yZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFy Z3VtZW50cy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9zcGVlY2gvc3Bl ZWNoLWlucHV0LXJlc3VsdC1saXN0LW5vdC1lbm91Z2gtYXJndW1lbnRzLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNDEgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFRE IEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9 Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAg aWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQg dHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2Rlc2NyaXB0aW9uKCdUZXN0cyBmb3IgU3BlZWNoSW5w dXRSZXN1bHRMaXN0XCcgYmVoYXZpb3Igd2l0aCB0b28gZmV3IGFyZ3VtZW50cy4nKTsKKwordmFy IHNwZWVjaElucHV0Q3JlYXRlZEJ5U2NyaXB0ID0gZmFsc2U7CisKK2Z1bmN0aW9uIG9uV2Via2l0 U3BlZWNoQ2hhbmdlKCkgeworICAgIHNob3VsZFRocm93KCd3aW5kb3cuZXZlbnQuaXRlbSgpJyk7 CisgICAgZmluaXNoSlNUZXN0KCk7Cit9CisKK2Z1bmN0aW9uIHJ1bigpIHsKKyAgICBpZiAoIXdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlciB8fCAhd2luZG93LmV2ZW50U2VuZGVyKQorICAgICAg ICByZXR1cm47CisKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5hZGRNb2NrU3BlZWNoSW5wdXRS ZXN1bHQoJ1BpY3R1cmVzIG9mIHRoZSBtb29uJywgMS4wLCAnJyk7CisgICAgdmFyIGlucHV0ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3NwZWVjaElucHV0Jyk7CisgICAgaW5wdXQuYWRkRXZl bnRMaXN0ZW5lcignd2Via2l0c3BlZWNoY2hhbmdlJywgb25XZWJraXRTcGVlY2hDaGFuZ2UpOwor ICAgIHZhciB4ID0gaW5wdXQub2Zmc2V0TGVmdCArIGlucHV0Lm9mZnNldFdpZHRoIC0gODsKKyAg ICB2YXIgeSA9IGlucHV0Lm9mZnNldFRvcCArIGlucHV0Lm9mZnNldEhlaWdodCAvIDI7CisgICAg ZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3du KCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworfQorCit3aW5kb3cub25sb2FkID0gcnVu Oword2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOword2luZG93LnN1Y2Nlc3NmdWxseVBhcnNl ZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzxpbnB1dCBpZD0nc3BlZWNoSW5wdXQnIHgtd2Via2l0LXNw ZWVjaD4KKzwvYm9keT4KKzwvaHRtbD4K 103277 2011-08-08 12:42:44 -0700 2011-08-11 01:11:01 -0700 Patch bug-65812-20110808124243.patch text/plain 3511 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkyNTg1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMDggIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBUZXN0IGhvdyBTcGVlY2hJbnB1dFJlc3VsdExpc3Qg YmVoYXZlcyB3aXRoIG5vdCBlbm91Z2ggYXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWVjaElucHV0UmVzdWx0TGlzdCBpcyBvbmx5IGV4 cG9zZWQgdmlhIHRoZSB4LXdlYmtpdC1zcGVlY2gKKyAgICAgICAgYXR0cmlidXRlLCB3aGljaCBt ZWFucyB0aGVyZSBpcyBsaXR0bGUgY29tcGF0aWJpbGl0eSByaXNrIGluIGFsaWduaW5nCisgICAg ICAgIG91ciB0b28tZmV3LWFyZ3VtZW50cyBiZWhhdmlvciB3aXRoIHRoZSBzcGVjaWZpY2F0aW9u LiAgVGhlcmUncyBhCisgICAgICAgIHF1ZXN0aW9uIGFib3V0IHdoZXRoZXIgYWxsIHRoZXNlICJm YWtlIGFycmF5IiBvYmplY3RzIHNob3VsZCB3b3JrCisgICAgICAgIGNvbnNpc3RlbnRseSwgYnV0 IHdlJ2xsIHByb2JhYmx5IHdhbnQgdGhlICJmYWtlIGFycmF5IiBvYmplY3RzIHdlCisgICAgICAg IGNyZWF0ZSBpbiB0aGUgZnV0dXJlIHRvIG1hdGNoIHRoZSBzcGVjLCBzbyBldmVuIGlmIHdlJ3Jl IGNvbnNpc3RlbnQKKyAgICAgICAgbm93LCB3ZSdsbCBlbmQgdXAgbm90IGJlaW5nIGNvbnNpc3Rl bnQgaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICAqIGZhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1y ZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFyZ3VtZW50cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1dC1yZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFy Z3VtZW50cy5odG1sOiBBZGRlZC4KKwogMjAxMS0wNy0yOCAgS2VudCBUYW11cmEgIDx0a2VudEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBNYWtlIGZvcm0gdmFsaWRhdGlvbiBi dWJibGUgZml0IHdpdGggQ2hyb21lIFVJIHN0eWxlCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3Nw ZWVjaC9zcGVlY2gtaW5wdXQtcmVzdWx0LWxpc3Qtbm90LWVub3VnaC1hcmd1bWVudHMtZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc3BlZWNoL3NwZWVjaC1pbnB1 dC1yZXN1bHQtbGlzdC1ub3QtZW5vdWdoLWFyZ3VtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NwZWVjaC9zcGVlY2gtaW5wdXQtcmVzdWx0LWxpc3Qt bm90LWVub3VnaC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDEwIEBACitUZXN0cyBmb3IgU3BlZWNoSW5wdXRSZXN1bHRMaXN0JyBiZWhhdmlvciB3aXRoIHRv byBmZXcgYXJndW1lbnRzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB3 aW5kb3cuZXZlbnQucmVzdWx0cy5pdGVtKCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90 IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RF U1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zcGVlY2gvc3BlZWNoLWlucHV0 LXJlc3VsdC1saXN0LW5vdC1lbm91Z2gtYXJndW1lbnRzLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9zcGVlY2gvc3BlZWNoLWlucHV0LXJlc3VsdC1saXN0LW5vdC1lbm91Z2gt YXJndW1lbnRzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NwZWVjaC9z cGVlY2gtaW5wdXQtcmVzdWx0LWxpc3Qtbm90LWVub3VnaC1hcmd1bWVudHMuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw0MSBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9E VEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJl Zj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8 cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorZGVzY3JpcHRpb24oJ1Rlc3RzIGZvciBTcGVlY2hJ bnB1dFJlc3VsdExpc3RcJyBiZWhhdmlvciB3aXRoIHRvbyBmZXcgYXJndW1lbnRzLicpOworCit2 YXIgc3BlZWNoSW5wdXRDcmVhdGVkQnlTY3JpcHQgPSBmYWxzZTsKKworZnVuY3Rpb24gb25XZWJr aXRTcGVlY2hDaGFuZ2UoKSB7CisgICAgc2hvdWxkVGhyb3coJ3dpbmRvdy5ldmVudC5yZXN1bHRz Lml0ZW0oKScpOworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCitmdW5jdGlvbiBydW4oKSB7Cisg ICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIgfHwgIXdpbmRvdy5ldmVudFNlbmRl cikKKyAgICAgICAgcmV0dXJuOworCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuYWRkTW9ja1Nw ZWVjaElucHV0UmVzdWx0KCdQaWN0dXJlcyBvZiB0aGUgbW9vbicsIDEuMCwgJycpOworICAgIHZh ciBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzcGVlY2hJbnB1dCcpOworICAgIGlu cHV0LmFkZEV2ZW50TGlzdGVuZXIoJ3dlYmtpdHNwZWVjaGNoYW5nZScsIG9uV2Via2l0U3BlZWNo Q2hhbmdlKTsKKyAgICB2YXIgeCA9IGlucHV0Lm9mZnNldExlZnQgKyBpbnB1dC5vZmZzZXRXaWR0 aCAtIDg7CisgICAgdmFyIHkgPSBpbnB1dC5vZmZzZXRUb3AgKyBpbnB1dC5vZmZzZXRIZWlnaHQg LyAyOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50U2VuZGVy Lm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KKword2luZG93Lm9u bG9hZCA9IHJ1bjsKK3dpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKK3dpbmRvdy5zdWNjZXNz ZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8aW5wdXQgaWQ9J3NwZWVjaElucHV0JyB4 LXdlYmtpdC1zcGVlY2g+Cis8L2JvZHk+Cis8L2h0bWw+Cg==