65806 2011-08-05 19:35:19 -0700 Potential Leaks - RetainPtr<> over retaining Create'd objects 2011-08-07 11:32:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned darin joepeck webkit.review.bot oldest_to_newest 447552 0 joepeck 2011-08-05 19:35:19 -0700 shell> cd Source/ shell> ack 'Retain.*?=.*?Create' WebCore/platform/network/mac/NetworkStateNotifierMac.cpp 108: RetainPtr<CFRunLoopSourceRef> configSource = SCDynamicStoreCreateRunLoopSource(0, m_store.get(), 0); WebCore/plugins/mac/PluginPackageMac.cpp 123: WTF::RetainPtr<CFStringRef> str = CFStringCreateWithPascalString(0, p, encoding); 143: WTF::RetainPtr<CFStringRef> path = CFStringCreateWithFormat(0, 0, CFSTR("%@/Library/Preferences/%@"), homeDir.get(), fileName.get()); WebKit/mac/WebView/WebView.mm 4215: RetainPtr<CFMutableSetRef> visitedViews = CFSetCreateMutable(0, 0, 0); The first looks harmless, the plugin ones look like it could be bad in encountered (in a loop), and the WebView one looks straightforward if ever encountered. 447555 1 103141 joepeck 2011-08-05 19:46:56 -0700 Created attachment 103141 [PATCH] Potential Fix (Untested, just code inspection and change) Each of these looks like they should be an Adopt after reading the immediately surrounding code. 447607 2 darin 2011-08-06 07:52:18 -0700 Did you do the same grep for Copy? 447613 3 103141 webkit.review.bot 2011-08-06 09:17:28 -0700 Comment on attachment 103141 [PATCH] Potential Fix (Untested, just code inspection and change) Clearing flags on attachment: 103141 Committed r92552: <http://trac.webkit.org/changeset/92552> 447614 4 webkit.review.bot 2011-08-06 09:17:32 -0700 All reviewed patches have been landed. Closing bug. 447760 5 joepeck 2011-08-07 11:32:08 -0700 (In reply to comment #2) > Did you do the same grep for Copy? Yep that turned up both of these: <http://webkit.org/b/65789> Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation <http://webkit.org/b/65790> [QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy Thanks! 103141 2011-08-05 19:46:56 -0700 2011-08-06 09:17:28 -0700 [PATCH] Potential Fix (Untested, just code inspection and change) patch.patch text/plain 4295 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZmI4ZTAxLi4xNjA2NmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDgtMDUgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAor ICAgICAgICBQb3RlbnRpYWwgTGVha3MgLSBSZXRhaW5QdHI8PiBvdmVyIHJldGFpbmluZyBDcmVh dGUnZCBvYmplY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTgwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBhIHBvc3NpYmxlIGxlYWsgYnkgYWRvcHRpbmcgYW4gYWxsb2NhdGlvbiBpbnN0ZWFk IG9mIHJldGFpbmluZyBpdC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL05ldHdv cmtTdGF0ZU5vdGlmaWVyTWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdGF0ZU5v dGlmaWVyOjpOZXR3b3JrU3RhdGVOb3RpZmllcik6CisgICAgICAgICogcGx1Z2lucy9tYWMvUGx1 Z2luUGFja2FnZU1hYy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzdHJpbmdMaXN0RnJvbVJlc291 cmNlSWQpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKToKKwor MjAxMS0wOC0wNSAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCiAgICAg ICAgIExlYWsgaW4gQ0ZOZXR3b3JrIExvYWRlciBSZXRhaW5QdHI8PiBzaG91bGQgQWRvcHQgYSBD b3B5IGFsbG9jYXRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY1Nzg5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL05ldHdvcmtTdGF0ZU5vdGlmaWVyTWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvbWFjL05ldHdvcmtTdGF0ZU5vdGlmaWVyTWFjLmNwcAppbmRleCBmMGZmYTc1 Li41YjEyMjBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21h Yy9OZXR3b3JrU3RhdGVOb3RpZmllck1hYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9tYWMvTmV0d29ya1N0YXRlTm90aWZpZXJNYWMuY3BwCkBAIC0xMDUsNyArMTA1 LDcgQEAgTmV0d29ya1N0YXRlTm90aWZpZXI6Ok5ldHdvcmtTdGF0ZU5vdGlmaWVyKCkKICAgICBp ZiAoIW1fc3RvcmUpCiAgICAgICAgIHJldHVybjsKIAotICAgIFJldGFpblB0cjxDRlJ1bkxvb3BT b3VyY2VSZWY+IGNvbmZpZ1NvdXJjZSA9IFNDRHluYW1pY1N0b3JlQ3JlYXRlUnVuTG9vcFNvdXJj ZSgwLCBtX3N0b3JlLmdldCgpLCAwKTsKKyAgICBSZXRhaW5QdHI8Q0ZSdW5Mb29wU291cmNlUmVm PiBjb25maWdTb3VyY2UoQWRvcHRDRiwgU0NEeW5hbWljU3RvcmVDcmVhdGVSdW5Mb29wU291cmNl KDAsIG1fc3RvcmUuZ2V0KCksIDApKTsKICAgICBpZiAoIWNvbmZpZ1NvdXJjZSkKICAgICAgICAg cmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL21hYy9QbHVnaW5Q YWNrYWdlTWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvbWFjL1BsdWdpblBhY2thZ2VN YWMuY3BwCmluZGV4IDg2NWVhMzIuLjcyM2UzYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvbWFjL1BsdWdpblBhY2thZ2VNYWMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs dWdpbnMvbWFjL1BsdWdpblBhY2thZ2VNYWMuY3BwCkBAIC0xMjAsNyArMTIwLDcgQEAgc3RhdGlj IFZlY3RvcjxTdHJpbmc+IHN0cmluZ0xpc3RGcm9tUmVzb3VyY2VJZChTSW50MTYgaWQpCiAKICAg ICBmb3IgKFNJbnQxNiBpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKICAgICAgICAgdW5zaWduZWQg Y2hhciBsZW5ndGggPSAqcDsKLSAgICAgICAgV1RGOjpSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHN0 ciA9IENGU3RyaW5nQ3JlYXRlV2l0aFBhc2NhbFN0cmluZygwLCBwLCBlbmNvZGluZyk7CisgICAg ICAgIFdURjo6UmV0YWluUHRyPENGU3RyaW5nUmVmPiBzdHIoQWRvcHRDRiwgQ0ZTdHJpbmdDcmVh dGVXaXRoUGFzY2FsU3RyaW5nKDAsIHAsIGVuY29kaW5nKSk7CiAgICAgICAgIGxpc3QuYXBwZW5k KHN0ci5nZXQoKSk7CiAgICAgICAgIHAgKz0gMSArIGxlbmd0aDsKICAgICB9CkBAIC0xNDAsNyAr MTQwLDcgQEAgYm9vbCBQbHVnaW5QYWNrYWdlOjpmZXRjaEluZm8oKQogCiAgICAgICAgIFdURjo6 UmV0YWluUHRyPENGU3RyaW5nUmVmPiBmaWxlTmFtZSA9IChDRlN0cmluZ1JlZiltaW1lVHlwZXNG aWxlTmFtZS5nZXQoKTsKICAgICAgICAgV1RGOjpSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGhvbWVE aXIgPSBob21lRGlyZWN0b3J5UGF0aCgpLmNyZWF0ZUNGU3RyaW5nKCk7Ci0gICAgICAgIFdURjo6 UmV0YWluUHRyPENGU3RyaW5nUmVmPiBwYXRoID0gQ0ZTdHJpbmdDcmVhdGVXaXRoRm9ybWF0KDAs IDAsIENGU1RSKCIlQC9MaWJyYXJ5L1ByZWZlcmVuY2VzLyVAIiksIGhvbWVEaXIuZ2V0KCksIGZp bGVOYW1lLmdldCgpKTsKKyAgICAgICAgV1RGOjpSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHBhdGgo QWRvcHRDRiwgQ0ZTdHJpbmdDcmVhdGVXaXRoRm9ybWF0KDAsIDAsIENGU1RSKCIlQC9MaWJyYXJ5 L1ByZWZlcmVuY2VzLyVAIiksIGhvbWVEaXIuZ2V0KCksIGZpbGVOYW1lLmdldCgpKSk7CiAKICAg ICAgICAgV1RGOjpSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBwbGlzdCA9IHJlYWRQTGlzdEZp bGUocGF0aC5nZXQoKSwgLypjcmVhdGVGaWxlKi8gZmFsc2UsIG1fbW9kdWxlKTsKICAgICAgICAg aWYgKHBsaXN0KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMWE4YjNjYi4uOWUzZjMzNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFj L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA4LTA1ICBKb3NlcGggUGVjb3Jhcm8g IDxqb2VwZWNrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUG90ZW50aWFsIExlYWtzIC0gUmV0YWlu UHRyPD4gb3ZlciByZXRhaW5pbmcgQ3JlYXRlJ2Qgb2JqZWN0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU4MDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBwb3NzaWJsZSBsZWFrIGJ5IGFkb3B0 aW5nIGFuIGFsbG9jYXRpb24gaW5zdGVhZCBvZiByZXRhaW5pbmcgaXQuCisKKyAgICAgICAgKiBX ZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgcHJldmlvdXNWYWxpZEtleVZp ZXddKToKKwogMjAxMS0wOC0wNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSBQbHVnaW5IYWx0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi Vmlldy5tbQppbmRleCBjYWJlZGMyLi41M2U5MTdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJWaWV3Lm1tCkBAIC00MjEyLDcgKzQyMTIsNyBAQCBzdGF0aWMgV2ViRnJhbWUgKmluY3JlbWVu dEZyYW1lKFdlYkZyYW1lICpmcmFtZSwgV2ViRmluZE9wdGlvbnMgb3B0aW9ucyA9IDApCiAKICAg ICAvLyBVc2UgYSB2aXNpdGVkIHNldCBzbyB3ZSBkb24ndCBsb29wIGluZGVmaW5pdGVseSB3aGVu IHdhbGtpbmcgY3Jhenkga2V5IGxvb3BzLgogICAgIC8vIEFwcEtpdCB1c2VzIHN1Y2ggc2V0cyBp bnRlcm5hbGx5IGFuZCB3ZSB3YW50IG91ciBsb29wIHRvIGJlIGFzIHJvYnVzdCBhcyBpdHMgbG9v cHMuCi0gICAgUmV0YWluUHRyPENGTXV0YWJsZVNldFJlZj4gdmlzaXRlZFZpZXdzID0gQ0ZTZXRD cmVhdGVNdXRhYmxlKDAsIDAsIDApOworICAgIFJldGFpblB0cjxDRk11dGFibGVTZXRSZWY+IHZp c2l0ZWRWaWV3cyhBZG9wdENGLCBDRlNldENyZWF0ZU11dGFibGUoMCwgMCwgMCkpOwogICAgIENG U2V0QWRkVmFsdWUodmlzaXRlZFZpZXdzLmdldCgpLCByZXN1bHQpOwogCiAgICAgTlNWaWV3ICpw cmV2aW91c1ZpZXcgPSBzZWxmOwo=