65789 2011-08-05 13:57:10 -0700 Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation 2011-08-05 17:25:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned aroben bweinstein joepeck psolanki webkit.review.bot oldest_to_newest 447397 0 joepeck 2011-08-05 13:57:10 -0700 Both of these: if (RetainPtr<CFDataRef> bodyData = CFURLRequestCopyHTTPRequestBody(request)) return FormData::create(CFDataGetBytePtr(bodyData.get()), CFDataGetLength(bodyData.get())); if (RetainPtr<CFArrayRef> bodyParts = wkCFURLRequestCopyHTTPRequestBodyParts(request)) { RefPtr<FormData> formData = FormData::create(); Cause leaks because RetainPtr::operation= will CFRetain() but FooCopyBar() already returns a +1 allocation. We should adopt the reference with AdoptCF. 447398 1 103104 joepeck 2011-08-05 14:00:18 -0700 Created attachment 103104 [PATCH] Proposed Fix 447423 2 103104 joepeck 2011-08-05 14:30:07 -0700 Comment on attachment 103104 [PATCH] Proposed Fix cq- based on the bot failing to build on Windows. 447425 3 joepeck 2011-08-05 14:34:09 -0700 Windows build bot says: http://queues.webkit.org/results/9323095 3>####### COMPILING 2 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ########### 3>FormDataStreamCFNet.cpp 3>..\platform\network\cf\FormDataStreamCFNet.cpp(94) : error C2061: syntax error : identifier 'AdoptCF' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(94) : error C2059: syntax error : ')' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2143: syntax error : missing ';' before 'return' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2065: 'bodyData' : undeclared identifier 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2228: left of '.get' must have class/struct/union 3> type is ''unknown-type'' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2228: left of '.get' must have class/struct/union 3> type is ''unknown-type'' This built fine for me locally. Maybe the Window's compiler doesn't like the shorthand constructor syntax inside of an if statement? I could move the assignments outside of the if statements if needed. Adding some windows developers. 447426 4 joepeck 2011-08-05 14:34:33 -0700 s/if statement/if condition/ 447433 5 103117 joepeck 2011-08-05 14:48:44 -0700 Created attachment 103117 [PATCH] Fix Build Issue With Previous Patch I forgot that by default PLATFORM(MAC) doesn't take this path by default. So my local build was a false positive. I've now tested building this change correctly. 447467 6 103117 ddkilzer 2011-08-05 16:24:46 -0700 Comment on attachment 103117 [PATCH] Fix Build Issue With Previous Patch r=me 447493 7 103117 webkit.review.bot 2011-08-05 17:25:05 -0700 Comment on attachment 103117 [PATCH] Fix Build Issue With Previous Patch Clearing flags on attachment: 103117 Committed r92530: <http://trac.webkit.org/changeset/92530> 447495 8 webkit.review.bot 2011-08-05 17:25:09 -0700 All reviewed patches have been landed. Closing bug. 103104 2011-08-05 14:00:18 -0700 2011-08-05 14:48:44 -0700 [PATCH] Proposed Fix proposed-1.patch text/plain 1770 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZWFhNzhkLi4wODhkMDk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDgtMDUgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBMZWFrIGluIENGTmV0d29yayBMb2FkZXIgUmV0YWluUHRyPD4gc2hvdWxkIEFkb3B0 IGEgQ29weSBhbGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NTc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBhIGxlYWsgYnkgYWRvcHRpbmcgYW4gYWxsb2NhdGlvbiBpbnN0ZWFkIG9m IHJldGFpbmluZyBpdC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvRm9ybURhdGFT dHJlYW1DRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpodHRwQm9keUZyb21SZXF1ZXN0KToK KwogMjAxMS0wOC0wMyAgSWFuIEhlbmRlcnNvbiAgPGlhbmhAYXBwbGUuY29tPgogCiAgICAgICAg IERyYXcgcmVjdGFuZ3VsYXIgYm94IHNoYWRvdyBmb3IgZWxlbWVudHMgd2l0aCBib3JkZXItcmFk aXVzIGlmIG5vIGNvcm5lcnMgYXJlIHZpc2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY2YvRm9ybURhdGFTdHJlYW1DRk5ldC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0Zvcm1EYXRhU3RyZWFtQ0ZOZXQuY3BwCmluZGV4IGU0 ZmM1MWMuLmQxMTIxYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvRm9ybURhdGFTdHJlYW1DRk5ldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jZi9Gb3JtRGF0YVN0cmVhbUNGTmV0LmNwcApAQCAtOTEsMTAgKzkxLDEwIEBA IHZvaWQgc2V0SFRUUEJvZHkoQ0ZNdXRhYmxlVVJMUmVxdWVzdFJlZiByZXF1ZXN0LCBQYXNzUmVm UHRyPEZvcm1EYXRhPiBmb3JtRGF0YSkKIAogUGFzc1JlZlB0cjxGb3JtRGF0YT4gaHR0cEJvZHlG cm9tUmVxdWVzdChDRlVSTFJlcXVlc3RSZWYgcmVxdWVzdCkKIHsKLSAgICBpZiAoUmV0YWluUHRy PENGRGF0YVJlZj4gYm9keURhdGEgPSBDRlVSTFJlcXVlc3RDb3B5SFRUUFJlcXVlc3RCb2R5KHJl cXVlc3QpKQorICAgIGlmIChSZXRhaW5QdHI8Q0ZEYXRhUmVmPiBib2R5RGF0YShBZG9wdENGLCBD RlVSTFJlcXVlc3RDb3B5SFRUUFJlcXVlc3RCb2R5KHJlcXVlc3QpKSkKICAgICAgICAgcmV0dXJu IEZvcm1EYXRhOjpjcmVhdGUoQ0ZEYXRhR2V0Qnl0ZVB0cihib2R5RGF0YS5nZXQoKSksIENGRGF0 YUdldExlbmd0aChib2R5RGF0YS5nZXQoKSkpOwogCi0gICAgaWYgKFJldGFpblB0cjxDRkFycmF5 UmVmPiBib2R5UGFydHMgPSB3a0NGVVJMUmVxdWVzdENvcHlIVFRQUmVxdWVzdEJvZHlQYXJ0cyhy ZXF1ZXN0KSkgeworICAgIGlmIChSZXRhaW5QdHI8Q0ZBcnJheVJlZj4gYm9keVBhcnRzKEFkb3B0 Q0YsIHdrQ0ZVUkxSZXF1ZXN0Q29weUhUVFBSZXF1ZXN0Qm9keVBhcnRzKHJlcXVlc3QpKSkgewog ICAgICAgICBSZWZQdHI8Rm9ybURhdGE+IGZvcm1EYXRhID0gRm9ybURhdGE6OmNyZWF0ZSgpOwog CiAgICAgICAgIENGSW5kZXggY291bnQgPSBDRkFycmF5R2V0Q291bnQoYm9keVBhcnRzLmdldCgp KTsK 103117 2011-08-05 14:48:44 -0700 2011-08-05 17:25:05 -0700 [PATCH] Fix Build Issue With Previous Patch take2.patch text/plain 1801 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZWFhNzhkLi4wODhkMDk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDgtMDUgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBMZWFrIGluIENGTmV0d29yayBMb2FkZXIgUmV0YWluUHRyPD4gc2hvdWxkIEFkb3B0 IGEgQ29weSBhbGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NTc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBhIGxlYWsgYnkgYWRvcHRpbmcgYW4gYWxsb2NhdGlvbiBpbnN0ZWFkIG9m IHJldGFpbmluZyBpdC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvRm9ybURhdGFT dHJlYW1DRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpodHRwQm9keUZyb21SZXF1ZXN0KToK KwogMjAxMS0wOC0wMyAgSWFuIEhlbmRlcnNvbiAgPGlhbmhAYXBwbGUuY29tPgogCiAgICAgICAg IERyYXcgcmVjdGFuZ3VsYXIgYm94IHNoYWRvdyBmb3IgZWxlbWVudHMgd2l0aCBib3JkZXItcmFk aXVzIGlmIG5vIGNvcm5lcnMgYXJlIHZpc2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY2YvRm9ybURhdGFTdHJlYW1DRk5ldC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0Zvcm1EYXRhU3RyZWFtQ0ZOZXQuY3BwCmluZGV4IGU0 ZmM1MWMuLmEyMTNjYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvRm9ybURhdGFTdHJlYW1DRk5ldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jZi9Gb3JtRGF0YVN0cmVhbUNGTmV0LmNwcApAQCAtOTEsMTAgKzkxLDEyIEBA IHZvaWQgc2V0SFRUUEJvZHkoQ0ZNdXRhYmxlVVJMUmVxdWVzdFJlZiByZXF1ZXN0LCBQYXNzUmVm UHRyPEZvcm1EYXRhPiBmb3JtRGF0YSkKIAogUGFzc1JlZlB0cjxGb3JtRGF0YT4gaHR0cEJvZHlG cm9tUmVxdWVzdChDRlVSTFJlcXVlc3RSZWYgcmVxdWVzdCkKIHsKLSAgICBpZiAoUmV0YWluUHRy PENGRGF0YVJlZj4gYm9keURhdGEgPSBDRlVSTFJlcXVlc3RDb3B5SFRUUFJlcXVlc3RCb2R5KHJl cXVlc3QpKQorICAgIFJldGFpblB0cjxDRkRhdGFSZWY+IGJvZHlEYXRhKEFkb3B0Q0YsIENGVVJM UmVxdWVzdENvcHlIVFRQUmVxdWVzdEJvZHkocmVxdWVzdCkpOworICAgIGlmIChib2R5RGF0YSkK ICAgICAgICAgcmV0dXJuIEZvcm1EYXRhOjpjcmVhdGUoQ0ZEYXRhR2V0Qnl0ZVB0cihib2R5RGF0 YS5nZXQoKSksIENGRGF0YUdldExlbmd0aChib2R5RGF0YS5nZXQoKSkpOwogCi0gICAgaWYgKFJl dGFpblB0cjxDRkFycmF5UmVmPiBib2R5UGFydHMgPSB3a0NGVVJMUmVxdWVzdENvcHlIVFRQUmVx dWVzdEJvZHlQYXJ0cyhyZXF1ZXN0KSkgeworICAgIFJldGFpblB0cjxDRkFycmF5UmVmPiBib2R5 UGFydHMoQWRvcHRDRiwgd2tDRlVSTFJlcXVlc3RDb3B5SFRUUFJlcXVlc3RCb2R5UGFydHMocmVx dWVzdCkpOworICAgIGlmIChib2R5UGFydHMpIHsKICAgICAgICAgUmVmUHRyPEZvcm1EYXRhPiBm b3JtRGF0YSA9IEZvcm1EYXRhOjpjcmVhdGUoKTsKIAogICAgICAgICBDRkluZGV4IGNvdW50ID0g Q0ZBcnJheUdldENvdW50KGJvZHlQYXJ0cy5nZXQoKSk7Cg==